Commit 0c4c8054 authored by Clement Ho's avatar Clement Ho

Merge branch 'refactor/move-assignee-title-vue-component' into 'master'

Move AssigneeTitle vue component

See merge request gitlab-org/gitlab-ce!17397
parents c591cf53 b3152bf2
...@@ -5,7 +5,7 @@ import Flash from '../../flash'; ...@@ -5,7 +5,7 @@ import Flash from '../../flash';
import { __ } from '../../locale'; import { __ } from '../../locale';
import Sidebar from '../../right_sidebar'; import Sidebar from '../../right_sidebar';
import eventHub from '../../sidebar/event_hub'; import eventHub from '../../sidebar/event_hub';
import assigneeTitle from '../../sidebar/components/assignees/assignee_title'; import assigneeTitle from '../../sidebar/components/assignees/assignee_title.vue';
import assignees from '../../sidebar/components/assignees/assignees.vue'; import assignees from '../../sidebar/components/assignees/assignees.vue';
import DueDateSelectors from '../../due_date_select'; import DueDateSelectors from '../../due_date_select';
import './sidebar/remove_issue'; import './sidebar/remove_issue';
......
<script>
export default { export default {
name: 'AssigneeTitle', name: 'AssigneeTitle',
props: { props: {
...@@ -26,34 +27,38 @@ export default { ...@@ -26,34 +27,38 @@ export default {
return assignees > 1 ? `${assignees} Assignees` : 'Assignee'; return assignees > 1 ? `${assignees} Assignees` : 'Assignee';
}, },
}, },
template: ` };
<div class="title hide-collapsed"> </script>
{{assigneeTitle}} <template>
<div class="title hide-collapsed">
{{ assigneeTitle }}
<i
v-if="loading"
aria-hidden="true"
class="fa fa-spinner fa-spin block-loading"
>
</i>
<a
v-if="editable"
class="js-sidebar-dropdown-toggle edit-link pull-right"
href="#"
>
{{ __('Edit') }}
</a>
<a
v-if="showToggle"
aria-label="Toggle sidebar"
class="gutter-toggle pull-right js-sidebar-toggle"
href="#"
role="button"
>
<i <i
v-if="loading"
aria-hidden="true" aria-hidden="true"
class="fa fa-spinner fa-spin block-loading" data-hidden="true"
/> class="fa fa-angle-double-right"
<a
v-if="editable"
class="js-sidebar-dropdown-toggle edit-link pull-right"
href="#"
>
{{ __('Edit') }}
</a>
<a
v-if="showToggle"
aria-label="Toggle sidebar"
class="gutter-toggle pull-right js-sidebar-toggle"
href="#"
role="button"
> >
<i </i>
aria-hidden="true" </a>
data-hidden="true" </div>
class="fa fa-angle-double-right" </template>
/>
</a>
</div>
`,
};
<script> <script>
import Flash from '../../../flash'; import Flash from '../../../flash';
import AssigneeTitle from './assignee_title'; import AssigneeTitle from './assignee_title.vue';
import Assignees from './assignees.vue'; import Assignees from './assignees.vue';
import Store from '../../stores/sidebar_store'; import Store from '../../stores/sidebar_store';
import eventHub from '../../event_hub'; import eventHub from '../../event_hub';
......
---
title: Move AssigneeTitle vue component
merge_request: 17397
author: George Tsiolis
type: performance
import Vue from 'vue'; import Vue from 'vue';
import AssigneeTitle from '~/sidebar/components/assignees/assignee_title'; import AssigneeTitle from '~/sidebar/components/assignees/assignee_title.vue';
describe('AssigneeTitle component', () => { describe('AssigneeTitle component', () => {
let component; let component;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment