merge_request_spec.rb 4.66 KB
Newer Older
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1 2 3 4
# == Schema Information
#
# Table name: merge_requests
#
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
#  id                :integer          not null, primary key
#  target_branch     :string(255)      not null
#  source_branch     :string(255)      not null
#  source_project_id :integer          not null
#  author_id         :integer
#  assignee_id       :integer
#  title             :string(255)
#  created_at        :datetime         not null
#  updated_at        :datetime         not null
#  st_commits        :text(2147483647)
#  st_diffs          :text(2147483647)
#  milestone_id      :integer
#  state             :string(255)
#  merge_status      :string(255)
#  target_project_id :integer          not null
#  iid               :integer
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
21
#  description       :text
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
22 23
#

24 25 26
require 'spec_helper'

describe MergeRequest do
27 28 29 30 31
  describe "Validation" do
    it { should validate_presence_of(:target_branch) }
    it { should validate_presence_of(:source_branch) }
  end

32 33 34 35 36
  describe "Mass assignment" do
    it { should_not allow_mass_assignment_of(:author_id) }
    it { should_not allow_mass_assignment_of(:project_id) }
  end

37 38 39 40 41
  describe "Respond to" do
    it { should respond_to(:unchecked?) }
    it { should respond_to(:can_be_merged?) }
    it { should respond_to(:cannot_be_merged?) }
  end
42

43
  describe 'modules' do
44
    it { should include_module(Issuable) }
45
  end
46 47

  describe "#mr_and_commit_notes" do
48
    let!(:merge_request) { create(:merge_request) }
49 50

    before do
51
      merge_request.stub(:commits) { [merge_request.source_project.repository.commit] }
52 53
      create(:note, commit_id: merge_request.commits.first.id, noteable_type: 'Commit', project: merge_request.project)
      create(:note, noteable: merge_request, project: merge_request.project)
54 55 56 57 58 59 60
    end

    it "should include notes for commits" do
      merge_request.commits.should_not be_empty
      merge_request.mr_and_commit_notes.count.should == 2
    end
  end
61

62
  subject { create(:merge_request) }
63 64 65

  describe '#is_being_reassigned?' do
    it 'returns true if the merge_request assignee has changed' do
66
      subject.assignee = create(:user)
67 68 69 70 71 72
      subject.is_being_reassigned?.should be_true
    end
    it 'returns false if the merge request assignee has not changed' do
      subject.is_being_reassigned?.should be_false
    end
  end
73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106

  describe '#for_fork?' do
    it 'returns true if the merge request is for a fork' do
      subject.source_project = create(:source_project)
      subject.target_project = create(:target_project)

      subject.for_fork?.should be_true
    end
    it 'returns false if is not for a fork' do
      subject.source_project = create(:source_project)
      subject.target_project = subject.source_project
      subject.for_fork?.should be_false
    end
  end

  describe '#allow_source_branch_removal?' do
    it 'should not allow removal when mr is a fork' do

      subject.disallow_source_branch_removal?.should be_true
    end
    it 'should not allow removal when the mr is not a fork, but the source branch is the root reference' do
      subject.target_project = subject.source_project
      subject.source_branch = subject.source_project.repository.root_ref
      subject.disallow_source_branch_removal?.should be_true
    end

    it 'should not disallow removal when the mr is not a fork, and but source branch is not the root reference' do
      subject.target_project = subject.source_project
      subject.source_branch = "Something Different #{subject.source_project.repository.root_ref}"
      subject.for_fork?.should be_false
      subject.disallow_source_branch_removal?.should be_false
    end
  end

107 108 109
  describe 'detection of issues to be closed' do
    let(:issue0) { create :issue, project: subject.project }
    let(:issue1) { create :issue, project: subject.project }
skv's avatar
skv committed
110 111 112
    let(:commit0) { double('commit0', closes_issues: [issue0]) }
    let(:commit1) { double('commit1', closes_issues: [issue0]) }
    let(:commit2) { double('commit2', closes_issues: [issue1]) }
113 114

    before do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
115
      subject.stub(commits: [commit0, commit1, commit2])
116 117 118
    end

    it 'accesses the set of issues that will be closed on acceptance' do
119
      subject.project.stub(default_branch: subject.target_branch)
120 121 122 123 124

      subject.closes_issues.should == [issue0, issue1].sort_by(&:id)
    end

    it 'only lists issues as to be closed if it targets the default branch' do
125
      subject.project.stub(default_branch: 'master')
126 127 128 129 130 131 132 133 134 135 136
      subject.target_branch = 'something-else'

      subject.closes_issues.should be_empty
    end
  end

  it_behaves_like 'an editable mentionable' do
    let(:subject) { create :merge_request, source_project: mproject, target_project: mproject }
    let(:backref_text) { "merge request !#{subject.iid}" }
    let(:set_mentionable_text) { ->(txt){ subject.title = txt } }
  end
137
end