issues_finder_spec.rb 27.6 KB
Newer Older
1 2
require 'spec_helper'

3
describe IssuesFinder do
4 5
  set(:user) { create(:user) }
  set(:user2) { create(:user) }
6 7 8
  set(:group) { create(:group) }
  set(:subgroup) { create(:group, parent: group) }
  set(:project1) { create(:project, group: group) }
9
  set(:project2) { create(:project) }
10
  set(:project3) { create(:project, group: subgroup) }
11 12
  set(:milestone) { create(:milestone, project: project1) }
  set(:label) { create(:label, project: project2) }
13 14 15
  set(:issue1) { create(:issue, author: user, assignees: [user], project: project1, milestone: milestone, title: 'gitlab', created_at: 1.week.ago, updated_at: 1.week.ago) }
  set(:issue2) { create(:issue, author: user, assignees: [user], project: project2, description: 'gitlab', created_at: 1.week.from_now, updated_at: 1.week.from_now) }
  set(:issue3) { create(:issue, author: user2, assignees: [user2], project: project2, title: 'tanuki', description: 'tanuki', created_at: 2.weeks.from_now, updated_at: 2.weeks.from_now) }
16
  set(:issue4) { create(:issue, project: project3) }
17 18 19
  set(:award_emoji1) { create(:award_emoji, name: 'thumbsup', user: user, awardable: issue1) }
  set(:award_emoji2) { create(:award_emoji, name: 'thumbsup', user: user2, awardable: issue2) }
  set(:award_emoji3) { create(:award_emoji, name: 'thumbsdown', user: user, awardable: issue3) }
20

21
  describe '#execute' do
22 23
    let!(:closed_issue) { create(:issue, author: user2, assignees: [user2], project: project2, state: 'closed') }
    let!(:label_link) { create(:label_link, label: label, target: issue2) }
24 25
    let(:search_user) { user }
    let(:params) { {} }
26
    let(:issues) { described_class.new(search_user, params.reverse_merge(scope: scope, state: 'opened')).execute }
27

28
    before(:context) do
29
      project1.add_maintainer(user)
30 31
      project2.add_developer(user)
      project2.add_developer(user2)
32
      project3.add_developer(user)
33 34 35 36

      issue1
      issue2
      issue3
37
      issue4
38 39 40 41

      award_emoji1
      award_emoji2
      award_emoji3
42 43
    end

44
    context 'scope: all' do
45
      let(:scope) { 'all' }
46

47
      it 'returns all issues' do
48
        expect(issues).to contain_exactly(issue1, issue2, issue3, issue4)
49
      end
50

51 52 53 54 55 56
      context 'filtering by assignee ID' do
        let(:params) { { assignee_id: user.id } }

        it 'returns issues assigned to that user' do
          expect(issues).to contain_exactly(issue1, issue2)
        end
57
      end
58

59
      context 'filtering by no assignee' do
60
        let(:params) { { assignee_id: 'None' } }
61

62
        it 'returns issues not assigned to any assignee' do
63 64 65
          expect(issues).to contain_exactly(issue4)
        end

66 67 68 69 70
        it 'returns issues not assigned to any assignee' do
          params[:assignee_id] = 0

          expect(issues).to contain_exactly(issue4)
        end
71 72

        it 'returns issues not assigned to any assignee' do
73 74
          params[:assignee_id] = 'none'

75 76 77 78 79 80 81 82 83 84
          expect(issues).to contain_exactly(issue4)
        end
      end

      context 'filtering by any assignee' do
        let(:params) { { assignee_id: 'Any' } }

        it 'returns issues assigned to any assignee' do
          expect(issues).to contain_exactly(issue1, issue2, issue3)
        end
85 86 87 88 89 90

        it 'returns issues assigned to any assignee' do
          params[:assignee_id] = 'any'

          expect(issues).to contain_exactly(issue1, issue2, issue3)
        end
91 92
      end

93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112
      context 'filtering by group_id' do
        let(:params) { { group_id: group.id } }

        context 'when include_subgroup param not set' do
          it 'returns all group issues' do
            expect(issues).to contain_exactly(issue1)
          end
        end

        context 'when include_subgroup param is true', :nested_groups do
          before do
            params[:include_subgroups] = true
          end

          it 'returns all group and subgroup issues' do
            expect(issues).to contain_exactly(issue1, issue4)
          end
        end
      end

113 114 115 116 117 118
      context 'filtering by author ID' do
        let(:params) { { author_id: user2.id } }

        it 'returns issues created by that user' do
          expect(issues).to contain_exactly(issue3)
        end
119 120
      end

121 122 123 124 125 126
      context 'filtering by milestone' do
        let(:params) { { milestone_title: milestone.title } }

        it 'returns issues assigned to that milestone' do
          expect(issues).to contain_exactly(issue1)
        end
127 128
      end

Felipe Artur's avatar
Felipe Artur committed
129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145
      context 'filtering by group milestone' do
        let!(:group) { create(:group, :public) }
        let(:group_milestone) { create(:milestone, group: group) }
        let!(:group_member) { create(:group_member, group: group, user: user) }
        let(:params) { { milestone_title: group_milestone.title } }

        before do
          project2.update(namespace: group)
          issue2.update(milestone: group_milestone)
          issue3.update(milestone: group_milestone)
        end

        it 'returns issues assigned to that group milestone' do
          expect(issues).to contain_exactly(issue2, issue3)
        end
      end

146
      context 'filtering by no milestone' do
147
        let(:params) { { milestone_title: 'None' } }
148 149

        it 'returns issues with no milestone' do
150
          expect(issues).to contain_exactly(issue2, issue3, issue4)
151
        end
152 153 154 155 156 157

        it 'returns issues with no milestone (deprecated)' do
          params[:milestone_title] = Milestone::None.title

          expect(issues).to contain_exactly(issue2, issue3, issue4)
        end
158 159
      end

160
      context 'filtering by any milestone' do
161
        let(:params) { { milestone_title: 'Any' } }
162 163 164 165

        it 'returns issues with any assigned milestone' do
          expect(issues).to contain_exactly(issue1)
        end
166 167 168 169 170 171

        it 'returns issues with any assigned milestone (deprecated)' do
          params[:milestone_title] = Milestone::Any.title

          expect(issues).to contain_exactly(issue1)
        end
172 173
      end

174 175 176
      context 'filtering by upcoming milestone' do
        let(:params) { { milestone_title: Milestone::Upcoming.name } }

177 178 179
        let!(:group) { create(:group, :public) }
        let!(:group_member) { create(:group_member, group: group, user: user) }

180 181 182
        let(:project_no_upcoming_milestones) { create(:project, :public) }
        let(:project_next_1_1) { create(:project, :public) }
        let(:project_next_8_8) { create(:project, :public) }
183
        let(:project_in_group) { create(:project, :public, namespace: group) }
184 185 186 187 188 189 190 191 192 193

        let(:yesterday) { Date.today - 1.day }
        let(:tomorrow) { Date.today + 1.day }
        let(:two_days_from_now) { Date.today + 2.days }
        let(:ten_days_from_now) { Date.today + 10.days }

        let(:milestones) do
          [
            create(:milestone, :closed, project: project_no_upcoming_milestones),
            create(:milestone, project: project_next_1_1, title: '1.1', due_date: two_days_from_now),
194 195 196 197
            create(:milestone, project: project_next_1_1, title: '8.9', due_date: ten_days_from_now),
            create(:milestone, project: project_next_8_8, title: '1.2', due_date: yesterday),
            create(:milestone, project: project_next_8_8, title: '8.8', due_date: tomorrow),
            create(:milestone, group: group, title: '9.9', due_date: tomorrow)
198 199 200 201 202
          ]
        end

        before do
          milestones.each do |milestone|
203
            create(:issue, project: milestone.project || project_in_group, milestone: milestone, author: user, assignees: [user])
204 205 206
          end
        end

207 208 209
        it 'returns issues in the upcoming milestone for each project or group' do
          expect(issues.map { |issue| issue.milestone.title }).to contain_exactly('1.1', '8.8', '9.9')
          expect(issues.map { |issue| issue.milestone.due_date }).to contain_exactly(tomorrow, two_days_from_now, tomorrow)
210 211 212
        end
      end

213 214 215
      context 'filtering by started milestone' do
        let(:params) { { milestone_title: Milestone::Started.name } }

216 217 218
        let(:project_no_started_milestones) { create(:project, :public) }
        let(:project_started_1_and_2) { create(:project, :public) }
        let(:project_started_8) { create(:project, :public) }
219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237

        let(:yesterday) { Date.today - 1.day }
        let(:tomorrow) { Date.today + 1.day }
        let(:two_days_ago) { Date.today - 2.days }

        let(:milestones) do
          [
            create(:milestone, project: project_no_started_milestones, start_date: tomorrow),
            create(:milestone, project: project_started_1_and_2, title: '1.0', start_date: two_days_ago),
            create(:milestone, project: project_started_1_and_2, title: '2.0', start_date: yesterday),
            create(:milestone, project: project_started_1_and_2, title: '3.0', start_date: tomorrow),
            create(:milestone, project: project_started_8, title: '7.0'),
            create(:milestone, project: project_started_8, title: '8.0', start_date: yesterday),
            create(:milestone, project: project_started_8, title: '9.0', start_date: tomorrow)
          ]
        end

        before do
          milestones.each do |milestone|
238
            create(:issue, project: milestone.project, milestone: milestone, author: user, assignees: [user])
239 240 241 242 243 244 245 246 247
          end
        end

        it 'returns issues in the started milestones for each project' do
          expect(issues.map { |issue| issue.milestone.title }).to contain_exactly('1.0', '2.0', '8.0')
          expect(issues.map { |issue| issue.milestone.start_date }).to contain_exactly(two_days_ago, yesterday, yesterday)
        end
      end

248 249
      context 'filtering by label' do
        let(:params) { { label_name: label.title } }
250

251 252 253 254
        it 'returns issues with that label' do
          expect(issues).to contain_exactly(issue2)
        end
      end
255

256 257 258
      context 'filtering by multiple labels' do
        let(:params) { { label_name: [label.title, label2.title].join(',') } }
        let(:label2) { create(:label, project: project2) }
259

260 261 262
        before do
          create(:label_link, label: label2, target: issue2)
        end
263

264 265 266 267 268 269 270 271 272 273 274 275 276
        it 'returns the unique issues with all those labels' do
          expect(issues).to contain_exactly(issue2)
        end
      end

      context 'filtering by a label that includes any or none in the title' do
        let(:params) { { label_name: [label.title, label2.title].join(',') } }
        let(:label) { create(:label, title: 'any foo', project: project2) }
        let(:label2) { create(:label, title: 'bar none', project: project2) }

        it 'returns the unique issues with all those labels' do
          create(:label_link, label: label2, target: issue2)

277 278
          expect(issues).to contain_exactly(issue2)
        end
279 280
      end

281
      context 'filtering by no label' do
282
        let(:params) { { label_name: described_class::FILTER_NONE } }
283 284

        it 'returns issues with no labels' do
285
          expect(issues).to contain_exactly(issue1, issue3, issue4)
286
        end
287 288
      end

289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308
      context 'filtering by legacy No+Label' do
        let(:params) { { label_name: Label::NONE } }

        it 'returns issues with no labels' do
          expect(issues).to contain_exactly(issue1, issue3, issue4)
        end
      end

      context 'filtering by any label' do
        let(:params) { { label_name: described_class::FILTER_ANY } }

        it 'returns issues that have one or more label' do
          2.times do
            create(:label_link, label: create(:label, project: project2), target: issue3)
          end

          expect(issues).to contain_exactly(issue2, issue3)
        end
      end

barthc's avatar
barthc committed
309 310 311 312 313 314 315 316
      context 'filtering by issue term' do
        let(:params) { { search: 'git' } }

        it 'returns issues with title and description match for search term' do
          expect(issues).to contain_exactly(issue1, issue2)
        end
      end

317 318 319 320 321 322 323 324
      context 'filtering by issue term in title' do
        let(:params) { { search: 'git', in: 'title' } }

        it 'returns issues with title match for search term' do
          expect(issues).to contain_exactly(issue1)
        end
      end

325 326
      context 'filtering by issues iids' do
        let(:params) { { iids: issue3.iid } }
barthc's avatar
barthc committed
327

328
        it 'returns issues with iids match' do
barthc's avatar
barthc committed
329 330 331 332
          expect(issues).to contain_exactly(issue3)
        end
      end

333 334 335 336 337
      context 'filtering by state' do
        context 'with opened' do
          let(:params) { { state: 'opened' } }

          it 'returns only opened issues' do
338
            expect(issues).to contain_exactly(issue1, issue2, issue3, issue4)
339 340 341 342 343 344 345 346 347 348 349 350 351 352 353
          end
        end

        context 'with closed' do
          let(:params) { { state: 'closed' } }

          it 'returns only closed issues' do
            expect(issues).to contain_exactly(closed_issue)
          end
        end

        context 'with all' do
          let(:params) { { state: 'all' } }

          it 'returns all issues' do
354
            expect(issues).to contain_exactly(issue1, issue2, issue3, closed_issue, issue4)
355 356 357 358 359 360 361
          end
        end

        context 'with invalid state' do
          let(:params) { { state: 'invalid_state' } }

          it 'returns all issues' do
362
            expect(issues).to contain_exactly(issue1, issue2, issue3, closed_issue, issue4)
363 364 365 366
          end
        end
      end

367 368 369 370 371 372 373 374 375 376
      context 'filtering by created_at' do
        context 'through created_after' do
          let(:params) { { created_after: issue3.created_at } }

          it 'returns issues created on or after the given date' do
            expect(issues).to contain_exactly(issue3)
          end
        end

        context 'through created_before' do
377
          let(:params) { { created_before: issue1.created_at } }
378 379 380 381 382

          it 'returns issues created on or before the given date' do
            expect(issues).to contain_exactly(issue1)
          end
        end
383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416

        context 'through created_after and created_before' do
          let(:params) { { created_after: issue2.created_at, created_before: issue3.created_at } }

          it 'returns issues created between the given dates' do
            expect(issues).to contain_exactly(issue2, issue3)
          end
        end
      end

      context 'filtering by updated_at' do
        context 'through updated_after' do
          let(:params) { { updated_after: issue3.updated_at } }

          it 'returns issues updated on or after the given date' do
            expect(issues).to contain_exactly(issue3)
          end
        end

        context 'through updated_before' do
          let(:params) { { updated_before: issue1.updated_at } }

          it 'returns issues updated on or before the given date' do
            expect(issues).to contain_exactly(issue1)
          end
        end

        context 'through updated_after and updated_before' do
          let(:params) { { updated_after: issue2.updated_at, updated_before: issue3.updated_at } }

          it 'returns issues updated between the given dates' do
            expect(issues).to contain_exactly(issue2, issue3)
          end
        end
417 418
      end

419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448
      context 'filtering by closed_at' do
        let!(:closed_issue1) { create(:issue, project: project1, state: :closed, closed_at: 1.week.ago) }
        let!(:closed_issue2) { create(:issue, project: project2, state: :closed, closed_at: 1.week.from_now) }
        let!(:closed_issue3) { create(:issue, project: project2, state: :closed, closed_at: 2.weeks.from_now) }

        context 'through closed_after' do
          let(:params) { { state: :closed, closed_after: closed_issue3.closed_at } }

          it 'returns issues closed on or after the given date' do
            expect(issues).to contain_exactly(closed_issue3)
          end
        end

        context 'through closed_before' do
          let(:params) { { state: :closed, closed_before: closed_issue1.closed_at } }

          it 'returns issues closed on or before the given date' do
            expect(issues).to contain_exactly(closed_issue1)
          end
        end

        context 'through closed_after and closed_before' do
          let(:params) { { state: :closed, closed_after: closed_issue2.closed_at, closed_before: closed_issue3.closed_at } }

          it 'returns issues closed between the given dates' do
            expect(issues).to contain_exactly(closed_issue2, closed_issue3)
          end
        end
      end

449
      context 'filtering by reaction name' do
Heinrich Lee Yu's avatar
Heinrich Lee Yu committed
450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465
        context 'user searches by no reaction' do
          let(:params) { { my_reaction_emoji: 'None' } }

          it 'returns issues that the user did not react to' do
            expect(issues).to contain_exactly(issue2, issue4)
          end
        end

        context 'user searches by any reaction' do
          let(:params) { { my_reaction_emoji: 'Any' } }

          it 'returns issues that the user reacted to' do
            expect(issues).to contain_exactly(issue1, issue3)
          end
        end

466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492
        context 'user searches by "thumbsup" reaction' do
          let(:params) { { my_reaction_emoji: 'thumbsup' } }

          it 'returns issues that the user thumbsup to' do
            expect(issues).to contain_exactly(issue1)
          end
        end

        context 'user2 searches by "thumbsup" reaction' do
          let(:search_user) { user2 }

          let(:params) { { my_reaction_emoji: 'thumbsup' } }

          it 'returns issues that the user2 thumbsup to' do
            expect(issues).to contain_exactly(issue2)
          end
        end

        context 'user searches by "thumbsdown" reaction' do
          let(:params) { { my_reaction_emoji: 'thumbsdown' } }

          it 'returns issues that the user thumbsdown to' do
            expect(issues).to contain_exactly(issue3)
          end
        end
      end

493 494 495 496 497 498 499 500 501 502
      context 'filtering by confidential' do
        set(:confidential_issue) { create(:issue, project: project1, confidential: true) }

        context 'no filtering' do
          it 'returns all issues' do
            expect(issues).to contain_exactly(issue1, issue2, issue3, issue4, confidential_issue)
          end
        end

        context 'user filters confidential issues' do
503
          let(:params) { { confidential: true } }
504 505 506 507 508 509 510

          it 'returns only confdential issues' do
            expect(issues).to contain_exactly(confidential_issue)
          end
        end

        context 'user filters only public issues' do
511
          let(:params) { { confidential: false } }
512 513 514 515 516 517 518

          it 'returns only confdential issues' do
            expect(issues).to contain_exactly(issue1, issue2, issue3, issue4)
          end
        end
      end

519 520 521 522 523 524
      context 'when the user is unauthorized' do
        let(:search_user) { nil }

        it 'returns no results' do
          expect(issues).to be_empty
        end
525 526
      end

527 528 529 530 531 532
      context 'when the user can see some, but not all, issues' do
        let(:search_user) { user2 }

        it 'returns only issues they can see' do
          expect(issues).to contain_exactly(issue2, issue3)
        end
533
      end
534 535 536

      it 'finds issues user can access due to group' do
        group = create(:group)
537
        project = create(:project, group: group)
538 539 540 541 542
        issue = create(:issue, project: project)
        group.add_user(user, :owner)

        expect(issues).to include(issue)
      end
543 544
    end

545
    context 'personal scope' do
546
      let(:scope) { 'assigned_to_me' }
547 548 549

      it 'returns issue assigned to the user' do
        expect(issues).to contain_exactly(issue1, issue2)
550 551
      end

552 553 554 555 556 557
      context 'filtering by project' do
        let(:params) { { project_id: project1.id } }

        it 'returns issues assigned to the user in that project' do
          expect(issues).to contain_exactly(issue1)
        end
558
      end
559
    end
560 561 562 563 564

    context 'when project restricts issues' do
      let(:scope) { nil }

      it "doesn't return team-only issues to non team members" do
565
        project = create(:project, :public, :issues_private)
566 567 568 569 570 571
        issue = create(:issue, project: project)

        expect(issues).not_to include(issue)
      end

      it "doesn't return issues if feature disabled" do
572
        [project1, project2, project3].each do |project|
573 574 575 576 577 578 579 580
          project.project_feature.update!(issues_access_level: ProjectFeature::DISABLED)
        end

        expect(issues.count).to eq 0
      end
    end
  end

581 582 583 584
  describe '#row_count', :request_store do
    it 'returns the number of rows for the default state' do
      finder = described_class.new(user)

585
      expect(finder.row_count).to eq(5)
586 587 588 589 590 591 592 593 594
    end

    it 'returns the number of rows for a given state' do
      finder = described_class.new(user, state: 'closed')

      expect(finder.row_count).to be_zero
    end
  end

595
  describe '#with_confidentiality_access_check' do
596 597
    let(:guest) { create(:user) }
    set(:authorized_user) { create(:user) }
598
    set(:project) { create(:project, namespace: authorized_user.namespace) }
599 600 601 602 603 604 605
    set(:public_issue) { create(:issue, project: project) }
    set(:confidential_issue) { create(:issue, project: project, confidential: true) }

    context 'when no project filter is given' do
      let(:params) { {} }

      context 'for an anonymous user' do
606
        subject { described_class.new(nil, params).with_confidentiality_access_check }
607 608 609 610 611 612 613 614

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end
      end

      context 'for a user without project membership' do
615
        subject { described_class.new(user, params).with_confidentiality_access_check }
616 617 618 619 620 621 622 623

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end
      end

      context 'for a guest user' do
624
        subject { described_class.new(guest, params).with_confidentiality_access_check }
625 626 627 628 629 630 631 632 633 634 635 636

        before do
          project.add_guest(guest)
        end

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end
      end

      context 'for a project member with access to view confidential issues' do
637
        subject { described_class.new(authorized_user, params).with_confidentiality_access_check }
638

639 640 641 642
        it 'returns all issues' do
          expect(subject).to include(public_issue, confidential_issue)
        end
      end
643 644
    end

645 646 647 648
    context 'when searching within a specific project' do
      let(:params) { { project_id: project.id } }

      context 'for an anonymous user' do
649
        subject { described_class.new(nil, params).with_confidentiality_access_check }
650 651 652 653 654 655 656 657 658 659 660 661 662 663

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end

        it 'does not filter by confidentiality' do
          expect(Issue).not_to receive(:where).with(a_string_matching('confidential'), anything)

          subject
        end
      end

      context 'for a user without project membership' do
664
        subject { described_class.new(user, params).with_confidentiality_access_check }
665 666 667 668 669 670 671 672 673 674 675 676 677 678

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end

        it 'filters by confidentiality' do
          expect(Issue).to receive(:where).with(a_string_matching('confidential'), anything)

          subject
        end
      end

      context 'for a guest user' do
679
        subject { described_class.new(guest, params).with_confidentiality_access_check }
680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697

        before do
          project.add_guest(guest)
        end

        it 'returns only public issues' do
          expect(subject).to include(public_issue)
          expect(subject).not_to include(confidential_issue)
        end

        it 'filters by confidentiality' do
          expect(Issue).to receive(:where).with(a_string_matching('confidential'), anything)

          subject
        end
      end

      context 'for a project member with access to view confidential issues' do
698
        subject { described_class.new(authorized_user, params).with_confidentiality_access_check }
699 700 701 702 703 704 705 706 707 708 709

        it 'returns all issues' do
          expect(subject).to include(public_issue, confidential_issue)
        end

        it 'does not filter by confidentiality' do
          expect(Issue).not_to receive(:where).with(a_string_matching('confidential'), anything)

          subject
        end
      end
710
    end
711
  end
712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838

  describe '#use_subquery_for_search?' do
    let(:finder) { described_class.new(nil, params) }

    before do
      allow(Gitlab::Database).to receive(:postgresql?).and_return(true)
      stub_feature_flags(use_subquery_for_group_issues_search: true)
    end

    context 'when there is no search param' do
      let(:params) { { attempt_group_search_optimizations: true } }

      it 'returns false' do
        expect(finder.use_subquery_for_search?).to be_falsey
      end
    end

    context 'when the database is not Postgres' do
      let(:params) { { search: 'foo', attempt_group_search_optimizations: true } }

      before do
        allow(Gitlab::Database).to receive(:postgresql?).and_return(false)
      end

      it 'returns false' do
        expect(finder.use_subquery_for_search?).to be_falsey
      end
    end

    context 'when the attempt_group_search_optimizations param is falsey' do
      let(:params) { { search: 'foo' } }

      it 'returns false' do
        expect(finder.use_subquery_for_search?).to be_falsey
      end
    end

    context 'when the use_subquery_for_group_issues_search flag is disabled' do
      let(:params) { { search: 'foo', attempt_group_search_optimizations: true } }

      before do
        stub_feature_flags(use_subquery_for_group_issues_search: false)
      end

      it 'returns false' do
        expect(finder.use_subquery_for_search?).to be_falsey
      end
    end

    context 'when all conditions are met' do
      let(:params) { { search: 'foo', attempt_group_search_optimizations: true } }

      it 'returns true' do
        expect(finder.use_subquery_for_search?).to be_truthy
      end
    end
  end

  describe '#use_cte_for_search?' do
    let(:finder) { described_class.new(nil, params) }

    before do
      allow(Gitlab::Database).to receive(:postgresql?).and_return(true)
      stub_feature_flags(use_cte_for_group_issues_search: true)
      stub_feature_flags(use_subquery_for_group_issues_search: false)
    end

    context 'when there is no search param' do
      let(:params) { { attempt_group_search_optimizations: true } }

      it 'returns false' do
        expect(finder.use_cte_for_search?).to be_falsey
      end
    end

    context 'when the database is not Postgres' do
      let(:params) { { search: 'foo', attempt_group_search_optimizations: true } }

      before do
        allow(Gitlab::Database).to receive(:postgresql?).and_return(false)
      end

      it 'returns false' do
        expect(finder.use_cte_for_search?).to be_falsey
      end
    end

    context 'when the attempt_group_search_optimizations param is falsey' do
      let(:params) { { search: 'foo' } }

      it 'returns false' do
        expect(finder.use_cte_for_search?).to be_falsey
      end
    end

    context 'when the use_cte_for_group_issues_search flag is disabled' do
      let(:params) { { search: 'foo', attempt_group_search_optimizations: true } }

      before do
        stub_feature_flags(use_cte_for_group_issues_search: false)
      end

      it 'returns false' do
        expect(finder.use_cte_for_search?).to be_falsey
      end
    end

    context 'when use_subquery_for_search? is true' do
      let(:params) { { search: 'foo', attempt_group_search_optimizations: true } }

      before do
        stub_feature_flags(use_subquery_for_group_issues_search: true)
      end

      it 'returns false' do
        expect(finder.use_cte_for_search?).to be_falsey
      end
    end

    context 'when all conditions are met' do
      let(:params) { { search: 'foo', attempt_group_search_optimizations: true } }

      it 'returns true' do
        expect(finder.use_cte_for_search?).to be_truthy
      end
    end
  end
839
end