.rubocop_todo.yml 22 KB
Newer Older
1
# This configuration was generated by
Douwe Maan's avatar
Douwe Maan committed
2 3
# `rubocop --auto-gen-config`
# on 2017-02-21 18:00:50 -0600 using RuboCop version 0.46.0.
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 10
10 11
# Cop supports --auto-correct.
Lint/UnifiedInteger:
Douwe Maan's avatar
Douwe Maan committed
12 13 14 15 16 17
  Exclude:
    - 'spec/lib/gitlab/metrics/method_call_spec.rb'
    - 'spec/lib/gitlab/metrics/metric_spec.rb'
    - 'spec/lib/gitlab/metrics/system_spec.rb'
    - 'spec/lib/gitlab/metrics/transaction_spec.rb'
    - 'spec/models/repository_spec.rb'
18

Douwe Maan's avatar
Douwe Maan committed
19
# Offense count: 23
20 21
# Cop supports --auto-correct.
Lint/UnneededSplatExpansion:
Douwe Maan's avatar
Douwe Maan committed
22 23 24 25 26 27 28 29 30 31 32 33 34 35
  Exclude:
    - 'app/services/projects/update_pages_service.rb'
    - 'config/application.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/bitbucket/page.rb'
    - 'lib/gitlab/markup_helper.rb'
    - 'spec/helpers/auth_helper_spec.rb'
    - 'spec/models/project_wiki_spec.rb'
    - 'spec/requests/api/projects_spec.rb'
    - 'spec/requests/api/tags_spec.rb'
    - 'spec/requests/api/v3/projects_spec.rb'
    - 'spec/support/seed_helper.rb'
    - 'spec/support/test_env.rb'

36
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
37 38
# Cop supports --auto-correct.
Performance/RedundantBlockCall:
Douwe Maan's avatar
Douwe Maan committed
39 40 41 42
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'lib/gitlab/optimistic_locking.rb'
    - 'lib/gitlab/shell.rb'
Connor Shea's avatar
Connor Shea committed
43

44
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
45 46
# Cop supports --auto-correct.
Performance/RedundantMatch:
Douwe Maan's avatar
Douwe Maan committed
47 48 49 50 51 52
  Exclude:
    - 'app/models/external_issue.rb'
    - 'lib/ci/api/helpers.rb'
    - 'lib/extracts_path.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/diff/parser.rb'
Connor Shea's avatar
Connor Shea committed
53

Douwe Maan's avatar
Douwe Maan committed
54
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
55 56 57 58 59
# Cop supports --auto-correct.
# Configuration parameters: MaxKeyValuePairs.
Performance/RedundantMerge:
  Enabled: false

60
# Offense count: 15
61 62
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup:
Douwe Maan's avatar
Douwe Maan committed
63 64 65 66 67 68 69 70 71
  Exclude:
    - 'spec/features/issues_spec.rb'
    - 'spec/features/notes_on_merge_requests_spec.rb'
    - 'spec/lib/gitlab/git_access_spec.rb'
    - 'spec/models/project_snippet_spec.rb'
    - 'spec/models/protected_branch_spec.rb'
    - 'spec/routing/routing_spec.rb'

# Offense count: 63
72 73 74 75 76
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Enabled: false

77 78 79 80
# Offense count: 12
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should
RSpec/ImplicitExpect:
Douwe Maan's avatar
Douwe Maan committed
81 82 83 84 85
  Exclude:
    - 'spec/lib/banzai/renderer_spec.rb'
    - 'spec/models/project_group_link_spec.rb'
    - 'spec/models/project_services/external_wiki_service_spec.rb'
    - 'spec/models/project_spec.rb'
86 87 88

# Offense count: 1
RSpec/SingleArgumentMessageChain:
Douwe Maan's avatar
Douwe Maan committed
89 90
  Exclude:
    - 'spec/requests/api/internal_spec.rb'
91

Douwe Maan's avatar
Douwe Maan committed
92
# Offense count: 126
93 94 95 96 97 98
# Cop supports --auto-correct.
# Configuration parameters: Whitelist.
# Whitelist: find_by_sql
Rails/DynamicFindBy:
  Enabled: false

Connor Shea's avatar
Connor Shea committed
99 100 101 102
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/Validation:
Douwe Maan's avatar
Douwe Maan committed
103 104 105 106 107 108 109 110 111 112 113 114
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/ci/runner_project.rb'
    - 'app/models/ci/trigger.rb'
    - 'app/models/commit_status.rb'
    - 'app/models/members/group_member.rb'
    - 'app/models/members/project_member.rb'
    - 'app/models/pages_domain.rb'
    - 'app/models/project.rb'
    - 'app/models/protected_branch.rb'
    - 'app/models/user.rb'
Connor Shea's avatar
Connor Shea committed
115

116
# Offense count: 8
117
# Cop supports --auto-correct.
118
# Configuration parameters: AutoCorrect.
119
Security/JSONLoad:
Douwe Maan's avatar
Douwe Maan committed
120 121 122 123 124 125 126
  Exclude:
    - 'db/migrate/20161019190736_migrate_sidekiq_queues_from_default.rb'
    - 'db/migrate/20161024042317_migrate_mailroom_queue_from_default.rb'
    - 'db/migrate/20161124141322_migrate_process_commit_worker_jobs.rb'
    - 'spec/migrations/migrate_process_commit_worker_jobs_spec.rb'
    - 'spec/models/project_services/irker_service_spec.rb'
    - 'spec/support/stub_gitlab_calls.rb'
127

Douwe Maan's avatar
Douwe Maan committed
128
# Offense count: 55
Connor Shea's avatar
Connor Shea committed
129 130 131 132 133 134
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
135
# Offense count: 399
Connor Shea's avatar
Connor Shea committed
136 137 138 139 140 141
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: braces, no_braces, context_dependent
Style/BracesAroundHashParameters:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
142
# Offense count: 33
Connor Shea's avatar
Connor Shea committed
143 144 145 146
# Cop supports --auto-correct.
Style/ColonMethodCall:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
147
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
148 149 150 151 152 153
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
154
# Offense count: 6
155
# Cop supports --auto-correct.
Connor Shea's avatar
Connor Shea committed
156
Style/EachWithObject:
Douwe Maan's avatar
Douwe Maan committed
157 158 159 160 161 162 163
  Exclude:
    - 'app/services/merge_requests/get_urls_service.rb'
    - 'lib/ci/ansi2html.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
Connor Shea's avatar
Connor Shea committed
164

165
# Offense count: 24
Connor Shea's avatar
Connor Shea committed
166 167 168 169 170 171
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

172
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
173 174
# Cop supports --auto-correct.
Style/EmptyLiteral:
Douwe Maan's avatar
Douwe Maan committed
175 176 177 178 179
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
180

Douwe Maan's avatar
Douwe Maan committed
181
# Offense count: 55
182 183 184 185
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
186
  Enabled: false
Connor Shea's avatar
Connor Shea committed
187

Douwe Maan's avatar
Douwe Maan committed
188
# Offense count: 173
Connor Shea's avatar
Connor Shea committed
189 190 191 192 193
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
  Enabled: false

194
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
195 196 197
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
198 199 200 201 202 203 204 205 206
  Exclude:
    - 'app/models/ci/pipeline.rb'
    - 'app/services/gravatar_service.rb'
    - 'config/initializers/rack_lineprof.rb'
    - 'lib/gitlab/version_info.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/services/issues/move_service_spec.rb'

# Offense count: 261
Connor Shea's avatar
Connor Shea committed
207 208 209 210
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
211
# Offense count: 12
Connor Shea's avatar
Connor Shea committed
212
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
213 214 215 216 217 218 219 220 221 222 223 224 225 226
  Exclude:
    - 'app/controllers/projects/forks_controller.rb'
    - 'app/controllers/projects/imports_controller.rb'
    - 'app/helpers/milestones_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/services/system_note_service.rb'
    - 'config/initializers/1_settings.rb'
    - 'lib/gitlab/auth.rb'
    - 'lib/gitlab/checks/change_access.rb'
    - 'lib/gitlab/database.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'

# Offense count: 178
Connor Shea's avatar
Connor Shea committed
227 228 229 230 231
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
232
# Offense count: 61
Connor Shea's avatar
Connor Shea committed
233 234 235 236 237 238
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
239
# Offense count: 110
Connor Shea's avatar
Connor Shea committed
240 241 242 243 244 245
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
246
# Offense count: 45
Connor Shea's avatar
Connor Shea committed
247 248 249 250
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
251
  Enabled: false
Connor Shea's avatar
Connor Shea committed
252

Douwe Maan's avatar
Douwe Maan committed
253
# Offense count: 7
Connor Shea's avatar
Connor Shea committed
254 255
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Douwe Maan's avatar
Douwe Maan committed
256 257 258 259 260 261
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/git_operation_service.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
262

Douwe Maan's avatar
Douwe Maan committed
263
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
264 265
# Cop supports --auto-correct.
Style/MethodCallParentheses:
Douwe Maan's avatar
Douwe Maan committed
266 267 268 269 270 271 272 273 274 275 276 277 278
  Exclude:
    - 'lib/ci/ansi2html.rb'
    - 'spec/controllers/projects/issues_controller_spec.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/controllers/projects/snippets_controller_spec.rb'
    - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_assignee_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_author_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_milestone_spec.rb'
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/helpers/submodule_helper_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
Connor Shea's avatar
Connor Shea committed
279

280
# Offense count: 9
281
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
282 283 284 285 286 287 288 289 290 291
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/models/commit.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/repository.rb'
    - 'config/initializers/gollum.rb'
    - 'lib/bitbucket/collection.rb'
    - 'lib/gitlab/github_import/client.rb'
    - 'lib/gitlab/lazy.rb'
    - 'lib/uploaded_file.rb'
292

293 294 295
# Offense count: 3
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Douwe Maan's avatar
Douwe Maan committed
296 297 298 299
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'lib/gitlab/workhorse.rb'
300

301
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
302 303
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
304 305 306 307 308
  Exclude:
    - 'app/helpers/commits_helper.rb'
    - 'app/workers/irker_worker.rb'
    - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
    - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
Connor Shea's avatar
Connor Shea committed
309

Douwe Maan's avatar
Douwe Maan committed
310
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
311 312 313 314
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
315 316 317 318 319 320 321 322 323 324 325 326 327
  Exclude:
    - 'app/models/namespace.rb'
    - 'app/models/user.rb'
    - 'app/services/merge_requests/refresh_service.rb'
    - 'config/initializers/secret_token.rb'
    - 'db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
    - 'db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
    - 'lib/banzai/filter/math_filter.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/metrics/instrumentation.rb'
    - 'lib/gitlab/metrics/sampler.rb'
    - 'lib/gitlab/project_search_results.rb'
Connor Shea's avatar
Connor Shea committed
328

329
# Offense count: 19
330 331 332 333
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349
  Exclude:
    - 'config/initializers/1_settings.rb'
    - 'config/initializers/secret_token.rb'
    - 'lib/gitlab/import_export/command_line_util.rb'
    - 'lib/gitlab/shell.rb'
    - 'lib/gitlab/workhorse.rb'
    - 'spec/features/projects/import_export/export_file_spec.rb'
    - 'spec/lib/gitlab/git/blob_spec.rb'
    - 'spec/lib/gitlab/git/hook_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'
    - 'spec/support/test_env.rb'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 68
350
# Cop supports --auto-correct.
351
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
352 353 354 355
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
356
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
357 358 359 360
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
361
# Offense count: 459
Connor Shea's avatar
Connor Shea committed
362 363 364 365 366
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

367
# Offense count: 10
Connor Shea's avatar
Connor Shea committed
368 369 370 371
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals:
Douwe Maan's avatar
Douwe Maan committed
372 373 374 375 376 377 378
  Exclude:
    - 'spec/lib/gitlab/diff/highlight_spec.rb'
    - 'spec/models/project_services/bamboo_service_spec.rb'
    - 'spec/models/project_services/buildkite_service_spec.rb'
    - 'spec/models/project_services/drone_ci_service_spec.rb'
    - 'spec/models/project_services/teamcity_service_spec.rb'
    - 'spec/workers/repository_import_worker_spec.rb'
Connor Shea's avatar
Connor Shea committed
379

Connor Shea's avatar
Connor Shea committed
380
# Offense count: 13
Connor Shea's avatar
Connor Shea committed
381 382
# Cop supports --auto-correct.
Style/PerlBackrefs:
Douwe Maan's avatar
Douwe Maan committed
383 384 385 386 387 388 389 390 391 392 393 394 395
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

# Offense count: 72
Connor Shea's avatar
Connor Shea committed
396 397 398 399 400 401 402
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
Style/PredicateName:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
403
# Offense count: 39
404
# Cop supports --auto-correct.
405 406
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: short, verbose
407
Style/PreferredHashMethods:
Connor Shea's avatar
Connor Shea committed
408 409
  Enabled: false

410
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
411 412
# Cop supports --auto-correct.
Style/Proc:
Douwe Maan's avatar
Douwe Maan committed
413 414 415 416 417 418 419
  Exclude:
    - 'app/mailers/base_mailer.rb'
    - 'app/models/milestone.rb'
    - 'app/models/service.rb'
    - 'lib/api/api_guard.rb'
    - 'lib/gitlab/ldap/config.rb'
    - 'spec/initializers/trusted_proxies_spec.rb'
Connor Shea's avatar
Connor Shea committed
420

Douwe Maan's avatar
Douwe Maan committed
421
# Offense count: 62
Connor Shea's avatar
Connor Shea committed
422 423 424 425 426 427
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
428
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
429 430
# Cop supports --auto-correct.
Style/RedundantBegin:
Douwe Maan's avatar
Douwe Maan committed
431 432 433 434
  Exclude:
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/gitlab/git/commit.rb'
Connor Shea's avatar
Connor Shea committed
435

Douwe Maan's avatar
Douwe Maan committed
436
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
437 438
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
439 440 441 442 443 444 445 446 447 448 449 450 451 452 453
  Exclude:
    - 'app/models/commit.rb'
    - 'app/models/merge_request.rb'
    - 'app/validators/color_validator.rb'
    - 'app/validators/line_code_validator.rb'
    - 'lib/api/templates.rb'
    - 'lib/api/v3/templates.rb'
    - 'lib/banzai/filter/blockquote_fence_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/banzai/filter/yaml_front_matter_filter.rb'
    - 'lib/gitlab/diff/inline_diff.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'lib/gitlab/middleware/static.rb'
    - 'lib/gitlab/regex.rb'
Connor Shea's avatar
Connor Shea committed
454

Douwe Maan's avatar
Douwe Maan committed
455
# Offense count: 15
456 457 458
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Douwe Maan's avatar
Douwe Maan committed
459 460 461 462 463 464 465 466 467 468 469 470
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/groups_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/labels_controller.rb'
    - 'app/controllers/projects/milestones_controller.rb'
    - 'app/services/access_token_validation_service.rb'

# Offense count: 365
Connor Shea's avatar
Connor Shea committed
471 472 473 474
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
475
# Offense count: 107
Connor Shea's avatar
Connor Shea committed
476 477 478 479 480 481
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
482
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
483 484
# Cop supports --auto-correct.
Style/RescueModifier:
485
  Enabled: false
486 487

# Offense count: 7
Connor Shea's avatar
Connor Shea committed
488 489
# Cop supports --auto-correct.
Style/SelfAssignment:
Douwe Maan's avatar
Douwe Maan committed
490 491 492 493 494 495
  Exclude:
    - 'app/models/project_team.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
496 497 498

# Offense count: 2
# Configuration parameters: Methods.
499
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Connor Shea's avatar
Connor Shea committed
500
Style/SingleLineBlockParams:
Douwe Maan's avatar
Douwe Maan committed
501 502 503
  Exclude:
    - 'app/models/commit.rb'
    - 'spec/support/services_shared_context.rb'
Connor Shea's avatar
Connor Shea committed
504 505 506 507 508

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Douwe Maan's avatar
Douwe Maan committed
509 510
  Exclude:
    - 'lib/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
511

Douwe Maan's avatar
Douwe Maan committed
512
# Offense count: 150
Connor Shea's avatar
Connor Shea committed
513 514 515 516 517 518
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
Style/SpaceBeforeBlockBraces:
  Enabled: false

519
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
520 521 522
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
Douwe Maan's avatar
Douwe Maan committed
523 524 525 526 527 528
  Exclude:
    - 'config/routes/project.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/system_note_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
529

Douwe Maan's avatar
Douwe Maan committed
530
# Offense count: 38
531 532 533 534
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral:
Douwe Maan's avatar
Douwe Maan committed
535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552
  Exclude:
    - 'app/models/commit_status.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/issue.rb'
    - 'app/models/member.rb'
    - 'lib/api/entities.rb'
    - 'lib/file_size_validator.rb'
    - 'lib/gitlab/visibility_level.rb'
    - 'spec/models/concerns/participable_spec.rb'
    - 'spec/models/cycle_analytics/code_spec.rb'
    - 'spec/models/cycle_analytics/issue_spec.rb'
    - 'spec/models/cycle_analytics/plan_spec.rb'
    - 'spec/models/cycle_analytics/production_spec.rb'
    - 'spec/models/cycle_analytics/review_spec.rb'
    - 'spec/models/cycle_analytics/staging_spec.rb'
    - 'spec/models/cycle_analytics/test_spec.rb'

# Offense count: 205
Connor Shea's avatar
Connor Shea committed
553 554 555 556 557 558
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
559
# Offense count: 90
Connor Shea's avatar
Connor Shea committed
560 561 562
# Cop supports --auto-correct.
Style/SpaceInsideParens:
  Enabled: false
563

564
# Offense count: 4
565 566
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
Douwe Maan's avatar
Douwe Maan committed
567 568
  Exclude:
    - 'lib/gitlab/git_access.rb'
Connor Shea's avatar
Connor Shea committed
569

Douwe Maan's avatar
Douwe Maan committed
570
# Offense count: 52
Connor Shea's avatar
Connor Shea committed
571 572 573 574 575 576
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

577
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
578 579 580 581
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
582 583 584 585 586 587 588 589 590 591 592 593 594 595 596
  Exclude:
    - 'app/helpers/labels_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/helpers/todos_helper.rb'
    - 'app/models/application_setting.rb'
    - 'app/models/project_services/campfire_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'db/migrate/20161017125927_add_unique_index_to_labels.rb'
    - 'features/steps/groups.rb'
    - 'features/steps/project/merge_requests.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/ci/gitlab_ci_yaml_processor.rb'
    - 'lib/gitlab/google_code_import/importer.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/models/project_services/hipchat_service_spec.rb'
597

Douwe Maan's avatar
Douwe Maan committed
598
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
599 600 601 602 603 604
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

605 606 607
# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
608
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
609
Style/TernaryParentheses:
Douwe Maan's avatar
Douwe Maan committed
610 611 612 613 614 615
  Exclude:
    - 'features/support/capybara.rb'
    - 'lib/api/v3/projects.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/support/capybara.rb'
616

Douwe Maan's avatar
Douwe Maan committed
617
# Offense count: 43
Connor Shea's avatar
Connor Shea committed
618 619 620 621 622 623 624 625 626 627
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
  Enabled: false

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Douwe Maan's avatar
Douwe Maan committed
628 629 630 631 632 633 634
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/controllers/projects/git_http_client_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/logger.rb'
Connor Shea's avatar
Connor Shea committed
635

Douwe Maan's avatar
Douwe Maan committed
636
# Offense count: 76
Connor Shea's avatar
Connor Shea committed
637 638 639 640
# Cop supports --auto-correct.
Style/TrailingWhitespace:
  Enabled: false

641
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
642 643 644 645
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Douwe Maan's avatar
Douwe Maan committed
646 647 648 649
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
    - 'lib/gitlab/ldap/person.rb'
Connor Shea's avatar
Connor Shea committed
650

651
# Offense count: 2
Connor Shea's avatar
Connor Shea committed
652 653
# Cop supports --auto-correct.
Style/UnlessElse:
Douwe Maan's avatar
Douwe Maan committed
654 655 656
  Exclude:
    - 'lib/gitlab/project_search_results.rb'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
657

Douwe Maan's avatar
Douwe Maan committed
658
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
659 660
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676
  Exclude:
    - 'app/helpers/boards_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/helpers/search_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/project_services/pushover_service.rb'
    - 'features/steps/project/forked_merge_requests.rb'
    - 'spec/controllers/admin/services_controller_spec.rb'
    - 'spec/features/admin/admin_projects_spec.rb'
    - 'spec/features/issues_spec.rb'
    - 'spec/features/projects/branches_spec.rb'
    - 'spec/features/projects/issuable_templates_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/requests/api/issues_spec.rb'
    - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
Connor Shea's avatar
Connor Shea committed
677 678 679 680

# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Douwe Maan's avatar
Douwe Maan committed
681 682 683 684 685 686 687 688
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/models/repository.rb'
    - 'lib/extracts_path.rb'