.rubocop_todo.yml 21.2 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Rémy Coutable's avatar
Rémy Coutable committed
2
# `rubocop --auto-gen-config`
3
# on 2018-01-18 18:23:26 +0100 using RuboCop version 0.52.1.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 181
Rémy Coutable's avatar
Rémy Coutable committed
10 11 12
Capybara/CurrentPathExpectation:
  Enabled: false

13
# Offense count: 167
Rémy Coutable's avatar
Rémy Coutable committed
14 15 16 17
# Cop supports --auto-correct.
Layout/EmptyLinesAroundArguments:
  Enabled: false

18
# Offense count: 253
19 20 21 22 23
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Layout/ExtraSpacing:
  Enabled: false

24
# Offense count: 83
25
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
26
# Configuration parameters: EnforcedStyle, IndentationWidth.
27 28 29 30
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Layout/IndentArray:
  Enabled: false

31
# Offense count: 237
32
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
33
# Configuration parameters: EnforcedStyle, IndentationWidth.
34 35 36 37
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Layout/IndentHash:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
38 39 40
# Offense count: 93
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
41 42 43 44
# SupportedStyles: require_no_space, require_space
Layout/SpaceInLambdaLiteral:
  Enabled: false

45
# Offense count: 327
Rémy Coutable's avatar
Rémy Coutable committed
46 47
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
48 49 50 51 52
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
  Enabled: false

53
# Offense count: 156
54 55 56 57
# Cop supports --auto-correct.
Layout/SpaceInsideParens:
  Enabled: false

58
# Offense count: 26
Rémy Coutable's avatar
Rémy Coutable committed
59 60 61 62 63 64 65 66 67 68 69 70 71 72 73
Lint/DuplicateMethods:
  Exclude:
    - 'app/models/application_setting.rb'
    - 'app/models/commit.rb'
    - 'app/models/note.rb'
    - 'app/services/merge_requests/merge_service.rb'
    - 'lib/bitbucket/representation/repo.rb'
    - 'lib/declarative_policy/base.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'lib/gitlab/cycle_analytics/base_event_fetcher.rb'
    - 'lib/gitlab/diff/formatters/base_formatter.rb'
    - 'lib/gitlab/git/blob.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/git/tree.rb'
    - 'lib/gitlab/git/wiki_page.rb'
74 75
    - 'lib/gitlab/auth/ldap/person.rb'
    - 'lib/gitlab/auth/o_auth/user.rb'
Rémy Coutable's avatar
Rémy Coutable committed
76 77 78 79 80 81 82 83

# Offense count: 4
Lint/InterpolationCheck:
  Exclude:
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/features/users_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'

84
# Offense count: 206
Rémy Coutable's avatar
Rémy Coutable committed
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
  Enabled: false

# Offense count: 1
Lint/ReturnInVoidContext:
  Exclude:
    - 'app/models/project.rb'

# Offense count: 9
Lint/UriEscapeUnescape:
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'spec/lib/google_api/auth_spec.rb'
    - 'spec/requests/api/files_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/requests/api/issues_spec.rb'

104 105 106 107 108 109
# Offense count: 1
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310

Rémy Coutable's avatar
Rémy Coutable committed
110 111 112 113 114 115 116 117
# Offense count: 11
# Configuration parameters: EnforcedStyle.
# SupportedStyles: lowercase, uppercase
Naming/HeredocDelimiterCase:
  Exclude:
    - 'spec/lib/gitlab/diff/parser_spec.rb'
    - 'spec/lib/json_web_token/rsa_token_spec.rb'
    - 'spec/models/commit_spec.rb'
118 119
    - 'spec/support/helpers/repo_helpers.rb'
    - 'spec/support/helpers/seed_repo.rb'
Rémy Coutable's avatar
Rémy Coutable committed
120

121
# Offense count: 112
Rémy Coutable's avatar
Rémy Coutable committed
122 123 124 125 126 127
# Configuration parameters: Blacklist.
# Blacklist: END, (?-mix:EO[A-Z]{1})
Naming/HeredocDelimiterNaming:
  Enabled: false


128
# Offense count: 3821
Rémy Coutable's avatar
Rémy Coutable committed
129 130 131
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
132 133
  Enabled: false

134
# Offense count: 293
135 136 137
RSpec/EmptyLineAfterFinalLet:
  Enabled: false

138
# Offense count: 188
139 140 141
RSpec/EmptyLineAfterSubject:
  Enabled: false

142 143 144 145 146 147 148
# Offense count: 258
# Configuration parameters: EnforcedStyle.
# SupportedStyles: method_call, block
RSpec/ExpectChange:
  Enabled: false

# Offense count: 221
Rémy Coutable's avatar
Rémy Coutable committed
149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
RSpec/ExpectInHook:
  Enabled: false

# Offense count: 7
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Exclude:
    - 'spec/spec_helper.rb'
    - 'spec/support/carrierwave.rb'
    - 'spec/support/db_cleaner.rb'
    - 'spec/support/gitaly.rb'
    - 'spec/support/setup_builds_storage.rb'

# Offense count: 19
# Configuration parameters: EnforcedStyle.
165 166
# SupportedStyles: it_behaves_like, it_should_behave_like
RSpec/ItBehavesLike:
Rémy Coutable's avatar
Rémy Coutable committed
167 168 169 170 171 172
  Exclude:
    - 'spec/lib/gitlab/git/commit_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/shell_spec.rb'
    - 'spec/services/notification_service_spec.rb'
    - 'spec/workers/git_garbage_collect_worker_spec.rb'
173

Rémy Coutable's avatar
Rémy Coutable committed
174
# Offense count: 5
175
RSpec/IteratedExpectation:
Rémy Coutable's avatar
Rémy Coutable committed
176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198
  Exclude:
    - 'spec/features/admin/admin_settings_spec.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/awards/user_interacts_with_awards_in_issue_spec.rb'
    - 'spec/lib/gitlab/gitlab_import/client_spec.rb'
    - 'spec/lib/gitlab/legacy_github_import/client_spec.rb'

# Offense count: 75
RSpec/LetBeforeExamples:
  Exclude:
    - 'spec/controllers/projects/commit_controller_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/lib/banzai/filter/user_reference_filter_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/milestone_spec.rb'
    - 'spec/models/project_services/packagist_service_spec.rb'
    - 'spec/models/repository_spec.rb'
    - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
    - 'spec/serializers/pipeline_details_entity_spec.rb'
    - 'spec/views/ci/lints/show.html.haml_spec.rb'
199

Rémy Coutable's avatar
Rémy Coutable committed
200 201 202 203 204 205
# Offense count: 1
RSpec/MultipleSubjects:
  Exclude:
    - 'spec/services/merge_requests/create_from_issue_service_spec.rb'

# Offense count: 4
206
RSpec/OverwritingSetup:
Rémy Coutable's avatar
Rémy Coutable committed
207 208 209 210 211 212
  Exclude:
    - 'spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb'
    - 'spec/models/email_spec.rb'
    - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
    - 'spec/services/notes/quick_actions_service_spec.rb'

213
# Offense count: 965
Rémy Coutable's avatar
Rémy Coutable committed
214 215 216
# Configuration parameters: Strict, EnforcedStyle.
# SupportedStyles: inflected, explicit
RSpec/PredicateMatcher:
217 218
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
219
# Offense count: 35
220 221 222
RSpec/RepeatedExample:
  Enabled: false

223
# Offense count: 140
Rémy Coutable's avatar
Rémy Coutable committed
224 225 226 227 228
# Configuration parameters: EnforcedStyle.
# SupportedStyles: and_return, block
RSpec/ReturnFromStub:
  Enabled: false

229
# Offense count: 112
230 231 232
RSpec/ScatteredLet:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
233
# Offense count: 22
234
RSpec/ScatteredSetup:
Rémy Coutable's avatar
Rémy Coutable committed
235 236 237 238 239 240
  Exclude:
    - 'spec/controllers/projects/templates_controller_spec.rb'
    - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
    - 'spec/lib/gitlab/git/env_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/services/projects/create_service_spec.rb'
241

242
# Offense count: 1
243
RSpec/SharedContext:
Rémy Coutable's avatar
Rémy Coutable committed
244 245 246 247 248 249 250 251 252 253 254 255
  Exclude:
    - 'spec/features/admin/admin_groups_spec.rb'

# Offense count: 5
RSpec/VoidExpect:
  Exclude:
    - 'spec/features/projects/artifacts/download_spec.rb'
    - 'spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb'
    - 'spec/models/ci/group_spec.rb'
    - 'spec/models/ci/runner_spec.rb'
    - 'spec/services/users/destroy_service_spec.rb'

256
# Offense count: 41
Rémy Coutable's avatar
Rémy Coutable committed
257 258 259
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/CreateTableWithTimestamps:
Douwe Maan's avatar
Douwe Maan committed
260 261
  Enabled: false

262
# Offense count: 155
263 264 265
Rails/FilePath:
  Enabled: false

266
# Offense count: 121
Rémy Coutable's avatar
Rémy Coutable committed
267 268 269 270 271
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
  Enabled: false

272
# Offense count: 157
Rémy Coutable's avatar
Rémy Coutable committed
273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/InverseOf:
  Enabled: false

# Offense count: 48
# Configuration parameters: Include.
# Include: app/controllers/**/*.rb
Rails/LexicallyScopedActionFilter:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Rails/Presence:
  Exclude:
    - 'app/controllers/projects/blob_controller.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/clusters/platforms/kubernetes.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/concerns/token_authenticatable.rb'
    - 'app/models/project_services/hipchat_service.rb'
    - 'app/models/project_services/irker_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'app/models/project_services/kubernetes_service.rb'
    - 'app/models/project_services/packagist_service.rb'
    - 'app/models/wiki_page.rb'
    - 'lib/gitlab/git/hook.rb'
    - 'lib/gitlab/github_import/importer/releases_importer.rb'

302 303 304 305
# Offense count: 2
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/ReversibleMigration:
Rémy Coutable's avatar
Rémy Coutable committed
306 307
  Exclude:
    - 'db/migrate/20160824103857_drop_unused_ci_tables.rb'
308

309
# Offense count: 446
310 311 312
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
Douwe Maan's avatar
Douwe Maan committed
313 314
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
315 316 317 318 319 320
# Offense count: 1
# Configuration parameters: Environments.
# Environments: development, test, production
Rails/UnknownEnv:
  Exclude:
    - 'db/migrate/20171124125748_populate_missing_merge_request_statuses.rb'
321

Rémy Coutable's avatar
Rémy Coutable committed
322
# Offense count: 13
323
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
324 325 326 327 328 329 330 331 332 333 334 335
Security/YAMLLoad:
  Exclude:
    - 'config/initializers/carrierwave.rb'
    - 'lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits.rb'
    - 'lib/gitlab/redis/wrapper.rb'
    - 'lib/system_check/incoming_email/imap_authentication_check.rb'
    - 'spec/config/mail_room_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'
    - 'spec/models/clusters/platforms/kubernetes_spec.rb'
    - 'spec/models/project_services/kubernetes_service_spec.rb'

336
# Offense count: 64
Rémy Coutable's avatar
Rémy Coutable committed
337 338
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
339 340 341
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false
342

Rémy Coutable's avatar
Rémy Coutable committed
343 344 345 346 347 348 349 350
# Offense count: 5
Style/CommentedKeyword:
  Exclude:
    - 'lib/tasks/gitlab/backup.rake'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 30
Style/DateTime:
Douwe Maan's avatar
Douwe Maan committed
351
  Enabled: false
Connor Shea's avatar
Connor Shea committed
352

Rémy Coutable's avatar
Rémy Coutable committed
353
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
354
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374
Style/Dir:
  Exclude:
    - 'qa/qa.rb'

# Offense count: 9
# Cop supports --auto-correct.
Style/EachWithObject:
  Exclude:
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ci/ansi2html.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/hook_data/issuable_builder.rb'
    - 'lib/gitlab/i18n/po_linter.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'scripts/static-analysis'

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
375 376 377 378
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
379 380 381 382 383 384 385 386
# Offense count: 14
# Cop supports --auto-correct.
Style/EmptyLambdaParameter:
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/runner.rb'

# Offense count: 12
Connor Shea's avatar
Connor Shea committed
387 388
# Cop supports --auto-correct.
Style/EmptyLiteral:
Rémy Coutable's avatar
Rémy Coutable committed
389 390 391 392 393
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/gitaly_client.rb'
394
    - 'scripts/trigger-build'
Rémy Coutable's avatar
Rémy Coutable committed
395 396 397 398 399
    - 'spec/features/merge_requests/versions_spec.rb'
    - 'spec/helpers/merge_requests_helper_spec.rb'
    - 'spec/lib/gitlab/request_context_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
400
    - 'spec/support/shared_examples/chat_slash_commands_shared_examples.rb'
401

402
# Offense count: 102
403
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
404
# Configuration parameters: EnforcedStyle.
405 406
# SupportedStyles: compact, expanded
Style/EmptyMethod:
407
  Enabled: false
Connor Shea's avatar
Connor Shea committed
408

409
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
410
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
411 412 413 414 415 416 417 418
Style/Encoding:
  Enabled: false

# Offense count: 2
Style/EvalWithLocation:
  Exclude:
    - 'app/models/service.rb'

419
# Offense count: 35
Rémy Coutable's avatar
Rémy Coutable committed
420 421
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
422 423
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
424 425
  Enabled: false

426
# Offense count: 384
Connor Shea's avatar
Connor Shea committed
427 428 429 430
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

431
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
432
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
433 434
  Enabled: false

435
# Offense count: 809
Connor Shea's avatar
Connor Shea committed
436 437 438 439
# Cop supports --auto-correct.
Style/IfUnlessModifier:
  Enabled: false

440
# Offense count: 75
Connor Shea's avatar
Connor Shea committed
441
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
442
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
443 444
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
445
  Enabled: false
Connor Shea's avatar
Connor Shea committed
446

Rémy Coutable's avatar
Rémy Coutable committed
447
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
448 449
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Rémy Coutable's avatar
Rémy Coutable committed
450 451 452 453 454 455
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'spec/features/issuables/markdown_references_spec.rb'
    - 'spec/lib/gitlab/checks/project_moved_spec.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
456

Rémy Coutable's avatar
Rémy Coutable committed
457
# Offense count: 39
Connor Shea's avatar
Connor Shea committed
458
# Cop supports --auto-correct.
459
Style/MethodCallWithoutArgsParentheses:
Douwe Maan's avatar
Douwe Maan committed
460
  Enabled: false
Connor Shea's avatar
Connor Shea committed
461

462
# Offense count: 18
463
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
464
  Enabled: false
465

Rémy Coutable's avatar
Rémy Coutable committed
466 467 468 469 470 471 472 473 474 475 476
# Offense count: 7
Style/MixinUsage:
  Exclude:
    - 'features/support/env.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/job_artifacts.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/factories/notes.rb'
    - 'spec/lib/gitlab/import_export/project_tree_restorer_spec.rb'
    - 'spec/lib/gitlab/import_export/version_checker_spec.rb'

477
# Offense count: 6
478 479
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Rémy Coutable's avatar
Rémy Coutable committed
480 481 482 483 484 485 486
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'app/services/ci/process_pipeline_service.rb'
    - 'app/services/create_deployment_service.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/ci/trace.rb'
487

488
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
489
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
490 491
# Configuration parameters: Whitelist.
# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
Connor Shea's avatar
Connor Shea committed
492
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
493
  Enabled: false
Connor Shea's avatar
Connor Shea committed
494

495
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
496
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
497
# Configuration parameters: EnforcedStyle, MinBodyLength.
Connor Shea's avatar
Connor Shea committed
498 499
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
500
  Enabled: false
Connor Shea's avatar
Connor Shea committed
501

502
# Offense count: 61
Z.J. van de Weg's avatar
Z.J. van de Weg committed
503
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
504
# Configuration parameters: EnforcedOctalStyle.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
505 506
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
507
  Enabled: false
Douwe Maan's avatar
Douwe Maan committed
508

509
# Offense count: 114
510
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
511
# Configuration parameters: AutoCorrect, EnforcedStyle.
512 513 514 515
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
516 517 518 519 520 521 522 523 524
# Offense count: 4
# Cop supports --auto-correct.
Style/OrAssignment:
  Exclude:
    - 'app/models/concerns/token_authenticatable.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/project_transfer.rb'

# Offense count: 50
Connor Shea's avatar
Connor Shea committed
525 526 527 528
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

529
# Offense count: 917
Connor Shea's avatar
Connor Shea committed
530 531 532 533 534
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

535
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
536 537
# Cop supports --auto-correct.
Style/PerlBackrefs:
Rémy Coutable's avatar
Rémy Coutable committed
538 539 540 541 542 543 544 545 546 547 548 549 550
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

551
# Offense count: 87
Rémy Coutable's avatar
Rémy Coutable committed
552 553
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
554 555 556 557
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

558
# Offense count: 9
Connor Shea's avatar
Connor Shea committed
559 560
# Cop supports --auto-correct.
Style/RedundantBegin:
Rémy Coutable's avatar
Rémy Coutable committed
561 562 563 564 565 566 567 568 569 570 571 572 573 574 575
  Exclude:
    - 'app/controllers/projects/clusters/gcp_controller.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/api/branches.rb'
    - 'lib/gitlab/current_settings.rb'
    - 'lib/gitlab/git/commit.rb'
    - 'lib/gitlab/health_checks/base_abstract_check.rb'
    - 'lib/tasks/gitlab/task_helpers.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantConditional:
  Exclude:
    - 'lib/system_check/helpers.rb'
Connor Shea's avatar
Connor Shea committed
576

577
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
578 579
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
580
  Enabled: false
Connor Shea's avatar
Connor Shea committed
581

Rémy Coutable's avatar
Rémy Coutable committed
582
# Offense count: 15
583 584 585
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Rémy Coutable's avatar
Rémy Coutable committed
586 587 588 589 590 591 592 593 594 595 596
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/application_controller.rb'
    - 'app/services/access_token_validation_service.rb'
    - 'lib/gitlab/utils.rb'
    - 'lib/google_api/auth.rb'

597
# Offense count: 460
Connor Shea's avatar
Connor Shea committed
598 599 600 601
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

602
# Offense count: 142
Connor Shea's avatar
Connor Shea committed
603
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
604
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
Connor Shea's avatar
Connor Shea committed
605 606
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
607 608 609
  Enabled: true
  EnforcedStyle: mixed
  AllowInnerSlashes: false
Connor Shea's avatar
Connor Shea committed
610

611
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
612 613
# Cop supports --auto-correct.
Style/RescueModifier:
614
  Enabled: false
615

616
# Offense count: 107
Rémy Coutable's avatar
Rémy Coutable committed
617 618 619 620 621 622
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
  Enabled: false

623
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
624 625
# Cop supports --auto-correct.
Style/SelfAssignment:
Rémy Coutable's avatar
Rémy Coutable committed
626 627 628 629 630 631 632 633
  Exclude:
    - 'app/models/concerns/bulk_member_access_load.rb'
    - 'app/serializers/base_serializer.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/clusters/interchangeability_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
634 635 636 637 638

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Rémy Coutable's avatar
Rémy Coutable committed
639 640
  Exclude:
    - 'lib/gitlab/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
641

Rémy Coutable's avatar
Rémy Coutable committed
642
# Offense count: 66
Connor Shea's avatar
Connor Shea committed
643
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
644
# Configuration parameters: .
Connor Shea's avatar
Connor Shea committed
645 646 647 648
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

Rémy Coutable's avatar
Rémy Coutable committed
649
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
650
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
651 652 653 654 655 656 657
Style/StderrPuts:
  Exclude:
    - 'config/initializers/rspec_profiling.rb'

# Offense count: 45
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
658 659
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
660
  Enabled: false
661

662
# Offense count: 106
Connor Shea's avatar
Connor Shea committed
663 664 665 666 667 668
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
669
# Offense count: 9
670
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
671
# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
672
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
673
Style/TernaryParentheses:
Rémy Coutable's avatar
Rémy Coutable committed
674 675 676 677 678 679 680
  Exclude:
    - 'app/finders/projects_finder.rb'
    - 'app/helpers/namespaces_helper.rb'
    - 'features/support/capybara.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/requests/api/pipeline_schedules_spec.rb'
    - 'spec/support/capybara.rb'
681

682
# Offense count: 17
Connor Shea's avatar
Connor Shea committed
683 684 685
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Rémy Coutable's avatar
Rémy Coutable committed
686 687 688 689 690 691 692 693 694 695 696 697 698
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/logger.rb'
    - 'lib/gitlab/upgrader.rb'
    - 'lib/system_check/app/migrations_are_up_check.rb'
    - 'lib/system_check/incoming_email/mail_room_running_check.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'lib/tasks/gitlab/task_helpers.rb'
    - 'spec/lib/gitlab/etag_caching/middleware_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
699

Rémy Coutable's avatar
Rémy Coutable committed
700
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
701 702 703 704
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Rémy Coutable's avatar
Rémy Coutable committed
705 706 707
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
708
    - 'lib/gitlab/auth/ldap/person.rb'
Rémy Coutable's avatar
Rémy Coutable committed
709
    - 'lib/system_check/base_check.rb'
Connor Shea's avatar
Connor Shea committed
710

Rémy Coutable's avatar
Rémy Coutable committed
711
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
712 713
# Cop supports --auto-correct.
Style/UnlessElse:
Rémy Coutable's avatar
Rémy Coutable committed
714 715 716 717 718
  Exclude:
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/project_search_results.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
719

720
# Offense count: 31
Connor Shea's avatar
Connor Shea committed
721 722
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
723
  Enabled: false
Connor Shea's avatar
Connor Shea committed
724

725
# Offense count: 22840
Rémy Coutable's avatar
Rémy Coutable committed
726 727 728 729
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310