.rubocop_todo.yml 25.2 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Rémy Coutable's avatar
Rémy Coutable committed
2 3
# `rubocop --auto-gen-config`
# on 2017-12-14 12:04:26 +0100 using RuboCop version 0.52.0.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

Rémy Coutable's avatar
Rémy Coutable committed
9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41
# Offense count: 174
Capybara/CurrentPathExpectation:
  Enabled: false

# Offense count: 951
Capybara/FeatureMethods:
  Enabled: false

# Offense count: 24
FactoryBot/DynamicAttributeDefinedStatically:
  Exclude:
    - 'spec/factories/broadcast_messages.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/runners.rb'
    - 'spec/factories/clusters/applications/helm.rb'
    - 'spec/factories/clusters/applications/ingress.rb'
    - 'spec/factories/clusters/platforms/kubernetes.rb'
    - 'spec/factories/emails.rb'
    - 'spec/factories/gpg_keys.rb'
    - 'spec/factories/group_members.rb'
    - 'spec/factories/merge_requests.rb'
    - 'spec/factories/notes.rb'
    - 'spec/factories/oauth_access_grants.rb'
    - 'spec/factories/project_members.rb'
    - 'spec/factories/todos.rb'
    - 'spec/factories/uploads.rb'

# Offense count: 65
# Cop supports --auto-correct.
Layout/EmptyLinesAroundArguments:
  Enabled: false

# Offense count: 249
42 43 44 45 46
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Layout/ExtraSpacing:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
47
# Offense count: 82
48
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
49
# Configuration parameters: EnforcedStyle, IndentationWidth.
50 51 52 53
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Layout/IndentArray:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
54
# Offense count: 239
55
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
56
# Configuration parameters: EnforcedStyle, IndentationWidth.
57 58 59 60
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Layout/IndentHash:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
61
# Offense count: 15
62
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
63 64 65 66 67 68
# Configuration parameters: .
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceBeforeBlockBraces:
  EnforcedStyle: space
  EnforcedStyleForEmptyBraces: space
69

Rémy Coutable's avatar
Rémy Coutable committed
70
# Offense count: 11
71
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
72 73 74 75 76 77 78 79 80 81 82 83 84 85 86
# Configuration parameters: AllowForAlignment.
Layout/SpaceBeforeFirstArg:
  Exclude:
    - 'config/routes/project.rb'
    - 'db/migrate/20170506185517_add_foreign_key_pipeline_schedules_and_pipelines.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/search/user_uses_search_filters_spec.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/system_note_service_spec.rb'

# Offense count: 93
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
87 88 89 90
# SupportedStyles: require_no_space, require_space
Layout/SpaceInLambdaLiteral:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
91
# Offense count: 1
92
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
93 94 95 96 97 98 99 100 101 102
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
# SupportedStyles: space, no_space, compact
# SupportedStylesForEmptyBrackets: space, no_space
Layout/SpaceInsideArrayLiteralBrackets:
  Exclude:
    - 'spec/lib/gitlab/import_export/relation_factory_spec.rb'

# Offense count: 323
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
103 104 105 106 107
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
108
# Offense count: 146
109 110 111 112 113 114 115
# Cop supports --auto-correct.
Layout/SpaceInsideParens:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Layout/SpaceInsidePercentLiteralDelimiters:
Rémy Coutable's avatar
Rémy Coutable committed
116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231
  Exclude:
    - 'lib/gitlab/git_access.rb'
    - 'lib/gitlab/health_checks/fs_shards_check.rb'
    - 'spec/lib/gitlab/health_checks/fs_shards_check_spec.rb'

# Offense count: 25
Lint/DuplicateMethods:
  Exclude:
    - 'app/models/application_setting.rb'
    - 'app/models/commit.rb'
    - 'app/models/note.rb'
    - 'app/services/merge_requests/merge_service.rb'
    - 'lib/bitbucket/representation/repo.rb'
    - 'lib/declarative_policy/base.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'lib/gitlab/cycle_analytics/base_event_fetcher.rb'
    - 'lib/gitlab/diff/formatters/base_formatter.rb'
    - 'lib/gitlab/git/blob.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/git/tree.rb'
    - 'lib/gitlab/git/wiki_page.rb'
    - 'lib/gitlab/ldap/person.rb'
    - 'lib/gitlab/o_auth/user.rb'

# Offense count: 4
Lint/InterpolationCheck:
  Exclude:
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/features/users_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'

# Offense count: 198
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
  Enabled: false

# Offense count: 2
Lint/NestedPercentLiteral:
  Exclude:
    - 'lib/gitlab/git/repository.rb'
    - 'spec/support/email_format_shared_examples.rb'

# Offense count: 1
Lint/ReturnInVoidContext:
  Exclude:
    - 'app/models/project.rb'

# Offense count: 1
# Configuration parameters: IgnoreImplicitReferences.
Lint/ShadowedArgument:
  Exclude:
    - 'lib/gitlab/database/sha_attribute.rb'

# Offense count: 3
# Cop supports --auto-correct.
Lint/UnneededRequireStatement:
  Exclude:
    - 'db/post_migrate/20161221153951_rename_reserved_project_names.rb'
    - 'db/post_migrate/20170313133418_rename_more_reserved_project_names.rb'
    - 'lib/declarative_policy.rb'

# Offense count: 9
Lint/UriEscapeUnescape:
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'spec/lib/google_api/auth_spec.rb'
    - 'spec/requests/api/files_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/requests/api/issues_spec.rb'
    - 'spec/requests/api/v3/issues_spec.rb'

# Offense count: 2
Naming/ConstantName:
  Exclude:
    - 'lib/gitlab/import_sources.rb'
    - 'lib/gitlab/ssh_public_key.rb'

# Offense count: 11
# Configuration parameters: EnforcedStyle.
# SupportedStyles: lowercase, uppercase
Naming/HeredocDelimiterCase:
  Exclude:
    - 'spec/lib/gitlab/diff/parser_spec.rb'
    - 'spec/lib/json_web_token/rsa_token_spec.rb'
    - 'spec/models/commit_spec.rb'
    - 'spec/support/repo_helpers.rb'
    - 'spec/support/seed_repo.rb'

# Offense count: 101
# Configuration parameters: Blacklist.
# Blacklist: END, (?-mix:EO[A-Z]{1})
Naming/HeredocDelimiterNaming:
  Enabled: false

# Offense count: 28
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Performance/HashEachMethods:
  Enabled: false

# Offense count: 1
Performance/UnfreezeString:
  Exclude:
    - 'features/steps/project/commits/commits.rb'

# Offense count: 1
# Cop supports --auto-correct.
Performance/UriDefaultParser:
  Exclude:
    - 'lib/gitlab/url_sanitizer.rb'

# Offense count: 3745
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
232 233
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
234
# Offense count: 291
235 236 237
RSpec/EmptyLineAfterFinalLet:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
238
# Offense count: 180
239 240 241
RSpec/EmptyLineAfterSubject:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
# Offense count: 220
RSpec/ExpectInHook:
  Enabled: false

# Offense count: 7
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Exclude:
    - 'spec/spec_helper.rb'
    - 'spec/support/carrierwave.rb'
    - 'spec/support/db_cleaner.rb'
    - 'spec/support/gitaly.rb'
    - 'spec/support/setup_builds_storage.rb'

# Offense count: 19
# Configuration parameters: EnforcedStyle.
259 260
# SupportedStyles: it_behaves_like, it_should_behave_like
RSpec/ItBehavesLike:
Rémy Coutable's avatar
Rémy Coutable committed
261 262 263 264 265 266
  Exclude:
    - 'spec/lib/gitlab/git/commit_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/shell_spec.rb'
    - 'spec/services/notification_service_spec.rb'
    - 'spec/workers/git_garbage_collect_worker_spec.rb'
267

Rémy Coutable's avatar
Rémy Coutable committed
268
# Offense count: 5
269
RSpec/IteratedExpectation:
Rémy Coutable's avatar
Rémy Coutable committed
270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292
  Exclude:
    - 'spec/features/admin/admin_settings_spec.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/awards/user_interacts_with_awards_in_issue_spec.rb'
    - 'spec/lib/gitlab/gitlab_import/client_spec.rb'
    - 'spec/lib/gitlab/legacy_github_import/client_spec.rb'

# Offense count: 75
RSpec/LetBeforeExamples:
  Exclude:
    - 'spec/controllers/projects/commit_controller_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/lib/banzai/filter/user_reference_filter_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/milestone_spec.rb'
    - 'spec/models/project_services/packagist_service_spec.rb'
    - 'spec/models/repository_spec.rb'
    - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
    - 'spec/serializers/pipeline_details_entity_spec.rb'
    - 'spec/views/ci/lints/show.html.haml_spec.rb'
293

Rémy Coutable's avatar
Rémy Coutable committed
294 295 296 297 298 299
# Offense count: 1
RSpec/MultipleSubjects:
  Exclude:
    - 'spec/services/merge_requests/create_from_issue_service_spec.rb'

# Offense count: 4
300
RSpec/OverwritingSetup:
Rémy Coutable's avatar
Rémy Coutable committed
301 302 303 304 305 306 307 308 309 310
  Exclude:
    - 'spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb'
    - 'spec/models/email_spec.rb'
    - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
    - 'spec/services/notes/quick_actions_service_spec.rb'

# Offense count: 917
# Configuration parameters: Strict, EnforcedStyle.
# SupportedStyles: inflected, explicit
RSpec/PredicateMatcher:
311 312
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
313
# Offense count: 35
314 315 316
RSpec/RepeatedExample:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
317 318 319 320 321 322 323
# Offense count: 132
# Configuration parameters: EnforcedStyle.
# SupportedStyles: and_return, block
RSpec/ReturnFromStub:
  Enabled: false

# Offense count: 105
324 325 326
RSpec/ScatteredLet:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
327
# Offense count: 22
328
RSpec/ScatteredSetup:
Rémy Coutable's avatar
Rémy Coutable committed
329 330 331 332 333 334 335 336
  Exclude:
    - 'spec/controllers/projects/templates_controller_spec.rb'
    - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
    - 'spec/lib/gitlab/git/env_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/requests/api/v3/builds_spec.rb'
    - 'spec/requests/api/v3/projects_spec.rb'
    - 'spec/services/projects/create_service_spec.rb'
337

338
# Offense count: 1
339
RSpec/SharedContext:
Rémy Coutable's avatar
Rémy Coutable committed
340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359
  Exclude:
    - 'spec/features/admin/admin_groups_spec.rb'

# Offense count: 90
RSpec/SingleLineHook:
  Enabled: false

# Offense count: 5
RSpec/VoidExpect:
  Exclude:
    - 'spec/features/projects/artifacts/download_spec.rb'
    - 'spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb'
    - 'spec/models/ci/group_spec.rb'
    - 'spec/models/ci/runner_spec.rb'
    - 'spec/services/users/destroy_service_spec.rb'

# Offense count: 40
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/CreateTableWithTimestamps:
Douwe Maan's avatar
Douwe Maan committed
360 361
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
362
# Offense count: 149
363 364 365
Rails/FilePath:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407
# Offense count: 119
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
  Enabled: false

# Offense count: 113
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/InverseOf:
  Enabled: false

# Offense count: 48
# Configuration parameters: Include.
# Include: app/controllers/**/*.rb
Rails/LexicallyScopedActionFilter:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Rails/Presence:
  Exclude:
    - 'app/controllers/projects/blob_controller.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/clusters/platforms/kubernetes.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/concerns/token_authenticatable.rb'
    - 'app/models/project_services/hipchat_service.rb'
    - 'app/models/project_services/irker_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'app/models/project_services/kubernetes_service.rb'
    - 'app/models/project_services/packagist_service.rb'
    - 'app/models/wiki_page.rb'
    - 'lib/gitlab/git/hook.rb'
    - 'lib/gitlab/github_import/importer/releases_importer.rb'

# Offense count: 14
# Cop supports --auto-correct.
Rails/RedundantReceiverInWithOptions:
  Exclude:
    - 'config/initializers/doorkeeper_openid_connect.rb'

408 409 410 411
# Offense count: 2
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/ReversibleMigration:
Rémy Coutable's avatar
Rémy Coutable committed
412 413
  Exclude:
    - 'db/migrate/20160824103857_drop_unused_ci_tables.rb'
414

Rémy Coutable's avatar
Rémy Coutable committed
415
# Offense count: 430
416 417 418
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
Douwe Maan's avatar
Douwe Maan committed
419 420
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
421 422 423 424 425 426
# Offense count: 1
# Configuration parameters: Environments.
# Environments: development, test, production
Rails/UnknownEnv:
  Exclude:
    - 'db/migrate/20171124125748_populate_missing_merge_request_statuses.rb'
Douwe Maan's avatar
Douwe Maan committed
427

Rémy Coutable's avatar
Rémy Coutable committed
428
# Offense count: 13
429
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
430 431 432 433 434 435 436 437 438 439 440 441 442 443 444
Security/YAMLLoad:
  Exclude:
    - 'config/initializers/carrierwave.rb'
    - 'lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits.rb'
    - 'lib/gitlab/redis/wrapper.rb'
    - 'lib/system_check/incoming_email/imap_authentication_check.rb'
    - 'spec/config/mail_room_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'
    - 'spec/models/clusters/platforms/kubernetes_spec.rb'
    - 'spec/models/project_services/kubernetes_service_spec.rb'

# Offense count: 63
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
445 446 447
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false
448

Rémy Coutable's avatar
Rémy Coutable committed
449 450 451 452 453 454 455 456
# Offense count: 5
Style/CommentedKeyword:
  Exclude:
    - 'lib/tasks/gitlab/backup.rake'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 30
Style/DateTime:
Douwe Maan's avatar
Douwe Maan committed
457
  Enabled: false
Connor Shea's avatar
Connor Shea committed
458

Rémy Coutable's avatar
Rémy Coutable committed
459
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
460
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481
Style/Dir:
  Exclude:
    - 'qa/qa.rb'

# Offense count: 9
# Cop supports --auto-correct.
Style/EachWithObject:
  Exclude:
    - 'config/initializers/gollum.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ci/ansi2html.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/hook_data/issuable_builder.rb'
    - 'lib/gitlab/i18n/po_linter.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'scripts/static-analysis'

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
482 483 484 485
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
486 487 488 489 490 491 492 493
# Offense count: 14
# Cop supports --auto-correct.
Style/EmptyLambdaParameter:
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/runner.rb'

# Offense count: 12
Connor Shea's avatar
Connor Shea committed
494 495
# Cop supports --auto-correct.
Style/EmptyLiteral:
Rémy Coutable's avatar
Rémy Coutable committed
496 497 498 499 500 501 502 503 504 505 506 507
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/gitaly_client.rb'
    - 'scripts/trigger-build-omnibus'
    - 'spec/features/merge_requests/versions_spec.rb'
    - 'spec/helpers/merge_requests_helper_spec.rb'
    - 'spec/lib/gitlab/request_context_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/support/chat_slash_commands_shared_examples.rb'
508

Rémy Coutable's avatar
Rémy Coutable committed
509
# Offense count: 98
510
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
511
# Configuration parameters: EnforcedStyle.
512 513
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Connor Shea's avatar
Connor Shea committed
514
  Enabled: false
Connor Shea's avatar
Connor Shea committed
515

516
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
517
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535
Style/Encoding:
  Enabled: false

# Offense count: 2
Style/EvalWithLocation:
  Exclude:
    - 'app/models/service.rb'

# Offense count: 52
# Cop supports --auto-correct.
# Configuration parameters: Autocorrect, EnforcedStyle.
# SupportedStyles: module_function, extend_self
Style/ExtendSelf:
  Enabled: false

# Offense count: 34
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
536 537
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
538 539
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
540
# Offense count: 371
Connor Shea's avatar
Connor Shea committed
541 542 543 544
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
545
# Offense count: 21
Connor Shea's avatar
Connor Shea committed
546
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
547 548
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
549
# Offense count: 781
Connor Shea's avatar
Connor Shea committed
550 551 552 553
# Cop supports --auto-correct.
Style/IfUnlessModifier:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
554
# Offense count: 71
Connor Shea's avatar
Connor Shea committed
555
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
556
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
557 558
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
Connor Shea's avatar
Connor Shea committed
559
  Enabled: false
Connor Shea's avatar
Connor Shea committed
560

Rémy Coutable's avatar
Rémy Coutable committed
561
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
562 563
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Rémy Coutable's avatar
Rémy Coutable committed
564 565 566 567 568 569
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'spec/features/issuables/markdown_references_spec.rb'
    - 'spec/lib/gitlab/checks/project_moved_spec.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
570

Rémy Coutable's avatar
Rémy Coutable committed
571
# Offense count: 39
Connor Shea's avatar
Connor Shea committed
572
# Cop supports --auto-correct.
573
Style/MethodCallWithoutArgsParentheses:
Douwe Maan's avatar
Douwe Maan committed
574
  Enabled: false
Connor Shea's avatar
Connor Shea committed
575

Rémy Coutable's avatar
Rémy Coutable committed
576
# Offense count: 17
577
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
578
  Enabled: false
579

Rémy Coutable's avatar
Rémy Coutable committed
580 581 582 583 584 585 586 587 588 589 590
# Offense count: 7
Style/MixinUsage:
  Exclude:
    - 'features/support/env.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/job_artifacts.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/factories/notes.rb'
    - 'spec/lib/gitlab/import_export/project_tree_restorer_spec.rb'
    - 'spec/lib/gitlab/import_export/version_checker_spec.rb'

591
# Offense count: 6
592 593
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Rémy Coutable's avatar
Rémy Coutable committed
594 595 596 597 598 599 600
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'app/services/ci/process_pipeline_service.rb'
    - 'app/services/create_deployment_service.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/ci/trace.rb'
601

Rémy Coutable's avatar
Rémy Coutable committed
602
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
603
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
604 605
# Configuration parameters: Whitelist.
# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
Connor Shea's avatar
Connor Shea committed
606
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
607
  Enabled: false
Connor Shea's avatar
Connor Shea committed
608

609
# Offense count: 20
Connor Shea's avatar
Connor Shea committed
610
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
611
# Configuration parameters: EnforcedStyle, MinBodyLength.
Connor Shea's avatar
Connor Shea committed
612 613
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
614
  Enabled: false
Connor Shea's avatar
Connor Shea committed
615

Rémy Coutable's avatar
Rémy Coutable committed
616
# Offense count: 58
Z.J. van de Weg's avatar
Z.J. van de Weg committed
617
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
618
# Configuration parameters: EnforcedOctalStyle.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
619 620
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
621
  Enabled: false
Douwe Maan's avatar
Douwe Maan committed
622

Rémy Coutable's avatar
Rémy Coutable committed
623
# Offense count: 112
624
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
625
# Configuration parameters: AutoCorrect, EnforcedStyle.
626 627 628 629
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
630 631 632 633 634 635 636 637 638 639
# Offense count: 4
# Cop supports --auto-correct.
Style/OrAssignment:
  Exclude:
    - 'app/models/concerns/token_authenticatable.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/api/v3/members.rb'
    - 'lib/gitlab/project_transfer.rb'

# Offense count: 50
Connor Shea's avatar
Connor Shea committed
640 641 642 643
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
644
# Offense count: 891
Connor Shea's avatar
Connor Shea committed
645 646 647 648 649
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

650
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
651 652
# Cop supports --auto-correct.
Style/PerlBackrefs:
Rémy Coutable's avatar
Rémy Coutable committed
653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

# Offense count: 82
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
669 670 671 672
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
673
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
674 675
# Cop supports --auto-correct.
Style/RedundantBegin:
Rémy Coutable's avatar
Rémy Coutable committed
676 677 678 679 680 681 682 683 684 685 686 687 688 689 690
  Exclude:
    - 'app/controllers/projects/clusters/gcp_controller.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/api/branches.rb'
    - 'lib/gitlab/current_settings.rb'
    - 'lib/gitlab/git/commit.rb'
    - 'lib/gitlab/health_checks/base_abstract_check.rb'
    - 'lib/tasks/gitlab/task_helpers.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantConditional:
  Exclude:
    - 'lib/system_check/helpers.rb'
Connor Shea's avatar
Connor Shea committed
691

Rémy Coutable's avatar
Rémy Coutable committed
692
# Offense count: 58
Connor Shea's avatar
Connor Shea committed
693 694
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
695
  Enabled: false
Connor Shea's avatar
Connor Shea committed
696

Rémy Coutable's avatar
Rémy Coutable committed
697
# Offense count: 15
698 699 700
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Rémy Coutable's avatar
Rémy Coutable committed
701 702 703 704 705 706 707 708 709 710 711 712
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/application_controller.rb'
    - 'app/services/access_token_validation_service.rb'
    - 'lib/gitlab/utils.rb'
    - 'lib/google_api/auth.rb'

# Offense count: 454
Connor Shea's avatar
Connor Shea committed
713 714 715 716
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
717
# Offense count: 140
Connor Shea's avatar
Connor Shea committed
718
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
719
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
Connor Shea's avatar
Connor Shea committed
720 721 722 723
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
724
# Offense count: 35
Connor Shea's avatar
Connor Shea committed
725 726
# Cop supports --auto-correct.
Style/RescueModifier:
727
  Enabled: false
728

Rémy Coutable's avatar
Rémy Coutable committed
729 730 731 732 733 734 735 736 737 738 739 740 741
# Offense count: 105
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
  Enabled: false

# Offense count: 91
# Cop supports --auto-correct.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil.
Style/SafeNavigation:
  Enabled: false

742
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
743 744
# Cop supports --auto-correct.
Style/SelfAssignment:
Rémy Coutable's avatar
Rémy Coutable committed
745 746 747 748 749 750 751 752
  Exclude:
    - 'app/models/concerns/bulk_member_access_load.rb'
    - 'app/serializers/base_serializer.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/clusters/interchangeability_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
753 754 755 756 757

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Rémy Coutable's avatar
Rémy Coutable committed
758 759
  Exclude:
    - 'lib/gitlab/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
760

Rémy Coutable's avatar
Rémy Coutable committed
761
# Offense count: 66
Connor Shea's avatar
Connor Shea committed
762
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
763
# Configuration parameters: .
Connor Shea's avatar
Connor Shea committed
764 765 766 767
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

Rémy Coutable's avatar
Rémy Coutable committed
768
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
769
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
770 771 772 773 774 775 776
Style/StderrPuts:
  Exclude:
    - 'config/initializers/rspec_profiling.rb'

# Offense count: 45
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
777 778
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
779
  Enabled: false
780

Rémy Coutable's avatar
Rémy Coutable committed
781
# Offense count: 99
Connor Shea's avatar
Connor Shea committed
782 783 784 785 786 787
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
788
# Offense count: 9
789
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
790
# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
791
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
792
Style/TernaryParentheses:
Rémy Coutable's avatar
Rémy Coutable committed
793 794 795 796 797 798 799 800
  Exclude:
    - 'app/finders/projects_finder.rb'
    - 'app/helpers/namespaces_helper.rb'
    - 'features/support/capybara.rb'
    - 'lib/api/v3/projects.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/requests/api/pipeline_schedules_spec.rb'
    - 'spec/support/capybara.rb'
801

802
# Offense count: 17
Connor Shea's avatar
Connor Shea committed
803 804 805
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Rémy Coutable's avatar
Rémy Coutable committed
806 807 808 809 810 811 812 813 814 815 816 817 818
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/logger.rb'
    - 'lib/gitlab/upgrader.rb'
    - 'lib/system_check/app/migrations_are_up_check.rb'
    - 'lib/system_check/incoming_email/mail_room_running_check.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'lib/tasks/gitlab/task_helpers.rb'
    - 'spec/lib/gitlab/etag_caching/middleware_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
819

Rémy Coutable's avatar
Rémy Coutable committed
820
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
821 822 823 824
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Rémy Coutable's avatar
Rémy Coutable committed
825 826 827 828 829
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
    - 'lib/gitlab/ldap/person.rb'
    - 'lib/system_check/base_check.rb'
Connor Shea's avatar
Connor Shea committed
830

Rémy Coutable's avatar
Rémy Coutable committed
831
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
832 833
# Cop supports --auto-correct.
Style/UnlessElse:
Rémy Coutable's avatar
Rémy Coutable committed
834 835 836 837 838
  Exclude:
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/project_search_results.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
839

Rémy Coutable's avatar
Rémy Coutable committed
840
# Offense count: 30
Connor Shea's avatar
Connor Shea committed
841 842
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
843
  Enabled: false
Connor Shea's avatar
Connor Shea committed
844

845
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
846 847
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Rémy Coutable's avatar
Rémy Coutable committed
848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/services/boards/create_service.rb'
    - 'app/services/merge_requests/conflicts/list_service.rb'
    - 'lib/declarative_policy/dsl.rb'
    - 'lib/extracts_path.rb'
    - 'lib/gitlab/git/repository.rb'

# Offense count: 22050
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310