.rubocop_todo.yml 20 KB
Newer Older
1
# This configuration was generated by
Rémy Coutable's avatar
Rémy Coutable committed
2
# `rubocop --auto-gen-config`
3
# on 2018-01-18 18:23:26 +0100 using RuboCop version 0.52.1.
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 181
Rémy Coutable's avatar
Rémy Coutable committed
10 11 12
Capybara/CurrentPathExpectation:
  Enabled: false

13
# Offense count: 167
Rémy Coutable's avatar
Rémy Coutable committed
14 15 16 17
# Cop supports --auto-correct.
Layout/EmptyLinesAroundArguments:
  Enabled: false

18
# Offense count: 83
19
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
20
# Configuration parameters: EnforcedStyle, IndentationWidth.
21 22 23 24
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Layout/IndentArray:
  Enabled: false

25
# Offense count: 237
26
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
27
# Configuration parameters: EnforcedStyle, IndentationWidth.
28 29 30 31
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Layout/IndentHash:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
32 33 34
# Offense count: 93
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
35 36 37 38
# SupportedStyles: require_no_space, require_space
Layout/SpaceInLambdaLiteral:
  Enabled: false

39
# Offense count: 327
Rémy Coutable's avatar
Rémy Coutable committed
40 41
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
42 43 44 45 46
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
  Enabled: false

47
# Offense count: 156
48 49 50 51
# Cop supports --auto-correct.
Layout/SpaceInsideParens:
  Enabled: false

52
# Offense count: 26
Rémy Coutable's avatar
Rémy Coutable committed
53 54 55 56 57 58 59 60 61 62 63 64 65 66 67
Lint/DuplicateMethods:
  Exclude:
    - 'app/models/application_setting.rb'
    - 'app/models/commit.rb'
    - 'app/models/note.rb'
    - 'app/services/merge_requests/merge_service.rb'
    - 'lib/bitbucket/representation/repo.rb'
    - 'lib/declarative_policy/base.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'lib/gitlab/cycle_analytics/base_event_fetcher.rb'
    - 'lib/gitlab/diff/formatters/base_formatter.rb'
    - 'lib/gitlab/git/blob.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/git/tree.rb'
    - 'lib/gitlab/git/wiki_page.rb'
68 69
    - 'lib/gitlab/auth/ldap/person.rb'
    - 'lib/gitlab/auth/o_auth/user.rb'
Rémy Coutable's avatar
Rémy Coutable committed
70 71 72 73 74 75 76 77

# Offense count: 4
Lint/InterpolationCheck:
  Exclude:
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/features/users_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'

78
# Offense count: 206
Rémy Coutable's avatar
Rémy Coutable committed
79 80 81 82 83 84 85 86 87 88 89 90 91 92
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
  Enabled: false

# Offense count: 9
Lint/UriEscapeUnescape:
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'spec/lib/google_api/auth_spec.rb'
    - 'spec/requests/api/files_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/requests/api/issues_spec.rb'

93 94 95 96 97 98
# Offense count: 1
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310

Rémy Coutable's avatar
Rémy Coutable committed
99 100 101 102 103 104 105 106
# Offense count: 11
# Configuration parameters: EnforcedStyle.
# SupportedStyles: lowercase, uppercase
Naming/HeredocDelimiterCase:
  Exclude:
    - 'spec/lib/gitlab/diff/parser_spec.rb'
    - 'spec/lib/json_web_token/rsa_token_spec.rb'
    - 'spec/models/commit_spec.rb'
107 108
    - 'spec/support/helpers/repo_helpers.rb'
    - 'spec/support/helpers/seed_repo.rb'
Rémy Coutable's avatar
Rémy Coutable committed
109

110
# Offense count: 112
Rémy Coutable's avatar
Rémy Coutable committed
111 112 113 114 115 116
# Configuration parameters: Blacklist.
# Blacklist: END, (?-mix:EO[A-Z]{1})
Naming/HeredocDelimiterNaming:
  Enabled: false


117
# Offense count: 3821
Rémy Coutable's avatar
Rémy Coutable committed
118 119 120
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
121 122
  Enabled: false

123
# Offense count: 293
124 125 126
RSpec/EmptyLineAfterFinalLet:
  Enabled: false

127
# Offense count: 188
128 129 130
RSpec/EmptyLineAfterSubject:
  Enabled: false

131 132 133 134 135 136 137
# Offense count: 258
# Configuration parameters: EnforcedStyle.
# SupportedStyles: method_call, block
RSpec/ExpectChange:
  Enabled: false

# Offense count: 221
Rémy Coutable's avatar
Rémy Coutable committed
138 139 140 141 142
RSpec/ExpectInHook:
  Enabled: false

# Offense count: 19
# Configuration parameters: EnforcedStyle.
143 144
# SupportedStyles: it_behaves_like, it_should_behave_like
RSpec/ItBehavesLike:
Rémy Coutable's avatar
Rémy Coutable committed
145 146 147 148 149 150
  Exclude:
    - 'spec/lib/gitlab/git/commit_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/shell_spec.rb'
    - 'spec/services/notification_service_spec.rb'
    - 'spec/workers/git_garbage_collect_worker_spec.rb'
151

Rémy Coutable's avatar
Rémy Coutable committed
152
# Offense count: 5
153
RSpec/IteratedExpectation:
Rémy Coutable's avatar
Rémy Coutable committed
154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176
  Exclude:
    - 'spec/features/admin/admin_settings_spec.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/awards/user_interacts_with_awards_in_issue_spec.rb'
    - 'spec/lib/gitlab/gitlab_import/client_spec.rb'
    - 'spec/lib/gitlab/legacy_github_import/client_spec.rb'

# Offense count: 75
RSpec/LetBeforeExamples:
  Exclude:
    - 'spec/controllers/projects/commit_controller_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/lib/banzai/filter/user_reference_filter_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/milestone_spec.rb'
    - 'spec/models/project_services/packagist_service_spec.rb'
    - 'spec/models/repository_spec.rb'
    - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
    - 'spec/serializers/pipeline_details_entity_spec.rb'
    - 'spec/views/ci/lints/show.html.haml_spec.rb'
177

Rémy Coutable's avatar
Rémy Coutable committed
178 179 180 181 182 183
# Offense count: 1
RSpec/MultipleSubjects:
  Exclude:
    - 'spec/services/merge_requests/create_from_issue_service_spec.rb'

# Offense count: 4
184
RSpec/OverwritingSetup:
Rémy Coutable's avatar
Rémy Coutable committed
185 186 187 188 189 190
  Exclude:
    - 'spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb'
    - 'spec/models/email_spec.rb'
    - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
    - 'spec/services/notes/quick_actions_service_spec.rb'

191
# Offense count: 965
Rémy Coutable's avatar
Rémy Coutable committed
192 193 194
# Configuration parameters: Strict, EnforcedStyle.
# SupportedStyles: inflected, explicit
RSpec/PredicateMatcher:
195 196
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
197
# Offense count: 35
198 199 200
RSpec/RepeatedExample:
  Enabled: false

201
# Offense count: 140
Rémy Coutable's avatar
Rémy Coutable committed
202 203 204 205 206
# Configuration parameters: EnforcedStyle.
# SupportedStyles: and_return, block
RSpec/ReturnFromStub:
  Enabled: false

207
# Offense count: 112
208 209 210
RSpec/ScatteredLet:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
211
# Offense count: 22
212
RSpec/ScatteredSetup:
Rémy Coutable's avatar
Rémy Coutable committed
213 214 215 216 217 218
  Exclude:
    - 'spec/controllers/projects/templates_controller_spec.rb'
    - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
    - 'spec/lib/gitlab/git/env_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/services/projects/create_service_spec.rb'
219

220
# Offense count: 1
221
RSpec/SharedContext:
Rémy Coutable's avatar
Rémy Coutable committed
222 223 224 225 226 227 228 229 230 231 232 233
  Exclude:
    - 'spec/features/admin/admin_groups_spec.rb'

# Offense count: 5
RSpec/VoidExpect:
  Exclude:
    - 'spec/features/projects/artifacts/download_spec.rb'
    - 'spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb'
    - 'spec/models/ci/group_spec.rb'
    - 'spec/models/ci/runner_spec.rb'
    - 'spec/services/users/destroy_service_spec.rb'

234
# Offense count: 41
Rémy Coutable's avatar
Rémy Coutable committed
235 236 237
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/CreateTableWithTimestamps:
238 239
  Enabled: false

240
# Offense count: 155
241 242 243
Rails/FilePath:
  Enabled: false

244
# Offense count: 121
Rémy Coutable's avatar
Rémy Coutable committed
245 246 247 248 249
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
  Enabled: false

250
# Offense count: 157
Rémy Coutable's avatar
Rémy Coutable committed
251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/InverseOf:
  Enabled: false

# Offense count: 48
# Configuration parameters: Include.
# Include: app/controllers/**/*.rb
Rails/LexicallyScopedActionFilter:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Rails/Presence:
  Exclude:
    - 'app/controllers/projects/blob_controller.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/clusters/platforms/kubernetes.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/concerns/token_authenticatable.rb'
    - 'app/models/project_services/irker_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'app/models/project_services/kubernetes_service.rb'
    - 'app/models/project_services/packagist_service.rb'
    - 'app/models/wiki_page.rb'
    - 'lib/gitlab/git/hook.rb'
    - 'lib/gitlab/github_import/importer/releases_importer.rb'

279 280 281 282
# Offense count: 2
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/ReversibleMigration:
Rémy Coutable's avatar
Rémy Coutable committed
283 284
  Exclude:
    - 'db/migrate/20160824103857_drop_unused_ci_tables.rb'
285

286
# Offense count: 446
287 288 289
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
290 291
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
292 293 294 295 296 297
# Offense count: 1
# Configuration parameters: Environments.
# Environments: development, test, production
Rails/UnknownEnv:
  Exclude:
    - 'db/migrate/20171124125748_populate_missing_merge_request_statuses.rb'
298

Rémy Coutable's avatar
Rémy Coutable committed
299
# Offense count: 13
300
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
301 302 303 304 305 306 307 308 309 310 311 312
Security/YAMLLoad:
  Exclude:
    - 'config/initializers/carrierwave.rb'
    - 'lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits.rb'
    - 'lib/gitlab/redis/wrapper.rb'
    - 'lib/system_check/incoming_email/imap_authentication_check.rb'
    - 'spec/config/mail_room_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'
    - 'spec/models/clusters/platforms/kubernetes_spec.rb'
    - 'spec/models/project_services/kubernetes_service_spec.rb'

313
# Offense count: 64
Rémy Coutable's avatar
Rémy Coutable committed
314 315
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
316 317 318
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false
319

Rémy Coutable's avatar
Rémy Coutable committed
320 321 322 323 324 325 326 327
# Offense count: 5
Style/CommentedKeyword:
  Exclude:
    - 'lib/tasks/gitlab/backup.rake'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 30
Style/DateTime:
328
  Enabled: false
Connor Shea's avatar
Connor Shea committed
329

Rémy Coutable's avatar
Rémy Coutable committed
330
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
331
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351
Style/Dir:
  Exclude:
    - 'qa/qa.rb'

# Offense count: 9
# Cop supports --auto-correct.
Style/EachWithObject:
  Exclude:
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ci/ansi2html.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/hook_data/issuable_builder.rb'
    - 'lib/gitlab/i18n/po_linter.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'scripts/static-analysis'

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
352 353 354 355
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
356 357 358 359 360 361 362 363
# Offense count: 14
# Cop supports --auto-correct.
Style/EmptyLambdaParameter:
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/runner.rb'

# Offense count: 12
Connor Shea's avatar
Connor Shea committed
364 365
# Cop supports --auto-correct.
Style/EmptyLiteral:
Rémy Coutable's avatar
Rémy Coutable committed
366 367 368 369 370
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/gitaly_client.rb'
371
    - 'scripts/trigger-build'
Rémy Coutable's avatar
Rémy Coutable committed
372 373 374 375 376
    - 'spec/features/merge_requests/versions_spec.rb'
    - 'spec/helpers/merge_requests_helper_spec.rb'
    - 'spec/lib/gitlab/request_context_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
377
    - 'spec/support/shared_examples/chat_slash_commands_shared_examples.rb'
378

379
# Offense count: 102
380
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
381
# Configuration parameters: EnforcedStyle.
382 383
# SupportedStyles: compact, expanded
Style/EmptyMethod:
384
  Enabled: false
Connor Shea's avatar
Connor Shea committed
385

386
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
387
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
388 389 390 391 392 393 394 395
Style/Encoding:
  Enabled: false

# Offense count: 2
Style/EvalWithLocation:
  Exclude:
    - 'app/models/service.rb'

396
# Offense count: 35
Rémy Coutable's avatar
Rémy Coutable committed
397 398
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
399 400
# SupportedStyles: format, sprintf, percent
Style/FormatString:
401 402
  Enabled: false

403
# Offense count: 384
Connor Shea's avatar
Connor Shea committed
404 405 406 407
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

408
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
409
Style/IfInsideElse:
410 411
  Enabled: false

412
# Offense count: 809
Connor Shea's avatar
Connor Shea committed
413 414 415 416
# Cop supports --auto-correct.
Style/IfUnlessModifier:
  Enabled: false

417
# Offense count: 75
Connor Shea's avatar
Connor Shea committed
418
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
419
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
420 421
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
422
  Enabled: false
Connor Shea's avatar
Connor Shea committed
423

Rémy Coutable's avatar
Rémy Coutable committed
424
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
425 426
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Rémy Coutable's avatar
Rémy Coutable committed
427 428 429 430 431 432
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'spec/features/issuables/markdown_references_spec.rb'
    - 'spec/lib/gitlab/checks/project_moved_spec.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
433

434
# Offense count: 18
435
Style/MethodMissing:
436
  Enabled: false
437

Rémy Coutable's avatar
Rémy Coutable committed
438 439 440 441 442 443 444 445 446 447 448
# Offense count: 7
Style/MixinUsage:
  Exclude:
    - 'features/support/env.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/job_artifacts.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/factories/notes.rb'
    - 'spec/lib/gitlab/import_export/project_tree_restorer_spec.rb'
    - 'spec/lib/gitlab/import_export/version_checker_spec.rb'

449
# Offense count: 6
450 451
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Rémy Coutable's avatar
Rémy Coutable committed
452 453 454 455 456 457 458
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'app/services/ci/process_pipeline_service.rb'
    - 'app/services/create_deployment_service.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/ci/trace.rb'
459

460
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
461
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
462 463
# Configuration parameters: Whitelist.
# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
Connor Shea's avatar
Connor Shea committed
464
Style/NestedParenthesizedCalls:
465
  Enabled: false
Connor Shea's avatar
Connor Shea committed
466

467
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
468
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
469
# Configuration parameters: EnforcedStyle, MinBodyLength.
Connor Shea's avatar
Connor Shea committed
470 471
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
472
  Enabled: false
Connor Shea's avatar
Connor Shea committed
473

474
# Offense count: 61
475
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
476
# Configuration parameters: EnforcedOctalStyle.
477 478
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
479
  Enabled: false
Douwe Maan's avatar
Douwe Maan committed
480

481
# Offense count: 114
482
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
483
# Configuration parameters: AutoCorrect, EnforcedStyle.
484 485 486 487
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
488 489 490 491 492 493 494 495 496
# Offense count: 4
# Cop supports --auto-correct.
Style/OrAssignment:
  Exclude:
    - 'app/models/concerns/token_authenticatable.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/project_transfer.rb'

# Offense count: 50
Connor Shea's avatar
Connor Shea committed
497 498 499 500
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

501
# Offense count: 917
Connor Shea's avatar
Connor Shea committed
502 503 504 505 506
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

507
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
508 509
# Cop supports --auto-correct.
Style/PerlBackrefs:
Rémy Coutable's avatar
Rémy Coutable committed
510 511 512 513 514 515 516 517 518 519 520 521 522
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

523
# Offense count: 87
Rémy Coutable's avatar
Rémy Coutable committed
524 525
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
526 527 528 529
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

530
# Offense count: 9
Connor Shea's avatar
Connor Shea committed
531 532
# Cop supports --auto-correct.
Style/RedundantBegin:
Rémy Coutable's avatar
Rémy Coutable committed
533 534 535 536 537 538 539 540 541 542 543 544 545 546 547
  Exclude:
    - 'app/controllers/projects/clusters/gcp_controller.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/api/branches.rb'
    - 'lib/gitlab/current_settings.rb'
    - 'lib/gitlab/git/commit.rb'
    - 'lib/gitlab/health_checks/base_abstract_check.rb'
    - 'lib/tasks/gitlab/task_helpers.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantConditional:
  Exclude:
    - 'lib/system_check/helpers.rb'
Connor Shea's avatar
Connor Shea committed
548

549
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
550 551
# Cop supports --auto-correct.
Style/RedundantFreeze:
552
  Enabled: false
Connor Shea's avatar
Connor Shea committed
553

Rémy Coutable's avatar
Rémy Coutable committed
554
# Offense count: 15
555 556 557
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Rémy Coutable's avatar
Rémy Coutable committed
558 559 560 561 562 563 564 565 566 567 568
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/application_controller.rb'
    - 'app/services/access_token_validation_service.rb'
    - 'lib/gitlab/utils.rb'
    - 'lib/google_api/auth.rb'

569
# Offense count: 460
Connor Shea's avatar
Connor Shea committed
570 571 572 573
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

574
# Offense count: 142
Connor Shea's avatar
Connor Shea committed
575
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
576
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
Connor Shea's avatar
Connor Shea committed
577 578
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
579 580 581
  Enabled: true
  EnforcedStyle: mixed
  AllowInnerSlashes: false
Connor Shea's avatar
Connor Shea committed
582

583
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
584 585
# Cop supports --auto-correct.
Style/RescueModifier:
586
  Enabled: false
587

588
# Offense count: 107
Rémy Coutable's avatar
Rémy Coutable committed
589 590 591 592 593 594
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
  Enabled: false

595
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
596 597
# Cop supports --auto-correct.
Style/SelfAssignment:
Rémy Coutable's avatar
Rémy Coutable committed
598 599 600 601 602 603 604 605
  Exclude:
    - 'app/models/concerns/bulk_member_access_load.rb'
    - 'app/serializers/base_serializer.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/clusters/interchangeability_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
606 607 608 609 610

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Rémy Coutable's avatar
Rémy Coutable committed
611 612
  Exclude:
    - 'lib/gitlab/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
613

Rémy Coutable's avatar
Rémy Coutable committed
614
# Offense count: 66
Connor Shea's avatar
Connor Shea committed
615
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
616
# Configuration parameters: .
Connor Shea's avatar
Connor Shea committed
617 618 619 620
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

Rémy Coutable's avatar
Rémy Coutable committed
621
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
622
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
623 624 625 626 627 628 629
Style/StderrPuts:
  Exclude:
    - 'config/initializers/rspec_profiling.rb'

# Offense count: 45
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
630 631
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
632
  Enabled: false
633

634
# Offense count: 106
Connor Shea's avatar
Connor Shea committed
635 636 637 638 639 640
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
641
# Offense count: 9
642
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
643
# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
644
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
645
Style/TernaryParentheses:
Rémy Coutable's avatar
Rémy Coutable committed
646 647 648 649 650 651 652
  Exclude:
    - 'app/finders/projects_finder.rb'
    - 'app/helpers/namespaces_helper.rb'
    - 'features/support/capybara.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/requests/api/pipeline_schedules_spec.rb'
    - 'spec/support/capybara.rb'
653

654
# Offense count: 17
Connor Shea's avatar
Connor Shea committed
655 656 657
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Rémy Coutable's avatar
Rémy Coutable committed
658 659 660 661 662 663 664 665 666 667 668 669 670
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/logger.rb'
    - 'lib/gitlab/upgrader.rb'
    - 'lib/system_check/app/migrations_are_up_check.rb'
    - 'lib/system_check/incoming_email/mail_room_running_check.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'lib/tasks/gitlab/task_helpers.rb'
    - 'spec/lib/gitlab/etag_caching/middleware_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
671

Rémy Coutable's avatar
Rémy Coutable committed
672
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
673 674
# Cop supports --auto-correct.
Style/UnlessElse:
Rémy Coutable's avatar
Rémy Coutable committed
675 676 677 678 679
  Exclude:
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/project_search_results.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
680

681
# Offense count: 31
Connor Shea's avatar
Connor Shea committed
682 683
# Cop supports --auto-correct.
Style/UnneededInterpolation:
684
  Enabled: false
Connor Shea's avatar
Connor Shea committed
685

686
# Offense count: 22840
Rémy Coutable's avatar
Rémy Coutable committed
687 688 689 690
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310