issue_spec.rb 26.6 KB
Newer Older
gitlabhq's avatar
gitlabhq committed
1 2
require 'spec_helper'

3
describe Issue do
gitlabhq's avatar
gitlabhq committed
4
  describe "Associations" do
5
    it { is_expected.to belong_to(:milestone) }
6
    it { is_expected.to have_many(:assignees) }
gitlabhq's avatar
gitlabhq committed
7 8
  end

9
  describe 'modules' do
10 11
    subject { described_class }

12
    it { is_expected.to include_module(Issuable) }
13 14 15
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(Taskable) }
16 17 18 19 20 21 22

    it_behaves_like 'AtomicInternalId' do
      let(:internal_id_attribute) { :iid }
      let(:instance) { build(:issue) }
      let(:scope_attrs) { { project: instance.project } }
      let(:usage) { :issues }
    end
23 24
  end

25
  subject { create(:issue) }
26

27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52
  describe 'callbacks' do
    describe '#ensure_metrics' do
      it 'creates metrics after saving' do
        issue = create(:issue)

        expect(issue.metrics).to be_persisted
        expect(Issue::Metrics.count).to eq(1)
      end

      it 'does not create duplicate metrics for an issue' do
        issue = create(:issue)

        issue.close!

        expect(issue.metrics).to be_persisted
        expect(Issue::Metrics.count).to eq(1)
      end

      it 'records current metrics' do
        expect_any_instance_of(Issue::Metrics).to receive(:record!)

        create(:issue)
      end
    end
  end

53
  describe '#order_by_position_and_priority' do
54
    let(:project) { create :project }
55 56 57 58 59 60 61 62
    let(:p1) { create(:label, title: 'P1', project: project, priority: 1) }
    let(:p2) { create(:label, title: 'P2', project: project, priority: 2) }
    let!(:issue1) { create(:labeled_issue, project: project, labels: [p1]) }
    let!(:issue2) { create(:labeled_issue, project: project, labels: [p2]) }
    let!(:issue3) { create(:issue, project: project, relative_position: 100) }
    let!(:issue4) { create(:issue, project: project, relative_position: 200) }

    it 'returns ordered list' do
63 64
      expect(project.issues.order_by_position_and_priority)
        .to match [issue3, issue4, issue1, issue2]
65 66 67
    end
  end

68 69 70 71 72
  describe '#card_attributes' do
    it 'includes the author name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignees).and_return([])

73 74
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => '' })
75 76 77 78 79 80
    end

    it 'includes the assignee name' do
      allow(subject).to receive(:author).and_return(double(name: 'Robert'))
      allow(subject).to receive(:assignees).and_return([double(name: 'Douwe')])

81 82
      expect(subject.card_attributes)
        .to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe' })
83 84 85
    end
  end

86 87 88 89
  describe '#closed_at' do
    it 'sets closed_at to Time.now when issue is closed' do
      issue = create(:issue, state: 'opened')

90 91
      expect(issue.closed_at).to be_nil

92 93
      issue.close

94
      expect(issue.closed_at).to be_present
95 96 97
    end
  end

98
  describe '#to_reference' do
99
    let(:namespace) { build(:namespace, path: 'sample-namespace') }
100
    let(:project)   { build(:project, name: 'sample-project', namespace: namespace) }
101 102
    let(:issue)     { build(:issue, iid: 1, project: project) }
    let(:group)     { create(:group, name: 'Group', path: 'sample-group') }
103

104 105 106 107
    context 'when nil argument' do
      it 'returns issue id' do
        expect(issue.to_reference).to eq "#1"
      end
108 109
    end

110
    context 'when full is true' do
111
      it 'returns complete path to the issue' do
112 113 114
        expect(issue.to_reference(full: true)).to          eq 'sample-namespace/sample-project#1'
        expect(issue.to_reference(project, full: true)).to eq 'sample-namespace/sample-project#1'
        expect(issue.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project#1'
115
      end
116 117
    end

118 119 120 121 122 123 124
    context 'when same project argument' do
      it 'returns issue id' do
        expect(issue.to_reference(project)).to eq("#1")
      end
    end

    context 'when cross namespace project argument' do
125
      let(:another_namespace_project) { create(:project, name: 'another-project') }
126 127 128 129

      it 'returns complete path to the issue' do
        expect(issue.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project#1'
      end
130 131
    end

132
    it 'supports a cross-project reference' do
133
      another_project = build(:project, name: 'another-project', namespace: project.namespace)
134
      expect(issue.to_reference(another_project)).to eq "sample-project#1"
135
    end
136

137
    context 'when same namespace / cross-project argument' do
138
      let(:another_project) { create(:project, namespace: namespace) }
139 140 141 142 143 144 145 146

      it 'returns path to the issue with the project name' do
        expect(issue.to_reference(another_project)).to eq 'sample-project#1'
      end
    end

    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace') }
147
      let(:another_project)   { create(:project, path: 'another-project', namespace: another_namespace) }
148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165

      it 'returns full path to the issue' do
        expect(issue.to_reference(another_project)).to eq 'sample-namespace/sample-project#1'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the issue with the project name' do
          expect(issue.to_reference(namespace)).to eq 'sample-project#1'
        end
      end

      context 'with different project path' do
        it 'returns full path to the issue' do
          expect(issue.to_reference(group)).to eq 'sample-namespace/sample-project#1'
        end
      end
166
    end
167 168
  end

169 170 171 172 173 174 175 176
  describe '#assignee_or_author?' do
    let(:user) { create(:user) }
    let(:issue) { create(:issue) }

    it 'returns true for a user that is assigned to an issue' do
      issue.assignees << user

      expect(issue.assignee_or_author?(user)).to be_truthy
177
    end
178 179 180 181 182 183 184 185 186

    it 'returns true for a user that is the author of an issue' do
      issue.update(author: user)

      expect(issue.assignee_or_author?(user)).to be_truthy
    end

    it 'returns false for a user that is not the assignee or author' do
      expect(issue.assignee_or_author?(user)).to be_falsey
187 188
    end
  end
189

190
  describe '#closed_by_merge_requests' do
191 192 193
    let(:project) { create(:project, :repository) }
    let(:issue) { create(:issue, project: project)}
    let(:closed_issue) { build(:issue, :closed, project: project)}
194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216

    let(:mr) do
      opts = {
        title: 'Awesome merge_request',
        description: "Fixes #{issue.to_reference}",
        source_branch: 'feature',
        target_branch: 'master'
      }
      MergeRequests::CreateService.new(project, project.owner, opts).execute
    end

    let(:closed_mr) do
      opts = {
        title: 'Awesome merge_request 2',
        description: "Fixes #{issue.to_reference}",
        source_branch: 'feature',
        target_branch: 'master',
        state: 'closed'
      }
      MergeRequests::CreateService.new(project, project.owner, opts).execute
    end

    it 'returns the merge request to close this issue' do
217
      expect(issue.closed_by_merge_requests(mr.author)).to eq([mr])
218 219
    end

220
    it "returns an empty array when the merge request is closed already" do
221
      expect(issue.closed_by_merge_requests(closed_mr.author)).to eq([])
222 223
    end

224
    it "returns an empty array when the current issue is closed already" do
225
      expect(closed_issue.closed_by_merge_requests(closed_issue.author)).to eq([])
226 227 228
    end
  end

229
  describe '#referenced_merge_requests' do
230 231 232 233 234 235 236 237 238 239
    let(:project) { create(:project, :public) }
    let(:issue) do
      create(:issue, description: merge_request.to_reference, project: project)
    end
    let!(:merge_request) do
      create(:merge_request,
             source_project: project,
             source_branch:  'master',
             target_branch:  'feature')
    end
240

241
    it 'returns the referenced merge requests' do
242 243 244 245 246 247 248 249 250 251
      mr2 = create(:merge_request,
                   source_project: project,
                   source_branch:  'feature',
                   target_branch:  'master')

      create(:note_on_issue,
             noteable:   issue,
             note:       mr2.to_reference,
             project_id: project.id)

252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278
      expect(issue.referenced_merge_requests).to eq([merge_request, mr2])
    end

    it 'returns cross project referenced merge requests' do
      other_project = create(:project, :public)
      cross_project_merge_request = create(:merge_request, source_project: other_project)
      create(:note_on_issue,
             noteable:   issue,
             note:       cross_project_merge_request.to_reference(issue.project),
             project_id: issue.project.id)

      expect(issue.referenced_merge_requests).to eq([merge_request, cross_project_merge_request])
    end

    it 'excludes cross project references if the user cannot read cross project' do
      user = create(:user)
      allow(Ability).to receive(:allowed?).and_call_original
      expect(Ability).to receive(:allowed?).with(user, :read_cross_project) { false }

      other_project = create(:project, :public)
      cross_project_merge_request = create(:merge_request, source_project: other_project)
      create(:note_on_issue,
             noteable:   issue,
             note:       cross_project_merge_request.to_reference(issue.project),
             project_id: issue.project.id)

      expect(issue.referenced_merge_requests(user)).to eq([merge_request])
279 280 281
    end
  end

282 283 284 285 286 287 288 289 290 291
  describe '#can_move?' do
    let(:user) { create(:user) }
    let(:issue) { create(:issue) }
    subject { issue.can_move?(user) }

    context 'user is not a member of project issue belongs to' do
      it { is_expected.to eq false}
    end

    context 'user is reporter in project issue belongs to' do
292
      let(:project) { create(:project) }
293 294
      let(:issue) { create(:issue, project: project) }

295
      before do
296
        project.add_reporter(user)
297
      end
298 299 300

      it { is_expected.to eq true }

301 302 303 304 305
      context 'issue not persisted' do
        let(:issue) { build(:issue, project: project) }
        it { is_expected.to eq false }
      end

306 307
      context 'checking destination project also' do
        subject { issue.can_move?(user, to_project) }
308
        let(:to_project) { create(:project) }
309 310

        context 'destination project allowed' do
311
          before do
312
            to_project.add_reporter(user)
313 314
          end

315 316 317 318
          it { is_expected.to eq true }
        end

        context 'destination project not allowed' do
319
          before do
320
            to_project.add_guest(user)
321 322
          end

323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344
          it { is_expected.to eq false }
        end
      end
    end
  end

  describe '#moved?' do
    let(:issue) { create(:issue) }
    subject { issue.moved? }

    context 'issue not moved' do
      it { is_expected.to eq false }
    end

    context 'issue already moved' do
      let(:moved_to_issue) { create(:issue) }
      let(:issue) { create(:issue, moved_to: moved_to_issue) }

      it { is_expected.to eq true }
    end
  end

345
  describe '#related_branches' do
346
    let(:user) { create(:admin) }
347

348
    before do
349 350
      allow(subject.project.repository).to receive(:branch_names)
                                            .and_return(["mpempe", "#{subject.iid}mepmep", subject.to_branch_name, "#{subject.iid}-branch"])
351 352 353 354 355 356 357 358

      # Without this stub, the `create(:merge_request)` above fails because it can't find
      # the source branch. This seems like a reasonable compromise, in comparison with
      # setting up a full repo here.
      allow_any_instance_of(MergeRequest).to receive(:create_merge_request_diff)
    end

    it "selects the right branches when there are no referenced merge requests" do
359
      expect(subject.related_branches(user)).to eq([subject.to_branch_name, "#{subject.iid}-branch"])
360
    end
361

362
    it "selects the right branches when there is a referenced merge request" do
Timothy Andrew's avatar
Timothy Andrew committed
363 364
      merge_request = create(:merge_request, { description: "Closes ##{subject.iid}",
                                               source_project: subject.project,
365
                                               source_branch: "#{subject.iid}-branch" })
366
      merge_request.create_cross_references!(user)
367
      expect(subject.referenced_merge_requests(user)).not_to be_empty
368
      expect(subject.related_branches(user)).to eq([subject.to_branch_name])
369
    end
370 371

    it 'excludes stable branches from the related branches' do
372 373
      allow(subject.project.repository).to receive(:branch_names)
        .and_return(["#{subject.iid}-0-stable"])
374

375
      expect(subject.related_branches(user)).to eq []
376
    end
377 378
  end

379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420
  describe '#suggested_branch_name' do
    let(:repository) { double }

    subject { build(:issue) }

    before do
      allow(subject.project).to receive(:repository).and_return(repository)
    end

    context '#to_branch_name does not exists' do
      before do
        allow(repository).to receive(:branch_exists?).and_return(false)
      end

      it 'returns #to_branch_name' do
        expect(subject.suggested_branch_name).to eq(subject.to_branch_name)
      end
    end

    context '#to_branch_name exists not ending with -index' do
      before do
        allow(repository).to receive(:branch_exists?).and_return(true)
        allow(repository).to receive(:branch_exists?).with(/#{subject.to_branch_name}-\d/).and_return(false)
      end

      it 'returns #to_branch_name ending with -2' do
        expect(subject.suggested_branch_name).to eq("#{subject.to_branch_name}-2")
      end
    end

    context '#to_branch_name exists ending with -index' do
      before do
        allow(repository).to receive(:branch_exists?).and_return(true)
        allow(repository).to receive(:branch_exists?).with("#{subject.to_branch_name}-3").and_return(false)
      end

      it 'returns #to_branch_name ending with max index + 1' do
        expect(subject.suggested_branch_name).to eq("#{subject.to_branch_name}-3")
      end
    end
  end

421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
  describe '#has_related_branch?' do
    let(:issue) { create(:issue, title: "Blue Bell Knoll") }
    subject { issue.has_related_branch? }

    context 'branch found' do
      before do
        allow(issue.project.repository).to receive(:branch_names).and_return(["iceblink-luck", issue.to_branch_name])
      end

      it { is_expected.to eq true }
    end

    context 'branch not found' do
      before do
        allow(issue.project.repository).to receive(:branch_names).and_return(["lazy-calm"])
      end

      it { is_expected.to eq false }
    end
  end

442
  it_behaves_like 'an editable mentionable' do
443
    subject { create(:issue, project: create(:project, :repository)) }
444

445
    let(:backref_text) { "issue #{subject.to_reference}" }
446
    let(:set_mentionable_text) { ->(txt) { subject.description = txt } }
447
  end
Vinnie Okada's avatar
Vinnie Okada committed
448 449 450 451

  it_behaves_like 'a Taskable' do
    let(:subject) { create :issue }
  end
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
452 453

  describe "#to_branch_name" do
454
    let(:issue) { create(:issue, title: 'testing-issue') }
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
455

456
    it 'starts with the issue iid' do
457
      expect(issue.to_branch_name).to match /\A#{issue.iid}-[A-Za-z\-]+\z/
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
458
    end
459 460

    it "contains the issue title if not confidential" do
461
      expect(issue.to_branch_name).to match /testing-issue\z/
462 463 464 465
    end

    it "does not contain the issue title if confidential" do
      issue = create(:issue, title: 'testing-issue', confidential: true)
466
      expect(issue.to_branch_name).to match /confidential-issue\z/
467
    end
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
468
  end
Yorick Peterse's avatar
Yorick Peterse committed
469

470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
  describe '#can_be_worked_on?' do
    let(:project) { build(:project) }
    subject { build(:issue, :opened, project: project) }

    context 'is closed' do
      subject { build(:issue, :closed) }

      it { is_expected.not_to be_can_be_worked_on }
    end

    context 'project is forked' do
      before do
        allow(project).to receive(:forked?).and_return(true)
      end

      it { is_expected.not_to be_can_be_worked_on }
    end

    it { is_expected.to be_can_be_worked_on }
  end

Yorick Peterse's avatar
Yorick Peterse committed
491 492
  describe '#participants' do
    context 'using a public project' do
493
      let(:project) { create(:project, :public) }
Yorick Peterse's avatar
Yorick Peterse committed
494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514
      let(:issue) { create(:issue, project: project) }

      let!(:note1) do
        create(:note_on_issue, noteable: issue, project: project, note: 'a')
      end

      let!(:note2) do
        create(:note_on_issue, noteable: issue, project: project, note: 'b')
      end

      it 'includes the issue author' do
        expect(issue.participants).to include(issue.author)
      end

      it 'includes the authors of the notes' do
        expect(issue.participants).to include(note1.author, note2.author)
      end
    end

    context 'using a private project' do
      it 'does not include mentioned users that do not have access to the project' do
515
        project = create(:project)
Yorick Peterse's avatar
Yorick Peterse committed
516 517 518 519 520 521 522 523 524 525 526 527
        user = create(:user)
        issue = create(:issue, project: project)

        create(:note_on_issue,
               noteable: issue,
               project: project,
               note: user.to_reference)

        expect(issue.participants).not_to include(user)
      end
    end
  end
528 529 530 531 532

  describe 'cached counts' do
    it 'updates when assignees change' do
      user1 = create(:user)
      user2 = create(:user)
533
      project = create(:project)
534
      issue = create(:issue, assignees: [user1], project: project)
535 536
      project.add_developer(user1)
      project.add_developer(user2)
537 538 539 540

      expect(user1.assigned_open_issues_count).to eq(1)
      expect(user2.assigned_open_issues_count).to eq(0)

541
      issue.assignees = [user2]
542 543 544 545 546 547
      issue.save

      expect(user1.assigned_open_issues_count).to eq(0)
      expect(user2.assigned_open_issues_count).to eq(1)
    end
  end
548 549

  describe '#visible_to_user?' do
550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565
    context 'without a user' do
      let(:issue) { build(:issue) }

      it 'returns true when the issue is publicly visible' do
        expect(issue).to receive(:publicly_visible?).and_return(true)

        expect(issue.visible_to_user?).to eq(true)
      end

      it 'returns false when the issue is not publicly visible' do
        expect(issue).to receive(:publicly_visible?).and_return(false)

        expect(issue.visible_to_user?).to eq(false)
      end
    end

566
    context 'with a user' do
567
      let(:user) { create(:user) }
568 569 570 571 572 573 574 575 576 577 578 579 580 581
      let(:issue) { build(:issue) }

      it 'returns true when the issue is readable' do
        expect(issue).to receive(:readable_by?).with(user).and_return(true)

        expect(issue.visible_to_user?(user)).to eq(true)
      end

      it 'returns false when the issue is not readable' do
        expect(issue).to receive(:readable_by?).with(user).and_return(false)

        expect(issue.visible_to_user?(user)).to eq(false)
      end

582 583
      it 'returns false when feature is disabled' do
        expect(issue).not_to receive(:readable_by?)
584

585
        issue.project.project_feature.update_attribute(:issues_access_level, ProjectFeature::DISABLED)
586

587
        expect(issue.visible_to_user?(user)).to eq(false)
588 589
      end

590 591
      it 'returns false when restricted for members' do
        expect(issue).not_to receive(:readable_by?)
592

593 594 595
        issue.project.project_feature.update_attribute(:issues_access_level, ProjectFeature::PRIVATE)

        expect(issue.visible_to_user?(user)).to eq(false)
596 597 598 599 600 601 602
      end
    end

    describe 'with a regular user that is not a team member' do
      let(:user) { create(:user) }

      context 'using a public project' do
603
        let(:project) { create(:project, :public) }
604 605 606 607

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

608
          expect(issue.visible_to_user?(user)).to eq(true)
609 610 611 612 613
        end

        it 'returns false for a confidential issue' do
          issue = build(:issue, project: project, confidential: true)

614
          expect(issue.visible_to_user?(user)).to eq(false)
615 616 617 618
        end
      end

      context 'using an internal project' do
619
        let(:project) { create(:project, :internal) }
620 621 622 623 624

        context 'using an internal user' do
          it 'returns true for a regular issue' do
            issue = build(:issue, project: project)

625
            expect(issue.visible_to_user?(user)).to eq(true)
626 627 628 629 630
          end

          it 'returns false for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

631
            expect(issue.visible_to_user?(user)).to eq(false)
632 633 634 635 636 637 638 639 640 641 642
          end
        end

        context 'using an external user' do
          before do
            allow(user).to receive(:external?).and_return(true)
          end

          it 'returns false for a regular issue' do
            issue = build(:issue, project: project)

643
            expect(issue.visible_to_user?(user)).to eq(false)
644 645 646 647 648
          end

          it 'returns false for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

649
            expect(issue.visible_to_user?(user)).to eq(false)
650 651 652 653 654
          end
        end
      end

      context 'using a private project' do
655
        let(:project) { create(:project, :private) }
656 657 658 659

        it 'returns false for a regular issue' do
          issue = build(:issue, project: project)

660
          expect(issue.visible_to_user?(user)).to eq(false)
661 662 663 664 665
        end

        it 'returns false for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

666
          expect(issue.visible_to_user?(user)).to eq(false)
667 668 669
        end

        context 'when the user is the project owner' do
670
          before do
671
            project.add_master(user)
672
          end
673

674 675 676
          it 'returns true for a regular issue' do
            issue = build(:issue, project: project)

677
            expect(issue.visible_to_user?(user)).to eq(true)
678 679 680 681 682
          end

          it 'returns true for a confidential issue' do
            issue = build(:issue, :confidential, project: project)

683
            expect(issue.visible_to_user?(user)).to eq(true)
684 685 686 687 688 689 690
          end
        end
      end
    end

    context 'with a regular user that is a team member' do
      let(:user) { create(:user) }
691
      let(:project) { create(:project, :public) }
692 693 694

      context 'using a public project' do
        before do
695
          project.add_developer(user)
696 697 698 699 700
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

701
          expect(issue.visible_to_user?(user)).to eq(true)
702 703 704 705 706
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

707
          expect(issue.visible_to_user?(user)).to eq(true)
708 709 710 711
        end
      end

      context 'using an internal project' do
712
        let(:project) { create(:project, :internal) }
713 714

        before do
715
          project.add_developer(user)
716 717 718 719 720
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

721
          expect(issue.visible_to_user?(user)).to eq(true)
722 723 724 725 726
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

727
          expect(issue.visible_to_user?(user)).to eq(true)
728 729 730 731
        end
      end

      context 'using a private project' do
732
        let(:project) { create(:project, :private) }
733 734

        before do
735
          project.add_developer(user)
736 737 738 739 740
        end

        it 'returns true for a regular issue' do
          issue = build(:issue, project: project)

741
          expect(issue.visible_to_user?(user)).to eq(true)
742 743 744 745 746
        end

        it 'returns true for a confidential issue' do
          issue = build(:issue, :confidential, project: project)

747
          expect(issue.visible_to_user?(user)).to eq(true)
748 749 750 751 752
        end
      end
    end

    context 'with an admin user' do
753
      let(:project) { create(:project) }
754
      let(:user) { create(:admin) }
755 756 757 758

      it 'returns true for a regular issue' do
        issue = build(:issue, project: project)

759
        expect(issue.visible_to_user?(user)).to eq(true)
760 761 762 763 764
      end

      it 'returns true for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

765
        expect(issue.visible_to_user?(user)).to eq(true)
766 767 768 769 770 771
      end
    end
  end

  describe '#publicly_visible?' do
    context 'using a public project' do
772
      let(:project) { create(:project, :public) }
773 774 775 776

      it 'returns true for a regular issue' do
        issue = build(:issue, project: project)

777
        expect(issue).to be_truthy
778 779 780 781 782
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

783
        expect(issue).not_to be_falsy
784 785 786 787
      end
    end

    context 'using an internal project' do
788
      let(:project) { create(:project, :internal) }
789 790 791 792

      it 'returns false for a regular issue' do
        issue = build(:issue, project: project)

793
        expect(issue).not_to be_falsy
794 795 796 797 798
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

799
        expect(issue).not_to be_falsy
800 801 802 803
      end
    end

    context 'using a private project' do
804
      let(:project) { create(:project, :private) }
805 806 807 808

      it 'returns false for a regular issue' do
        issue = build(:issue, project: project)

809
        expect(issue).not_to be_falsy
810 811 812 813 814
      end

      it 'returns false for a confidential issue' do
        issue = build(:issue, :confidential, project: project)

815
        expect(issue).not_to be_falsy
816 817 818
      end
    end
  end
819 820

  describe '#hook_attrs' do
821 822 823 824 825 826 827 828
    it 'delegates to Gitlab::HookData::IssueBuilder#build' do
      builder = double

      expect(Gitlab::HookData::IssueBuilder)
        .to receive(:new).with(subject).and_return(builder)
      expect(builder).to receive(:build)

      subject.hook_attrs
829
    end
830
  end
831 832

  describe '#check_for_spam' do
833
    let(:project) { create :project, visibility_level: visibility_level }
834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867
    let(:issue) { create :issue, project: project }

    subject do
      issue.assign_attributes(description: description)
      issue.check_for_spam?
    end

    context 'when project is public and spammable attributes changed' do
      let(:visibility_level) { Gitlab::VisibilityLevel::PUBLIC }
      let(:description) { 'woo' }

      it 'returns true' do
        is_expected.to be_truthy
      end
    end

    context 'when project is private' do
      let(:visibility_level) { Gitlab::VisibilityLevel::PRIVATE }
      let(:description) { issue.description }

      it 'returns false' do
        is_expected.to be_falsey
      end
    end

    context 'when spammable attributes have not changed' do
      let(:visibility_level) { Gitlab::VisibilityLevel::PUBLIC }
      let(:description) { issue.description }

      it 'returns false' do
        is_expected.to be_falsey
      end
    end
  end
868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885

  describe 'removing an issue' do
    it 'refreshes the number of open issues of the project' do
      project = subject.project

      expect { subject.destroy }
        .to change { project.open_issues_count }.from(1).to(0)
    end
  end

  describe '.public_only' do
    it 'only returns public issues' do
      public_issue = create(:issue)
      create(:issue, confidential: true)

      expect(described_class.public_only).to eq([public_issue])
    end
  end
886 887 888 889

  it_behaves_like 'throttled touch' do
    subject { create(:issue, updated_at: 1.hour.ago) }
  end
gitlabhq's avatar
gitlabhq committed
890
end