1. 07 Feb, 2019 2 commits
  2. 06 Feb, 2019 10 commits
  3. 05 Feb, 2019 4 commits
  4. 04 Feb, 2019 4 commits
  5. 03 Feb, 2019 1 commit
  6. 01 Feb, 2019 1 commit
  7. 31 Jan, 2019 7 commits
  8. 30 Jan, 2019 3 commits
  9. 29 Jan, 2019 3 commits
    • Stan Hu's avatar
      Fix failed LDAP logins when nil user_id present · ab4aba70
      Stan Hu authored
      When a LDAP user signs in the for the first time and if there
      is an `Identity` object with `user_id` of `nil`, new users
      will not be able to be register until that entry is cleared
      because of the way identities are created:
      1. First, the User object is built but not saved, so it has no `id`.
      2. Then, `user.identities.build(provider: 'ldapmain')` is called,
         but it does not have an associated `user_id` as a result.
      3. `User#save` is called, but the `Identity` validation fails if an
         existing entry with `user_id` of `nil` already exists.
      The uniqueness validation for `nil` values doesn't make any sense in
      this case. We should be enforcing this at the database level with a
      foreign key constraint. To work around the issue we can validate
      against the user instead, which does the right thing even when
      the user isn't saved yet.
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56734
    • Adrian Moisey's avatar
      Add GitLab Pages predefined variables · 88d1ec62
      Adrian Moisey authored
    • Andreas Brandl's avatar
      Flush InternalId records after import · fede3a0b
      Andreas Brandl authored
      After the import has finished, we flush (delete) the InternalId records
      related to the project at hand. This means we're starting over with
      tracking correct internal id values, a new record will be created
      automatically when the next internal id is generated.
      The GitHub importer assigns iid values by using supplied values from
      GitHub. We skip tracking internal id values during the import in favor
      of higher concurrency. Deleting any InternalId records after the import
      has finished is an extra measure to guarantee consistency.
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54270.
  10. 28 Jan, 2019 3 commits
  11. 25 Jan, 2019 2 commits