1. 05 Dec, 2015 1 commit
    • Stan Hu's avatar
      Fix Error 500 when creating global milestones with Unicode characters · d800a949
      Stan Hu authored
      Two issues:
      
      1. The constraints in the resources were incorrect. Here's what it was before:
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      In this case, id is actually the title of the milestone, which can be anything at the moment.
      
      After:
      
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
      
      ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
      
      This change uses the babosa library to create a better slug, which surprisingly
      isn't actually used by the global milestone controllers. Instead, they use the
      title passed as a query string for some reason.
      
      Closes https://github.com/gitlabhq/gitlabhq/issues/9881
      
      Fix constraints
      d800a949
  2. 27 Nov, 2015 1 commit
  3. 26 Nov, 2015 2 commits
  4. 25 Nov, 2015 4 commits
  5. 24 Nov, 2015 4 commits
  6. 23 Nov, 2015 1 commit
  7. 19 Nov, 2015 1 commit
  8. 11 Nov, 2015 1 commit
  9. 10 Nov, 2015 2 commits
  10. 09 Nov, 2015 2 commits
    • Stan Hu's avatar
      Upgrade gitlab_git to 7.2.20 and rugged to 0.23.3. · 4017a4fc
      Stan Hu authored
      Switch back to github-linguist
      4017a4fc
    • Yorick Peterse's avatar
      Added Sherlock, a custom profiling tool for GitLab · dec3e4ce
      Yorick Peterse authored
      Sherlock will be a new GitLab specific tool for measuring the
      performance of Rails requests (and SideKiq jobs at some point). Some of
      the things that are currently tracked:
      
      * SQL queries along with their timings, backtraces and query plans
        (using "EXPLAIN ANALYZE" for PostgreSQL and regular "EXPLAIN" for
        MySQL)
      * Timings of application files (including views) on a per line basis
      * Some meta data such as the request method, path, total duration, etc
      
      More tracking (e.g. Rugged or gitlab-shell timings) might be added in
      the future.
      
      Sherlock will replace any existing tools we have used so far (e.g.
      active_record_query_trace and rack-mini-profiler), hence the
      corresponding Gems have been removed from the Gemfile.
      
      Sherlock can be enabled by starting Rails as following:
      
          ENABLE_SHERLOCK=1 bundle exec rails s
      
      Recorded transactions can be found at `/sherlock/transactions`.
      dec3e4ce
  11. 08 Nov, 2015 1 commit
  12. 03 Nov, 2015 2 commits
  13. 26 Oct, 2015 2 commits
  14. 15 Oct, 2015 5 commits
  15. 14 Oct, 2015 1 commit
  16. 13 Oct, 2015 1 commit
  17. 11 Oct, 2015 1 commit
  18. 09 Oct, 2015 3 commits
  19. 08 Oct, 2015 5 commits