1. 27 Feb, 2019 2 commits
  2. 21 Feb, 2019 1 commit
    • Thong Kuah's avatar
      Do not allow local urls in Kubernetes form · e5181ff4
      Thong Kuah authored
      Use existing `public_url` validation to block various local urls. Note
      that this validation will allow local urls if the "Allow requests to the
      local network from hooks and services" admin setting is enabled.
      
      Block KubeClient from using local addresses
      
      It will also respect `allow_local_requests_from_hooks_and_services` so
      if that is enabled KubeClinet will allow local addresses
      e5181ff4
  3. 18 Feb, 2019 2 commits
  4. 14 Feb, 2019 1 commit
  5. 13 Feb, 2019 1 commit
    • Jarka Košanová's avatar
      Check issue milestone availability · 98df4053
      Jarka Košanová authored
      Add project when creating milestone in specs
      
      We validate milestone is from the same
      project/parent group as issuable ->
      we need to set project in specs correctly
      
      Improve methods names and specs organization
      98df4053
  6. 07 Feb, 2019 2 commits
  7. 06 Feb, 2019 10 commits
  8. 05 Feb, 2019 4 commits
  9. 04 Feb, 2019 4 commits
  10. 03 Feb, 2019 1 commit
  11. 01 Feb, 2019 1 commit
  12. 31 Jan, 2019 7 commits
  13. 30 Jan, 2019 3 commits
  14. 29 Jan, 2019 1 commit
    • Stan Hu's avatar
      Fix failed LDAP logins when nil user_id present · ab4aba70
      Stan Hu authored
      When a LDAP user signs in the for the first time and if there
      is an `Identity` object with `user_id` of `nil`, new users
      will not be able to be register until that entry is cleared
      because of the way identities are created:
      
      1. First, the User object is built but not saved, so it has no `id`.
      2. Then, `user.identities.build(provider: 'ldapmain')` is called,
         but it does not have an associated `user_id` as a result.
      3. `User#save` is called, but the `Identity` validation fails if an
         existing entry with `user_id` of `nil` already exists.
      
      The uniqueness validation for `nil` values doesn't make any sense in
      this case. We should be enforcing this at the database level with a
      foreign key constraint. To work around the issue we can validate
      against the user instead, which does the right thing even when
      the user isn't saved yet.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56734
      ab4aba70