1. 13 Feb, 2019 1 commit
    • Jarka Košanová's avatar
      Check issue milestone availability · 98df4053
      Jarka Košanová authored
      Add project when creating milestone in specs
      
      We validate milestone is from the same
      project/parent group as issuable ->
      we need to set project in specs correctly
      
      Improve methods names and specs organization
      98df4053
  2. 07 Feb, 2019 1 commit
  3. 30 Jan, 2019 2 commits
  4. 14 Dec, 2018 1 commit
  5. 02 Nov, 2018 1 commit
  6. 07 Sep, 2018 1 commit
  7. 30 Jul, 2018 1 commit
  8. 11 Jul, 2018 1 commit
  9. 09 Jul, 2018 1 commit
  10. 01 Jun, 2018 1 commit
  11. 05 Apr, 2018 1 commit
  12. 03 Apr, 2018 1 commit
  13. 31 Jan, 2018 1 commit
  14. 22 Dec, 2017 1 commit
  15. 09 Oct, 2017 1 commit
  16. 19 Sep, 2017 1 commit
    • Yorick Peterse's avatar
      Fix refreshing of issues/MR count caches · 57b96eb6
      Yorick Peterse authored
      This ensures the open issues/MR count caches are refreshed properly when
      creating new issues or MRs. This MR also includes a change to the cache
      keys to ensure all caches are rebuilt on the fly.
      
      This particular problem was not caught in the test suite due to a null
      cache being used, resulting in all calls that would use a cache using
      the underlying data directly. In production the code would fail because
      a newly saved record returns an empty hash in #changes meaning checks
      such as `state_changed? || confidential_changed?` would return false for
      new rows, thus never updating the counters.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
      57b96eb6
  17. 14 Sep, 2017 2 commits
  18. 02 Sep, 2017 1 commit
    • Robert Speicher's avatar
      Fix a spec failure dependent on load order · 7cc19cd5
      Robert Speicher authored
      We were incorrectly stubbing `Issues::MoveService#execute`. This only
      caused a failure when another spec caused it to be autoloaded --
      `spec/controllers/projects/issues_controller_spec.rb` in this case.
      7cc19cd5
  19. 31 Aug, 2017 2 commits
  20. 09 Aug, 2017 1 commit
  21. 03 Aug, 2017 1 commit
    • Lin Jen-Shin's avatar
      Don't include EmailHelpers manually, pick with rspec · bb5f79d4
      Lin Jen-Shin authored
      `:mailer` is needed to pick it easily, while
      `type: :mailer` is needed for picking it automatically for
      tests located in spec/mailers/*_spec.rb
      
      It's a bit complicated in spec/services/notification_service_spec.rb
      but we'll leave it alone for now.
      bb5f79d4
  22. 02 Aug, 2017 1 commit
  23. 27 Jul, 2017 2 commits
  24. 21 Jul, 2017 1 commit
  25. 20 Jul, 2017 2 commits
  26. 07 Jul, 2017 1 commit
  27. 14 Jun, 2017 1 commit
  28. 12 Jun, 2017 1 commit
  29. 12 May, 2017 1 commit
  30. 05 May, 2017 2 commits
  31. 04 May, 2017 1 commit
  32. 29 Mar, 2017 1 commit
  33. 07 Mar, 2017 1 commit
  34. 02 Mar, 2017 1 commit