1. 22 Aug, 2017 1 commit
  2. 21 Aug, 2017 1 commit
  3. 02 Aug, 2017 1 commit
  4. 01 May, 2017 1 commit
  5. 28 Mar, 2017 1 commit
  6. 12 Aug, 2016 1 commit
    • Stan Hu's avatar
      Fix bug where destroying a namespace would not always destroy projects · cb8a425b
      Stan Hu authored
      There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
      1. User attempts to delete group
      2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
      3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
      4. Projects::DestroyService runs later but the can?(current_user,
         :remove_project) is `false` because the user no longer has permission to
         destroy projects with no namespace.
      5. This leaves the project in pending_delete state with no namespace/group.
      Projects without a namespace or group also adds another problem: it's not possible to destroy the container
      registry tags, since container_registry_path_with_namespace is the wrong value.
      The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
      Closes #17893