1. 05 Jul, 2018 1 commit
  2. 23 Apr, 2018 1 commit
  3. 17 Jan, 2018 1 commit
  4. 27 Jul, 2017 1 commit
  5. 20 Jul, 2017 1 commit
  6. 07 Jul, 2017 1 commit
    • Timothy Andrew's avatar
      Test logging in via the Authentiq OAuth provider in a feature spec. · d53690b6
      Timothy Andrew authored
      - The `migration:path-pg` build was previously failing when the Authentiq
        feature spec was enabled by placing Authentiq configuration in the `test`
        section of `gitlab.yml`
      
      - The `migration:path-pg` task checks out an old revision of the
        codebase (`v8.14.10`) and runs a `schema:load`. It then checks out the commit
        under test, and runs `db:migrate`, to verify that migrations run without
        errors.
      
      - The problem here is that `v8.14.10` does not have the Authentiq module
        installed, but is run with the `gitlab.yml` for `master`, which would contain
        the `Authentiq` configuration in the `test` section.
      
      - The solution was to use the `v8.14.10` `gitlab.yml` for the `schema:load`,
        rather than the `gitlab.yml` from master.
      d53690b6
  7. 06 Jul, 2017 6 commits
    • Timothy Andrew's avatar
      Remove Authentiq from the OAuth login integration tests. · 89b0c987
      Timothy Andrew authored
      - This is causing autoload-related errors in the `migration:path` builds. We
        need to find a better way of testing this provider.
      89b0c987
    • Timothy Andrew's avatar
      Implement review comments for !11963 from @adamniedzielski. · 8fa08ea3
      Timothy Andrew authored
      - Change double quotes to single quotes.
      - Why is `OmniAuth.config.full_host` being reassigned in the integration test?
      - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
      - Other minor changes
      8fa08ea3
    • Timothy Andrew's avatar
      Add Omniauth OAuth config to the test section of `gitlab.yml` · 15dba34c
      Timothy Andrew authored
      - I tried to get this to work by stubbing out portions of the config within the
        test. This didn't work as expected because Devise/Omniauth loaded before the
        stub could run, and the stubbed config was ignored.
      
      - I attempted to fix this by reloading Devise/Omniauth after stubbing the
        config. This successfully got Devise to load the stubbed providers, but failed
        while trying to access a route such as `user_gitlab_omniauth_authorize_path`.
      
      - I spent a while trying to figure this out (even trying
        `Rails.application.reload_routes!`), but nothing seemed to work.
      
      - I settled for adding this config directly to `gitlab.yml` rather than go down
        this path any further.
      15dba34c
    • Timothy Andrew's avatar
      Add more providers to the OAuth login integration tests. · fd948558
      Timothy Andrew authored
      - Added saml, authentiq, cas3, and auth0
      - Crowd seems to be a special case that will be handled separately.
      fd948558
    • Timothy Andrew's avatar
      43337c12
    • Timothy Andrew's avatar
      Add integration tests around OAuth login. · e936db96
      Timothy Andrew authored
      - There was previously a test for `saml` login in `login_spec`, but this didn't
        seem to be passing. A lot of things didn't seem right here, and I suspect that
        this test hasn't been running. I'll investigate this further.
      
      - It took almost a whole working day to figure out this line:
      
          OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }
      
        As always, it's obvious in retrospect, but it took some digging to figure out
        tests were failing and returning 404s during the callback phase.
      
      - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
      e936db96
  8. 05 Jul, 2017 1 commit
  9. 03 Jul, 2017 5 commits
    • Timothy Andrew's avatar
      Implement review comments for !11963 from @adamniedzielski. · 4c34374d
      Timothy Andrew authored
      - Change double quotes to single quotes.
      - Why is `OmniAuth.config.full_host` being reassigned in the integration test?
      - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
      - Other minor changes
      4c34374d
    • Timothy Andrew's avatar
      Add Omniauth OAuth config to the test section of `gitlab.yml` · a931ead0
      Timothy Andrew authored
      - I tried to get this to work by stubbing out portions of the config within the
        test. This didn't work as expected because Devise/Omniauth loaded before the
        stub could run, and the stubbed config was ignored.
      
      - I attempted to fix this by reloading Devise/Omniauth after stubbing the
        config. This successfully got Devise to load the stubbed providers, but failed
        while trying to access a route such as `user_gitlab_omniauth_authorize_path`.
      
      - I spent a while trying to figure this out (even trying
        `Rails.application.reload_routes!`), but nothing seemed to work.
      
      - I settled for adding this config directly to `gitlab.yml` rather than go down
        this path any further.
      a931ead0
    • Timothy Andrew's avatar
      Add more providers to the OAuth login integration tests. · de0dcfe5
      Timothy Andrew authored
      - Added saml, authentiq, cas3, and auth0
      - Crowd seems to be a special case that will be handled separately.
      de0dcfe5
    • Timothy Andrew's avatar
      6bfc355e
    • Timothy Andrew's avatar
      Add integration tests around OAuth login. · dd926401
      Timothy Andrew authored
      - There was previously a test for `saml` login in `login_spec`, but this didn't
        seem to be passing. A lot of things didn't seem right here, and I suspect that
        this test hasn't been running. I'll investigate this further.
      
      - It took almost a whole working day to figure out this line:
      
          OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }
      
        As always, it's obvious in retrospect, but it took some digging to figure out
        tests were failing and returning 404s during the callback phase.
      
      - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
      dd926401