1. 15 Aug, 2016 17 commits
  2. 14 Aug, 2016 1 commit
    • Ahmad Sherif's avatar
      Fix a memory leak caused by Banzai::Filter::SanitizationFilter · 504a3b5e
      Ahmad Sherif authored
      In Banzai::Filter::SanitizationFilter#customize_whitelist, we append
      three lambdas that has reference to the SanitizationFilter instance,
      which in turn (potentially) has a reference to the following chain:
      context hash -> Project instance -> Repository instance -> lookup hash
      -> various Rugged instances -> various mmap-ed git pack files.
      All of the above is not garbage collected because the array we append
      the lambdas to is the constant
  3. 13 Aug, 2016 16 commits
  4. 12 Aug, 2016 6 commits
    • Drew Blessing's avatar
      Add archived badge to project listing · 60858c3d
      Drew Blessing authored
    • Robert Speicher's avatar
      Merge branch 'fix-namespace-deletion' into 'master' · 11eefba8
      Robert Speicher authored
      Fix bug where destroying a namespace would not always destroy projects
      There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
      1. User attempts to delete group
      2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
      3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
      4. Projects::DestroyService runs later but the can?(current_user,
          :remove_project) is `false` because the user no longer has permission to
          destroy projects with no namespace.
      5. This leaves the project in pending_delete state with no namespace/group.
      Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since `container_registry_path_with_namespace` is the wrong value.
      The fix is to destroy the group asynchronously and run `execute` directly on Projects::DestroyService.
      Closes #17893
      See merge request !4341
    • Douwe Maan's avatar
      Merge branch 'ruby-2-3-1' into 'master' · 7b63f828
      Douwe Maan authored
      Update ruby 2.3.1
      We where using 2.3.0, now 2.3.1
      cc @connorshea 
      See merge request !5790
    • Jacob Schatz's avatar
      Merge branch '20059-environment-list' into 'master' · 8d1c7c5d
      Jacob Schatz authored
      Resolve "Format branch, tag, and commit in environment list"
      ## What does this MR do?
      Updates Environments page rows to match the new pipeline updates
      ## Are there points in the code the reviewer needs to double check?
      I removed `private` from `avatars_helper.rb` so I could use `user_avatar`.
      ## What are the relevant issue numbers?
      Closes #20059 
      ## Screenshots (if relevant)
      See merge request !5687
    • Paco Guzman's avatar
      Recover usage of Todos counter cache · f8b53ba2
      Paco Guzman authored
      We’re being kept up to date the counter data but we’re not using it.
      The only thing which is not real if is the number of projects that the 
      user read changes the number of todos can be stale for some time.
      The counters will be sync just after the user receives a new todo or mark any as done
    • Paco Guzman's avatar