GitLab

Fix bug where replies to commit notes displayed in the MR discussion tab wouldn't show up on the commit page

Helping to diagnose #20178

We were seeing a number of error messages when attempting to create a keep-around ref:

1. Failed to create locked file `refs/keep-around/XYZ`: File exists
2. Failed to write reference `refs/keep-around/XYZ`: a reference with that name already exists.

I'm not sure how these happen, but I suspect when multiple workers attempt to write the same
file we may have an issue. The force parameter should help ensure the file gets created,
as well as the rescues to prevent 500 Errors.

Rugged/libgit2 unfortunately do not allow you to delete or re-create a reference that has
been corrupted, even with the force parameter.

Closes #20109

Replace invocation of `find` with Ruby code that matches old cached
files in a better, and safe way to avoid data-integrity issues.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13204564

Signed-off-by: Rémy Coutable <remy@rymai.me>

Currently, even when searching for all authorized issues of *one* project, we run the
`Users#authorized_projects` query (which can be rather slow). This update checks if
we are handling issues of just one project and does the authorization check locally.
It does have the downside of basically repeating the logic of `Users#authorized_projects`
on `Project#authorized_for_user`.

This version of MySQL doesn't yet support 'LIMIT & IN/ALL/ANY/SOME
subquery'

Oh well.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13198105

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13199055

So we no longer join anything, just find the latest pipeline
and load builds from there to avoid mixing builds.

Thanks Kamil for the help and tests.

Signed-off-by: Rémy Coutable <remy@rymai.me>

also added a test for checking this.

Prior, when providing a `min_access_level` parameter to this method, we
called `Gitlab::Access.values` instead of `all_values`, mistakenly
omitting the `OWNER` level.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/19878

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173842

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173871

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13170854

* This method previously iterated over all services in a project.  Now it
will directly query the ExternalWikiService for the project and filter
by active state.
* The presence of an external wiki is also cached
* When an external wiki is added or removed, the cached value is updated

This was extracted from !5142 and implementing part of #4255.
We split it from !5142 because we want to ship it in 8.10
while !5142 was not ready yet.