- 07 Dec, 2017 1 commit
-
-
Douwe Maan authored
-
- 21 Nov, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
After installing a new gem, batch-loader, a construct can be used to queue data to be fetched in bulk. The gem was also introduced in both gitlab-org/gitlab-ce!14680 and gitlab-org/gitlab-ce!14846, but those mrs are not merged yet. For the generation of diffs, both the old blob and the new blob need to be loaded. This for every file in the diff, too. Now we collect all these so we do 1 fetch. Three `.allow_n_plus_1_calls` have been removed, which I expect to be valid, but this needs to be confirmed by a full CI run. Possibly closes: - https://gitlab.com/gitlab-org/gitlab-ce/issues/37445 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37599 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37431
-
- 13 Oct, 2017 1 commit
-
-
Brett Walker authored
-
- 12 Oct, 2017 1 commit
-
-
Brett Walker authored
threshhold, a message is shown indicating we didn't perform the search
-
- 11 Oct, 2017 1 commit
-
-
Brett Walker authored
the long running git query
-
- 19 Sep, 2017 1 commit
-
-
Andrew Newdigate authored
-
- 06 Sep, 2017 1 commit
-
-
micael.bergeron authored
this will remove the need make N queries (per-note) at the cost of having to mark notes with an attribute this opens up the possibility for other special roles for notes
-
- 14 Jul, 2017 1 commit
-
-
Filipa Lacerda authored
-
- 05 Jul, 2017 1 commit
-
-
Douwe Maan authored
-
- 09 May, 2017 1 commit
-
-
Fatih Acet authored
-
- 20 Apr, 2017 1 commit
-
-
Douwe Maan authored
-
- 06 Apr, 2017 1 commit
-
-
Toon Claes authored
Also poll for pipeline changes on: - Pipeline table on commit page - Pipeline table on merge request page - Pipeline table on new merge request page
-
- 05 Apr, 2017 3 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- 03 Mar, 2017 1 commit
-
-
Douwe Maan authored
-
- 23 Feb, 2017 4 commits
-
-
Douwe Maan authored
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9. # Conflicts: # .rubocop.yml # .rubocop_todo.yml # lib/gitlab/ci/config/entry/global.rb # lib/gitlab/ci/config/entry/jobs.rb # spec/lib/gitlab/ci/config/entry/factory_spec.rb # spec/lib/gitlab/ci/config/entry/global_spec.rb # spec/lib/gitlab/ci/config/entry/job_spec.rb # spec/lib/gitlab/ci/status/build/factory_spec.rb # spec/lib/gitlab/incoming_email_spec.rb
-
Douwe Maan authored
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
-
Douwe Maan authored
-
Douwe Maan authored
-
- 07 Feb, 2017 1 commit
-
-
Douwe Maan authored
-
- 06 Feb, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 03 Feb, 2017 1 commit
-
-
Filipa Lacerda authored
Document and remove unused code Declare components in a consistent way; Use " instead of ' to improve consistency; Update documentation; Fix commit author verification to match the use cases; Adds tests for the added components Fix paths in pagination spec Adds tests to pipelines table used in merge requests and commits Use same resource interceptor Fix eslint error
-
- 27 Jan, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 19 Jan, 2017 1 commit
-
-
Takuya Noguchi authored
-
- 05 Jan, 2017 1 commit
-
-
Lin Jen-Shin authored
Removing those weird setup in assign_change_commit_vars fixed all the failures in the tests. I still cannot say why but clearly we need to have better names. It's so confusing right now. We should seriously stop fiddling those instance variables.
-
- 21 Dec, 2016 2 commits
-
-
Filipa Lacerda authored
Fix broken test Remove spinach tests for the builds tab
-
Filipa Lacerda authored
Remove unused file Fix commit link
-
- 09 Dec, 2016 1 commit
-
-
Douwe Maan authored
Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
⚠ - Potentially untested💣 - No test coverage🚥 - Test coverage of some sort exists (a test failed when error raised)🚦 - Test coverage of return value (a test failed when nil used)✅ - Permissions check tested - [x]💣 app/finders/notes_finder.rb:17 - [x]⚠ app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x]💣 app/controllers/concerns/creates_commit.rb:84 - [x]🚥 app/controllers/projects/commits_controller.rb:24 - [x]🚥 app/controllers/projects/compare_controller.rb:56 - [x]🚦 app/controllers/projects/discussions_controller.rb:29 - [x]✅ app/controllers/projects/todos_controller.rb:27 - [x]🚦 app/models/commit.rb:268 - [x]✅ lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033
-
- 27 Sep, 2016 1 commit
-
-
Kamil Trzcinski authored
-
- 13 Aug, 2016 1 commit
-
-
Douwe Maan authored
-
- 11 Aug, 2016 1 commit
-
-
Kamil Trzcinski authored
This change simplifies a Pipeline processing by introducing a special new status: created. This status is used for all builds that are created for a pipeline. We are then processing next stages and queueing some of the builds (created -> pending) or skipping them (created -> skipped). This makes it possible to simplify and solve a few ordering problems with how previously builds were scheduled. This also allows us to visualise a full pipeline (with created builds). This also removes an after_touch used for updating a pipeline state parameters. Right now in various places we explicitly call a reload_status! on pipeline to force it to be updated and saved.
-
- 03 Aug, 2016 3 commits
-
-
Paco Guzman authored
So we have raw_diffs too
-
Paco Guzman authored
Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection
-
Paco Guzman authored
Introducing the concept of SafeDiffs which relates diffs with UI highlighting.
-
- 21 Jul, 2016 1 commit
-
-
Douwe Maan authored
-
- 08 Jul, 2016 2 commits
-
-
Sean McGivern authored
1. Move render method to a concern, not a helper. 2. Let DiffHelper#diff_options automatically add the path option. 3. Move more instance var definitions to before filters.
-
Sean McGivern authored
When rendering a list of diff files, skip those where the diff is over 10 KB and provide an endpoint to render individually instead.
-
- 07 Jul, 2016 1 commit
-
-
Douwe Maan authored
-