1. 10 Aug, 2016 1 commit
  2. 03 Aug, 2016 1 commit
  3. 29 Jul, 2016 3 commits
    • Z.J. van de Weg's avatar
      Add API support for environments · 84cd2120
      Z.J. van de Weg authored
      84cd2120
    • Timothy Andrew's avatar
      Use `Gitlab::Access` to protected branch access levels. · 0a8aeb46
      Timothy Andrew authored
      1. It makes sense to reuse these constants since we had them duplicated
         in the previous enum implementation. This also simplifies our
         `check_access` implementation, because we can use
         `project.team.max_member_access` directly.
      
      2. Use `accepts_nested_attributes_for` to create push/merge access
         levels. This was a bit fiddly to set up, but this simplifies our code
         by quite a large amount. We can even get rid of
         `ProtectedBranches::BaseService`.
      
      3. Move API handling back into the API (previously in
         `ProtectedBranches::BaseService#translate_api_params`.
      
      4. The protected branch services now return a `ProtectedBranch` rather
         than `true/false`.
      
      5. Run `load_protected_branches` on-demand in the `create` action, to
         prevent it being called unneccessarily.
      
      6. "Masters" is pre-selected as the default option for "Allowed to Push"
         and "Allowed to Merge".
      
      7. These changes were based on a review from @rymai in !5081.
      0a8aeb46
    • Timothy Andrew's avatar
      Have the `branches` API work with the new protected branches data model. · 01d190a8
      Timothy Andrew authored
      1. The new data model moves from `developers_can_{push,merge}` to
         `allowed_to_{push,merge}`.
      
      2. The API interface has not been changed. It still accepts
         `developers_can_push` and `developers_can_merge` as options. These
         attributes are inferred from the new data model.
      
      3. Modify the protected branch create/update services to translate from
         the API interface to our current data model.
      01d190a8
  4. 28 Jul, 2016 1 commit
  5. 19 Jul, 2016 5 commits
  6. 12 Jul, 2016 9 commits
  7. 11 Jul, 2016 2 commits
  8. 08 Jul, 2016 4 commits
  9. 07 Jul, 2016 1 commit
  10. 06 Jul, 2016 2 commits
  11. 01 Jul, 2016 5 commits
  12. 30 Jun, 2016 1 commit
  13. 21 Jun, 2016 1 commit
  14. 20 Jun, 2016 1 commit
  15. 17 Jun, 2016 2 commits
  16. 16 Jun, 2016 1 commit