1. 18 May, 2018 2 commits
    • DJ Mountney's avatar
      Use defaults for retry · 1fb431c6
      DJ Mountney authored
      And use a supported syntax for ignoring docs during gem install
      1fb431c6
    • DJ Mountney's avatar
      Build cloud native images on tags · 0bc78d08
      DJ Mountney authored
      When on a tag, trigger a multi-project pipeline in the CNG repostiory.
      
      Opting for a trigger rather than an addition to our release-tools
      project for a few reasons:
      
      - The Dockerfiles in the CNG image repo change infrequently, and as a result
      I don't feel the need/overhead for stable branches in that repo at this time
      - My intent with the CNG repo, is that once stable, the Dockerfiles
      would actualy move to their component projects, to be versioned with the
      code they are building
      - It is likely that we will want to followup with a manually triggered package
      for branches for devs, and possibly review apps, so it made sense to
      build the CNG ci jobs to accept this sort of pipeline.
      0bc78d08
  2. 17 May, 2018 31 commits
    • Annabel Gray's avatar
      Merge branch 'fix/assignee-name-wrap' into 'master' · 09a387b5
      Annabel Gray authored
      fix / assigne username wrapping problem has been fixed
      
      See merge request gitlab-org/gitlab-ce!18986
      09a387b5
    • Murat Dogan's avatar
      3babd1e0
    • Annabel Gray's avatar
      Merge branch '39584-nesting-depth-5-pages-pipelines' into 'master' · f5e0b35d
      Annabel Gray authored
      NestingDepth (level 5) in pages/pipelines.scss
      
      See merge request gitlab-org/gitlab-ce!18830
      f5e0b35d
    • Annabel Gray's avatar
      Merge branch 'dz-fix-list-bottom-margin' into 'master' · 3a402fc7
      Annabel Gray authored
      Fix group lists visual
      
      See merge request gitlab-org/gitlab-ce!19010
      3a402fc7
    • Mayra Cabrera's avatar
      Merge branch 'sh-remove-deprecation-warnings-from-com' into 'master' · 399996ca
      Mayra Cabrera authored
      Conditionally enable deprecation log messages
      
      Closes #46158 and gitlab-com/infrastructure#4228
      
      See merge request gitlab-org/gitlab-ce!18997
      399996ca
    • Stan Hu's avatar
    • Rémy Coutable's avatar
      Merge branch '46193-fix-big-estimate' into 'master' · 4609a126
      Rémy Coutable authored
      Resolve "Estimating a large amount results in a server error 500"
      
      Closes #46193
      
      See merge request gitlab-org/gitlab-ce!18964
      4609a126
    • Annabel Gray's avatar
      Merge branch '46381-dropdown-mr-widget' into 'master' · 7f7f8741
      Annabel Gray authored
      Resolve "Dropdown actions in mini pipeline graph in mr widget don't work"
      
      Closes #46381
      
      See merge request gitlab-org/gitlab-ce!18976
      7f7f8741
    • Jacopo's avatar
      Fixes 500 error on /estimate BIG_VALUE · e4adf015
      Jacopo authored
      e4adf015
    • Rémy Coutable's avatar
      Merge branch 'order_groups' into 'master' · be54edbf
      Rémy Coutable authored
      Fix: Use case in-sensitive ordering by name for groups
      
      See merge request gitlab-org/gitlab-ce!18553
      be54edbf
    • Harish Ved's avatar
      b11c218a
    • Robert Speicher's avatar
      Merge branch '6020-extract-ee-specific-controller-lines' into 'master' · 47555ef8
      Robert Speicher authored
      [CE]  Resolve "Extract EE specific files/lines for some controllers"
      
      See merge request gitlab-org/gitlab-ce!18994
      47555ef8
    • Dmitriy Zaporozhets's avatar
      Fix group lists visual · 88fa0ecd
      Dmitriy Zaporozhets authored
      * Reset p bottom margin for group lists to fix vertical alignment
      * Remove double border for group lists to be consistent with project
      lists
      Signed-off-by: default avatarDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
      88fa0ecd
    • Grzegorz Bizon's avatar
      Merge branch 'pipelines-index-performance' into 'master' · 4583e67c
      Grzegorz Bizon authored
      Improve performance of Projects::PipelinesController#index
      
      See merge request gitlab-org/gitlab-ce!18427
      4583e67c
    • Filipa Lacerda's avatar
      Merge branch 'master' into 46381-dropdown-mr-widget · 49673de3
      Filipa Lacerda authored
      * master: (40 commits)
        Add changelog
        Update quick_start_guide.md
        Resolve "Opening Project with invite but without accepting leads to 404 error page"
        Respect the inheritance chain between Ci::Build and CommitStatus
        Remove unneccessary imports
        fixed copy to cliboard button in embedded snippets
        Fix Error 500 viewing admin page due to statement timeouts
        Grant privileges after database is created
        Only setup db in the first checkout!
        Project Sidebar: Split CI/CD into CI/CD and Operations
        Fix GPM content types for Doorkeeper
        Workhorse to send raw diff and patch for commits
        Refactor out duplication in runner_policy.rb
        Remove unnecessary runner.is_shared? checks in api because they are handled by policy
        Allow admin to assign shared runner to project through API
        Change policy list_runner_jobs -> read_runner
        Rename User#ci_authorized_runners -> ci_owned_runners
        Improve efficiency of authorized_runner policy query
        Use can? policies for lib/api/runners.rb
        Allow group runners to be viewed/edited in API
        ...
      49673de3
    • Grzegorz Bizon's avatar
      Merge branch '46177-fix-present-on-generic-commit-status' into 'master' · d9b78477
      Grzegorz Bizon authored
      Resolve "NoMethodError: undefined method `present' for #<GenericCommitStatus:0x00007f6eacf34a40>"
      
      Closes #46177
      
      See merge request gitlab-org/gitlab-ce!18979
      d9b78477
    • Achilleas Pipinellis's avatar
      Merge branch... · 2eb8099f
      Achilleas Pipinellis authored
      Merge branch 'docs/46042-document-that-project-templates-can-be-used-with-auto-devops' into 'master'
      
      Resolve "Document that Project Templates can be used with Auto DevOps"
      
      Closes #46042
      
      See merge request gitlab-org/gitlab-ce!19009
      2eb8099f
    • Mayra Cabrera's avatar
      Add changelog · 22d3e90c
      Mayra Cabrera authored
      22d3e90c
    • Fabio Busatto's avatar
      Update quick_start_guide.md · 143a98a3
      Fabio Busatto authored
      143a98a3
    • Yorick Peterse's avatar
      da7bbef8
    • Yorick Peterse's avatar
      Exclude coverage data from the pipelines page · 878ca2e6
      Yorick Peterse authored
      When displaying a project's pipelines
      (Projects::PipelinesController#index) we now exclude the coverage data.
      This data was not used by the frontend, yet getting it would require one
      SQL query per pipeline. These queries in turn could be quite expensive
      on GitLab.com.
      878ca2e6
    • Yorick Peterse's avatar
      Preload pipeline data for project pipelines · 19428e80
      Yorick Peterse authored
      When displaying the pipelines of a project we now preload the following
      data:
      
      1. Authors of the commits that belong to these pipelines
      2. The number of warnings per pipeline, which is used by
         Ci::Pipeline#has_warnings?
      
      == Commit Authors
      
      Previously this data was queried for every Commit separately, leading to
      20 SQL queries being executed in the worst case. With an average of 3 to
      5 milliseconds per SQL query this could result in 100 milliseconds being
      spent in _just_ getting Commit authors.
      
      To preload this data Commit#author now uses BatchLoader (through
      Commit#lazy_author), and a separate module
      Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded
      before they are used.
      
      == Number of warnings
      
      This changes Ci::Pipeline#has_warnings? so it supports preloading of the
      number of warnings per pipeline. This removes the need for executing a
      COUNT(*) query for every pipeline just to see if it has any warnings or
      not.
      19428e80
    • Yorick Peterse's avatar
      Limit the number of pipelines to count · 70985aa1
      Yorick Peterse authored
      When displaying the project pipelines dashboard we display a few tabs
      for different pipeline states. For every such tab we count the number of
      pipelines that belong to it. For large projects such as GitLab CE this
      means having to count over 80 000 rows, which can easily take between 70
      and 100 milliseconds per query.
      
      To improve this we apply a technique we already use for search results:
      we limit the number of rows to count. The current limit is 1000, which
      means that if more than 1000 rows are present for a state we will show
      "1000+" instead of the exact number. The SQL queries used for this
      perform much better than a regular COUNT, even when a project has a lot
      of pipelines.
      
      Prior to these changes we would end up running a query like this:
      
          SELECT COUNT(*)
          FROM ci_pipelines
          WHERE project_id = 13083
          AND status IN ('success', 'failed', 'canceled')
      
      This would produce a plan along the lines of the following:
      
          Aggregate  (cost=3147.55..3147.56 rows=1 width=8) (actual time=501.413..501.413 rows=1 loops=1)
            Buffers: shared hit=17116 read=861 dirtied=2
            ->  Index Only Scan using index_ci_pipelines_on_project_id_and_ref_and_status_and_id on ci_pipelines  (cost=0.56..2984.14 rows=65364 width=0) (actual time=0.095..490.263 rows=80388 loops=1)
                  Index Cond: (project_id = 13083)
                  Filter: ((status)::text = ANY ('{success,failed,canceled}'::text[]))
                  Rows Removed by Filter: 2894
                  Heap Fetches: 353
                  Buffers: shared hit=17116 read=861 dirtied=2
          Planning time: 1.409 ms
          Execution time: 501.519 ms
      
      Using the LIMIT count technique we instead run the following query:
      
          SELECT COUNT(*)
          FROM (
              SELECT 1
              FROM ci_pipelines
              WHERE project_id = 13083
              AND status IN ('success', 'failed', 'canceled')
              LIMIT 1001
          ) for_count
      
      This query produces the following plan:
      
          Aggregate  (cost=58.77..58.78 rows=1 width=8) (actual time=1.726..1.727 rows=1 loops=1)
            Buffers: shared hit=169 read=15
            ->  Limit  (cost=0.56..46.25 rows=1001 width=4) (actual time=0.164..1.570 rows=1001 loops=1)
                  Buffers: shared hit=169 read=15
                  ->  Index Only Scan using index_ci_pipelines_on_project_id_and_ref_and_status_and_id on ci_pipelines  (cost=0.56..2984.14 rows=65364 width=4) (actual time=0.162..1.426 rows=1001 loops=1)
                        Index Cond: (project_id = 13083)
                        Filter: ((status)::text = ANY ('{success,failed,canceled}'::text[]))
                        Rows Removed by Filter: 9
                        Heap Fetches: 10
                        Buffers: shared hit=169 read=15
          Planning time: 1.832 ms
          Execution time: 1.821 ms
      
      While this query still uses a Filter for the "status" field the number
      of rows that it may end up filtering (at most 1001) is small enough that
      an additional index does not appear to be necessary at this time.
      
      See https://gitlab.com/gitlab-org/gitlab-ce/issues/43132#note_68659234
      for more information.
      70985aa1
    • Filipa Lacerda's avatar
      Fix eslint · 9e61d26c
      Filipa Lacerda authored
      9e61d26c
    • Filipa Lacerda's avatar
      Moves string to a constant · 1bf74bfd
      Filipa Lacerda authored
      1bf74bfd
    • Douwe Maan's avatar
      Merge branch '42531-open-invite-404' into 'master' · ec7163ae
      Douwe Maan authored
      Resolve "Opening Project with invite but without accepting leads to 404 error page"
      
      Closes #42531
      
      See merge request gitlab-org/gitlab-ce!17634
      ec7163ae
    • 🙈  jacopo beschi 🙉's avatar
    • Douwe Maan's avatar
      Merge branch 'ce-5980-add-ce-upgrade-ee-test' into 'master' · bbd8d5b2
      Douwe Maan authored
      CE: Add jobs to verify that migrating from CE to EE works
      
      See merge request gitlab-org/gitlab-ce!18909
      bbd8d5b2
    • Grzegorz Bizon's avatar
      Merge branch 'zj-workhorse-commit-patch-diff' into 'master' · 48877dfc
      Grzegorz Bizon authored
      Workhorse to send raw diff and patch for commits
      
      Closes gitaly#1196
      
      See merge request gitlab-org/gitlab-ce!18974
      48877dfc
    • Phil Hughes's avatar
      Merge branch 'remove-css-imports' into 'master' · 2f7e0aba
      Phil Hughes authored
      Remove unneccessary imports
      
      See merge request gitlab-org/gitlab-ce!18993
      2f7e0aba
    • Phil Hughes's avatar
      Merge branch 'jivl-add-dot-system-notes' into 'master' · e5289643
      Phil Hughes authored
      Add dot to separate system notes content
      
      Closes #45676
      
      See merge request gitlab-org/gitlab-ce!18864
      e5289643
  3. 16 May, 2018 7 commits