GitLab steht wegen Wartungsarbeiten am Montag, den 10. Mai, zwischen 17:00 und 19:00 Uhr nicht zur Verfügung.

  1. 10 Jun, 2016 23 commits
    • Paco Guzman's avatar
      Cache the presence of an issue_tracker at project level · 136a4ea3
      Paco Guzman authored
      Using update_column to store the boolean flag to avoid
      any side effects with the current state of the project
      instance
      136a4ea3
    • Rémy Coutable's avatar
      Merge branch 'fix/incremental-trace-update-api' into 'master' · f29fd65c
      Rémy Coutable authored
      Fix UTF-8 handling in incremental trace update API
      
      ## What does this MR do?
      
      This MR fixes invalid UTF-8 handling in incremental trace update API (used by GitLab Runner).
      
      ## Why was this MR needed?
      
      Current version is using `.length` method to determine current trace size where Runner is using the trace size in bytes. Also this byte size is used in headers and file operations to agree the trace part to send. This is a problem when build trace contains any multi-byte UTF-8 characters. This MR is fixing this situation so all parts are using the same size in bytes.
      
      ### Runner -> API communication before fix:
      ```
      Checking for builds... received                     runner=_token_
      gitlab-ci-multi-runner 1.3.0~beta.26.gcfd63b9 (cfd63b9)  build=25 runner=_token_
      Using Docker executor with image debian:jessie ...  build=25 runner=_token_
      Pulling docker image debian:jessie ...              build=25 runner=_token_
      25 Submitting build to coordinator... ok            runner=_token_
      25 Appending trace to coordinator... ok             RemoteRange=0-158 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=0-158 runner=_token_
      25 Appending trace to coordinator... ok             RemoteRange=0-491 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=158-505 runner=_token_
      WARNING: 25 Appending trace to coordinator... range missmatch  RemoteRange=0-491 RemoteState= ResponseMessage=416 Requested Range Not Satisfiable ResponseStatusCode=416 SentRange=505-584 runner=_token_
      WARNING: 25 Resending trace patch due to range missmatch  runner=_token_
      25 Appending trace to coordinator... ok             RemoteRange=0-556 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=491-584 runner=_token_
      WARNING: 25 Appending trace to coordinator... range missmatch  RemoteRange=0-556 RemoteState= ResponseMessage=416 Requested Range Not Satisfiable ResponseStatusCode=416 SentRange=584-663 runner=_token_
      WARNING: 25 Resending trace patch due to range missmatch  runner=_token_
      25 Appending trace to coordinator... ok             RemoteRange=0-621 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=556-663 runner=_token_
      Build succeeded                                     build=25 runner=_token_
      WARNING: 25 Appending trace to coordinator... range missmatch  RemoteRange=0-621 RemoteState= ResponseMessage=416 Requested Range Not Satisfiable ResponseStatusCode=416 SentRange=663-797 runner=_token_
      WARNING: 25 Resending trace patch due to range missmatch  runner=_token_
      25 Appending trace to coordinator... ok             RemoteRange=0-741 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=621-797 runner=_token_
      25 Submitting build to coordinator... ok            runner=_token_
      ```
      
      ### Runner -> API communication after fix:
      ```
      Checking for builds... received                     runner=_token_
      gitlab-ci-multi-runner 1.3.0~beta.26.gcfd63b9 (cfd63b9)  build=26 runner=_token_
      Using Docker executor with image debian:jessie ...  build=26 runner=_token_
      Pulling docker image debian:jessie ...              build=26 runner=_token_
      26 Submitting build to coordinator... ok            runner=_token_
      26 Appending trace to coordinator... ok             RemoteRange=0-158 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=0-158 runner=_token_
      26 Appending trace to coordinator... ok             RemoteRange=0-505 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=158-505 runner=_token_
      26 Appending trace to coordinator... ok             RemoteRange=0-584 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=505-584 runner=_token_
      26 Appending trace to coordinator... ok             RemoteRange=0-663 RemoteState=running ResponseMessage=202 Accepted ResponseStatusCode=202 SentRange=584-663 runner=_token_
      Build succeeded                                     build=26 runner=_token_
      26 Submitting build to coordinator... ok            runner=_token_
      ```
      
      See merge request !4541
      f29fd65c
    • Rémy Coutable's avatar
      Merge branch 'ruianderson/gitlab-ce-option-to-allow-or-not-merge-failed-builds' into 'master' · 43f2d8ad
      Rémy Coutable authored
      Add option to restrict merge MR with failed build
      
      _Originally opened at !3828 by @ruianderson._
      
      -----
      
      ## What does this MR do?
      
      This MR adds an option to prevent MR from being merged if their build status is not a success. Please note that if the MR has no `ci_commit`, the MR can be merged (i.e. we don't enforce builds to be configured).
      
      ## Are there points in the code the reviewer needs to double check?
      
      Probably the copy in the edit project's page and in the documentation.
      
      ## What are the relevant issue numbers?
      
      Closes #5940.
      
      ## Screenshots
      
      ![only_allow_merge_if_build_succeeds](/uploads/bb43cf131f680c9af0eb2ea5155189e0/only_allow_merge_if_build_succeeds.png)
      
      See merge request !4503
      43f2d8ad
    • Rémy Coutable's avatar
      Rename ci_commit -> pipeline · 3579edba
      Rémy Coutable authored
      Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
      3579edba
    • Tomasz Maczukin's avatar
      Update CHANGELOG · 34bef254
      Tomasz Maczukin authored
      34bef254
    • Rémy Coutable's avatar
      Rename MergeRequest#cannot_be_merged_because_build_is_not_success? to #mergeable_ci_state? · 5324c936
      Rémy Coutable authored
      The logic of the method was obviously inverted.
      Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
      5324c936
    • Rémy Coutable's avatar
    • Rémy Coutable's avatar
      Improve initial implementation of the 'only_allow_merge_if_build_succeeds.rb' feature · 6dff7c17
      Rémy Coutable authored
      Based on the feedback from reviewers.
      Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
      6dff7c17
    • Rui Anderson's avatar
      Allow or not merge MR with failed build · 07dbd6b3
      Rui Anderson authored
      Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
      07dbd6b3
    • Stan Hu's avatar
      Merge branch 'fix-already-initialized-constant' into 'master' · 9734b8bb
      Stan Hu authored
      Don't require Gitlab::Redis in mail_room.yml if it's already defined
      
      ## What does this MR do?
      
      Avoid requiring `lib/gitlab/redis.rb` if `Gitlab::Redis` is already defined.
      
      ## Are there points in the code the reviewer needs to double check?
      
      No.
      
      ## Why was this MR needed?
      
      Because otherwise you get `already initialized constant Gitlab::Redis::XXX`, e.g.:
      
      ```
      › bin/rspec spec/config/mail_room_spec.rb
      Running via Spring preloader in process 24658
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:3: warning: already initialized constant Gitlab::Redis::CACHE_NAMESPACE 
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:3: warning: previous definition of CACHE_NAMESPACE was here
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:4: warning: already initialized constant Gitlab::Redis::SESSION_NAMESPACE
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:4: warning: previous definition of SESSION_NAMESPACE was here
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:5: warning: already initialized constant Gitlab::Redis::SIDEKIQ_NAMESPACE
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:5: warning: previous definition of SIDEKIQ_NAMESPACE was here
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:12: warning: already initialized constant Gitlab::Redis::URL_MUTEX
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:12: warning: previous definition of URL_MUTEX was here
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:13: warning: already initialized constant Gitlab::Redis::POOL_MUTEX
      /Users/remy/Code/GitLab/gdk/gitlab/lib/gitlab/redis.rb:13: warning: previous definition of POOL_MUTEX was here
       2/2 |================================================= 100 =================================================>| Time: 00:00:00 
      
      Finished in 0.38505 seconds (files took 0.48292 seconds to load)
      2 examples, 0 failures
      ```
      
      ## What are the relevant issue numbers?
      
      None!
      
      ## Does this MR meet the acceptance criteria?
      
      - [x] ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~ Not needed.
      - [x] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ Not needed.
      - [x] ~~API support added.~~ Not needed.
      - [x] ~~Tests.~~ Not needed.
      - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
      - [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
      - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
      
      See merge request !4586
      9734b8bb
    • Rémy Coutable's avatar
    • Tomasz Maczukin's avatar
      9dfb809c
    • Rémy Coutable's avatar
      Merge branch 'cs-issue-pr-templates' into 'master' · cfc99bbd
      Rémy Coutable authored
      Add Issue/PR Templates to deter issues/contributions on the GitHub mirror of the project
      
      ## What does this MR do?
      Adds GitHub-specific `ISSUE_TEMPLATE.md` and `PULL_REQUEST_TEMPLATE.md` files in a `.github` directory. To prevent new issues/PRs, I figured it'd be good to direct users/contributors to open issues/contribute code in the "correct" project.
      
      ## Are there points in the code the reviewer needs to double check?
      Wording/phrasing, mostly.
      
      ## Why was this MR needed?
      The GitHub issue tracker is being closed, and PRs on GitHub haven't been accepted for a while now. This was discussed briefly during the GitLab Strategy Session at the Austin Summit.
      
      cc: @dzaporozhets @rymai  @MrChrisW @dblessing @virtuacreative @amara  
      
      See merge request !4324
      cfc99bbd
    • Douwe Maan's avatar
      Merge branch 'enable-rubocop-for-migrations' into 'master' · 0dcd050b
      Douwe Maan authored
      Enable RuboCop for migrations
      
      ## What does this MR do?
      
      Enable RuboCop for all files inside `db/migrate`, then add magic comments to all existing files, so that this only affects new migrations.
      
      ## Are there points in the code the reviewer needs to double check?
      
      This entire change is a config change and a bunch of comments.
      
      ## Why was this MR needed?
      
      ```
      Yorick Peterse [11:55 AM]  
      I don't think we have any use case for nested def, might as well blacklist it
      
      Sean McGivern [11:57 AM]  
      http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/NestedMethodDefinition
      
      Sean McGivern [11:57 AM]  
      hmm, it's already enabled
      
      Sean McGivern [11:57 AM]  
      ... because we exclude `db/` from rubocop 🙂
      
      Douwe Maan [11:57 AM]  
      @smcgivern: heh
      
      Sean McGivern [11:59 AM]  
      I guess that's because we don't want to change the old migrations? I wonder if it's worth enabling it and adding magic comments to all the previous ones to ignore rubocop
      
      Douwe Maan [11:59 AM]  
      @smcgivern: agreed
      ```
      
      ## What are the relevant issue numbers?
      
      None.
      
      ## Screenshots (if relevant)
      
      None, but if I remove the magic comment from the migration `20160416182152_convert_award_note_to_emoji_award.rb` I get:
      ```
      $ be rubocop
      Inspecting 1959 files
      ..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
      
      Offenses:
      
      db/migrate/20160416182152_convert_award_note_to_emoji_award.rb:3:5: W: Lint/NestedMethodDefinition: Method definitions must not be nested. Use lambda instead.
          def up ...
          ^^^^^^
      
      1959 files inspected, 1 offense detected
      ```
      
      ## Does this MR meet the acceptance criteria?
      
      - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
      - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
      - [ ] API support added
      - [ ] Tests
        - [ ] Added for this feature/bug
        - [ ] All builds are passing
      - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
      - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
      - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
      
      See merge request !4559
      0dcd050b
    • Douwe Maan's avatar
      Merge branch 'gh-rate-limit' into 'master' · a9a9f19b
      Douwe Maan authored
      Wrap all rate limiting logic inside GitHub API client
      
      ## What does this MR do?
      
      Move the actual rate limiting logic to GitHub API to clean the code inside the GitHub importer, and avoid code duplication.
      
      ## Are there points in the code the reviewer needs to double check?
      
      No there aren't.
      
      ## Why was this MR needed?
      
      Avoid code duplication to handle API rate limit in every call to the GitHub API.
      
      ## What are the relevant issue numbers?
      
      There are none.
      
      ## Screenshots (if relevant)
      
      Not relevant.
      
      See merge request !4552
      a9a9f19b
    • Douwe Maan's avatar
      Merge branch '18447-investigate-smtp-error' into 'master' · e0f3e44b
      Douwe Maan authored
      Fix failing `EmailOnPush` spec.
      
      Closes #18447 
      
      - This should fix CI on master
      
      /cc @smcgivern @ayufan @stanhu @pacoguzman 
      
      See merge request !4582
      e0f3e44b
    • Timothy Andrew's avatar
      Fix failing `EmailOnPush` spec. · 99d5a91d
      Timothy Andrew authored
      99d5a91d
    • Jacob Schatz's avatar
      Merge branch 'award-emoji-fixes' into 'master' · cea3cf17
      Jacob Schatz authored
      Award emoji fixes
      
      Fixes #18357 #18325 and #18424
      
      See merge request !4550
      cea3cf17
    • Fatih Acet's avatar
      Minor MR comment fixes. · 94826d9a
      Fatih Acet authored
      yes -> true
      no -> false
      . frequent -> .frequent-emojis
      94826d9a
    • Robert Speicher's avatar
      Update CHANGELOG for 8.8.4 and 8.8.5 · e328eab0
      Robert Speicher authored
      [ci skip]
      e328eab0
    • Robert Speicher's avatar
      Merge branch 'fix-issue-15259-postgresql' into 'master' · b51a36cb
      Robert Speicher authored
      Properly quote table name in Rake task for MySQL and PostgreSQL compatibility
      
      !4318 broke the gitlab:db:drop_tables functionality for PostgreSQL.
          
      Closes #15259
      
      See merge request !4577
      b51a36cb
    • Jacob Schatz's avatar
      Merge branch 'milestone-tooltip' into 'master' · dbc4f718
      Jacob Schatz authored
      Add milestone expire date to the right sidebar
      
      ## What does this MR do?
      Shows milestone expire date tooltip in the sidebar. It also shows the tooltip when sidebar is collapsed.
      
      ## Are there points in the code the reviewer needs to double check?
      `common_utils.js.coffee` and `milestones_helper.rb` should be reviewed deeply.
      
      ## What are the relevant issue numbers?
      https://gitlab.com/gitlab-org/gitlab-ce/issues/17355
      
      ## Screencast
      ![zngAcytBWq](/uploads/bd8514506aa5010aef9b081455ee90af/zngAcytBWq.gif)
      
      See merge request !4448
      dbc4f718
    • Stan Hu's avatar
      Properly quote table name in Rake task for MySQL and PostgreSQL compatibility · bf92ea68
      Stan Hu authored
      !4318 broke the gitlab:db:drop_tables functionality for PostgreSQL.
      
      Closes #15259
      bf92ea68
  2. 09 Jun, 2016 17 commits
    • Jacob Schatz's avatar
      Merge branch 'autocomplete-comment-fix' into 'master' · 5f803f0f
      Jacob Schatz authored
      Checks for undefined when inserting autocomplete into textarea
      
      ## What does this MR do?
      
      Correctly checks for undefined before inserting anything into the textarea when using autocomplete. This happens because the loading indicator tries to insert `@undefined` which we dont want to insert.
      
      See merge request !4561
      5f803f0f
    • Stan Hu's avatar
      Merge branch 'fix_issue_15259' into 'master' · 4fbb284c
      Stan Hu authored
      Fix bug with SQL syntax error during backup restoration
      
      ## What does this MR do?
      It properly escapes the table name in the `DROP TABLE IF EXISTS ...` statement used during restore of a backup.
      
      ## Are there points in the code the reviewer needs to double check?
      Please check compatibility with PostgreSQL
      
      ## Why was this MR needed?
      Fix an issue with backups can not be restored if MySQL is used as database for GitLab.
      
      ## What are the relevant issue numbers?
      #15259 
      
      ## Screenshots (if relevant)
      -
      
      See merge request !4318
      4fbb284c
    • Phil Hughes's avatar
      ef48dd01
    • Phil Hughes's avatar
    • Jacob Schatz's avatar
      Merge branch 'fix-empty-user-projects-snippets-list' into 'master' · 69e72774
      Jacob Schatz authored
      Fix empty user projects snippets list
      
      ## What are the relevant issue numbers?
      Closes #17952 #17816 and  #17737 
      
      cc: @lbennett  @jschatz1 
      
      See merge request !4532
      69e72774
    • Jacob Schatz's avatar
      Merge branch 'dz-improve-ui-consistency-2' into 'master' · 5fcb0919
      Jacob Schatz authored
      Improve ui consistency. Part 2
      
      * Use responsive top-area on project branches and tags pages
      * Use default button size in the content list controls
      * Improve button margin for btn-grouped css class
      
      For https://gitlab.com/gitlab-org/gitlab-ce/issues/18324
      
      See merge request !4536
      5fcb0919
    • Jacob Schatz's avatar
      Merge branch 'due-date-field-ux-improv' into 'master' · 600078cc
      Jacob Schatz authored
      Improved the UX of issue & milestone date picker
      
      ## What does this MR do?
      
      Improves the UX of the date picker on issue form & milestone form.
      
      ## What are the relevant issue numbers?
      
      Closes #18198 
      
      ## Screenshots (if relevant)
      
      ### Issues
      
      ![Screen_Shot_2016-06-06_at_09.28.29](/uploads/d9c192dff0d8076adc3ed6f005ea3790/Screen_Shot_2016-06-06_at_09.28.29.png)
      
      ### Project milestones
      
      ![Screen_Shot_2016-06-06_at_09.28.18](/uploads/2d03d72791c5fc6badfadb975a85af2b/Screen_Shot_2016-06-06_at_09.28.18.png)
      
      ### Group milestones
      
      ![Screen_Shot_2016-06-06_at_09.28.05](/uploads/0f28532396a16e6fd48ddea784ca28e3/Screen_Shot_2016-06-06_at_09.28.05.png)
      
      See merge request !4485
      600078cc
    • Jacob Schatz's avatar
      Merge branch 'remove-chart' into 'master' · 87c77718
      Jacob Schatz authored
      Only load Chart.js when necessary.
      
      Only load Chart.js where it's used, namely the Graphs section. Follow up on !4394.
      
      cc: @jschatz1 
      
      See merge request !4516
      87c77718
    • Fatih Acet's avatar
      Ignore frequent emojis in search. · e885c2fd
      Fatih Acet authored
      e885c2fd
    • Jacob Schatz's avatar
      Merge branch 'issue_17607' into 'master' · 2cb4cb2e
      Jacob Schatz authored
      Fix local timeago on user dashboard
      
      ## What does this MR do?
      Fixes incorrect date times on tooltips on the dashboard page
      
      ## Are there points in the code the reviewer needs to double check?
      Yes,  The tooltip has to be recreated again because we needed a custom CSS classname in order to fix the date being splitted into two lines.
      
      ## Why was this MR needed?
      Because the datetimes were incorrect we have to have the same format for .timeago() instances.
      
      ## What are the relevant issue numbers?
      #17607
      
      ## Screenshots (if relevant)
      
      **Before**
      
      <img src="/uploads/f40cd58e8086d9675262e98a1fe57885/Screen_Shot_2016-05-24_at_7.23.25_PM.png" width="705">
      
      **After**
      
      <img src="/uploads/bd48046ef11659cc742f827b3404fbcd/Screen_Shot_2016-05-24_at_7.22.29_PM.png" width="704">
      
      
      See merge request !4285
      2cb4cb2e
    • Jacob Schatz's avatar
      Merge branch 'input-padding' into 'master' · c05604a6
      Jacob Schatz authored
      Improve input padding, fix #18237.
      
      ## What does this MR do?
      Improves horizontal padding for input fields.
      
      ## What are the relevant issue numbers?
      #18237
      
      ## Screenshots (if relevant)
      
      Before:
      
      ![Screen_Shot_2016-06-06_at_12.11.07_PM](/uploads/11d24c84e1ca8d268a5acc2b4e10bb77/Screen_Shot_2016-06-06_at_12.11.07_PM.png)
      
      After:
      
      ![Screen_Shot_2016-06-06_at_12.10.38_PM](/uploads/cbb407d8fca1e8dc1ace2af6c0774181/Screen_Shot_2016-06-06_at_12.10.38_PM.png)
      
      cc: @jschatz1 
      
      See merge request !4489
      c05604a6
    • Jacob Schatz's avatar
      Merge branch 'merge-conflicts-icon-color' into 'master' · edba48c6
      Jacob Schatz authored
      Use warning color merge conflicts icon in MR status widget.
      
      Fixes #18174 
      
      ### Before
      ![Screen_Shot_2016-06-06_at_18.00.56](/uploads/4a74b1710478daee5ee95b7c6b6a835f/Screen_Shot_2016-06-06_at_18.00.56.png)
      
      ### After
      ![Screen_Shot_2016-06-06_at_17.58.04](/uploads/28faefaebef30e4256390029c87b28bb/Screen_Shot_2016-06-06_at_17.58.04.png)
      
      See merge request !4487
      edba48c6
    • Phil Hughes's avatar
      Fixed tests · 7c88141b
      Phil Hughes authored
      7c88141b
    • Phil Hughes's avatar
      CHANGELOG · be7b67d2
      Phil Hughes authored
      be7b67d2
    • Phil Hughes's avatar
      Improved the UX of issue & milestone date picker · cc971f03
      Phil Hughes authored
      Closes #18198
      cc971f03
    • Jacob Schatz's avatar
      Merge branch 'note-edit-background-color' into 'master' · 787b73f5
      Jacob Schatz authored
      Edit form background color on highlighted note
      
      ## What does this MR do?
      
      Added white background to edit form when in a highlighted note
      
      ## What are the relevant issue numbers?
      
      Closes #18101 
      
      ## Screenshots (if relevant)
      
      ![Screen_Shot_2016-06-02_at_11.24.20](/uploads/c7c7fe710aa74d86152a109560fd0ebe/Screen_Shot_2016-06-02_at_11.24.20.png)
      
      See merge request !4435
      787b73f5
    • Fatih Acet's avatar