1. 27 Feb, 2019 1 commit
  2. 22 Feb, 2019 1 commit
    • Zeger-Jan van de Weg's avatar
      Only allow 30 RPCs per test case to Gitaly · c00a1ec0
      Zeger-Jan van de Weg authored
      Prior to this change, 35 Gitaly RPCs were allowed. But recently there's
      been a renewed interest in performance. By lowering the number of
      calls new N + 1's will pop up.
      Later commits will add blocks to ignore the raised errors, followed by
      an issue for each to be fixed.
  3. 06 Feb, 2019 8 commits
  4. 04 Jan, 2019 1 commit
  5. 06 Nov, 2018 1 commit
  6. 22 Oct, 2018 1 commit
  7. 12 Sep, 2018 1 commit
  8. 11 Sep, 2018 1 commit
  9. 09 Jul, 2018 1 commit
  10. 06 Jul, 2018 1 commit
  11. 19 Jun, 2018 1 commit
  12. 12 Jun, 2018 1 commit
  13. 02 May, 2018 1 commit
  14. 25 Apr, 2018 1 commit
  15. 18 Apr, 2018 1 commit
  16. 03 Apr, 2018 1 commit
  17. 21 Mar, 2018 1 commit
  18. 14 Mar, 2018 2 commits
    • Zeger-Jan van de Weg's avatar
      Set Gitlab::Shell#create_repository as OPT_OUT · 7d02292a
      Zeger-Jan van de Weg authored
      On .com repositories are created through Gitaly for a while now. For
      customers this is not the case unless these have chosen to do so through
      feature flags. By moving this to opt out, everyone will be using this.
      This move is part of the migration issue
      The bigger impact this commit will have is that tests that use a
      repository through `FactoryBot.create(:project, :repository)` will now
      use Gitaly to do so. As tests run on the same disk, or at least machine,
      this will most probably slow them down.
    • Zeger-Jan van de Weg's avatar
      Change Gitlab::Shell#add_namespace to #create_namespace · 77f0906e
      Zeger-Jan van de Weg authored
      Prior to this change, this method was called add_namespace, which broke
      the CRUD convention and made it harder to grep for what I was looking
      for. Given the change was a find and replace kind of fix, this was
      changed without opening an issue and on another feature branch.
      If more dynamic calls are made to add_namespace, these could've been
      missed which might lead to incorrect bahaviour. However, going through
      the commit log it seems thats not the case.
  19. 06 Mar, 2018 1 commit
  20. 09 Jan, 2018 1 commit
    • Zeger-Jan van de Weg's avatar
      Migrate GitlabProject (re)move project endpoints · 58e17bf3
      Zeger-Jan van de Weg authored
      Migration is done through a small refactoring, which makes us call
      endpoins which are performing the same actions for namespaces.
      Tests are added to ensure only the project is removed that should be
      Closes gitlab-org/gitaly#873
  21. 08 Jan, 2018 3 commits
    • Sean McGivern's avatar
    • Michael Kozono's avatar
      Backport authorized_keys_enabled defaults to true' · 797fe0a6
      Michael Kozono authored
      Originally from branch 'fix-authorized-keys-enabled-default-2738' via merge request https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2240
      Removed background migrations which were intended to fix state after using Gitlab
      without a default having been set
      Squashed commits:
      Locally, if Spring was not restarted, `current_application_settings` was still cached, which prevented the migration from editing the file. This will also ensure that any app server somehow hitting old cache data will properly default this setting regardless.
      Retroactively fix migration
        This allows us to identify customers who ran the broken migration. Their `authorized_keys_enabled` column does not have a default at this point.
        We will fix the column after we fix the `authorized_keys` file.
      Fix authorized_keys file if needed
      Add default to authorized_keys_enabled setting
        Reminder: The original migration was fixed retroactively a few commits ago, so people who did not ever run GitLab 9.3.0 already have a column that defaults to true and disallows nulls. I have tested on PostgreSQL and MySQL that it is safe to run this migration regardless.
        Affected customers who did run 9.3.0 are the ones who need this migration to fix the authorized_keys_enabled column.
        The reason for the retroactive fix plus this migration is that it allows us to run a migration in between to fix the authorized_keys file only for those who ran 9.3.0.
      Tweaks to address feedback
      Extract work into background migration
      Move batch-add-logic to background migration
        Do the work synchronously to avoid multiple workers attempting to add batches of keys at the same time.
        Also, make the delete portion wait until after adding is done.
      Do read and delete work in background migration
      Fix Rubocop offenses
      Add changelog entry
      Inform the user of actions taken or not taken
      Prevent unnecessary `select`s and `remove_key`s
      Add logs for action taken
      Fix optimization
      Reuse `Gitlab::ShellAdapter`
      Guarantee the earliest key
      Fix migration spec for MySQL
    • Michael Kozono's avatar
      Backport option to disable writing to `authorized_keys` file · 255a0f85
      Michael Kozono authored
      Originally branch 'mk-toggle-writing-to-auth-keys-1631'
      See merge request !2004
      Squashed commits:
      Add authorized_keys_enabled to Application Settings
      Ensure default settings are exposed in UI
      Without this change, `authorized_keys_enabled` is unchecked when it is nil, even if it should be checked by default.
      Add “Speed up SSH operations” documentation
      Clarify the reasons for disabling writes
      Add "How to go back" section
      Tweak copy
      Update Application Setting screenshot
  22. 05 Jan, 2018 1 commit
  23. 04 Jan, 2018 5 commits
  24. 14 Dec, 2017 1 commit
    • Nick Thomas's avatar
      Import gitlab_projects.rb from gitlab-shell · 4b785df2
      Nick Thomas authored
      By importing this Ruby code into gitlab-rails (and gitaly-ruby), we avoid
      200ms of startup time for each gitlab_projects subprocess we are eliminating.
      By not having a gitlab_projects subprocess between gitlab-rails / sidekiq and
      any git subprocesses (e.g. for fork_project, fetch_remote, etc, calls), we can
      also manage these git processes more cleanly, and avoid sending SIGKILL to them
  25. 13 Dec, 2017 1 commit
  26. 04 Dec, 2017 1 commit