Merge branch 'security-tags-oracle-11-8' into '11-8-stable'

Prevent Releases links API to leak tag existence

See merge request gitlab/gitlabhq!2908

changelogs/unreleased/security-tags-oracle.yml

+---
+title: Prevent releases links API to leak tag existance
+merge_request:
+author:
+type: security

lib/api/release/links.rb

@@ -8,6 +8,8 @@ class Links < Grape::API
       RELEASE_ENDPOINT_REQUIREMETS = API::NAMESPACE_OR_PROJECT_REQUIREMENTS
         .merge(tag_name: API::NO_SLASH_URL_PART_REGEX)
 
+      before { authorize! :read_release, user_project }
+
       params do
         requires :id, type: String, desc: 'The ID of a project'
       end

spec/requests/api/release/links_spec.rb

@@ -73,6 +73,22 @@
           expect(response).to have_gitlab_http_status(:ok)
         end
       end
+
+      context 'when project is public and the repository is private' do
+        let(:project) { create(:project, :repository, :public, :repository_private) }
+
+        it_behaves_like '403 response' do
+          let(:request) { get api("/projects/#{project.id}/releases/v0.1/assets/links", non_project_member) }
+        end
+
+        context 'when the release does not exists' do
+          let!(:release) { }
+
+          it_behaves_like '403 response' do
+            let(:request) { get api("/projects/#{project.id}/releases/v0.1/assets/links", non_project_member) }
+          end
+        end
+      end
     end
   end