Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
GitLab
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
projects.thm.de
GitLab
Commits
c9577711
Commit
c9577711
authored
Apr 30, 2016
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Handle issue move access instead of raising error
Closes #15533
parent
b8f28628
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
41 additions
and
0 deletions
+41
-0
app/controllers/projects/issues_controller.rb
app/controllers/projects/issues_controller.rb
+2
-0
spec/controllers/projects/issues_controller_spec.rb
spec/controllers/projects/issues_controller_spec.rb
+39
-0
No files found.
app/controllers/projects/issues_controller.rb
View file @
c9577711
...
...
@@ -96,6 +96,8 @@ def update
if
params
[
:move_to_project_id
].
to_i
>
0
new_project
=
Project
.
find
(
params
[
:move_to_project_id
])
return
render_404
unless
issue
.
can_move?
(
current_user
,
new_project
)
move_service
=
Issues
::
MoveService
.
new
(
project
,
current_user
)
@issue
=
move_service
.
execute
(
@issue
,
new_project
)
end
...
...
spec/controllers/projects/issues_controller_spec.rb
View file @
c9577711
...
...
@@ -40,6 +40,45 @@
end
end
describe
'PUT #update'
do
context
'when moving issue to another private project'
do
let
(
:another_project
)
{
create
(
:project
,
:private
)
}
before
do
sign_in
(
user
)
project
.
team
<<
[
user
,
:developer
]
end
context
'when user has access to move issue'
do
before
{
another_project
.
team
<<
[
user
,
:reporter
]
}
it
'moves issue to another project'
do
move_issue
expect
(
response
).
to
have_http_status
:found
expect
(
another_project
.
issues
).
to_not
be_empty
end
end
context
'when user does not have access to move issue'
do
it
'responds with 404'
do
move_issue
expect
(
response
).
to
have_http_status
:not_found
end
end
def
move_issue
put
:update
,
namespace_id:
project
.
namespace
.
to_param
,
project_id:
project
.
to_param
,
id:
issue
.
iid
,
issue:
{
title:
'New title'
},
move_to_project_id:
another_project
.
id
end
end
end
describe
'Confidential Issues'
do
let
(
:project
)
{
create
(
:project_empty_repo
,
:public
)
}
let
(
:assignee
)
{
create
(
:assignee
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment