Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
GitLab
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
projects.thm.de
GitLab
Commits
c379973b
Commit
c379973b
authored
Jan 16, 2019
by
Semyon Pupkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
chore(rubocop): fix Style/TrivialAccessors issues
parent
a2b26577
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
11 additions
and
30 deletions
+11
-30
.rubocop_todo.yml
.rubocop_todo.yml
+0
-11
app/models/external_issue.rb
app/models/external_issue.rb
+3
-5
app/serializers/base_serializer.rb
app/serializers/base_serializer.rb
+5
-5
lib/gitlab/auth/ldap/person.rb
lib/gitlab/auth/ldap/person.rb
+1
-3
lib/system_check/base_check.rb
lib/system_check/base_check.rb
+2
-6
No files found.
.rubocop_todo.yml
View file @
c379973b
...
...
@@ -686,17 +686,6 @@ Style/TrailingUnderscoreVariable:
-
'
spec/lib/gitlab/etag_caching/middleware_spec.rb'
-
'
spec/services/quick_actions/interpret_service_spec.rb'
# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors
:
Exclude
:
-
'
app/models/external_issue.rb'
-
'
app/serializers/base_serializer.rb'
-
'
lib/gitlab/auth/ldap/person.rb'
-
'
lib/system_check/base_check.rb'
# Offense count: 4
# Cop supports --auto-correct.
Style/UnlessElse
:
...
...
app/models/external_issue.rb
View file @
c379973b
...
...
@@ -3,6 +3,8 @@
class
ExternalIssue
include
Referable
attr_reader
:project
def
initialize
(
issue_identifier
,
project
)
@issue_identifier
,
@project
=
issue_identifier
,
project
end
...
...
@@ -32,12 +34,8 @@ def hash
[
self
.
class
,
to_s
].
hash
end
def
project
@project
end
def
project_id
@
project
.
id
project
.
id
end
def
to_reference
(
_from
=
nil
,
full:
nil
)
...
...
app/serializers/base_serializer.rb
View file @
c379973b
...
...
@@ -16,11 +16,11 @@ def represent(resource, opts = {}, entity_class = nil)
.
as_json
end
def
self
.
entity
(
entity_class
)
@entity_class
||=
entity_class
end
class
<<
self
attr_reader
:entity_class
def
self
.
entity_class
@entity_class
def
entity
(
entity_class
)
@entity_class
||=
entity_class
end
end
end
lib/gitlab/auth/ldap/person.rb
View file @
c379973b
...
...
@@ -98,9 +98,7 @@ def dn
private
def
entry
@entry
end
attr_reader
:entry
def
config
@config
||=
Gitlab
::
Auth
::
LDAP
::
Config
.
new
(
provider
)
...
...
lib/system_check/base_check.rb
View file @
c379973b
...
...
@@ -70,18 +70,14 @@ def self.skip_reason
# multiple reasons why a check can fail
#
# @param [String] reason to be displayed
def
skip_reason
=
(
reason
)
@skip_reason
=
reason
end
attr_writer
:skip_reason
# Skip reason defined during runtime
#
# This value have precedence over the one defined in the subclass
#
# @return [String] the reason
def
skip_reason
@skip_reason
end
attr_reader
:skip_reason
# Does the check support automatically repair routine?
#
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment