Commit b62cdc3c authored by Tony Chu's avatar Tony Chu Committed by Rémy Coutable

Actually use the `skip_merges` option in Repository#commits

parent bce482a5
......@@ -24,6 +24,7 @@ v 8.5.0 (unreleased)
- Update the ExternalIssue regex pattern (Blake Hitchcock)
- Optimized performance of finding issues to be closed by a merge request
- Revert "Add IP check against DNSBLs at account sign-up"
- Actually use the `skip_merges` option in Repository#commits (Tony Chu)
- Fix API to keep request parameters in Link header (Michael Potthoff)
- Deprecate API "merge_request/:merge_request_id/comments". Use "merge_requests/:merge_request_id/notes" instead
- Deprecate API "merge_request/:merge_request_id/...". Use "merge_requests/:merge_request_id/..." instead
......@@ -78,7 +78,8 @@ class Repository
offset: offset,
# --follow doesn't play well with --skip. See:
follow: false
follow: false,
skip_merges: skip_merges
commits = Gitlab::Git::Commit.where(options)
......@@ -239,4 +239,10 @@ describe Repository, models: true do
it { eq(true) }
describe :skip_merged_commit do
subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", nil, 100, 0, true).map{ |k| } }
it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment