Commit a744279f authored by Douwe Maan's avatar Douwe Maan
Browse files

Merge branch 'rs-have_link-arguments' into 'master'

Correct usage of the have_link matcher

See merge request gitlab-org/gitlab-ce!21755
parents 85ca8931 14a27a4f
......@@ -533,7 +533,7 @@ def visit_blob(path, anchor: nil, ref: 'master', legacy_render: nil)
expect(page).to have_content('This project is licensed under the MIT License.')
# shows a learn more link
expect(page).to have_link('Learn more', 'http://choosealicense.com/licenses/mit/')
expect(page).to have_link('Learn more', href: 'http://choosealicense.com/licenses/mit/')
end
end
end
......@@ -566,10 +566,10 @@ def visit_blob(path, anchor: nil, ref: 'master', legacy_render: nil)
expect(page).to have_content('This project manages its dependencies using RubyGems and defines a gem named activerecord.')
# shows a link to the gem
expect(page).to have_link('activerecord', 'https://rubygems.org/gems/activerecord')
expect(page).to have_link('activerecord', href: 'https://rubygems.org/gems/activerecord')
# shows a learn more link
expect(page).to have_link('Learn more', 'http://choosealicense.com/licenses/mit/')
expect(page).to have_link('Learn more', href: 'https://rubygems.org/')
end
end
end
......
......@@ -21,7 +21,7 @@
render
expect(rendered).to match '8.0.2'
expect(rendered).to have_link('abcdefg', 'https://gitlab.com/gitlab-org/gitlab-ce/commits/abcdefg')
expect(rendered).to have_link('abcdefg', href: 'https://gitlab.com/gitlab-org/gitlab-ce/commits/abcdefg')
end
end
......@@ -29,7 +29,7 @@
it 'is visible to guests' do
render
expect(rendered).to have_link(nil, help_instance_configuration_url)
expect(rendered).to have_link(nil, href: help_instance_configuration_url)
end
end
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment