Commit a55e8f10 authored by Grzegorz Bizon's avatar Grzegorz Bizon

Enable Style/NegatedIf Rubocop cop

Favor `unless` over `if` for negative conditions
(or control flow ||).

See #17478
parent 43c35b0f
......@@ -394,7 +394,7 @@ Style/MutableConstant:
# Favor unless over if for negative conditions (or control flow or).
Style/NegatedIf:
Enabled: false
Enabled: true
# Favor until over while for negative conditions.
Style/NegatedWhile:
......
......@@ -60,7 +60,7 @@ def assign_to(project, current_user = nil)
end
def display_name
return short_sha unless !description.blank?
return short_sha if description.blank?
description
end
......
......@@ -23,7 +23,7 @@ def build_push_data
commits = []
message = nil
if !Gitlab::Git.blank_ref?(params[:newrev])
unless Gitlab::Git.blank_ref?(params[:newrev])
tag_name = Gitlab::Git.ref_name(params[:ref])
tag = project.repository.find_tag(tag_name)
if tag && tag.target == params[:newrev]
......
......@@ -22,7 +22,7 @@ def initialize(project)
end
def execute
raise LeaseTaken if !try_obtain_lease
raise LeaseTaken unless try_obtain_lease
GitlabShellOneShotWorker.perform_async(:gc, @project.path_with_namespace)
ensure
......
......@@ -52,7 +52,7 @@ def build_gitlab_url
# check that values in `current` (string or integer) is a contant in `modul`.
def verify_constant_array(modul, current, default)
values = default || []
if !current.nil?
unless current.nil?
values = []
current.each do |constant|
values.push(verify_constant(modul, constant, nil))
......
......@@ -265,7 +265,7 @@ def validate_job_artifacts!(name, job)
end
def validate_job_dependencies!(name, job)
if !validate_array_of_strings(job[:dependencies])
unless validate_array_of_strings(job[:dependencies])
raise ValidationError, "#{name} job: dependencies parameter should be an array of strings"
end
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment