Commit 5eb936dc authored by James Lopez's avatar James Lopez

moved and refactored feature based on feedback. Also updated CHANGELOG

parent eef9c9d4
...@@ -8,6 +8,7 @@ v 8.5.0 (unreleased) ...@@ -8,6 +8,7 @@ v 8.5.0 (unreleased)
- Fix diff comments loaded by AJAX to load comment with diff in discussion tab - Fix diff comments loaded by AJAX to load comment with diff in discussion tab
- Whitelist raw "abbr" elements when parsing Markdown (Benedict Etzel) - Whitelist raw "abbr" elements when parsing Markdown (Benedict Etzel)
- Don't vendor minified JS - Don't vendor minified JS
- Display 404 error on group not found
v 8.4.1 v 8.4.1
- Apply security updates for Rails (4.2.5.1), rails-html-sanitizer (1.0.3), - Apply security updates for Rails (4.2.5.1), rails-html-sanitizer (1.0.3),
......
...@@ -3,11 +3,6 @@ Feature: Explore Groups ...@@ -3,11 +3,6 @@ Feature: Explore Groups
Background: Background:
Given group "TestGroup" has private project "Enterprise" Given group "TestGroup" has private project "Enterprise"
Scenario: I should not see a group if it does not exist
When I sign in as a user
And I visit group "NonExistentGroup" page
Then page status code should be 404
Scenario: I should see group with private and internal projects as user Scenario: I should see group with private and internal projects as user
Given group "TestGroup" has internal project "Internal" Given group "TestGroup" has internal project "Internal"
When I sign in as a user When I sign in as a user
......
...@@ -3,6 +3,10 @@ Feature: Groups ...@@ -3,6 +3,10 @@ Feature: Groups
Given I sign in as "John Doe" Given I sign in as "John Doe"
And "John Doe" is owner of group "Owned" And "John Doe" is owner of group "Owned"
Scenario: I should not see a group if it does not exist
When I visit group "NonExistentGroup" page
Then page status code should be 404
Scenario: I should have back to group button Scenario: I should have back to group button
When I visit group "Owned" page When I visit group "Owned" page
Then I should see back to dashboard button Then I should see back to dashboard button
......
...@@ -26,10 +26,6 @@ class Spinach::Features::ExploreGroups < Spinach::FeatureSteps ...@@ -26,10 +26,6 @@ class Spinach::Features::ExploreGroups < Spinach::FeatureSteps
visit group_path(Group.find_by(name: "TestGroup")) visit group_path(Group.find_by(name: "TestGroup"))
end end
step 'I visit group "NonExistentGroup" page' do
visit group_path(-1)
end
step 'I visit group "TestGroup" issues page' do step 'I visit group "TestGroup" issues page' do
visit issues_group_path(Group.find_by(name: "TestGroup")) visit issues_group_path(Group.find_by(name: "TestGroup"))
end end
......
...@@ -120,6 +120,10 @@ class Spinach::Features::Groups < Spinach::FeatureSteps ...@@ -120,6 +120,10 @@ class Spinach::Features::Groups < Spinach::FeatureSteps
expect(page).to have_xpath("//span[@class='label label-warning']", text: 'archived') expect(page).to have_xpath("//span[@class='label label-warning']", text: 'archived')
end end
step 'I visit group "NonExistentGroup" page' do
visit group_path(-1)
end
private private
def assigned_to_me(key) def assigned_to_me(key)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment