Commit 590cc1d4 authored by Lin Jen-Shin's avatar Lin Jen-Shin
Browse files

Merge branch 'comment-url-validator-cycle' into 'master'

Comment why we can't use Gitlab::CurrentSettings

See merge request gitlab-org/gitlab-ce!25412
parents 678f55da 89f7bac3
......@@ -93,6 +93,12 @@ def blocker_args
def allow_setting_local_requests?
# We cannot use Gitlab::CurrentSettings as ApplicationSetting itself
# uses UrlValidator to validate urls. This ends up in a cycle
# when Gitlab::CurrentSettings creates an ApplicationSetting which then
# calls this validator.
# See
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment