Commit 4e42168b authored by Nick Thomas's avatar Nick Thomas

Merge branch 'docs/zj-reviewer-guidelines' into 'master'

Add a soft SLA for reviewers and maintainers

See merge request gitlab-org/gitlab-ce!25192
parents 08271ba4 633cb37e
......@@ -137,6 +137,14 @@ If a developer who happens to also be a maintainer was involved in a merge reque
as a domain expert and/or reviewer, it is recommended that they are not also picked
as the maintainer to ultimately approve and merge it.
Try to review in a timely manner; doing so allows everyone involved in the merge
request to iterate faster as the context is fresh in memory. Further, this
improves contributors' experiences significantly. Reviewers should aim to review
within two working days from the date they were assigned the merge request. If
you don't think you'll be able to review a merge request within that time, let
the author know as soon as possible. When the author of the merge request has not
heard anything after two days, a new reviewer should be assigned.
Maintainers should check before merging if the merge request is approved by the
required approvers.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment