Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
7
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
projects.thm.de
GitLab
Commits
3f598ad7
Unverified
Commit
3f598ad7
authored
Mar 30, 2018
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Ignore current RSpec/FactoriesInMigrationSpecs offenses
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
4b035896
Changes
22
Hide whitespace changes
Inline
Side-by-side
Showing
22 changed files
with
84 additions
and
84 deletions
+84
-84
spec/migrations/add_foreign_keys_to_todos_spec.rb
spec/migrations/add_foreign_keys_to_todos_spec.rb
+3
-3
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb
...grations/add_head_pipeline_for_each_merge_request_spec.rb
+9
-9
spec/migrations/calculate_conv_dev_index_percentages_spec.rb
spec/migrations/calculate_conv_dev_index_percentages_spec.rb
+1
-1
spec/migrations/cleanup_namespaceless_pending_delete_projects_spec.rb
...ons/cleanup_namespaceless_pending_delete_projects_spec.rb
+5
-5
spec/migrations/cleanup_nonexisting_namespace_pending_delete_projects_spec.rb
...nup_nonexisting_namespace_pending_delete_projects_spec.rb
+4
-4
spec/migrations/issues_moved_to_id_foreign_key_spec.rb
spec/migrations/issues_moved_to_id_foreign_key_spec.rb
+3
-3
spec/migrations/migrate_old_artifacts_spec.rb
spec/migrations/migrate_old_artifacts_spec.rb
+12
-12
spec/migrations/migrate_process_commit_worker_jobs_spec.rb
spec/migrations/migrate_process_commit_worker_jobs_spec.rb
+2
-2
spec/migrations/migrate_user_activities_to_users_last_activity_on_spec.rb
...migrate_user_activities_to_users_last_activity_on_spec.rb
+2
-2
spec/migrations/migrate_user_project_view_spec.rb
spec/migrations/migrate_user_project_view_spec.rb
+1
-1
spec/migrations/move_personal_snippets_files_spec.rb
spec/migrations/move_personal_snippets_files_spec.rb
+8
-8
spec/migrations/remove_dot_git_from_usernames_spec.rb
spec/migrations/remove_dot_git_from_usernames_spec.rb
+2
-2
spec/migrations/remove_duplicate_mr_events_spec.rb
spec/migrations/remove_duplicate_mr_events_spec.rb
+9
-9
spec/migrations/remove_project_labels_group_id_spec.rb
spec/migrations/remove_project_labels_group_id_spec.rb
+3
-3
spec/migrations/remove_soft_removed_objects_spec.rb
spec/migrations/remove_soft_removed_objects_spec.rb
+4
-4
spec/migrations/rename_more_reserved_project_names_spec.rb
spec/migrations/rename_more_reserved_project_names_spec.rb
+1
-1
spec/migrations/rename_reserved_project_names_spec.rb
spec/migrations/rename_reserved_project_names_spec.rb
+1
-1
spec/migrations/rename_users_with_renamed_namespace_spec.rb
spec/migrations/rename_users_with_renamed_namespace_spec.rb
+4
-4
spec/migrations/schedule_create_gpg_key_subkeys_from_gpg_keys_spec.rb
...ons/schedule_create_gpg_key_subkeys_from_gpg_keys_spec.rb
+2
-2
spec/migrations/schedule_populate_merge_request_metrics_with_events_data_spec.rb
...e_populate_merge_request_metrics_with_events_data_spec.rb
+1
-1
spec/migrations/turn_nested_groups_into_regular_groups_for_mysql_spec.rb
.../turn_nested_groups_into_regular_groups_for_mysql_spec.rb
+4
-4
spec/migrations/update_retried_for_ci_build_spec.rb
spec/migrations/update_retried_for_ci_build_spec.rb
+3
-3
No files found.
spec/migrations/add_foreign_keys_to_todos_spec.rb
View file @
3f598ad7
...
...
@@ -4,8 +4,8 @@
describe
AddForeignKeysToTodos
,
:migration
do
let
(
:todos
)
{
table
(
:todos
)
}
let
(
:project
)
{
create
(
:project
)
}
let
(
:user
)
{
create
(
:user
)
}
let
(
:project
)
{
create
(
:project
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let
(
:user
)
{
create
(
:user
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
context
'add foreign key on user_id'
do
let!
(
:todo_with_user
)
{
create_todo
(
user_id:
user
.
id
)
}
...
...
@@ -34,7 +34,7 @@
end
context
'add foreign key on note_id'
do
let
(
:note
)
{
create
(
:note
)
}
let
(
:note
)
{
create
(
:note
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:todo_with_note
)
{
create_todo
(
note_id:
note
.
id
)
}
let!
(
:todo_with_invalid_note
)
{
create_todo
(
note_id:
4711
)
}
let!
(
:todo_without_note
)
{
create_todo
(
note_id:
nil
)
}
...
...
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb
View file @
3f598ad7
...
...
@@ -6,18 +6,18 @@
let
(
:migration
)
{
described_class
.
new
}
let!
(
:project
)
{
create
(
:project
)
}
let!
(
:project
)
{
create
(
:project
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:other_project
)
{
fork_project
(
project
)
}
let!
(
:pipeline_1
)
{
create
(
:ci_pipeline
,
project:
project
,
ref:
"branch_1"
)
}
let!
(
:pipeline_2
)
{
create
(
:ci_pipeline
,
project:
other_project
,
ref:
"branch_1"
)
}
let!
(
:pipeline_3
)
{
create
(
:ci_pipeline
,
project:
other_project
,
ref:
"branch_1"
)
}
let!
(
:pipeline_4
)
{
create
(
:ci_pipeline
,
project:
project
,
ref:
"branch_2"
)
}
let!
(
:pipeline_1
)
{
create
(
:ci_pipeline
,
project:
project
,
ref:
"branch_1"
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:pipeline_2
)
{
create
(
:ci_pipeline
,
project:
other_project
,
ref:
"branch_1"
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:pipeline_3
)
{
create
(
:ci_pipeline
,
project:
other_project
,
ref:
"branch_1"
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:pipeline_4
)
{
create
(
:ci_pipeline
,
project:
project
,
ref:
"branch_2"
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:mr_1
)
{
create
(
:merge_request
,
source_project:
project
,
target_project:
project
,
source_branch:
"branch_1"
,
target_branch:
"target_1"
)
}
let!
(
:mr_2
)
{
create
(
:merge_request
,
source_project:
other_project
,
target_project:
project
,
source_branch:
"branch_1"
,
target_branch:
"target_2"
)
}
let!
(
:mr_3
)
{
create
(
:merge_request
,
source_project:
project
,
target_project:
project
,
source_branch:
"branch_2"
,
target_branch:
"master"
)
}
let!
(
:mr_4
)
{
create
(
:merge_request
,
source_project:
project
,
target_project:
project
,
source_branch:
"branch_3"
,
target_branch:
"master"
)
}
let!
(
:mr_1
)
{
create
(
:merge_request
,
source_project:
project
,
target_project:
project
,
source_branch:
"branch_1"
,
target_branch:
"target_1"
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:mr_2
)
{
create
(
:merge_request
,
source_project:
other_project
,
target_project:
project
,
source_branch:
"branch_1"
,
target_branch:
"target_2"
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:mr_3
)
{
create
(
:merge_request
,
source_project:
project
,
target_project:
project
,
source_branch:
"branch_2"
,
target_branch:
"master"
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:mr_4
)
{
create
(
:merge_request
,
source_project:
project
,
target_project:
project
,
source_branch:
"branch_3"
,
target_branch:
"master"
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
context
"#up"
do
context
"when source_project and source_branch of pipeline are the same of merge request"
do
...
...
spec/migrations/calculate_conv_dev_index_percentages_spec.rb
View file @
3f598ad7
...
...
@@ -6,7 +6,7 @@
describe
CalculateConvDevIndexPercentages
,
:delete
do
let
(
:migration
)
{
described_class
.
new
}
let!
(
:conv_dev_index
)
do
create
(
:conversational_development_index_metric
,
create
(
:conversational_development_index_metric
,
# rubocop:disable RSpec/FactoriesInMigrationSpecs
leader_notes:
0
,
instance_milestones:
0
,
percentage_issues:
0
,
...
...
spec/migrations/cleanup_namespaceless_pending_delete_projects_spec.rb
View file @
3f598ad7
...
...
@@ -10,9 +10,9 @@
describe
'#up'
do
it
'only cleans up pending delete projects'
do
create
(
:project
)
create
(
:project
,
pending_delete:
true
)
project
=
build
(
:project
,
pending_delete:
true
,
namespace_id:
nil
)
create
(
:project
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create
(
:project
,
pending_delete:
true
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
project
=
build
(
:project
,
pending_delete:
true
,
namespace_id:
nil
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
project
.
save
(
validate:
false
)
expect
(
NamespacelessProjectDestroyWorker
).
to
receive
(
:bulk_perform_async
).
with
([[
project
.
id
]])
...
...
@@ -21,8 +21,8 @@
end
it
'does nothing when no pending delete projects without namespace found'
do
create
(
:project
)
create
(
:project
,
pending_delete:
true
)
create
(
:project
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create
(
:project
,
pending_delete:
true
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
expect
(
NamespacelessProjectDestroyWorker
).
not_to
receive
(
:bulk_perform_async
)
...
...
spec/migrations/cleanup_nonexisting_namespace_pending_delete_projects_spec.rb
View file @
3f598ad7
...
...
@@ -9,11 +9,11 @@
end
describe
'#up'
do
set
(
:some_project
)
{
create
(
:project
)
}
set
(
:some_project
)
{
create
(
:project
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
it
'only cleans up when namespace does not exist'
do
create
(
:project
,
pending_delete:
true
)
project
=
build
(
:project
,
pending_delete:
true
,
namespace:
nil
,
namespace_id:
Namespace
.
maximum
(
:id
).
to_i
.
succ
)
create
(
:project
,
pending_delete:
true
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
project
=
build
(
:project
,
pending_delete:
true
,
namespace:
nil
,
namespace_id:
Namespace
.
maximum
(
:id
).
to_i
.
succ
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
project
.
save
(
validate:
false
)
expect
(
NamespacelessProjectDestroyWorker
).
to
receive
(
:bulk_perform_async
).
with
([[
project
.
id
]])
...
...
@@ -22,7 +22,7 @@
end
it
'does nothing when no pending delete projects without namespace found'
do
create
(
:project
,
pending_delete:
true
,
namespace:
create
(
:namespace
))
create
(
:project
,
pending_delete:
true
,
namespace:
create
(
:namespace
))
# rubocop:disable RSpec/FactoriesInMigrationSpecs
expect
(
NamespacelessProjectDestroyWorker
).
not_to
receive
(
:bulk_perform_async
)
...
...
spec/migrations/issues_moved_to_id_foreign_key_spec.rb
View file @
3f598ad7
...
...
@@ -5,9 +5,9 @@
# only_mirror_protected_branches column in the projects table to create a
# project via FactoryBot.
describe
IssuesMovedToIdForeignKey
,
:migration
,
schema:
20171114150259
do
let!
(
:issue_first
)
{
create
(
:issue
,
moved_to_id:
issue_second
.
id
)
}
let!
(
:issue_second
)
{
create
(
:issue
,
moved_to_id:
issue_third
.
id
)
}
let!
(
:issue_third
)
{
create
(
:issue
)
}
let!
(
:issue_first
)
{
create
(
:issue
,
moved_to_id:
issue_second
.
id
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:issue_second
)
{
create
(
:issue
,
moved_to_id:
issue_third
.
id
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:issue_third
)
{
create
(
:issue
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
subject
{
described_class
.
new
}
...
...
spec/migrations/migrate_old_artifacts_spec.rb
View file @
3f598ad7
...
...
@@ -16,18 +16,18 @@
end
context
'with migratable data'
do
set
(
:project1
)
{
create
(
:project
,
ci_id:
2
)
}
set
(
:project2
)
{
create
(
:project
,
ci_id:
3
)
}
set
(
:project3
)
{
create
(
:project
)
}
set
(
:pipeline1
)
{
create
(
:ci_empty_pipeline
,
project:
project1
)
}
set
(
:pipeline2
)
{
create
(
:ci_empty_pipeline
,
project:
project2
)
}
set
(
:pipeline3
)
{
create
(
:ci_empty_pipeline
,
project:
project3
)
}
let!
(
:build_with_legacy_artifacts
)
{
create
(
:ci_build
,
pipeline:
pipeline1
)
}
let!
(
:build_without_artifacts
)
{
create
(
:ci_build
,
pipeline:
pipeline1
)
}
let!
(
:build2
)
{
create
(
:ci_build
,
pipeline:
pipeline2
)
}
let!
(
:build3
)
{
create
(
:ci_build
,
pipeline:
pipeline3
)
}
set
(
:project1
)
{
create
(
:project
,
ci_id:
2
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
set
(
:project2
)
{
create
(
:project
,
ci_id:
3
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
set
(
:project3
)
{
create
(
:project
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
set
(
:pipeline1
)
{
create
(
:ci_empty_pipeline
,
project:
project1
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
set
(
:pipeline2
)
{
create
(
:ci_empty_pipeline
,
project:
project2
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
set
(
:pipeline3
)
{
create
(
:ci_empty_pipeline
,
project:
project3
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:build_with_legacy_artifacts
)
{
create
(
:ci_build
,
pipeline:
pipeline1
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:build_without_artifacts
)
{
create
(
:ci_build
,
pipeline:
pipeline1
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:build2
)
{
create
(
:ci_build
,
pipeline:
pipeline2
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:build3
)
{
create
(
:ci_build
,
pipeline:
pipeline3
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
before
do
setup_builds
(
build2
,
build3
)
...
...
spec/migrations/migrate_process_commit_worker_jobs_spec.rb
View file @
3f598ad7
...
...
@@ -4,8 +4,8 @@
require
Rails
.
root
.
join
(
'db'
,
'migrate'
,
'20161124141322_migrate_process_commit_worker_jobs.rb'
)
describe
MigrateProcessCommitWorkerJobs
do
let
(
:project
)
{
create
(
:project
,
:legacy_storage
,
:repository
)
}
let
(
:user
)
{
create
(
:user
)
}
let
(
:project
)
{
create
(
:project
,
:legacy_storage
,
:repository
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let
(
:user
)
{
create
(
:user
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let
(
:commit
)
{
project
.
commit
.
raw
.
rugged_commit
}
describe
'Project'
do
...
...
spec/migrations/migrate_user_activities_to_users_last_activity_on_spec.rb
View file @
3f598ad7
...
...
@@ -5,8 +5,8 @@
describe
MigrateUserActivitiesToUsersLastActivityOn
,
:clean_gitlab_redis_shared_state
,
:delete
do
let
(
:migration
)
{
described_class
.
new
}
let!
(
:user_active_1
)
{
create
(
:user
)
}
let!
(
:user_active_2
)
{
create
(
:user
)
}
let!
(
:user_active_1
)
{
create
(
:user
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:user_active_2
)
{
create
(
:user
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
def
record_activity
(
user
,
time
)
Gitlab
::
Redis
::
SharedState
.
with
do
|
redis
|
...
...
spec/migrations/migrate_user_project_view_spec.rb
View file @
3f598ad7
...
...
@@ -5,7 +5,7 @@
describe
MigrateUserProjectView
,
:delete
do
let
(
:migration
)
{
described_class
.
new
}
let!
(
:user
)
{
create
(
:user
,
project_view:
'readme'
)
}
let!
(
:user
)
{
create
(
:user
,
project_view:
'readme'
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
describe
'#up'
do
it
'updates project view setting with new value'
do
...
...
spec/migrations/move_personal_snippets_files_spec.rb
View file @
3f598ad7
...
...
@@ -16,14 +16,14 @@
describe
"#up"
do
let
(
:snippet
)
do
snippet
=
create
(
:personal_snippet
)
snippet
=
create
(
:personal_snippet
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create_upload
(
'picture.jpg'
,
snippet
)
snippet
.
update
(
description:
markdown_linking_file
(
'picture.jpg'
,
snippet
))
snippet
end
let
(
:snippet_with_missing_file
)
do
snippet
=
create
(
:snippet
)
snippet
=
create
(
:snippet
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create_upload
(
'picture.jpg'
,
snippet
,
create_file:
false
)
snippet
.
update
(
description:
markdown_linking_file
(
'picture.jpg'
,
snippet
))
snippet
...
...
@@ -62,7 +62,7 @@
secret
=
"secret
#{
snippet
.
id
}
"
file_location
=
"/uploads/-/system/personal_snippet/
#{
snippet
.
id
}
/
#{
secret
}
/picture.jpg"
markdown
=
markdown_linking_file
(
'picture.jpg'
,
snippet
)
note
=
create
(
:note_on_personal_snippet
,
noteable:
snippet
,
note:
"with
#{
markdown
}
"
)
note
=
create
(
:note_on_personal_snippet
,
noteable:
snippet
,
note:
"with
#{
markdown
}
"
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
migration
.
up
...
...
@@ -73,14 +73,14 @@
describe
"#down"
do
let
(
:snippet
)
do
snippet
=
create
(
:personal_snippet
)
snippet
=
create
(
:personal_snippet
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create_upload
(
'picture.jpg'
,
snippet
,
in_new_path:
true
)
snippet
.
update
(
description:
markdown_linking_file
(
'picture.jpg'
,
snippet
,
in_new_path:
true
))
snippet
end
let
(
:snippet_with_missing_file
)
do
snippet
=
create
(
:personal_snippet
)
snippet
=
create
(
:personal_snippet
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create_upload
(
'picture.jpg'
,
snippet
,
create_file:
false
,
in_new_path:
true
)
snippet
.
update
(
description:
markdown_linking_file
(
'picture.jpg'
,
snippet
,
in_new_path:
true
))
snippet
...
...
@@ -119,7 +119,7 @@
markdown
=
markdown_linking_file
(
'picture.jpg'
,
snippet
,
in_new_path:
true
)
secret
=
"secret
#{
snippet
.
id
}
"
file_location
=
"/uploads/personal_snippet/
#{
snippet
.
id
}
/
#{
secret
}
/picture.jpg"
note
=
create
(
:note_on_personal_snippet
,
noteable:
snippet
,
note:
"with
#{
markdown
}
"
)
note
=
create
(
:note_on_personal_snippet
,
noteable:
snippet
,
note:
"with
#{
markdown
}
"
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
migration
.
down
...
...
@@ -135,7 +135,7 @@
secret
=
'123456789'
filename
=
'hello.jpg'
snippet
=
create
(
:personal_snippet
)
snippet
=
create
(
:personal_snippet
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
path_before
=
"/uploads/personal_snippet/
#{
snippet
.
id
}
/
#{
secret
}
/
#{
filename
}
"
path_after
=
"/uploads/system/personal_snippet/
#{
snippet
.
id
}
/
#{
secret
}
/
#{
filename
}
"
...
...
@@ -161,7 +161,7 @@ def create_upload(filename, snippet, create_file: true, in_new_path: false)
FileUtils
.
touch
(
absolute_path
)
end
create
(
:upload
,
model:
snippet
,
path:
"
#{
secret
}
/
#{
filename
}
"
,
uploader:
PersonalFileUploader
)
create
(
:upload
,
model:
snippet
,
path:
"
#{
secret
}
/
#{
filename
}
"
,
uploader:
PersonalFileUploader
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
end
def
markdown_linking_file
(
filename
,
snippet
,
in_new_path:
false
)
...
...
spec/migrations/remove_dot_git_from_usernames_spec.rb
View file @
3f598ad7
...
...
@@ -4,7 +4,7 @@
require
Rails
.
root
.
join
(
'db'
,
'migrate'
,
'20161226122833_remove_dot_git_from_usernames.rb'
)
describe
RemoveDotGitFromUsernames
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:user
)
{
create
(
:user
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let
(
:migration
)
{
described_class
.
new
}
describe
'#up'
do
...
...
@@ -23,7 +23,7 @@
context
'when new path exists already'
do
describe
'#up'
do
let
(
:user2
)
{
create
(
:user
)
}
let
(
:user2
)
{
create
(
:user
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
before
do
update_namespace
(
user
,
'test.git'
)
...
...
spec/migrations/remove_duplicate_mr_events_spec.rb
View file @
3f598ad7
...
...
@@ -5,17 +5,17 @@
let
(
:migration
)
{
described_class
.
new
}
describe
'#up'
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:merge_requests
)
{
create_list
(
:merge_request
,
2
)
}
let
(
:issue
)
{
create
(
:issue
)
}
let
(
:user
)
{
create
(
:user
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let
(
:merge_requests
)
{
create_list
(
:merge_request
,
2
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let
(
:issue
)
{
create
(
:issue
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:events
)
do
[
create
(
:event
,
:created
,
author:
user
,
target:
merge_requests
.
first
),
create
(
:event
,
:created
,
author:
user
,
target:
merge_requests
.
first
),
create
(
:event
,
:updated
,
author:
user
,
target:
merge_requests
.
first
),
create
(
:event
,
:created
,
author:
user
,
target:
merge_requests
.
second
),
create
(
:event
,
:created
,
author:
user
,
target:
issue
),
create
(
:event
,
:created
,
author:
user
,
target:
issue
)
create
(
:event
,
:created
,
author:
user
,
target:
merge_requests
.
first
),
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create
(
:event
,
:created
,
author:
user
,
target:
merge_requests
.
first
),
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create
(
:event
,
:updated
,
author:
user
,
target:
merge_requests
.
first
),
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create
(
:event
,
:created
,
author:
user
,
target:
merge_requests
.
second
),
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create
(
:event
,
:created
,
author:
user
,
target:
issue
),
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create
(
:event
,
:created
,
author:
user
,
target:
issue
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
]
end
...
...
spec/migrations/remove_project_labels_group_id_spec.rb
View file @
3f598ad7
...
...
@@ -5,9 +5,9 @@
describe
RemoveProjectLabelsGroupId
,
:delete
do
let
(
:migration
)
{
described_class
.
new
}
let
(
:group
)
{
create
(
:group
)
}
let!
(
:project_label
)
{
create
(
:label
,
group_id:
group
.
id
)
}
let!
(
:group_label
)
{
create
(
:group_label
)
}
let
(
:group
)
{
create
(
:group
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:project_label
)
{
create
(
:label
,
group_id:
group
.
id
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:group_label
)
{
create
(
:group_label
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
describe
'#up'
do
it
'updates the project labels group ID'
do
...
...
spec/migrations/remove_soft_removed_objects_spec.rb
View file @
3f598ad7
...
...
@@ -8,7 +8,7 @@
create_with_deleted_at
(
:issue
)
end
regular_issue
=
create
(
:issue
)
regular_issue
=
create
(
:issue
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
run_migration
...
...
@@ -28,7 +28,7 @@
it
'removes routes of soft removed personal namespaces'
do
namespace
=
create_with_deleted_at
(
:namespace
)
group
=
create
(
:group
)
group
=
create
(
:group
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
expect
(
Route
.
where
(
source:
namespace
).
exists?
).
to
eq
(
true
)
expect
(
Route
.
where
(
source:
group
).
exists?
).
to
eq
(
true
)
...
...
@@ -41,7 +41,7 @@
it
'schedules the removal of soft removed groups'
do
group
=
create_with_deleted_at
(
:group
)
admin
=
create
(
:user
,
admin:
true
)
admin
=
create
(
:user
,
admin:
true
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
expect_any_instance_of
(
GroupDestroyWorker
)
.
to
receive
(
:perform
)
...
...
@@ -67,7 +67,7 @@ def run_migration
end
def
create_with_deleted_at
(
*
args
)
row
=
create
(
*
args
)
row
=
create
(
*
args
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
# We set "deleted_at" this way so we don't run into any column cache issues.
row
.
class
.
where
(
id:
row
.
id
).
update_all
(
deleted_at:
1
.
year
.
ago
)
...
...
spec/migrations/rename_more_reserved_project_names_spec.rb
View file @
3f598ad7
...
...
@@ -8,7 +8,7 @@
# around this we use the DELETE cleaning strategy.
describe
RenameMoreReservedProjectNames
,
:delete
do
let
(
:migration
)
{
described_class
.
new
}
let!
(
:project
)
{
create
(
:project
)
}
let!
(
:project
)
{
create
(
:project
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
before
do
project
.
path
=
'artifacts'
...
...
spec/migrations/rename_reserved_project_names_spec.rb
View file @
3f598ad7
...
...
@@ -12,7 +12,7 @@
# Ideally, the test should not use factories and rely on the `table` helper instead.
describe
RenameReservedProjectNames
,
:migration
,
schema: :latest
do
let
(
:migration
)
{
described_class
.
new
}
let!
(
:project
)
{
create
(
:project
)
}
let!
(
:project
)
{
create
(
:project
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
before
do
project
.
path
=
'projects'
...
...
spec/migrations/rename_users_with_renamed_namespace_spec.rb
View file @
3f598ad7
...
...
@@ -3,12 +3,12 @@
describe
RenameUsersWithRenamedNamespace
,
:delete
do
it
'renames a user that had their namespace renamed to the namespace path'
do
other_user
=
create
(
:user
,
username:
'kodingu'
)
other_user1
=
create
(
:user
,
username:
'api0'
)
other_user
=
create
(
:user
,
username:
'kodingu'
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
other_user1
=
create
(
:user
,
username:
'api0'
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
user
=
create
(
:user
,
username:
"Users0"
)
user
=
create
(
:user
,
username:
"Users0"
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
user
.
update_column
(
:username
,
'Users'
)
user1
=
create
(
:user
,
username:
"import0"
)
user1
=
create
(
:user
,
username:
"import0"
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
user1
.
update_column
(
:username
,
'import'
)
described_class
.
new
.
up
...
...
spec/migrations/schedule_create_gpg_key_subkeys_from_gpg_keys_spec.rb
View file @
3f598ad7
...
...
@@ -3,8 +3,8 @@
describe
ScheduleCreateGpgKeySubkeysFromGpgKeys
,
:migration
,
:sidekiq
do
before
do
create
(
:gpg_key
,
id:
1
,
key:
GpgHelpers
::
User1
.
public_key
)
create
(
:gpg_key
,
id:
2
,
key:
GpgHelpers
::
User3
.
public_key
)
create
(
:gpg_key
,
id:
1
,
key:
GpgHelpers
::
User1
.
public_key
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
create
(
:gpg_key
,
id:
2
,
key:
GpgHelpers
::
User3
.
public_key
)
# rubocop:disable RSpec/FactoriesInMigrationSpecs
# Delete all subkeys so they can be recreated
GpgKeySubkey
.
destroy_all
end
...
...
spec/migrations/schedule_populate_merge_request_metrics_with_events_data_spec.rb
View file @
3f598ad7
...
...
@@ -8,7 +8,7 @@
.
to
receive
(
:commits_count
=
).
and_return
(
nil
)
end
let!
(
:mrs
)
{
create_list
(
:merge_request
,
3
)
}
let!
(
:mrs
)
{
create_list
(
:merge_request
,
3
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
it
'correctly schedules background migrations'
do
stub_const
(
"
#{
described_class
.
name
}
::BATCH_SIZE"
,
2
)
...
...
spec/migrations/turn_nested_groups_into_regular_groups_for_mysql_spec.rb
View file @
3f598ad7
...
...
@@ -2,10 +2,10 @@
require
Rails
.
root
.
join
(
'db'
,
'migrate'
,
'20170503140202_turn_nested_groups_into_regular_groups_for_mysql.rb'
)
describe
TurnNestedGroupsIntoRegularGroupsForMysql
do
let!
(
:parent_group
)
{
create
(
:group
)
}
let!
(
:child_group
)
{
create
(
:group
,
parent:
parent_group
)
}
let!
(
:project
)
{
create
(
:project
,
:legacy_storage
,
:empty_repo
,
namespace:
child_group
)
}
let!
(
:member
)
{
create
(
:user
)
}
let!
(
:parent_group
)
{
create
(
:group
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:child_group
)
{
create
(
:group
,
parent:
parent_group
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:project
)
{
create
(
:project
,
:legacy_storage
,
:empty_repo
,
namespace:
child_group
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:member
)
{
create
(
:user
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let
(
:migration
)
{
described_class
.
new
}
before
do
...
...
spec/migrations/update_retried_for_ci_build_spec.rb
View file @
3f598ad7
...
...
@@ -2,9 +2,9 @@
require
Rails
.
root
.
join
(
'db'
,
'post_migrate'
,
'20170503004427_update_retried_for_ci_build.rb'
)
describe
UpdateRetriedForCiBuild
,
:delete
do
let
(
:pipeline
)
{
create
(
:ci_pipeline
)
}
let!
(
:build_old
)
{
create
(
:ci_build
,
pipeline:
pipeline
,
name:
'test'
)
}
let!
(
:build_new
)
{
create
(
:ci_build
,
pipeline:
pipeline
,
name:
'test'
)
}
let
(
:pipeline
)
{
create
(
:ci_pipeline
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:build_old
)
{
create
(
:ci_build
,
pipeline:
pipeline
,
name:
'test'
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
let!
(
:build_new
)
{
create
(
:ci_build
,
pipeline:
pipeline
,
name:
'test'
)
}
# rubocop:disable RSpec/FactoriesInMigrationSpecs
before
do
described_class
.
new
.
up
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment