Commit 3ba72f69 authored by Robert Speicher's avatar Robert Speicher

Enable Style/SpaceAroundKeyword cop and fix offenses

parent 68b8e86a
......@@ -525,10 +525,9 @@ Style/SpaceAfterSemicolon:
Style/SpaceAroundEqualsInParameterDefault:
Enabled: false
# TODO: Enable SpaceAroundKeyword Cop.
# Use a space around keywords if appropriate.
Style/SpaceAroundKeyword:
Enabled: false
Enabled: true
# Use a single space around operators.
Style/SpaceAroundOperators:
......
......@@ -110,8 +110,7 @@ def grouped_options_refs
]
# If reference is commit id - we should add it to branch/tag selectbox
if(@ref && !options.flatten.include?(@ref) &&
@ref =~ /\A[0-9a-zA-Z]{6,52}\z/)
if @ref && !options.flatten.include?(@ref) && @ref =~ /\A[0-9a-zA-Z]{6,52}\z/
options << ['Commit', [@ref]]
end
......
......@@ -98,7 +98,7 @@ def convert(raw, new_state)
open_new_tag
s = StringScanner.new(ansi)
while(!s.eos?)
until s.eos?
if s.scan(/\e([@-_])(.*?)([@-~])/)
handle_sequence(s)
elsif s.scan(/\e(([@-_])(.*?)?)?$/)
......
......@@ -28,7 +28,7 @@
expect(group.shared_projects).to include project
end
it 'redirects to project group links page'do
it 'redirects to project group links page' do
expect(response).to redirect_to(
namespace_project_group_links_path(project.namespace, project)
)
......
......@@ -5,7 +5,7 @@
describe "#{factory.name} factory" do
let(:entity) { build(factory.name) }
it 'does not raise error when created 'do
it 'does not raise error when created' do
expect { entity }.to_not raise_error
end
......
......@@ -49,7 +49,7 @@
context 'token is generated' do
before { subject.send("reset_#{token_field}!") }
it 'persists a new token 'do
it 'persists a new token' do
expect(subject.send(:read_attribute, token_field)).to be_a String
end
end
......
......@@ -54,7 +54,7 @@
label_ids: [label.id] }
end
it 'does not assign label'do
it 'does not assign label' do
expect(issue.labels).to_not include label
end
end
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment