Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
GitLab
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
projects.thm.de
GitLab
Commits
2f40dac3
Commit
2f40dac3
authored
Oct 19, 2017
by
Jacopo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactor `have_http_status` into `have_gitlab_http_status` in the specs
parent
b4dc0ba2
Changes
179
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
179 changed files
with
2663 additions
and
2658 deletions
+2663
-2658
changelogs/unreleased/35644-refactor-have-http-status-into-have-gitlab-http-status.yml
...efactor-have-http-status-into-have-gitlab-http-status.yml
+5
-0
spec/controllers/admin/hooks_controller_spec.rb
spec/controllers/admin/hooks_controller_spec.rb
+1
-1
spec/controllers/admin/impersonations_controller_spec.rb
spec/controllers/admin/impersonations_controller_spec.rb
+3
-3
spec/controllers/admin/projects_controller_spec.rb
spec/controllers/admin/projects_controller_spec.rb
+1
-1
spec/controllers/admin/runners_controller_spec.rb
spec/controllers/admin/runners_controller_spec.rb
+7
-7
spec/controllers/admin/services_controller_spec.rb
spec/controllers/admin/services_controller_spec.rb
+3
-3
spec/controllers/admin/spam_logs_controller_spec.rb
spec/controllers/admin/spam_logs_controller_spec.rb
+4
-4
spec/controllers/admin/users_controller_spec.rb
spec/controllers/admin/users_controller_spec.rb
+2
-2
spec/controllers/application_controller_spec.rb
spec/controllers/application_controller_spec.rb
+8
-8
spec/controllers/autocomplete_controller_spec.rb
spec/controllers/autocomplete_controller_spec.rb
+5
-5
spec/controllers/boards/issues_controller_spec.rb
spec/controllers/boards/issues_controller_spec.rb
+14
-14
spec/controllers/boards/lists_controller_spec.rb
spec/controllers/boards/lists_controller_spec.rb
+16
-16
spec/controllers/dashboard/milestones_controller_spec.rb
spec/controllers/dashboard/milestones_controller_spec.rb
+1
-1
spec/controllers/dashboard/todos_controller_spec.rb
spec/controllers/dashboard/todos_controller_spec.rb
+7
-7
spec/controllers/groups/group_members_controller_spec.rb
spec/controllers/groups/group_members_controller_spec.rb
+9
-9
spec/controllers/groups/labels_controller_spec.rb
spec/controllers/groups/labels_controller_spec.rb
+1
-1
spec/controllers/groups/milestones_controller_spec.rb
spec/controllers/groups/milestones_controller_spec.rb
+7
-7
spec/controllers/groups/settings/ci_cd_controller_spec.rb
spec/controllers/groups/settings/ci_cd_controller_spec.rb
+1
-1
spec/controllers/groups/variables_controller_spec.rb
spec/controllers/groups/variables_controller_spec.rb
+1
-1
spec/controllers/groups_controller_spec.rb
spec/controllers/groups_controller_spec.rb
+9
-9
spec/controllers/health_check_controller_spec.rb
spec/controllers/health_check_controller_spec.rb
+4
-4
spec/controllers/help_controller_spec.rb
spec/controllers/help_controller_spec.rb
+1
-1
spec/controllers/invites_controller_spec.rb
spec/controllers/invites_controller_spec.rb
+2
-2
spec/controllers/notification_settings_controller_spec.rb
spec/controllers/notification_settings_controller_spec.rb
+2
-2
spec/controllers/oauth/applications_controller_spec.rb
spec/controllers/oauth/applications_controller_spec.rb
+2
-2
spec/controllers/oauth/authorizations_controller_spec.rb
spec/controllers/oauth/authorizations_controller_spec.rb
+3
-3
spec/controllers/passwords_controller_spec.rb
spec/controllers/passwords_controller_spec.rb
+1
-1
spec/controllers/profiles/accounts_controller_spec.rb
spec/controllers/profiles/accounts_controller_spec.rb
+3
-3
spec/controllers/projects/artifacts_controller_spec.rb
spec/controllers/projects/artifacts_controller_spec.rb
+4
-4
spec/controllers/projects/badges_controller_spec.rb
spec/controllers/projects/badges_controller_spec.rb
+2
-2
spec/controllers/projects/blame_controller_spec.rb
spec/controllers/projects/blame_controller_spec.rb
+1
-1
spec/controllers/projects/blob_controller_spec.rb
spec/controllers/projects/blob_controller_spec.rb
+2
-2
spec/controllers/projects/boards_controller_spec.rb
spec/controllers/projects/boards_controller_spec.rb
+3
-3
spec/controllers/projects/branches_controller_spec.rb
spec/controllers/projects/branches_controller_spec.rb
+14
-14
spec/controllers/projects/clusters_controller_spec.rb
spec/controllers/projects/clusters_controller_spec.rb
+7
-7
spec/controllers/projects/commit_controller_spec.rb
spec/controllers/projects/commit_controller_spec.rb
+6
-6
spec/controllers/projects/compare_controller_spec.rb
spec/controllers/projects/compare_controller_spec.rb
+4
-4
spec/controllers/projects/deployments_controller_spec.rb
spec/controllers/projects/deployments_controller_spec.rb
+2
-2
spec/controllers/projects/discussions_controller_spec.rb
spec/controllers/projects/discussions_controller_spec.rb
+6
-6
spec/controllers/projects/environments_controller_spec.rb
spec/controllers/projects/environments_controller_spec.rb
+13
-13
spec/controllers/projects/forks_controller_spec.rb
spec/controllers/projects/forks_controller_spec.rb
+2
-2
spec/controllers/projects/issues_controller_spec.rb
spec/controllers/projects/issues_controller_spec.rb
+22
-22
spec/controllers/projects/jobs_controller_spec.rb
spec/controllers/projects/jobs_controller_spec.rb
+23
-23
spec/controllers/projects/labels_controller_spec.rb
spec/controllers/projects/labels_controller_spec.rb
+9
-9
spec/controllers/projects/mattermosts_controller_spec.rb
spec/controllers/projects/mattermosts_controller_spec.rb
+1
-1
spec/controllers/projects/merge_requests/conflicts_controller_spec.rb
...lers/projects/merge_requests/conflicts_controller_spec.rb
+8
-8
spec/controllers/projects/merge_requests/creations_controller_spec.rb
...lers/projects/merge_requests/creations_controller_spec.rb
+1
-1
spec/controllers/projects/merge_requests/diffs_controller_spec.rb
...trollers/projects/merge_requests/diffs_controller_spec.rb
+4
-4
spec/controllers/projects/merge_requests_controller_spec.rb
spec/controllers/projects/merge_requests_controller_spec.rb
+7
-7
spec/controllers/projects/milestones_controller_spec.rb
spec/controllers/projects/milestones_controller_spec.rb
+1
-1
spec/controllers/projects/notes_controller_spec.rb
spec/controllers/projects/notes_controller_spec.rb
+19
-19
spec/controllers/projects/pages_controller_spec.rb
spec/controllers/projects/pages_controller_spec.rb
+5
-5
spec/controllers/projects/pages_domains_controller_spec.rb
spec/controllers/projects/pages_domains_controller_spec.rb
+6
-6
spec/controllers/projects/pipeline_schedules_controller_spec.rb
...ontrollers/projects/pipeline_schedules_controller_spec.rb
+8
-8
spec/controllers/projects/pipelines_controller_spec.rb
spec/controllers/projects/pipelines_controller_spec.rb
+9
-9
spec/controllers/projects/pipelines_settings_controller_spec.rb
...ontrollers/projects/pipelines_settings_controller_spec.rb
+1
-1
spec/controllers/projects/project_members_controller_spec.rb
spec/controllers/projects/project_members_controller_spec.rb
+8
-8
spec/controllers/projects/prometheus_controller_spec.rb
spec/controllers/projects/prometheus_controller_spec.rb
+3
-3
spec/controllers/projects/raw_controller_spec.rb
spec/controllers/projects/raw_controller_spec.rb
+5
-5
spec/controllers/projects/registry/repositories_controller_spec.rb
...rollers/projects/registry/repositories_controller_spec.rb
+6
-6
spec/controllers/projects/registry/tags_controller_spec.rb
spec/controllers/projects/registry/tags_controller_spec.rb
+3
-3
spec/controllers/projects/repositories_controller_spec.rb
spec/controllers/projects/repositories_controller_spec.rb
+1
-1
spec/controllers/projects/runners_controller_spec.rb
spec/controllers/projects/runners_controller_spec.rb
+4
-4
spec/controllers/projects/services_controller_spec.rb
spec/controllers/projects/services_controller_spec.rb
+1
-1
spec/controllers/projects/settings/ci_cd_controller_spec.rb
spec/controllers/projects/settings/ci_cd_controller_spec.rb
+1
-1
spec/controllers/projects/settings/integrations_controller_spec.rb
...rollers/projects/settings/integrations_controller_spec.rb
+1
-1
spec/controllers/projects/settings/repository_controller_spec.rb
...ntrollers/projects/settings/repository_controller_spec.rb
+1
-1
spec/controllers/projects/snippets_controller_spec.rb
spec/controllers/projects/snippets_controller_spec.rb
+9
-9
spec/controllers/projects/todos_controller_spec.rb
spec/controllers/projects/todos_controller_spec.rb
+10
-10
spec/controllers/projects/tree_controller_spec.rb
spec/controllers/projects/tree_controller_spec.rb
+1
-1
spec/controllers/projects/uploads_controller_spec.rb
spec/controllers/projects/uploads_controller_spec.rb
+11
-11
spec/controllers/projects/variables_controller_spec.rb
spec/controllers/projects/variables_controller_spec.rb
+1
-1
spec/controllers/projects_controller_spec.rb
spec/controllers/projects_controller_spec.rb
+27
-27
spec/controllers/sent_notifications_controller_spec.rb
spec/controllers/sent_notifications_controller_spec.rb
+1
-1
spec/controllers/sessions_controller_spec.rb
spec/controllers/sessions_controller_spec.rb
+2
-2
spec/controllers/snippets/notes_controller_spec.rb
spec/controllers/snippets/notes_controller_spec.rb
+10
-10
spec/controllers/snippets_controller_spec.rb
spec/controllers/snippets_controller_spec.rb
+13
-13
spec/controllers/uploads_controller_spec.rb
spec/controllers/uploads_controller_spec.rb
+20
-20
spec/controllers/users_controller_spec.rb
spec/controllers/users_controller_spec.rb
+6
-6
spec/features/profiles/chat_names_spec.rb
spec/features/profiles/chat_names_spec.rb
+2
-2
spec/features/profiles/password_spec.rb
spec/features/profiles/password_spec.rb
+2
-2
spec/features/projects/badges/coverage_spec.rb
spec/features/projects/badges/coverage_spec.rb
+1
-1
spec/features/projects/environments/environment_spec.rb
spec/features/projects/environments/environment_spec.rb
+1
-1
spec/features/projects/jobs_spec.rb
spec/features/projects/jobs_spec.rb
+1
-1
spec/features/projects/pipelines/pipelines_spec.rb
spec/features/projects/pipelines/pipelines_spec.rb
+1
-1
spec/requests/api/access_requests_spec.rb
spec/requests/api/access_requests_spec.rb
+14
-14
spec/requests/api/award_emoji_spec.rb
spec/requests/api/award_emoji_spec.rb
+27
-27
spec/requests/api/boards_spec.rb
spec/requests/api/boards_spec.rb
+17
-17
spec/requests/api/broadcast_messages_spec.rb
spec/requests/api/broadcast_messages_spec.rb
+19
-19
spec/requests/api/circuit_breakers_spec.rb
spec/requests/api/circuit_breakers_spec.rb
+5
-5
spec/requests/api/commit_statuses_spec.rb
spec/requests/api/commit_statuses_spec.rb
+19
-19
spec/requests/api/commits_spec.rb
spec/requests/api/commits_spec.rb
+16
-16
spec/requests/api/deploy_keys_spec.rb
spec/requests/api/deploy_keys_spec.rb
+15
-15
spec/requests/api/deployments_spec.rb
spec/requests/api/deployments_spec.rb
+4
-4
spec/requests/api/doorkeeper_access_spec.rb
spec/requests/api/doorkeeper_access_spec.rb
+5
-5
spec/requests/api/environments_spec.rb
spec/requests/api/environments_spec.rb
+17
-17
spec/requests/api/events_spec.rb
spec/requests/api/events_spec.rb
+12
-12
spec/requests/api/features_spec.rb
spec/requests/api/features_spec.rb
+17
-17
spec/requests/api/files_spec.rb
spec/requests/api/files_spec.rb
+22
-22
spec/requests/api/group_variables_spec.rb
spec/requests/api/group_variables_spec.rb
+20
-20
spec/requests/api/groups_spec.rb
spec/requests/api/groups_spec.rb
+60
-60
spec/requests/api/internal_spec.rb
spec/requests/api/internal_spec.rb
+39
-39
spec/requests/api/issues_spec.rb
spec/requests/api/issues_spec.rb
+80
-80
spec/requests/api/jobs_spec.rb
spec/requests/api/jobs_spec.rb
+40
-40
spec/requests/api/keys_spec.rb
spec/requests/api/keys_spec.rb
+3
-3
spec/requests/api/labels_spec.rb
spec/requests/api/labels_spec.rb
+32
-32
spec/requests/api/lint_spec.rb
spec/requests/api/lint_spec.rb
+4
-4
spec/requests/api/members_spec.rb
spec/requests/api/members_spec.rb
+22
-22
spec/requests/api/merge_request_diffs_spec.rb
spec/requests/api/merge_request_diffs_spec.rb
+5
-5
spec/requests/api/merge_requests_spec.rb
spec/requests/api/merge_requests_spec.rb
+6
-6
spec/requests/api/namespaces_spec.rb
spec/requests/api/namespaces_spec.rb
+6
-6
spec/requests/api/notes_spec.rb
spec/requests/api/notes_spec.rb
+46
-46
spec/requests/api/notification_settings_spec.rb
spec/requests/api/notification_settings_spec.rb
+8
-8
spec/requests/api/oauth_tokens_spec.rb
spec/requests/api/oauth_tokens_spec.rb
+4
-4
spec/requests/api/pipeline_schedules_spec.rb
spec/requests/api/pipeline_schedules_spec.rb
+36
-36
spec/requests/api/pipelines_spec.rb
spec/requests/api/pipelines_spec.rb
+32
-32
spec/requests/api/project_hooks_spec.rb
spec/requests/api/project_hooks_spec.rb
+19
-19
spec/requests/api/project_snippets_spec.rb
spec/requests/api/project_snippets_spec.rb
+17
-17
spec/requests/api/projects_spec.rb
spec/requests/api/projects_spec.rb
+128
-128
spec/requests/api/repositories_spec.rb
spec/requests/api/repositories_spec.rb
+12
-12
spec/requests/api/runner_spec.rb
spec/requests/api/runner_spec.rb
+61
-61
spec/requests/api/runners_spec.rb
spec/requests/api/runners_spec.rb
+49
-49
spec/requests/api/services_spec.rb
spec/requests/api/services_spec.rb
+12
-12
spec/requests/api/session_spec.rb
spec/requests/api/session_spec.rb
+8
-8
spec/requests/api/settings_spec.rb
spec/requests/api/settings_spec.rb
+4
-4
spec/requests/api/sidekiq_metrics_spec.rb
spec/requests/api/sidekiq_metrics_spec.rb
+4
-4
spec/requests/api/snippets_spec.rb
spec/requests/api/snippets_spec.rb
+19
-19
spec/requests/api/system_hooks_spec.rb
spec/requests/api/system_hooks_spec.rb
+10
-10
spec/requests/api/templates_spec.rb
spec/requests/api/templates_spec.rb
+6
-6
spec/requests/api/todos_spec.rb
spec/requests/api/todos_spec.rb
+6
-6
spec/requests/api/triggers_spec.rb
spec/requests/api/triggers_spec.rb
+32
-32
spec/requests/api/users_spec.rb
spec/requests/api/users_spec.rb
+172
-172
spec/requests/api/v3/award_emoji_spec.rb
spec/requests/api/v3/award_emoji_spec.rb
+27
-27
spec/requests/api/v3/boards_spec.rb
spec/requests/api/v3/boards_spec.rb
+8
-8
spec/requests/api/v3/branches_spec.rb
spec/requests/api/v3/branches_spec.rb
+12
-12
spec/requests/api/v3/broadcast_messages_spec.rb
spec/requests/api/v3/broadcast_messages_spec.rb
+3
-3
spec/requests/api/v3/builds_spec.rb
spec/requests/api/v3/builds_spec.rb
+29
-29
spec/requests/api/v3/commits_spec.rb
spec/requests/api/v3/commits_spec.rb
+41
-41
spec/requests/api/v3/deploy_keys_spec.rb
spec/requests/api/v3/deploy_keys_spec.rb
+13
-13
spec/requests/api/v3/deployments_spec.rb
spec/requests/api/v3/deployments_spec.rb
+4
-4
spec/requests/api/v3/environments_spec.rb
spec/requests/api/v3/environments_spec.rb
+14
-14
spec/requests/api/v3/files_spec.rb
spec/requests/api/v3/files_spec.rb
+14
-14
spec/requests/api/v3/groups_spec.rb
spec/requests/api/v3/groups_spec.rb
+57
-57
spec/requests/api/v3/issues_spec.rb
spec/requests/api/v3/issues_spec.rb
+118
-118
spec/requests/api/v3/labels_spec.rb
spec/requests/api/v3/labels_spec.rb
+12
-12
spec/requests/api/v3/members_spec.rb
spec/requests/api/v3/members_spec.rb
+22
-22
spec/requests/api/v3/merge_request_diffs_spec.rb
spec/requests/api/v3/merge_request_diffs_spec.rb
+2
-2
spec/requests/api/v3/merge_requests_spec.rb
spec/requests/api/v3/merge_requests_spec.rb
+60
-60
spec/requests/api/v3/milestones_spec.rb
spec/requests/api/v3/milestones_spec.rb
+23
-23
spec/requests/api/v3/notes_spec.rb
spec/requests/api/v3/notes_spec.rb
+44
-44
spec/requests/api/v3/pipelines_spec.rb
spec/requests/api/v3/pipelines_spec.rb
+13
-13
spec/requests/api/v3/project_hooks_spec.rb
spec/requests/api/v3/project_hooks_spec.rb
+20
-20
spec/requests/api/v3/project_snippets_spec.rb
spec/requests/api/v3/project_snippets_spec.rb
+13
-13
spec/requests/api/v3/projects_spec.rb
spec/requests/api/v3/projects_spec.rb
+112
-112
spec/requests/api/v3/repositories_spec.rb
spec/requests/api/v3/repositories_spec.rb
+12
-12
spec/requests/api/v3/runners_spec.rb
spec/requests/api/v3/runners_spec.rb
+14
-14
spec/requests/api/v3/services_spec.rb
spec/requests/api/v3/services_spec.rb
+1
-1
spec/requests/api/v3/settings_spec.rb
spec/requests/api/v3/settings_spec.rb
+4
-4
spec/requests/api/v3/snippets_spec.rb
spec/requests/api/v3/snippets_spec.rb
+14
-14
spec/requests/api/v3/system_hooks_spec.rb
spec/requests/api/v3/system_hooks_spec.rb
+5
-5
spec/requests/api/v3/tags_spec.rb
spec/requests/api/v3/tags_spec.rb
+5
-5
spec/requests/api/v3/templates_spec.rb
spec/requests/api/v3/templates_spec.rb
+6
-6
spec/requests/api/v3/triggers_spec.rb
spec/requests/api/v3/triggers_spec.rb
+24
-24
spec/requests/api/v3/users_spec.rb
spec/requests/api/v3/users_spec.rb
+26
-26
spec/requests/api/variables_spec.rb
spec/requests/api/variables_spec.rb
+20
-20
spec/requests/api/wikis_spec.rb
spec/requests/api/wikis_spec.rb
+11
-11
spec/requests/git_http_spec.rb
spec/requests/git_http_spec.rb
+44
-44
spec/requests/jwt_controller_spec.rb
spec/requests/jwt_controller_spec.rb
+10
-10
spec/requests/lfs_http_spec.rb
spec/requests/lfs_http_spec.rb
+54
-54
spec/requests/openid_connect_spec.rb
spec/requests/openid_connect_spec.rb
+1
-1
spec/requests/projects/cycle_analytics_events_spec.rb
spec/requests/projects/cycle_analytics_events_spec.rb
+3
-3
spec/support/api/issues_resolving_discussions_shared_examples.rb
...pport/api/issues_resolving_discussions_shared_examples.rb
+1
-1
spec/support/api/members_shared_examples.rb
spec/support/api/members_shared_examples.rb
+1
-1
spec/support/api/milestones_shared_examples.rb
spec/support/api/milestones_shared_examples.rb
+33
-33
spec/support/api/scopes/read_user_shared_examples.rb
spec/support/api/scopes/read_user_shared_examples.rb
+7
-7
spec/support/api/time_tracking_shared_examples.rb
spec/support/api/time_tracking_shared_examples.rb
+9
-9
spec/support/api/v3/time_tracking_shared_examples.rb
spec/support/api/v3/time_tracking_shared_examples.rb
+9
-9
spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb
...xamples/requests/api/custom_attributes_shared_examples.rb
+7
-7
spec/support/unique_ip_check_shared_examples.rb
spec/support/unique_ip_check_shared_examples.rb
+4
-4
No files found.
changelogs/unreleased/35644-refactor-have-http-status-into-have-gitlab-http-status.yml
0 → 100644
View file @
2f40dac3
---
title
:
Refactor have_http_status into have_gitlab_http_status
merge_request
:
14958
author
:
Jacopo Beschi @jacopo-beschi
type
:
added
spec/controllers/admin/hooks_controller_spec.rb
View file @
2f40dac3
...
...
@@ -20,7 +20,7 @@
post
:create
,
hook:
hook_params
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
expect
(
SystemHook
.
all
.
size
).
to
eq
(
1
)
expect
(
SystemHook
.
first
).
to
have_attributes
(
hook_params
)
end
...
...
spec/controllers/admin/impersonations_controller_spec.rb
View file @
2f40dac3
...
...
@@ -22,7 +22,7 @@
it
"responds with status 404"
do
delete
:destroy
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
it
"doesn't sign us in"
do
...
...
@@ -46,7 +46,7 @@
it
"responds with status 404"
do
delete
:destroy
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
it
"doesn't sign us in as the impersonator"
do
...
...
@@ -65,7 +65,7 @@
it
"responds with status 404"
do
delete
:destroy
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
it
"doesn't sign us in as the impersonator"
do
...
...
spec/controllers/admin/projects_controller_spec.rb
View file @
2f40dac3
...
...
@@ -27,7 +27,7 @@
get
:index
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
expect
(
response
.
body
).
not_to
match
(
pending_delete_project
.
name
)
expect
(
response
.
body
).
to
match
(
project
.
name
)
end
...
...
spec/controllers/admin/runners_controller_spec.rb
View file @
2f40dac3
...
...
@@ -11,7 +11,7 @@
it
'lists all runners'
do
get
:index
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
end
...
...
@@ -19,13 +19,13 @@
it
'shows a particular runner'
do
get
:show
,
id:
runner
.
id
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
it
'shows 404 for unknown runner'
do
get
:show
,
id:
0
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
...
...
@@ -39,7 +39,7 @@
runner
.
reload
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
expect
(
runner
.
description
).
to
eq
(
new_desc
)
end
end
...
...
@@ -48,7 +48,7 @@
it
'destroys the runner'
do
delete
:destroy
,
id:
runner
.
id
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
expect
(
Ci
::
Runner
.
find_by
(
id:
runner
.
id
)).
to
be_nil
end
end
...
...
@@ -63,7 +63,7 @@
runner
.
reload
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
expect
(
runner
.
active
).
to
eq
(
true
)
end
end
...
...
@@ -78,7 +78,7 @@
runner
.
reload
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
expect
(
runner
.
active
).
to
eq
(
false
)
end
end
...
...
spec/controllers/admin/services_controller_spec.rb
View file @
2f40dac3
...
...
@@ -20,7 +20,7 @@
it
'successfully displays the template'
do
get
:edit
,
id:
service
.
id
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
end
end
...
...
@@ -46,7 +46,7 @@
put
:update
,
id:
service
.
id
,
service:
{
active:
true
}
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
end
it
'does not call the propagation worker when service is not active'
do
...
...
@@ -54,7 +54,7 @@
put
:update
,
id:
service
.
id
,
service:
{
properties:
{}
}
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
end
end
end
spec/controllers/admin/spam_logs_controller_spec.rb
View file @
2f40dac3
...
...
@@ -14,7 +14,7 @@
it
'lists all spam logs'
do
get
:index
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
end
...
...
@@ -22,14 +22,14 @@
it
'removes only the spam log when removing log'
do
expect
{
delete
:destroy
,
id:
first_spam
.
id
}.
to
change
{
SpamLog
.
count
}.
by
(
-
1
)
expect
(
User
.
find
(
user
.
id
)).
to
be_truthy
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
it
'removes user and his spam logs when removing the user'
do
delete
:destroy
,
id:
first_spam
.
id
,
remove_user:
true
expect
(
flash
[
:notice
]).
to
eq
"User
#{
user
.
username
}
was successfully removed."
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
expect
(
SpamLog
.
count
).
to
eq
(
0
)
expect
{
User
.
find
(
user
.
id
)
}.
to
raise_error
(
ActiveRecord
::
RecordNotFound
)
end
...
...
@@ -42,7 +42,7 @@
it
'submits the log as ham'
do
post
:mark_as_ham
,
id:
first_spam
.
id
expect
(
response
).
to
have_http_status
(
302
)
expect
(
response
).
to
have_
gitlab_
http_status
(
302
)
expect
(
SpamLog
.
find
(
first_spam
.
id
).
submitted_as_ham
).
to
be_truthy
end
end
...
...
spec/controllers/admin/users_controller_spec.rb
View file @
2f40dac3
...
...
@@ -19,7 +19,7 @@
it
'deletes user and ghosts their contributions'
do
delete
:destroy
,
id:
user
.
username
,
format: :json
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
expect
(
User
.
exists?
(
user
.
id
)).
to
be_falsy
expect
(
issue
.
reload
.
author
).
to
be_ghost
end
...
...
@@ -27,7 +27,7 @@
it
'deletes the user and their contributions when hard delete is specified'
do
delete
:destroy
,
id:
user
.
username
,
hard_delete:
true
,
format: :json
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
expect
(
User
.
exists?
(
user
.
id
)).
to
be_falsy
expect
(
Issue
.
exists?
(
issue
.
id
)).
to
be_falsy
end
...
...
spec/controllers/application_controller_spec.rb
View file @
2f40dac3
...
...
@@ -61,7 +61,7 @@ def index
context
"when the 'private_token' param is populated with the private token"
do
it
"logs the user in"
do
get
:index
,
private_token:
user
.
private_token
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
expect
(
response
.
body
).
to
eq
(
"authenticated"
)
end
end
...
...
@@ -70,7 +70,7 @@ def index
it
"logs the user in"
do
@request
.
headers
[
'PRIVATE-TOKEN'
]
=
user
.
private_token
get
:index
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
expect
(
response
.
body
).
to
eq
(
"authenticated"
)
end
end
...
...
@@ -95,7 +95,7 @@ def index
context
"when the 'personal_access_token' param is populated with the personal access token"
do
it
"logs the user in"
do
get
:index
,
private_token:
personal_access_token
.
token
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
expect
(
response
.
body
).
to
eq
(
'authenticated'
)
end
end
...
...
@@ -104,7 +104,7 @@ def index
it
"logs the user in"
do
@request
.
headers
[
"PRIVATE-TOKEN"
]
=
personal_access_token
.
token
get
:index
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
expect
(
response
.
body
).
to
eq
(
'authenticated'
)
end
end
...
...
@@ -158,7 +158,7 @@ def index
it
'returns 200 response'
do
get
:index
,
private_token:
user
.
private_token
,
format:
requested_format
expect
(
response
).
to
have_http_status
200
expect
(
response
).
to
have_
gitlab_
http_status
200
end
end
...
...
@@ -166,7 +166,7 @@ def index
it
'returns 404 response'
do
get
:index
,
private_token:
user
.
private_token
expect
(
response
).
to
have_http_status
404
expect
(
response
).
to
have_
gitlab_
http_status
404
end
end
end
...
...
@@ -183,7 +183,7 @@ def index
context
'when the request format is atom'
do
it
"logs the user in"
do
get
:index
,
rss_token:
user
.
rss_token
,
format: :atom
expect
(
response
).
to
have_http_status
200
expect
(
response
).
to
have_
gitlab_
http_status
200
expect
(
response
.
body
).
to
eq
'authenticated'
end
end
...
...
@@ -191,7 +191,7 @@ def index
context
'when the request format is not atom'
do
it
"doesn't log the user in"
do
get
:index
,
rss_token:
user
.
rss_token
expect
(
response
.
status
).
not_to
have_http_status
200
expect
(
response
.
status
).
not_to
have_
gitlab_
http_status
200
expect
(
response
.
body
).
not_to
eq
'authenticated'
end
end
...
...
spec/controllers/autocomplete_controller_spec.rb
View file @
2f40dac3
...
...
@@ -30,7 +30,7 @@
get
(
:users
,
project_id:
'unknown'
)
end
it
{
expect
(
response
).
to
have_http_status
(
404
)
}
it
{
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
}
end
end
...
...
@@ -59,7 +59,7 @@
get
(
:users
,
group_id:
'unknown'
)
end
it
{
expect
(
response
).
to
have_http_status
(
404
)
}
it
{
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
}
end
end
...
...
@@ -138,7 +138,7 @@
get
(
:users
,
project_id:
project
.
id
)
end
it
{
expect
(
response
).
to
have_http_status
(
404
)
}
it
{
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
}
end
describe
'GET #users with unknown project'
do
...
...
@@ -146,7 +146,7 @@
get
(
:users
,
project_id:
'unknown'
)
end
it
{
expect
(
response
).
to
have_http_status
(
404
)
}
it
{
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
}
end
describe
'GET #users with inaccessible group'
do
...
...
@@ -155,7 +155,7 @@
get
(
:users
,
group_id:
user
.
namespace
.
id
)
end
it
{
expect
(
response
).
to
have_http_status
(
404
)
}
it
{
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
}
end
describe
'GET #users with no project'
do
...
...
spec/controllers/boards/issues_controller_spec.rb
View file @
2f40dac3
...
...
@@ -24,7 +24,7 @@
it
'returns a not found 404 response'
do
list_issues
user:
user
,
board:
999
,
list:
list2
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
...
...
@@ -62,7 +62,7 @@
it
'returns a not found 404 response'
do
list_issues
user:
user
,
board:
board
,
list:
999
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
end
...
...
@@ -93,7 +93,7 @@
it
'returns a forbidden 403 response'
do
list_issues
user:
user
,
board:
board
,
list:
list2
expect
(
response
).
to
have_http_status
(
403
)
expect
(
response
).
to
have_
gitlab_
http_status
(
403
)
end
end
...
...
@@ -116,7 +116,7 @@ def list_issues(user:, board:, list: nil)
it
'returns a successful 200 response'
do
create_issue
user:
user
,
board:
board
,
list:
list1
,
title:
'New issue'
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
it
'returns the created issue'
do
...
...
@@ -131,7 +131,7 @@ def list_issues(user:, board:, list: nil)
it
'returns an unprocessable entity 422 response'
do
create_issue
user:
user
,
board:
board
,
list:
list1
,
title:
nil
expect
(
response
).
to
have_http_status
(
422
)
expect
(
response
).
to
have_
gitlab_
http_status
(
422
)
end
end
...
...
@@ -141,7 +141,7 @@ def list_issues(user:, board:, list: nil)
create_issue
user:
user
,
board:
board
,
list:
list
,
title:
'New issue'
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
...
...
@@ -149,7 +149,7 @@ def list_issues(user:, board:, list: nil)
it
'returns a not found 404 response'
do
create_issue
user:
user
,
board:
999
,
list:
list1
,
title:
'New issue'
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
...
...
@@ -157,7 +157,7 @@ def list_issues(user:, board:, list: nil)
it
'returns a not found 404 response'
do
create_issue
user:
user
,
board:
board
,
list:
999
,
title:
'New issue'
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
end
...
...
@@ -166,7 +166,7 @@ def list_issues(user:, board:, list: nil)
it
'returns a forbidden 403 response'
do
create_issue
user:
guest
,
board:
board
,
list:
list1
,
title:
'New issue'
expect
(
response
).
to
have_http_status
(
403
)
expect
(
response
).
to
have_
gitlab_
http_status
(
403
)
end
end
...
...
@@ -187,7 +187,7 @@ def create_issue(user:, board:, list:, title:)
it
'returns a successful 200 response'
do
move
user:
user
,
board:
board
,
issue:
issue
,
from_list_id:
list1
.
id
,
to_list_id:
list2
.
id
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
it
'moves issue to the desired list'
do
...
...
@@ -201,19 +201,19 @@ def create_issue(user:, board:, list:, title:)
it
'returns a unprocessable entity 422 response for invalid lists'
do
move
user:
user
,
board:
board
,
issue:
issue
,
from_list_id:
nil
,
to_list_id:
nil
expect
(
response
).
to
have_http_status
(
422
)
expect
(
response
).
to
have_
gitlab_
http_status
(
422
)
end
it
'returns a not found 404 response for invalid board id'
do
move
user:
user
,
board:
999
,
issue:
issue
,
from_list_id:
list1
.
id
,
to_list_id:
list2
.
id
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
it
'returns a not found 404 response for invalid issue id'
do
move
user:
user
,
board:
board
,
issue:
double
(
id:
999
),
from_list_id:
list1
.
id
,
to_list_id:
list2
.
id
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
...
...
@@ -227,7 +227,7 @@ def create_issue(user:, board:, list:, title:)
it
'returns a forbidden 403 response'
do
move
user:
guest
,
board:
board
,
issue:
issue
,
from_list_id:
list1
.
id
,
to_list_id:
list2
.
id
expect
(
response
).
to
have_http_status
(
403
)
expect
(
response
).
to
have_
gitlab_
http_status
(
403
)
end
end
...
...
spec/controllers/boards/lists_controller_spec.rb
View file @
2f40dac3
...
...
@@ -15,7 +15,7 @@
it
'returns a successful 200 response'
do
read_board_list
user:
user
,
board:
board
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
expect
(
response
.
content_type
).
to
eq
'application/json'
end
...
...
@@ -39,7 +39,7 @@
it
'returns a forbidden 403 response'
do
read_board_list
user:
user
,
board:
board
expect
(
response
).
to
have_http_status
(
403
)
expect
(
response
).
to
have_
gitlab_
http_status
(
403
)
end
end
...
...
@@ -60,7 +60,7 @@ def read_board_list(user:, board:)
it
'returns a successful 200 response'
do
create_board_list
user:
user
,
board:
board
,
label_id:
label
.
id
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
it
'returns the created list'
do
...
...
@@ -75,7 +75,7 @@ def read_board_list(user:, board:)
it
'returns a not found 404 response'
do
create_board_list
user:
user
,
board:
board
,
label_id:
nil
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
...
...
@@ -85,7 +85,7 @@ def read_board_list(user:, board:)
create_board_list
user:
user
,
board:
board
,
label_id:
label
.
id
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
end
...
...
@@ -96,7 +96,7 @@ def read_board_list(user:, board:)
create_board_list
user:
guest
,
board:
board
,
label_id:
label
.
id
expect
(
response
).
to
have_http_status
(
403
)
expect
(
response
).
to
have_
gitlab_
http_status
(
403
)
end
end
...
...
@@ -119,7 +119,7 @@ def create_board_list(user:, board:, label_id:)
it
'returns a successful 200 response'
do
move
user:
user
,
board:
board
,
list:
planning
,
position:
1
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
it
'moves the list to the desired position'
do
...
...
@@ -133,7 +133,7 @@ def create_board_list(user:, board:, label_id:)
it
'returns an unprocessable entity 422 response'
do
move
user:
user
,
board:
board
,
list:
planning
,
position:
6
expect
(
response
).
to
have_http_status
(
422
)
expect
(
response
).
to
have_
gitlab_
http_status
(
422
)
end
end
...
...
@@ -141,7 +141,7 @@ def create_board_list(user:, board:, label_id:)
it
'returns a not found 404 response'
do
move
user:
user
,
board:
board
,
list:
999
,
position:
1
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
...
...
@@ -149,7 +149,7 @@ def create_board_list(user:, board:, label_id:)
it
'returns a forbidden 403 response'
do
move
user:
guest
,
board:
board
,
list:
planning
,
position:
6
expect
(
response
).
to
have_http_status
(
403
)
expect
(
response
).
to
have_
gitlab_
http_status
(
403
)
end
end
...
...
@@ -172,7 +172,7 @@ def move(user:, board:, list:, position:)
it
'returns a successful 200 response'
do
remove_board_list
user:
user
,
board:
board
,
list:
planning
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
it
'removes list from board'
do
...
...
@@ -184,7 +184,7 @@ def move(user:, board:, list:, position:)
it
'returns a not found 404 response'
do
remove_board_list
user:
user
,
board:
board
,
list:
999
expect
(
response
).
to
have_http_status
(
404
)
expect
(
response
).
to
have_
gitlab_
http_status
(
404
)
end
end
...
...
@@ -192,7 +192,7 @@ def move(user:, board:, list:, position:)
it
'returns a forbidden 403 response'
do
remove_board_list
user:
guest
,
board:
board
,
list:
planning
expect
(
response
).
to
have_http_status
(
403
)
expect
(
response
).
to
have_
gitlab_
http_status
(
403
)
end
end
...
...
@@ -212,7 +212,7 @@ def remove_board_list(user:, board:, list:)
it
'returns a successful 200 response'
do
generate_default_lists
user:
user
,
board:
board
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_
gitlab_
http_status
(
200
)
end
it
'returns the defaults lists'
do
...
...
@@ -228,7 +228,7 @@ def remove_board_list(user:, board:, list:)
generate_default_lists
user:
user
,
board:
board
expect
(
response
).
to
have_http_status
(
422
)
expect
(
response
).
to
have_
gitlab_
http_status
(
422
)
end
end
...
...
@@ -236,7 +236,7 @@ def remove_board_list(user:, board:, list:)
it
'returns a forbidden 403 response'
do
generate_default_lists
user:
guest
,
board:
board
expect
(
response
).
to
have_http_status
(
403
)
expect
(
response
).
to
have_
gitlab_
http_status
(
403
)
end
end
...
...
spec/controllers/dashboard/milestones_controller_spec.rb
View file @
2f40dac3
...
...
@@ -32,7 +32,7 @@ def view_milestone
it
'shows milestone page'
do
view_milestone