GitLab steht wegen Wartungsarbeiten am Montag, den 10. Mai, zwischen 17:00 und 19:00 Uhr nicht zur Verfügung.

Commit 1bd140ca authored by Phil Hughes's avatar Phil Hughes

Merge branch '35164-cycle-analytics-firefox' into 'master'

move click handler to button. when on the icon it wasn't triggered in firefox

Closes #35164

See merge request !12905
parents 5c4f99a3 a8f22ddf
......@@ -9,8 +9,8 @@
#cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } }
- if @cycle_analytics_no_data
.landing.content-block{ "v-if" => "!isOverviewDialogDismissed" }
%button.dismiss-button{ type: 'button', 'aria-label': 'Dismiss Cycle Analytics introduction box' }
= icon("times", "@click" => "dismissOverviewDialog()")
%button.dismiss-button{ type: 'button', 'aria-label': 'Dismiss Cycle Analytics introduction box', "@click" => "dismissOverviewDialog()" }
= icon("times")
.svg-container
= custom_icon('icon_cycle_analytics_splash')
.inner-content
......
---
title: allow closing Cycle Analytics intro box in firefox
merge_request:
author:
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment