• Douwe Maan's avatar
    Merge branch 'new-mr-disable-change-target-branch' into 'master' · 07956981
    Douwe Maan authored
    Disable changing of target branch in new merge request page when a branch has already been specified
    
    ### What does this MR do?
    
    This MR prevents a user from changing the target branch inside a new merge request page if the target branch has already been specified (e.g. from the shortcut in the activity feed). A link to "Change branches" is provided to allow the user to do this properly.
    
    ### Why was this MR needed?
    
    If a user attempted to create a merge request from a shortcut with a pre-specified target branch (e.g. `master`), the dropdown would suggest that the user could change the branch. However, this did not actually work due to duplicate data elements (see #1830 for more details), and the target branch would always be set to the original, default branch. This would lead to confusion, potentially causing an improper merge request to be created.
    
    ### What are the relevant issue numbers?
    
    Closes #1830
    
    ### Screenshot
    
    ![image](https://gitlab.com/stanhu/gitlab-ce/uploads/eeec4f5d4b66625a14be41e5ecbdc016/image.png)
    
    See merge request !846
    07956981
To find the state of this project's repository at the time of any of these versions, check out the tags.