.rubocop_todo.yml 16.1 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Connor Shea's avatar
Connor Shea committed
2 3
# `rubocop --auto-gen-config --exclude-limit 8`
# on 2016-07-03 15:32:25 -0600 using RuboCop version 0.41.1.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

Connor Shea's avatar
Connor Shea committed
9 10 11 12 13 14 15 16 17
# Offense count: 152
Lint/AmbiguousRegexpLiteral:
  Enabled: false

# Offense count: 42
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
  Enabled: false

Z.J. van de Weg's avatar
Z.J. van de Weg committed
18
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43
Lint/DuplicateMethods:
  Exclude:
    - 'lib/gitlab/github_import/branch_formatter.rb'

# Offense count: 14
Lint/HandleExceptions:
  Enabled: false

# Offense count: 20
Lint/IneffectiveAccessModifier:
  Enabled: false

# Offense count: 2
Lint/Loop:
  Exclude:
    - 'app/mailers/notify.rb'
    - 'lib/gitlab/bitbucket_import/client.rb'

# Offense count: 12
Lint/ShadowingOuterLocalVariable:
  Enabled: false

# Offense count: 3
# Cop supports --auto-correct.
Lint/StringConversionInInterpolation:
Z.J. van de Weg's avatar
Z.J. van de Weg committed
44
  Exclude:
Connor Shea's avatar
Connor Shea committed
45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63
    - 'app/models/commit_range.rb'
    - 'app/services/system_hooks_service.rb'
    - 'app/services/system_note_service.rb'

# Offense count: 42
# Cop supports --auto-correct.
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument:
  Enabled: false

# Offense count: 125
# Cop supports --auto-correct.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
Lint/UnusedMethodArgument:
  Enabled: false

# Offense count: 11
Lint/UselessAccessModifier:
  Enabled: false
Z.J. van de Weg's avatar
Z.J. van de Weg committed
64 65 66 67 68 69 70 71 72 73 74 75 76

# Offense count: 12
# Cop supports --auto-correct.
Performance/PushSplat:
  Exclude:
    - 'app/controllers/projects/refs_controller.rb'
    - 'app/helpers/page_layout_helper.rb'
    - 'app/models/ability.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_team.rb'
    - 'app/models/user.rb'
    - 'config/application.rb'

Connor Shea's avatar
Connor Shea committed
77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
# Offense count: 2
# Cop supports --auto-correct.
Performance/RedundantBlockCall:
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'lib/gitlab/backend/shell.rb'

# Offense count: 5
# Cop supports --auto-correct.
Performance/RedundantMatch:
  Exclude:
    - 'app/models/external_issue.rb'
    - 'lib/extracts_path.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/diff/inline_diff.rb'
    - 'lib/gitlab/diff/parser.rb'

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: MaxKeyValuePairs.
Performance/RedundantMerge:
  Enabled: false

Z.J. van de Weg's avatar
Z.J. van de Weg committed
100 101 102 103
# Offense count: 59
Rails/OutputSafety:
  Enabled: false

Connor Shea's avatar
Connor Shea committed
104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333
# Offense count: 125
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: strict, flexible
Rails/TimeZone:
  Enabled: false

# Offense count: 12
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/Validation:
  Enabled: false

# Offense count: 18
Style/AccessorMethodName:
  Enabled: false

# Offense count: 208
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: with_first_parameter, with_fixed_indentation
Style/AlignParameters:
  Enabled: false

# Offense count: 32
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: always, conditionals
Style/AndOr:
  Enabled: false

# Offense count: 47
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false

# Offense count: 255
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: braces, no_braces, context_dependent
Style/BracesAroundHashParameters:
  Enabled: false

# Offense count: 4
Style/CaseEquality:
  Exclude:
    - 'app/helpers/auth_helper.rb'
    - 'app/models/commit.rb'
    - 'app/services/projects/download_service.rb'
    - 'config/initializers/trusted_proxies.rb'

# Offense count: 19
# Cop supports --auto-correct.
Style/ColonMethodCall:
  Enabled: false

# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: Keywords.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
Style/CommentAnnotation:
  Exclude:
    - 'app/models/project.rb'
    - 'lib/api/entities.rb'
    - 'spec/requests/api/project_snippets_spec.rb'

# Offense count: 35
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment:
  Enabled: false

# Offense count: 762
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: leading, trailing
Style/DotPosition:
  Enabled: false

# Offense count: 14
Style/DoubleNegation:
  Enabled: false

# Offense count: 3
Style/EachWithObject:
  Exclude:
    - 'app/models/commit_status.rb'
    - 'lib/ci/ansi2html.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'

# Offense count: 29
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

# Offense count: 3
# Cop supports --auto-correct.
Style/EmptyLiteral:
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'

# Offense count: 119
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
  Enabled: false

# Offense count: 7
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
  Exclude:
    - 'app/models/ci/pipeline.rb'
    - 'app/services/gravatar_service.rb'
    - 'config/initializers/rack_lineprof.rb'
    - 'lib/ci/version_info.rb'
    - 'lib/gitlab/version_info.rb'
    - 'spec/requests/api/issues_spec.rb'

# Offense count: 50
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

# Offense count: 9
Style/IdenticalConditionalBranches:
  Exclude:
    - 'app/controllers/projects_controller.rb'
    - 'app/models/project_services/irker_service.rb'
    - 'app/services/merge_requests/refresh_service.rb'
    - 'lib/rouge/formatters/html_gitlab.rb'

# Offense count: 10
Style/IfInsideElse:
  Enabled: false

# Offense count: 178
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
  Enabled: false

# Offense count: 48
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray:
  Enabled: false

# Offense count: 85
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash:
  Enabled: false

# Offense count: 11
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
  Exclude:
    - 'app/models/ci/runner.rb'
    - 'app/models/event.rb'
    - 'app/models/note.rb'
    - 'config/routes.rb'
    - 'lib/api/entities.rb'
    - 'spec/models/concerns/participable_spec.rb'

# Offense count: 6
# Cop supports --auto-correct.
Style/LineEndConcatenation:
  Exclude:
    - 'app/helpers/preferences_helper.rb'
    - 'app/helpers/tree_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/user.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'

# Offense count: 13
# Cop supports --auto-correct.
Style/MethodCallParentheses:
  Exclude:
    - 'lib/api/helpers.rb'
    - 'lib/ci/ansi2html.rb'
    - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
    - 'spec/helpers/submodule_helper_spec.rb'
    - 'spec/workers/post_receive_spec.rb'

# Offense count: 9
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: module_function, extend_self
Style/ModuleFunction:
  Enabled: false

# Offense count: 3
Style/MultilineTernaryOperator:
  Exclude:
    - 'lib/banzai/filter/relative_link_filter.rb'
    - 'spec/support/api_helpers.rb'

# Offense count: 62
# Cop supports --auto-correct.
Style/MutableConstant:
  Enabled: false

# Offense count: 10
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
  Exclude:
    - 'app/helpers/commits_helper.rb'
    - 'app/workers/irker_worker.rb'
    - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
    - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
    - 'spec/services/ci/create_builds_service_spec.rb'

# Offense count: 13
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
  Enabled: false

Z.J. van de Weg's avatar
Z.J. van de Weg committed
334 335 336 337 338 339 340 341 342 343 344 345
# Offense count: 6
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
  Exclude:
    - 'config/initializers/1_settings.rb'
    - 'config/initializers/secret_token.rb'
    - 'lib/gitlab/backend/shell.rb'
    - 'spec/support/test_env.rb'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

Connor Shea's avatar
Connor Shea committed
346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381
# Offense count: 29
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

# Offense count: 201
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

# Offense count: 11
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals:
  Exclude:
    - 'spec/helpers/gitlab_markdown_helper_spec.rb'
    - 'spec/lib/gitlab/diff/highlight_spec.rb'
    - 'spec/models/project_services/bamboo_service_spec.rb'
    - 'spec/models/project_services/teamcity_service_spec.rb'
    - 'spec/workers/repository_import_worker_spec.rb'

# Offense count: 14
# Cop supports --auto-correct.
Style/PerlBackrefs:
  Enabled: false

# Offense count: 30
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
Style/PredicateName:
  Enabled: false

Z.J. van de Weg's avatar
Z.J. van de Weg committed
382 383 384
# Offense count: 28
# Cop supports --auto-correct.
Style/PreferredHashMethods:
Connor Shea's avatar
Connor Shea committed
385 386 387 388 389
  Enabled: false

# Offense count: 6
# Cop supports --auto-correct.
Style/Proc:
Z.J. van de Weg's avatar
Z.J. van de Weg committed
390
  Exclude:
Connor Shea's avatar
Connor Shea committed
391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505
    - 'app/mailers/base_mailer.rb'
    - 'app/models/label.rb'
    - 'app/models/service.rb'
    - 'lib/api/api_guard.rb'
    - 'spec/initializers/trusted_proxies_spec.rb'

# Offense count: 21
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

# Offense count: 3
# Cop supports --auto-correct.
Style/RedundantBegin:
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantException:
  Exclude:
    - 'app/helpers/preferences_helper.rb'

# Offense count: 21
# Cop supports --auto-correct.
Style/RedundantFreeze:
  Enabled: false

# Offense count: 312
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

# Offense count: 92
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Style/RescueModifier:
  Enabled: false

# Offense count: 2
# Cop supports --auto-correct.
Style/SelfAssignment:
  Exclude:
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'

# Offense count: 2
# Configuration parameters: Methods.
# Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]}
Style/SingleLineBlockParams:
  Exclude:
    - 'app/models/commit.rb'
    - 'spec/support/services_shared_context.rb'

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
  Exclude:
    - 'lib/ci/ansi2html.rb'

# Offense count: 14
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
Style/SpaceAroundEqualsInParameterDefault:
  Enabled: false

# Offense count: 118
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
Style/SpaceBeforeBlockBraces:
  Enabled: false

# Offense count: 11
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
  Exclude:
    - 'config/initializers/doorkeeper.rb'
    - 'config/routes.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/delete_user_service_spec.rb'
    - 'spec/services/projects/fork_service_spec.rb'
    - 'spec/services/system_note_service_spec.rb'

# Offense count: 129
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces:
  Enabled: false

# Offense count: 92
# Cop supports --auto-correct.
Style/SpaceInsideBrackets:
  Enabled: false

# Offense count: 60
# Cop supports --auto-correct.
Style/SpaceInsideParens:
  Enabled: false
Z.J. van de Weg's avatar
Z.J. van de Weg committed
506 507 508 509 510 511 512

# Offense count: 5
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
  Exclude:
    - 'lib/event_filter.rb'
    - 'lib/gitlab/git_access.rb'
Connor Shea's avatar
Connor Shea committed
513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598

# Offense count: 33
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

# Offense count: 30
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
  Enabled: false

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

# Offense count: 23
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
  Enabled: false

# Offense count: 117
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInLiteral:
  Enabled: false

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/controllers/projects/git_http_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/gitlab/force_push_check.rb'
    - 'lib/gitlab/logger.rb'

# Offense count: 89
# Cop supports --auto-correct.
Style/TrailingWhitespace:
  Enabled: false

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
  Exclude:
    - 'app/models/external_issue.rb'
    - 'lib/gitlab/ldap/person.rb'

# Offense count: 3
# Cop supports --auto-correct.
Style/UnlessElse:
  Exclude:
    - 'lib/api/projects.rb'
    - 'lib/gitlab/backend/grack_auth.rb'
    - 'lib/gitlab/project_search_results.rb'

# Offense count: 14
# Cop supports --auto-correct.
Style/UnneededInterpolation:
  Enabled: false

# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/models/repository.rb'
    - 'lib/extracts_path.rb'
    - 'lib/gitlab/force_push_check.rb'