.rubocop_todo.yml 27.4 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
2 3
# `rubocop --auto-gen-config`
# on 2017-01-05 14:31:09 -0800 using RuboCop version 0.46.0.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9 10 11 12 13 14 15 16
# Offense count: 28
# Configuration parameters: Include.
# Include: **/Gemfile, **/gems.rb
Bundler/OrderedGems:
  Exclude:
    - 'Gemfile'

# Offense count: 174
Connor Shea's avatar
Connor Shea committed
17 18 19
Lint/AmbiguousRegexpLiteral:
  Enabled: false

20
# Offense count: 53
Connor Shea's avatar
Connor Shea committed
21 22 23 24
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
  Enabled: false

25 26 27 28 29 30
# Offense count: 1
Lint/EmptyWhen:
  Exclude:
    - 'lib/gitlab/diff/parser.rb'

# Offense count: 20
Connor Shea's avatar
Connor Shea committed
31 32 33
Lint/HandleExceptions:
  Enabled: false

34
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
35
Lint/Loop:
36 37
  Exclude:
    - 'app/mailers/notify.rb'
Connor Shea's avatar
Connor Shea committed
38

39
# Offense count: 28
Connor Shea's avatar
Connor Shea committed
40 41 42
Lint/ShadowingOuterLocalVariable:
  Enabled: false

43
# Offense count: 10
44 45
# Cop supports --auto-correct.
Lint/UnifiedInteger:
46 47 48 49 50 51
  Exclude:
    - 'spec/lib/gitlab/metrics/method_call_spec.rb'
    - 'spec/lib/gitlab/metrics/metric_spec.rb'
    - 'spec/lib/gitlab/metrics/system_spec.rb'
    - 'spec/lib/gitlab/metrics/transaction_spec.rb'
    - 'spec/models/repository_spec.rb'
52

53
# Offense count: 21
54 55
# Cop supports --auto-correct.
Lint/UnneededSplatExpansion:
56 57 58 59 60 61 62 63 64 65 66 67 68
  Exclude:
    - 'config/application.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/bitbucket/page.rb'
    - 'lib/gitlab/markup_helper.rb'
    - 'spec/helpers/auth_helper_spec.rb'
    - 'spec/models/project_wiki_spec.rb'
    - 'spec/requests/api/projects_spec.rb'
    - 'spec/requests/api/tags_spec.rb'
    - 'spec/support/seed_helper.rb'
    - 'spec/support/test_env.rb'

# Offense count: 82
Connor Shea's avatar
Connor Shea committed
69 70 71 72 73
# Cop supports --auto-correct.
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument:
  Enabled: false

74
# Offense count: 173
Connor Shea's avatar
Connor Shea committed
75 76 77 78 79
# Cop supports --auto-correct.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
Lint/UnusedMethodArgument:
  Enabled: false

80 81 82 83 84 85
# Offense count: 94
# Configuration parameters: CountComments.
Metrics/BlockLength:
  Max: 289

# Offense count: 3
Connor Shea's avatar
Connor Shea committed
86 87
# Cop supports --auto-correct.
Performance/RedundantBlockCall:
88 89 90 91
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'lib/gitlab/backend/shell.rb'
    - 'lib/gitlab/optimistic_locking.rb'
Connor Shea's avatar
Connor Shea committed
92

93
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
94 95
# Cop supports --auto-correct.
Performance/RedundantMatch:
96 97 98 99 100 101
  Exclude:
    - 'app/models/external_issue.rb'
    - 'lib/ci/api/helpers.rb'
    - 'lib/extracts_path.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/diff/parser.rb'
Connor Shea's avatar
Connor Shea committed
102

103
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
104 105 106 107 108
# Cop supports --auto-correct.
# Configuration parameters: MaxKeyValuePairs.
Performance/RedundantMerge:
  Enabled: false

109 110
# Offense count: 7
RSpec/BeEql:
111 112 113 114
  Exclude:
    - 'spec/lib/gitlab/ldap/user_spec.rb'
    - 'spec/lib/gitlab/o_auth/user_spec.rb'
    - 'spec/lib/gitlab/saml/user_spec.rb'
115

116
# Offense count: 15
117 118
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup:
119 120 121 122 123 124 125
  Exclude:
    - 'spec/features/issues_spec.rb'
    - 'spec/features/notes_on_merge_requests_spec.rb'
    - 'spec/lib/gitlab/git_access_spec.rb'
    - 'spec/models/project_snippet_spec.rb'
    - 'spec/models/protected_branch_spec.rb'
    - 'spec/routing/routing_spec.rb'
126

127
# Offense count: 24
128
RSpec/ExpectActual:
129 130
  Exclude:
    - 'spec/lib/gitlab/regex_spec.rb'
131

132
# Offense count: 58
133 134 135 136 137
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Enabled: false

138 139 140 141 142 143 144 145 146 147 148
# Offense count: 12
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should
RSpec/ImplicitExpect:
  Exclude:
    - 'spec/lib/banzai/renderer_spec.rb'
    - 'spec/models/project_group_link_spec.rb'
    - 'spec/models/project_services/external_wiki_service_spec.rb'
    - 'spec/models/project_spec.rb'

# Offense count: 235
149 150 151
RSpec/LeadingSubject:
  Enabled: false

152
# Offense count: 246
153 154 155
RSpec/LetSetup:
  Enabled: false

156
# Offense count: 13
157
RSpec/MessageChain:
158 159 160 161 162 163 164 165 166 167 168
  Exclude:
    - 'spec/finders/move_to_project_finder_spec.rb'
    - 'spec/helpers/issues_helper_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/models/build_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/services/merge_requests/build_service_spec.rb'
    - 'spec/services/notes/create_service_spec.rb'
    - 'spec/workers/emails_on_push_worker_spec.rb'

# Offense count: 468
169
# Configuration parameters: EnforcedStyle, SupportedStyles.
170 171
# SupportedStyles: have_received, receive
RSpec/MessageSpies:
172 173
  Enabled: false

174
# Offense count: 3013
175
RSpec/MultipleExpectations:
176
  Max: 37
177

178
# Offense count: 2072
179 180 181
RSpec/NamedSubject:
  Enabled: false

182
# Offense count: 1949
183 184 185 186
# Configuration parameters: MaxNesting.
RSpec/NestedGroups:
  Enabled: false

187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209
# Offense count: 32
RSpec/RepeatedDescription:
  Exclude:
    - 'spec/controllers/projects/todo_controller_spec.rb'
    - 'spec/features/boards/boards_spec.rb'
    - 'spec/helpers/issuables_helper_spec.rb'
    - 'spec/lib/banzai/filter/emoji_filter_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/global_milestone_spec.rb'
    - 'spec/models/hooks/system_hook_spec.rb'
    - 'spec/requests/api/commits_spec.rb'
    - 'spec/requests/api/merge_requests_spec.rb'
    - 'spec/requests/api/users_spec.rb'
    - 'spec/requests/lfs_http_spec.rb'
    - 'spec/routing/admin_routing_spec.rb'
    - 'spec/services/notification_service_spec.rb'

# Offense count: 1
RSpec/SingleArgumentMessageChain:
  Exclude:
    - 'spec/requests/api/internal_spec.rb'

# Offense count: 125
210 211 212
RSpec/SubjectStub:
  Enabled: false

213 214 215 216 217 218 219 220 221 222 223 224 225 226 227
# Offense count: 104
# Cop supports --auto-correct.
# Configuration parameters: Whitelist.
# Whitelist: find_by_sql
Rails/DynamicFindBy:
  Enabled: false

# Offense count: 929
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: spec/**/*, test/**/*
Rails/HttpPositionalArguments:
  Enabled: false

# Offense count: 55
Z.J. van de Weg's avatar
Z.J. van de Weg committed
228 229 230
Rails/OutputSafety:
  Enabled: false

231
# Offense count: 181
Connor Shea's avatar
Connor Shea committed
232 233 234 235 236
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: strict, flexible
Rails/TimeZone:
  Enabled: false

237
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
238 239 240 241
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/Validation:
242 243 244 245 246 247 248 249 250 251 252
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/ci/runner_project.rb'
    - 'app/models/ci/trigger.rb'
    - 'app/models/commit_status.rb'
    - 'app/models/members/group_member.rb'
    - 'app/models/members/project_member.rb'
    - 'app/models/project.rb'
    - 'app/models/protected_branch.rb'
    - 'app/models/user.rb'
Connor Shea's avatar
Connor Shea committed
253

254
# Offense count: 8
255
# Cop supports --auto-correct.
256
# Configuration parameters: AutoCorrect.
257
Security/JSONLoad:
258 259 260 261 262 263 264
  Exclude:
    - 'db/migrate/20161019190736_migrate_sidekiq_queues_from_default.rb'
    - 'db/migrate/20161024042317_migrate_mailroom_queue_from_default.rb'
    - 'db/migrate/20161124141322_migrate_process_commit_worker_jobs.rb'
    - 'spec/migrations/migrate_process_commit_worker_jobs_spec.rb'
    - 'spec/models/project_services/irker_service_spec.rb'
    - 'spec/support/stub_gitlab_calls.rb'
265

266
# Offense count: 339
Connor Shea's avatar
Connor Shea committed
267 268 269 270 271 272
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: with_first_parameter, with_fixed_indentation
Style/AlignParameters:
  Enabled: false

273
# Offense count: 27
Connor Shea's avatar
Connor Shea committed
274 275 276 277 278 279
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: always, conditionals
Style/AndOr:
  Enabled: false

280
# Offense count: 53
Connor Shea's avatar
Connor Shea committed
281 282 283 284 285 286
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false

287
# Offense count: 354
Connor Shea's avatar
Connor Shea committed
288 289 290 291 292 293
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: braces, no_braces, context_dependent
Style/BracesAroundHashParameters:
  Enabled: false

294
# Offense count: 6
Connor Shea's avatar
Connor Shea committed
295
Style/CaseEquality:
296 297 298 299 300 301 302
  Exclude:
    - 'app/helpers/auth_helper.rb'
    - 'app/models/commit.rb'
    - 'app/models/protected_branch.rb'
    - 'app/services/projects/download_service.rb'
    - 'config/initializers/trusted_proxies.rb'
    - 'spec/features/calendar_spec.rb'
Connor Shea's avatar
Connor Shea committed
303

304
# Offense count: 37
Connor Shea's avatar
Connor Shea committed
305 306 307 308
# Cop supports --auto-correct.
Style/ColonMethodCall:
  Enabled: false

309
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
310 311 312 313
# Cop supports --auto-correct.
# Configuration parameters: Keywords.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
Style/CommentAnnotation:
314 315 316 317 318
  Exclude:
    - 'config/routes/user.rb'
    - 'lib/api/commits.rb'
    - 'lib/api/entities.rb'
    - 'spec/requests/api/project_snippets_spec.rb'
Connor Shea's avatar
Connor Shea committed
319

320
# Offense count: 29
Connor Shea's avatar
Connor Shea committed
321 322 323 324 325 326
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment:
  Enabled: false

327
# Offense count: 1210
Connor Shea's avatar
Connor Shea committed
328 329 330 331 332 333
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: leading, trailing
Style/DotPosition:
  Enabled: false

334
# Offense count: 18
Connor Shea's avatar
Connor Shea committed
335
Style/DoubleNegation:
336 337 338 339 340 341 342 343 344 345 346 347 348 349 350
  Exclude:
    - 'app/controllers/users_controller.rb'
    - 'app/models/commit.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/project.rb'
    - 'app/models/project_services/buildkite_service.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'app/models/project_wiki.rb'
    - 'app/models/user.rb'
    - 'config/initializers/6_validations.rb'
    - 'lib/banzai/filter/relative_link_filter.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/sherlock.rb'
    - 'lib/gitlab/sherlock/middleware.rb'
Connor Shea's avatar
Connor Shea committed
351

352
# Offense count: 7
353
# Cop supports --auto-correct.
Connor Shea's avatar
Connor Shea committed
354
Style/EachWithObject:
355 356 357 358 359 360 361 362
  Exclude:
    - 'app/controllers/projects/cycle_analytics_controller.rb'
    - 'app/services/merge_requests/get_urls_service.rb'
    - 'lib/ci/ansi2html.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
Connor Shea's avatar
Connor Shea committed
363

364
# Offense count: 24
Connor Shea's avatar
Connor Shea committed
365 366 367 368 369 370
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

371
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
372 373
# Cop supports --auto-correct.
Style/EmptyLiteral:
374 375 376 377 378 379 380 381 382 383 384
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'

# Offense count: 57
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
385
  Enabled: false
Connor Shea's avatar
Connor Shea committed
386

387
# Offense count: 145
Connor Shea's avatar
Connor Shea committed
388 389 390 391 392
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
  Enabled: false

393
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
394 395 396
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
397 398 399 400 401 402 403 404 405
  Exclude:
    - 'app/models/ci/pipeline.rb'
    - 'app/services/gravatar_service.rb'
    - 'config/initializers/rack_lineprof.rb'
    - 'lib/gitlab/version_info.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/services/issues/move_service_spec.rb'

# Offense count: 236
Connor Shea's avatar
Connor Shea committed
406 407 408 409
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

410
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
411
Style/IfInsideElse:
412 413 414 415 416 417 418 419 420 421 422 423 424 425
  Exclude:
    - 'app/controllers/projects/forks_controller.rb'
    - 'app/controllers/projects/imports_controller.rb'
    - 'app/helpers/milestones_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/services/system_note_service.rb'
    - 'config/initializers/1_settings.rb'
    - 'lib/gitlab/auth.rb'
    - 'lib/gitlab/checks/change_access.rb'
    - 'lib/gitlab/database.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'

# Offense count: 173
Connor Shea's avatar
Connor Shea committed
426 427 428 429 430
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
  Enabled: false

431
# Offense count: 55
Connor Shea's avatar
Connor Shea committed
432 433 434 435 436 437
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray:
  Enabled: false

438
# Offense count: 99
Connor Shea's avatar
Connor Shea committed
439 440 441 442 443 444
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash:
  Enabled: false

445
# Offense count: 41
Connor Shea's avatar
Connor Shea committed
446 447 448 449
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
450
  Enabled: false
Connor Shea's avatar
Connor Shea committed
451

452
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
453 454
# Cop supports --auto-correct.
Style/LineEndConcatenation:
455 456 457 458 459
  Exclude:
    - 'app/helpers/preferences_helper.rb'
    - 'app/helpers/tree_helper.rb'
    - 'app/models/merge_request.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
Connor Shea's avatar
Connor Shea committed
460

461
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
462 463
# Cop supports --auto-correct.
Style/MethodCallParentheses:
464 465 466 467 468 469 470 471 472 473 474
  Exclude:
    - 'lib/ci/ansi2html.rb'
    - 'spec/controllers/dashboard/todos_controller_spec.rb'
    - 'spec/controllers/projects/issues_controller_spec.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/controllers/projects/snippets_controller_spec.rb'
    - 'spec/features/calendar_spec.rb'
    - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
    - 'spec/helpers/submodule_helper_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
Connor Shea's avatar
Connor Shea committed
475

476
# Offense count: 9
477
Style/MethodMissing:
478 479 480 481 482 483 484 485 486 487
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/models/commit.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/repository.rb'
    - 'config/initializers/gollum.rb'
    - 'lib/bitbucket/collection.rb'
    - 'lib/gitlab/github_import/client.rb'
    - 'lib/gitlab/lazy.rb'
    - 'lib/uploaded_file.rb'
488

489 490 491 492 493 494 495 496 497
# Offense count: 3
# Cop supports --auto-correct.
Style/MultilineIfModifier:
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/project_wiki.rb'

# Offense count: 178
Connor Shea's avatar
Connor Shea committed
498 499 500 501
# Cop supports --auto-correct.
Style/MutableConstant:
  Enabled: false

502
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
503 504
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
505 506 507 508 509
  Exclude:
    - 'app/helpers/commits_helper.rb'
    - 'app/workers/irker_worker.rb'
    - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
    - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
Connor Shea's avatar
Connor Shea committed
510

511
# Offense count: 13
Connor Shea's avatar
Connor Shea committed
512 513 514 515
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
516 517 518 519 520 521 522 523 524 525 526 527
  Exclude:
    - 'app/models/namespace.rb'
    - 'app/models/user.rb'
    - 'config/initializers/secret_token.rb'
    - 'db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
    - 'db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
    - 'lib/banzai/filter/math_filter.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/metrics/instrumentation.rb'
    - 'lib/gitlab/metrics/sampler.rb'
    - 'lib/gitlab/project_search_results.rb'
Connor Shea's avatar
Connor Shea committed
528

529
# Offense count: 19
Z.J. van de Weg's avatar
Z.J. van de Weg committed
530 531 532 533
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
534 535 536 537 538 539 540 541 542 543 544 545 546 547
  Exclude:
    - 'config/initializers/1_settings.rb'
    - 'config/initializers/secret_token.rb'
    - 'lib/gitlab/backend/shell.rb'
    - 'lib/gitlab/import_export/command_line_util.rb'
    - 'lib/gitlab/workhorse.rb'
    - 'spec/features/projects/import_export/export_file_spec.rb'
    - 'spec/lib/gitlab/git/blob_spec.rb'
    - 'spec/lib/gitlab/git/hook_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'
    - 'spec/support/test_env.rb'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'
Z.J. van de Weg's avatar
Z.J. van de Weg committed
548

549
# Offense count: 19
550
# Cop supports --auto-correct.
551
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
552 553 554 555
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

556
# Offense count: 34
Connor Shea's avatar
Connor Shea committed
557 558 559 560
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

561
# Offense count: 416
Connor Shea's avatar
Connor Shea committed
562 563 564 565 566
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

567
# Offense count: 10
Connor Shea's avatar
Connor Shea committed
568 569 570 571
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals:
572 573 574 575 576
  Exclude:
    - 'spec/lib/gitlab/diff/highlight_spec.rb'
    - 'spec/models/project_services/bamboo_service_spec.rb'
    - 'spec/models/project_services/teamcity_service_spec.rb'
    - 'spec/workers/repository_import_worker_spec.rb'
Connor Shea's avatar
Connor Shea committed
577

Connor Shea's avatar
Connor Shea committed
578
# Offense count: 13
Connor Shea's avatar
Connor Shea committed
579 580
# Cop supports --auto-correct.
Style/PerlBackrefs:
581 582 583 584 585 586 587 588 589 590 591 592 593
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

# Offense count: 63
Connor Shea's avatar
Connor Shea committed
594 595 596 597 598 599 600
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
Style/PredicateName:
  Enabled: false

601
# Offense count: 33
Z.J. van de Weg's avatar
Z.J. van de Weg committed
602
# Cop supports --auto-correct.
603 604
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: short, verbose
Z.J. van de Weg's avatar
Z.J. van de Weg committed
605
Style/PreferredHashMethods:
Connor Shea's avatar
Connor Shea committed
606 607
  Enabled: false

608
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
609 610
# Cop supports --auto-correct.
Style/Proc:
611 612 613 614 615 616 617
  Exclude:
    - 'app/mailers/base_mailer.rb'
    - 'app/models/milestone.rb'
    - 'app/models/service.rb'
    - 'lib/api/api_guard.rb'
    - 'lib/gitlab/ldap/config.rb'
    - 'spec/initializers/trusted_proxies_spec.rb'
Connor Shea's avatar
Connor Shea committed
618

619
# Offense count: 50
Connor Shea's avatar
Connor Shea committed
620 621 622 623 624 625
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

626
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
627 628
# Cop supports --auto-correct.
Style/RedundantBegin:
629 630 631 632 633
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/gitlab/git/commit.rb'
Connor Shea's avatar
Connor Shea committed
634 635 636 637

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantException:
638 639
  Exclude:
    - 'app/helpers/preferences_helper.rb'
Connor Shea's avatar
Connor Shea committed
640

641
# Offense count: 29
Connor Shea's avatar
Connor Shea committed
642 643
# Cop supports --auto-correct.
Style/RedundantFreeze:
644 645 646 647 648 649 650 651 652 653 654 655 656 657
  Exclude:
    - 'app/models/merge_request.rb'
    - 'app/validators/color_validator.rb'
    - 'app/validators/line_code_validator.rb'
    - 'lib/api/templates.rb'
    - 'lib/banzai/filter/blockquote_fence_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/banzai/filter/yaml_front_matter_filter.rb'
    - 'lib/gitlab/diff/inline_diff.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'lib/gitlab/incoming_email.rb'
    - 'lib/gitlab/middleware/static.rb'
    - 'lib/gitlab/regex.rb'
Connor Shea's avatar
Connor Shea committed
658

659 660 661 662 663 664 665 666 667 668 669 670 671
# Offense count: 11
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
  Exclude:
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/groups_controller.rb'
    - 'app/controllers/projects/labels_controller.rb'
    - 'app/controllers/projects/milestones_controller.rb'
    - 'app/services/access_token_validation_service.rb'

# Offense count: 359
Connor Shea's avatar
Connor Shea committed
672 673 674 675
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

676
# Offense count: 105
Connor Shea's avatar
Connor Shea committed
677 678 679 680 681 682
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
  Enabled: false

683
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
684 685
# Cop supports --auto-correct.
Style/RescueModifier:
686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701
  Exclude:
    - 'app/controllers/admin/system_info_controller.rb'
    - 'app/controllers/users_controller.rb'
    - 'app/helpers/blob_helper.rb'
    - 'app/helpers/issues_helper.rb'
    - 'app/models/diff_note.rb'
    - 'app/models/project_services/external_wiki_service.rb'
    - 'app/models/sent_notification.rb'
    - 'app/models/todo.rb'
    - 'config/initializers/1_settings.rb'
    - 'config/initializers/attr_encrypted_no_db_connection.rb'
    - 'lib/gitlab/current_settings.rb'
    - 'lib/gitlab/diff/parser.rb'
    - 'lib/gitlab/kubernetes.rb'
    - 'lib/gitlab/slash_commands/command_definition.rb'
    - 'spec/support/matchers/be_url.rb'
702 703

# Offense count: 7
Connor Shea's avatar
Connor Shea committed
704 705
# Cop supports --auto-correct.
Style/SelfAssignment:
706 707 708 709 710 711
  Exclude:
    - 'app/models/project_team.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
712 713 714

# Offense count: 2
# Configuration parameters: Methods.
715
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Connor Shea's avatar
Connor Shea committed
716
Style/SingleLineBlockParams:
717 718 719
  Exclude:
    - 'app/models/commit.rb'
    - 'spec/support/services_shared_context.rb'
Connor Shea's avatar
Connor Shea committed
720 721 722 723 724

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
725 726
  Exclude:
    - 'lib/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
727

728
# Offense count: 140
Connor Shea's avatar
Connor Shea committed
729 730 731 732 733 734
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
Style/SpaceBeforeBlockBraces:
  Enabled: false

735
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
736 737 738
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
739 740 741 742 743 744
  Exclude:
    - 'config/routes/project.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/system_note_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
745

746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767
# Offense count: 37
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral:
  Exclude:
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/issue.rb'
    - 'app/models/member.rb'
    - 'lib/api/entities.rb'
    - 'lib/file_size_validator.rb'
    - 'lib/gitlab/visibility_level.rb'
    - 'spec/models/concerns/participable_spec.rb'
    - 'spec/models/cycle_analytics/code_spec.rb'
    - 'spec/models/cycle_analytics/issue_spec.rb'
    - 'spec/models/cycle_analytics/plan_spec.rb'
    - 'spec/models/cycle_analytics/production_spec.rb'
    - 'spec/models/cycle_analytics/review_spec.rb'
    - 'spec/models/cycle_analytics/staging_spec.rb'
    - 'spec/models/cycle_analytics/test_spec.rb'

# Offense count: 174
Connor Shea's avatar
Connor Shea committed
768 769 770 771 772 773
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces:
  Enabled: false

774
# Offense count: 115
Connor Shea's avatar
Connor Shea committed
775 776 777 778
# Cop supports --auto-correct.
Style/SpaceInsideBrackets:
  Enabled: false

779
# Offense count: 77
Connor Shea's avatar
Connor Shea committed
780 781 782
# Cop supports --auto-correct.
Style/SpaceInsideParens:
  Enabled: false
Z.J. van de Weg's avatar
Z.J. van de Weg committed
783

784
# Offense count: 4
Z.J. van de Weg's avatar
Z.J. van de Weg committed
785 786
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
787 788
  Exclude:
    - 'lib/gitlab/git_access.rb'
Connor Shea's avatar
Connor Shea committed
789

790
# Offense count: 53
Connor Shea's avatar
Connor Shea committed
791 792 793 794 795 796
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

797
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
798 799 800 801
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
802 803 804 805 806 807 808 809 810 811 812 813 814 815 816
  Exclude:
    - 'app/helpers/labels_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/helpers/todos_helper.rb'
    - 'app/models/application_setting.rb'
    - 'app/models/project_services/campfire_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'db/migrate/20161017125927_add_unique_index_to_labels.rb'
    - 'features/steps/groups.rb'
    - 'features/steps/project/merge_requests.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/ci/gitlab_ci_yaml_processor.rb'
    - 'lib/gitlab/google_code_import/importer.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/models/project_services/hipchat_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
817

818
# Offense count: 52
Connor Shea's avatar
Connor Shea committed
819 820 821 822 823 824
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

825 826 827
# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
828
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
829
Style/TernaryParentheses:
830 831 832 833 834 835
  Exclude:
    - 'features/support/capybara.rb'
    - 'lib/api/projects.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/support/capybara.rb'
836

837
# Offense count: 35
Connor Shea's avatar
Connor Shea committed
838 839 840 841 842 843
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
  Enabled: false

844
# Offense count: 149
Connor Shea's avatar
Connor Shea committed
845 846 847 848 849 850 851 852 853 854
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInLiteral:
  Enabled: false

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
855 856 857 858 859 860 861
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/controllers/projects/git_http_client_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/logger.rb'
Connor Shea's avatar
Connor Shea committed
862

863
# Offense count: 66
Connor Shea's avatar
Connor Shea committed
864 865 866 867
# Cop supports --auto-correct.
Style/TrailingWhitespace:
  Enabled: false

868
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
869 870 871 872
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
873 874 875 876
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
    - 'lib/gitlab/ldap/person.rb'
Connor Shea's avatar
Connor Shea committed
877

878
# Offense count: 2
Connor Shea's avatar
Connor Shea committed
879 880
# Cop supports --auto-correct.
Style/UnlessElse:
881 882 883
  Exclude:
    - 'lib/gitlab/project_search_results.rb'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
884

885
# Offense count: 17
Connor Shea's avatar
Connor Shea committed
886 887
# Cop supports --auto-correct.
Style/UnneededInterpolation:
888 889 890 891 892 893 894 895 896 897 898 899 900 901
  Exclude:
    - 'app/helpers/boards_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/helpers/search_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/project_services/pushover_service.rb'
    - 'features/steps/project/forked_merge_requests.rb'
    - 'spec/features/admin/admin_projects_spec.rb'
    - 'spec/features/issues_spec.rb'
    - 'spec/features/projects/branches_spec.rb'
    - 'spec/features/projects/issuable_templates_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
Connor Shea's avatar
Connor Shea committed
902 903 904 905

# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
906 907 908 909 910 911 912 913
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/models/repository.rb'
    - 'lib/extracts_path.rb'