.rubocop_todo.yml 26.8 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Douwe Maan's avatar
Douwe Maan committed
2
3
# `rubocop --auto-gen-config`
# on 2017-02-21 18:00:50 -0600 using RuboCop version 0.46.0.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4
5
6
7
8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

Douwe Maan's avatar
Douwe Maan committed
9
# Offense count: 28
10
11
12
# Configuration parameters: Include.
# Include: **/Gemfile, **/gems.rb
Bundler/OrderedGems:
Douwe Maan's avatar
Douwe Maan committed
13
14
  Exclude:
    - 'Gemfile'
15

Douwe Maan's avatar
Douwe Maan committed
16
# Offense count: 176
Connor Shea's avatar
Connor Shea committed
17
18
19
Lint/AmbiguousRegexpLiteral:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
20
# Offense count: 54
Connor Shea's avatar
Connor Shea committed
21
22
23
24
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
25
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
26
27
28
Lint/HandleExceptions:
  Enabled: false

29
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
30
Lint/Loop:
Douwe Maan's avatar
Douwe Maan committed
31
32
  Exclude:
    - 'app/mailers/notify.rb'
Connor Shea's avatar
Connor Shea committed
33

Douwe Maan's avatar
Douwe Maan committed
34
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
35
36
37
Lint/ShadowingOuterLocalVariable:
  Enabled: false

38
# Offense count: 10
39
40
# Cop supports --auto-correct.
Lint/UnifiedInteger:
Douwe Maan's avatar
Douwe Maan committed
41
42
43
44
45
46
  Exclude:
    - 'spec/lib/gitlab/metrics/method_call_spec.rb'
    - 'spec/lib/gitlab/metrics/metric_spec.rb'
    - 'spec/lib/gitlab/metrics/system_spec.rb'
    - 'spec/lib/gitlab/metrics/transaction_spec.rb'
    - 'spec/models/repository_spec.rb'
47

Douwe Maan's avatar
Douwe Maan committed
48
# Offense count: 23
49
50
# Cop supports --auto-correct.
Lint/UnneededSplatExpansion:
Douwe Maan's avatar
Douwe Maan committed
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
  Exclude:
    - 'app/services/projects/update_pages_service.rb'
    - 'config/application.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/bitbucket/page.rb'
    - 'lib/gitlab/markup_helper.rb'
    - 'spec/helpers/auth_helper_spec.rb'
    - 'spec/models/project_wiki_spec.rb'
    - 'spec/requests/api/projects_spec.rb'
    - 'spec/requests/api/tags_spec.rb'
    - 'spec/requests/api/v3/projects_spec.rb'
    - 'spec/support/seed_helper.rb'
    - 'spec/support/test_env.rb'

# Offense count: 89
Connor Shea's avatar
Connor Shea committed
66
67
68
69
70
# Cop supports --auto-correct.
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
71
# Offense count: 171
Connor Shea's avatar
Connor Shea committed
72
73
74
75
76
# Cop supports --auto-correct.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
Lint/UnusedMethodArgument:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
77
# Offense count: 114
78
79
# Configuration parameters: CountComments.
Metrics/BlockLength:
Douwe Maan's avatar
Douwe Maan committed
80
  Max: 302
81
82

# Offense count: 3
Connor Shea's avatar
Connor Shea committed
83
84
# Cop supports --auto-correct.
Performance/RedundantBlockCall:
Douwe Maan's avatar
Douwe Maan committed
85
86
87
88
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'lib/gitlab/optimistic_locking.rb'
    - 'lib/gitlab/shell.rb'
Connor Shea's avatar
Connor Shea committed
89

90
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
91
92
# Cop supports --auto-correct.
Performance/RedundantMatch:
Douwe Maan's avatar
Douwe Maan committed
93
94
95
96
97
98
  Exclude:
    - 'app/models/external_issue.rb'
    - 'lib/ci/api/helpers.rb'
    - 'lib/extracts_path.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/diff/parser.rb'
Connor Shea's avatar
Connor Shea committed
99

Douwe Maan's avatar
Douwe Maan committed
100
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
101
102
103
104
105
# Cop supports --auto-correct.
# Configuration parameters: MaxKeyValuePairs.
Performance/RedundantMerge:
  Enabled: false

106
# Offense count: 15
107
108
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup:
Douwe Maan's avatar
Douwe Maan committed
109
110
111
112
113
114
115
116
117
  Exclude:
    - 'spec/features/issues_spec.rb'
    - 'spec/features/notes_on_merge_requests_spec.rb'
    - 'spec/lib/gitlab/git_access_spec.rb'
    - 'spec/models/project_snippet_spec.rb'
    - 'spec/models/protected_branch_spec.rb'
    - 'spec/routing/routing_spec.rb'

# Offense count: 63
118
119
120
121
122
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Enabled: false

123
124
125
126
# Offense count: 12
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should
RSpec/ImplicitExpect:
Douwe Maan's avatar
Douwe Maan committed
127
128
129
130
131
  Exclude:
    - 'spec/lib/banzai/renderer_spec.rb'
    - 'spec/models/project_group_link_spec.rb'
    - 'spec/models/project_services/external_wiki_service_spec.rb'
    - 'spec/models/project_spec.rb'
132

Douwe Maan's avatar
Douwe Maan committed
133
# Offense count: 258
134
135
136
RSpec/LeadingSubject:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
137
# Offense count: 281
138
139
140
RSpec/LetSetup:
  Enabled: false

141
# Offense count: 13
142
RSpec/MessageChain:
Douwe Maan's avatar
Douwe Maan committed
143
144
145
146
147
148
149
150
151
152
153
154
  Exclude:
    - 'spec/finders/move_to_project_finder_spec.rb'
    - 'spec/helpers/issues_helper_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/models/ci/build_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/services/ci/retry_build_service_spec.rb'
    - 'spec/services/ci/retry_pipeline_service_spec.rb'
    - 'spec/services/merge_requests/build_service_spec.rb'
    - 'spec/workers/emails_on_push_worker_spec.rb'

# Offense count: 505
155
# Configuration parameters: EnforcedStyle, SupportedStyles.
156
157
# SupportedStyles: have_received, receive
RSpec/MessageSpies:
158
159
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
160
# Offense count: 3625
161
RSpec/MultipleExpectations:
Douwe Maan's avatar
Douwe Maan committed
162
  Max: 37
163

Douwe Maan's avatar
Douwe Maan committed
164
# Offense count: 2217
165
166
167
RSpec/NamedSubject:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
168
# Offense count: 2126
169
170
171
172
# Configuration parameters: MaxNesting.
RSpec/NestedGroups:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
173
# Offense count: 36
174
RSpec/RepeatedDescription:
Douwe Maan's avatar
Douwe Maan committed
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
  Exclude:
    - 'spec/controllers/projects/todo_controller_spec.rb'
    - 'spec/features/boards/boards_spec.rb'
    - 'spec/helpers/issuables_helper_spec.rb'
    - 'spec/lib/banzai/filter/emoji_filter_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/global_milestone_spec.rb'
    - 'spec/models/hooks/system_hook_spec.rb'
    - 'spec/requests/api/commits_spec.rb'
    - 'spec/requests/api/merge_requests_spec.rb'
    - 'spec/requests/api/milestones_spec.rb'
    - 'spec/requests/api/users_spec.rb'
    - 'spec/requests/api/v3/merge_requests_spec.rb'
    - 'spec/requests/lfs_http_spec.rb'
    - 'spec/routing/admin_routing_spec.rb'
    - 'spec/services/notification_service_spec.rb'
191
192
193

# Offense count: 1
RSpec/SingleArgumentMessageChain:
Douwe Maan's avatar
Douwe Maan committed
194
195
  Exclude:
    - 'spec/requests/api/internal_spec.rb'
196

Douwe Maan's avatar
Douwe Maan committed
197
# Offense count: 140
198
199
200
RSpec/SubjectStub:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
201
# Offense count: 126
202
203
204
205
206
207
# Cop supports --auto-correct.
# Configuration parameters: Whitelist.
# Whitelist: find_by_sql
Rails/DynamicFindBy:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
208
# Offense count: 1162
209
210
211
212
213
214
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: spec/**/*, test/**/*
Rails/HttpPositionalArguments:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
215
# Offense count: 56
Z.J. van de Weg's avatar
Z.J. van de Weg committed
216
217
218
Rails/OutputSafety:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
219
# Offense count: 202
Connor Shea's avatar
Connor Shea committed
220
221
222
223
224
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: strict, flexible
Rails/TimeZone:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
225
# Offense count: 16
Connor Shea's avatar
Connor Shea committed
226
227
228
229
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/Validation:
Douwe Maan's avatar
Douwe Maan committed
230
231
232
233
234
235
236
237
238
239
240
241
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/ci/runner_project.rb'
    - 'app/models/ci/trigger.rb'
    - 'app/models/commit_status.rb'
    - 'app/models/members/group_member.rb'
    - 'app/models/members/project_member.rb'
    - 'app/models/pages_domain.rb'
    - 'app/models/project.rb'
    - 'app/models/protected_branch.rb'
    - 'app/models/user.rb'
Connor Shea's avatar
Connor Shea committed
242

243
# Offense count: 8
244
# Cop supports --auto-correct.
245
# Configuration parameters: AutoCorrect.
246
Security/JSONLoad:
Douwe Maan's avatar
Douwe Maan committed
247
248
249
250
251
252
253
  Exclude:
    - 'db/migrate/20161019190736_migrate_sidekiq_queues_from_default.rb'
    - 'db/migrate/20161024042317_migrate_mailroom_queue_from_default.rb'
    - 'db/migrate/20161124141322_migrate_process_commit_worker_jobs.rb'
    - 'spec/migrations/migrate_process_commit_worker_jobs_spec.rb'
    - 'spec/models/project_services/irker_service_spec.rb'
    - 'spec/support/stub_gitlab_calls.rb'
254

Douwe Maan's avatar
Douwe Maan committed
255
# Offense count: 431
Connor Shea's avatar
Connor Shea committed
256
257
258
259
260
261
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: with_first_parameter, with_fixed_indentation
Style/AlignParameters:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
262
# Offense count: 55
Connor Shea's avatar
Connor Shea committed
263
264
265
266
267
268
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
269
# Offense count: 399
Connor Shea's avatar
Connor Shea committed
270
271
272
273
274
275
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: braces, no_braces, context_dependent
Style/BracesAroundHashParameters:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
276
# Offense count: 7
Connor Shea's avatar
Connor Shea committed
277
Style/CaseEquality:
Douwe Maan's avatar
Douwe Maan committed
278
279
280
281
282
283
284
285
  Exclude:
    - 'app/helpers/auth_helper.rb'
    - 'app/helpers/builds_helper.rb'
    - 'app/models/commit.rb'
    - 'app/models/protected_branch.rb'
    - 'app/services/projects/download_service.rb'
    - 'config/initializers/trusted_proxies.rb'
    - 'lib/gitlab/route_map.rb'
Connor Shea's avatar
Connor Shea committed
286

Douwe Maan's avatar
Douwe Maan committed
287
# Offense count: 33
Connor Shea's avatar
Connor Shea committed
288
289
290
291
# Cop supports --auto-correct.
Style/ColonMethodCall:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
292
# Offense count: 2
Connor Shea's avatar
Connor Shea committed
293
294
295
296
# Cop supports --auto-correct.
# Configuration parameters: Keywords.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
Style/CommentAnnotation:
Douwe Maan's avatar
Douwe Maan committed
297
298
299
  Exclude:
    - 'config/routes/user.rb'
    - 'spec/requests/api/v3/project_snippets_spec.rb'
Connor Shea's avatar
Connor Shea committed
300

Douwe Maan's avatar
Douwe Maan committed
301
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
302
303
304
305
306
307
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
308
# Offense count: 21
Connor Shea's avatar
Connor Shea committed
309
Style/DoubleNegation:
Douwe Maan's avatar
Douwe Maan committed
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
  Exclude:
    - 'app/controllers/users_controller.rb'
    - 'app/models/commit.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/project.rb'
    - 'app/models/project_services/buildkite_service.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'app/models/project_wiki.rb'
    - 'app/models/user.rb'
    - 'config/initializers/6_validations.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/relative_link_filter.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/sherlock.rb'
    - 'lib/gitlab/sherlock/middleware.rb'
Connor Shea's avatar
Connor Shea committed
326

Douwe Maan's avatar
Douwe Maan committed
327
# Offense count: 6
328
# Cop supports --auto-correct.
Connor Shea's avatar
Connor Shea committed
329
Style/EachWithObject:
Douwe Maan's avatar
Douwe Maan committed
330
331
332
333
334
335
336
  Exclude:
    - 'app/services/merge_requests/get_urls_service.rb'
    - 'lib/ci/ansi2html.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
Connor Shea's avatar
Connor Shea committed
337

338
# Offense count: 24
Connor Shea's avatar
Connor Shea committed
339
340
341
342
343
344
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

345
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
346
347
# Cop supports --auto-correct.
Style/EmptyLiteral:
Douwe Maan's avatar
Douwe Maan committed
348
349
350
351
352
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
353

Douwe Maan's avatar
Douwe Maan committed
354
# Offense count: 55
355
356
357
358
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Connor Shea's avatar
Connor Shea committed
359
  Enabled: false
Connor Shea's avatar
Connor Shea committed
360

Douwe Maan's avatar
Douwe Maan committed
361
# Offense count: 173
Connor Shea's avatar
Connor Shea committed
362
363
364
365
366
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
  Enabled: false

367
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
368
369
370
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
371
372
373
374
375
376
377
378
379
  Exclude:
    - 'app/models/ci/pipeline.rb'
    - 'app/services/gravatar_service.rb'
    - 'config/initializers/rack_lineprof.rb'
    - 'lib/gitlab/version_info.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/services/issues/move_service_spec.rb'

# Offense count: 261
Connor Shea's avatar
Connor Shea committed
380
381
382
383
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
384
# Offense count: 12
Connor Shea's avatar
Connor Shea committed
385
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
386
387
388
389
390
391
392
393
394
395
396
397
398
399
  Exclude:
    - 'app/controllers/projects/forks_controller.rb'
    - 'app/controllers/projects/imports_controller.rb'
    - 'app/helpers/milestones_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/services/system_note_service.rb'
    - 'config/initializers/1_settings.rb'
    - 'lib/gitlab/auth.rb'
    - 'lib/gitlab/checks/change_access.rb'
    - 'lib/gitlab/database.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'

# Offense count: 178
Connor Shea's avatar
Connor Shea committed
400
401
402
403
404
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
405
# Offense count: 61
Connor Shea's avatar
Connor Shea committed
406
407
408
409
410
411
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
412
# Offense count: 110
Connor Shea's avatar
Connor Shea committed
413
414
415
416
417
418
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
419
# Offense count: 45
Connor Shea's avatar
Connor Shea committed
420
421
422
423
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
Connor Shea's avatar
Connor Shea committed
424
  Enabled: false
Connor Shea's avatar
Connor Shea committed
425

Douwe Maan's avatar
Douwe Maan committed
426
# Offense count: 7
Connor Shea's avatar
Connor Shea committed
427
428
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Douwe Maan's avatar
Douwe Maan committed
429
430
431
432
433
434
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/git_operation_service.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
435

Douwe Maan's avatar
Douwe Maan committed
436
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
437
438
# Cop supports --auto-correct.
Style/MethodCallParentheses:
Douwe Maan's avatar
Douwe Maan committed
439
440
441
442
443
444
445
446
447
448
449
450
451
  Exclude:
    - 'lib/ci/ansi2html.rb'
    - 'spec/controllers/projects/issues_controller_spec.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/controllers/projects/snippets_controller_spec.rb'
    - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_assignee_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_author_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_milestone_spec.rb'
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/helpers/submodule_helper_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
Connor Shea's avatar
Connor Shea committed
452

453
# Offense count: 9
454
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
455
456
457
458
459
460
461
462
463
464
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/models/commit.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/repository.rb'
    - 'config/initializers/gollum.rb'
    - 'lib/bitbucket/collection.rb'
    - 'lib/gitlab/github_import/client.rb'
    - 'lib/gitlab/lazy.rb'
    - 'lib/uploaded_file.rb'
465

466
467
468
# Offense count: 3
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Douwe Maan's avatar
Douwe Maan committed
469
470
471
472
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'lib/gitlab/workhorse.rb'
473

474
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
475
476
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
477
478
479
480
481
  Exclude:
    - 'app/helpers/commits_helper.rb'
    - 'app/workers/irker_worker.rb'
    - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
    - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
Connor Shea's avatar
Connor Shea committed
482

Douwe Maan's avatar
Douwe Maan committed
483
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
484
485
486
487
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
488
489
490
491
492
493
494
495
496
497
498
499
500
  Exclude:
    - 'app/models/namespace.rb'
    - 'app/models/user.rb'
    - 'app/services/merge_requests/refresh_service.rb'
    - 'config/initializers/secret_token.rb'
    - 'db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
    - 'db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
    - 'lib/banzai/filter/math_filter.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/metrics/instrumentation.rb'
    - 'lib/gitlab/metrics/sampler.rb'
    - 'lib/gitlab/project_search_results.rb'
Connor Shea's avatar
Connor Shea committed
501

502
# Offense count: 19
Z.J. van de Weg's avatar
Z.J. van de Weg committed
503
504
505
506
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
  Exclude:
    - 'config/initializers/1_settings.rb'
    - 'config/initializers/secret_token.rb'
    - 'lib/gitlab/import_export/command_line_util.rb'
    - 'lib/gitlab/shell.rb'
    - 'lib/gitlab/workhorse.rb'
    - 'spec/features/projects/import_export/export_file_spec.rb'
    - 'spec/lib/gitlab/git/blob_spec.rb'
    - 'spec/lib/gitlab/git/hook_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'
    - 'spec/support/test_env.rb'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 68
523
# Cop supports --auto-correct.
524
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
525
526
527
528
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
529
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
530
531
532
533
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
534
# Offense count: 459
Connor Shea's avatar
Connor Shea committed
535
536
537
538
539
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

540
# Offense count: 10
Connor Shea's avatar
Connor Shea committed
541
542
543
544
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals:
Douwe Maan's avatar
Douwe Maan committed
545
546
547
548
549
550
551
  Exclude:
    - 'spec/lib/gitlab/diff/highlight_spec.rb'
    - 'spec/models/project_services/bamboo_service_spec.rb'
    - 'spec/models/project_services/buildkite_service_spec.rb'
    - 'spec/models/project_services/drone_ci_service_spec.rb'
    - 'spec/models/project_services/teamcity_service_spec.rb'
    - 'spec/workers/repository_import_worker_spec.rb'
Connor Shea's avatar
Connor Shea committed
552

Connor Shea's avatar
Connor Shea committed
553
# Offense count: 13
Connor Shea's avatar
Connor Shea committed
554
555
# Cop supports --auto-correct.
Style/PerlBackrefs:
Douwe Maan's avatar
Douwe Maan committed
556
557
558
559
560
561
562
563
564
565
566
567
568
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

# Offense count: 72
Connor Shea's avatar
Connor Shea committed
569
570
571
572
573
574
575
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
Style/PredicateName:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
576
# Offense count: 39
Z.J. van de Weg's avatar
Z.J. van de Weg committed
577
# Cop supports --auto-correct.
578
579
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: short, verbose
Z.J. van de Weg's avatar
Z.J. van de Weg committed
580
Style/PreferredHashMethods:
Connor Shea's avatar
Connor Shea committed
581
582
  Enabled: false

583
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
584
585
# Cop supports --auto-correct.
Style/Proc:
Douwe Maan's avatar
Douwe Maan committed
586
587
588
589
590
591
592
  Exclude:
    - 'app/mailers/base_mailer.rb'
    - 'app/models/milestone.rb'
    - 'app/models/service.rb'
    - 'lib/api/api_guard.rb'
    - 'lib/gitlab/ldap/config.rb'
    - 'spec/initializers/trusted_proxies_spec.rb'
Connor Shea's avatar
Connor Shea committed
593

Douwe Maan's avatar
Douwe Maan committed
594
# Offense count: 62
Connor Shea's avatar
Connor Shea committed
595
596
597
598
599
600
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
601
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
602
603
# Cop supports --auto-correct.
Style/RedundantBegin:
Douwe Maan's avatar
Douwe Maan committed
604
605
606
607
  Exclude:
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/gitlab/git/commit.rb'
Connor Shea's avatar
Connor Shea committed
608

Douwe Maan's avatar
Douwe Maan committed
609
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
610
611
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
  Exclude:
    - 'app/models/commit.rb'
    - 'app/models/merge_request.rb'
    - 'app/validators/color_validator.rb'
    - 'app/validators/line_code_validator.rb'
    - 'lib/api/templates.rb'
    - 'lib/api/v3/templates.rb'
    - 'lib/banzai/filter/blockquote_fence_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/banzai/filter/yaml_front_matter_filter.rb'
    - 'lib/gitlab/diff/inline_diff.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'lib/gitlab/middleware/static.rb'
    - 'lib/gitlab/regex.rb'
Connor Shea's avatar
Connor Shea committed
627

Douwe Maan's avatar
Douwe Maan committed
628
# Offense count: 15
629
630
631
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Douwe Maan's avatar
Douwe Maan committed
632
633
634
635
636
637
638
639
640
641
642
643
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/groups_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/labels_controller.rb'
    - 'app/controllers/projects/milestones_controller.rb'
    - 'app/services/access_token_validation_service.rb'

# Offense count: 365
Connor Shea's avatar
Connor Shea committed
644
645
646
647
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
648
# Offense count: 107
Connor Shea's avatar
Connor Shea committed
649
650
651
652
653
654
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
655
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
656
657
# Cop supports --auto-correct.
Style/RescueModifier:
658
  Enabled: false
659
660

# Offense count: 7
Connor Shea's avatar
Connor Shea committed
661
662
# Cop supports --auto-correct.
Style/SelfAssignment:
Douwe Maan's avatar
Douwe Maan committed
663
664
665
666
667
668
  Exclude:
    - 'app/models/project_team.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
669
670
671

# Offense count: 2
# Configuration parameters: Methods.
672
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Connor Shea's avatar
Connor Shea committed
673
Style/SingleLineBlockParams:
Douwe Maan's avatar
Douwe Maan committed
674
675
676
  Exclude:
    - 'app/models/commit.rb'
    - 'spec/support/services_shared_context.rb'
Connor Shea's avatar
Connor Shea committed
677
678
679
680
681

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Douwe Maan's avatar
Douwe Maan committed
682
683
  Exclude:
    - 'lib/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
684

Douwe Maan's avatar
Douwe Maan committed
685
# Offense count: 150
Connor Shea's avatar
Connor Shea committed
686
687
688
689
690
691
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
Style/SpaceBeforeBlockBraces:
  Enabled: false

692
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
693
694
695
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
Douwe Maan's avatar
Douwe Maan committed
696
697
698
699
700
701
  Exclude:
    - 'config/routes/project.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/system_note_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
702

Douwe Maan's avatar
Douwe Maan committed
703
# Offense count: 38
704
705
706
707
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral:
Douwe Maan's avatar
Douwe Maan committed
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
  Exclude:
    - 'app/models/commit_status.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/issue.rb'
    - 'app/models/member.rb'
    - 'lib/api/entities.rb'
    - 'lib/file_size_validator.rb'
    - 'lib/gitlab/visibility_level.rb'
    - 'spec/models/concerns/participable_spec.rb'
    - 'spec/models/cycle_analytics/code_spec.rb'
    - 'spec/models/cycle_analytics/issue_spec.rb'
    - 'spec/models/cycle_analytics/plan_spec.rb'
    - 'spec/models/cycle_analytics/production_spec.rb'
    - 'spec/models/cycle_analytics/review_spec.rb'
    - 'spec/models/cycle_analytics/staging_spec.rb'
    - 'spec/models/cycle_analytics/test_spec.rb'

# Offense count: 205
Connor Shea's avatar
Connor Shea committed
726
727
728
729
730
731
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
732
# Offense count: 120
Connor Shea's avatar
Connor Shea committed
733
734
735
736
# Cop supports --auto-correct.
Style/SpaceInsideBrackets:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
737
# Offense count: 90
Connor Shea's avatar
Connor Shea committed
738
739
740
# Cop supports --auto-correct.
Style/SpaceInsideParens:
  Enabled: false
Z.J. van de Weg's avatar
Z.J. van de Weg committed
741

742
# Offense count: 4
Z.J. van de Weg's avatar
Z.J. van de Weg committed
743
744
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
Douwe Maan's avatar
Douwe Maan committed
745
746
  Exclude:
    - 'lib/gitlab/git_access.rb'
Connor Shea's avatar
Connor Shea committed
747

Douwe Maan's avatar
Douwe Maan committed
748
# Offense count: 52
Connor Shea's avatar
Connor Shea committed
749
750
751
752
753
754
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

755
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
756
757
758
759
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
  Exclude:
    - 'app/helpers/labels_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/helpers/todos_helper.rb'
    - 'app/models/application_setting.rb'
    - 'app/models/project_services/campfire_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'db/migrate/20161017125927_add_unique_index_to_labels.rb'
    - 'features/steps/groups.rb'
    - 'features/steps/project/merge_requests.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/ci/gitlab_ci_yaml_processor.rb'
    - 'lib/gitlab/google_code_import/importer.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/models/project_services/hipchat_service_spec.rb'
775

Douwe Maan's avatar
Douwe Maan committed
776
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
777
778
779
780
781
782
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

783
784
785
# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
786
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
787
Style/TernaryParentheses:
Douwe Maan's avatar
Douwe Maan committed
788
789
790
791
792
793
  Exclude:
    - 'features/support/capybara.rb'
    - 'lib/api/v3/projects.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/support/capybara.rb'
794

Douwe Maan's avatar
Douwe Maan committed
795
# Offense count: 43
Connor Shea's avatar
Connor Shea committed
796
797
798
799
800
801
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
802
# Offense count: 158
Connor Shea's avatar
Connor Shea committed
803
804
805
806
807
808
809
810
811
812
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInLiteral:
  Enabled: false

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Douwe Maan's avatar
Douwe Maan committed
813
814
815
816
817
818
819
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/controllers/projects/git_http_client_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/logger.rb'
Connor Shea's avatar
Connor Shea committed
820

Douwe Maan's avatar
Douwe Maan committed
821
# Offense count: 76
Connor Shea's avatar
Connor Shea committed
822
823
824
825
# Cop supports --auto-correct.
Style/TrailingWhitespace:
  Enabled: false

826
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
827
828
829
830
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Douwe Maan's avatar
Douwe Maan committed
831
832
833
834
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
    - 'lib/gitlab/ldap/person.rb'
Connor Shea's avatar
Connor Shea committed
835

836
# Offense count: 2
Connor Shea's avatar
Connor Shea committed
837
838
# Cop supports --auto-correct.
Style/UnlessElse:
Douwe Maan's avatar
Douwe Maan committed
839
840
841
  Exclude:
    - 'lib/gitlab/project_search_results.rb'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
842

Douwe Maan's avatar
Douwe Maan committed
843
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
844
845
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
  Exclude:
    - 'app/helpers/boards_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/helpers/search_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/project_services/pushover_service.rb'
    - 'features/steps/project/forked_merge_requests.rb'
    - 'spec/controllers/admin/services_controller_spec.rb'
    - 'spec/features/admin/admin_projects_spec.rb'
    - 'spec/features/issues_spec.rb'
    - 'spec/features/projects/branches_spec.rb'
    - 'spec/features/projects/issuable_templates_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/requests/api/issues_spec.rb'
    - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
Connor Shea's avatar
Connor Shea committed
862
863
864
865

# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Douwe Maan's avatar
Douwe Maan committed
866
867
868
869
870
871
872
873
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/models/repository.rb'
    - 'lib/extracts_path.rb'