issuable_spec.rb 25.6 KB
Newer Older
1 2
require 'spec_helper'

Sean McGivern's avatar
Sean McGivern committed
3 4
describe Issuable do
  let(:issuable_class) { Issue }
5
  let(:issue) { create(:issue, title: 'An issue', description: 'A description') }
6
  let(:user) { create(:user) }
7 8

  describe "Associations" do
Sean McGivern's avatar
Sean McGivern committed
9 10
    subject { build(:issue) }

11 12 13
    it { is_expected.to belong_to(:project) }
    it { is_expected.to belong_to(:author) }
    it { is_expected.to have_many(:notes).dependent(:destroy) }
14
    it { is_expected.to have_many(:todos).dependent(:destroy) }
15
    it { is_expected.to have_many(:labels) }
16 17 18 19 20 21 22 23 24 25

    context 'Notes' do
      let!(:note) { create(:note, noteable: issue, project: issue.project) }
      let(:scoped_issue) { Issue.includes(notes: :author).find(issue.id) }

      it 'indicates if the notes have their authors loaded' do
        expect(issue.notes).not_to be_authors_loaded
        expect(scoped_issue.notes).to be_authors_loaded
      end
    end
26 27
  end

28
  describe 'Included modules' do
Sean McGivern's avatar
Sean McGivern committed
29 30
    let(:described_class) { issuable_class }

31 32 33
    it { is_expected.to include_module(Awardable) }
  end

34
  describe "Validation" do
35 36 37 38 39 40
    context 'general validations' do
      subject { build(:issue) }

      before do
        allow(InternalId).to receive(:generate_next).and_return(nil)
      end
Sean McGivern's avatar
Sean McGivern committed
41

42 43 44 45 46
      it { is_expected.to validate_presence_of(:project) }
      it { is_expected.to validate_presence_of(:iid) }
      it { is_expected.to validate_presence_of(:author) }
      it { is_expected.to validate_presence_of(:title) }
      it { is_expected.to validate_length_of(:title).is_at_most(255) }
47 48
    end

49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84
    describe 'milestone' do
      let(:project) { create(:project) }
      let(:milestone_id) { create(:milestone, project: project).id }
      let(:params) do
        {
          title: 'something',
          project: project,
          author: build(:user),
          milestone_id: milestone_id
        }
      end

      subject { issuable_class.new(params) }

      context 'with correct params' do
        it { is_expected.to be_valid }
      end

      context 'with empty string milestone' do
        let(:milestone_id) { '' }

        it { is_expected.to be_valid }
      end

      context 'with nil milestone id' do
        let(:milestone_id) { nil }

        it { is_expected.to be_valid }
      end

      context 'with a milestone id from another project' do
        let(:milestone_id) { create(:milestone).id }

        it { is_expected.to be_invalid }
      end
    end
85 86 87
  end

  describe "Scope" do
Sean McGivern's avatar
Sean McGivern committed
88 89 90 91 92
    subject { build(:issue) }

    it { expect(issuable_class).to respond_to(:opened) }
    it { expect(issuable_class).to respond_to(:closed) }
    it { expect(issuable_class).to respond_to(:assigned) }
93 94
  end

95 96 97 98 99 100 101 102 103 104 105 106 107
  describe 'author_name' do
    it 'is delegated to author' do
      expect(issue.author_name).to eq issue.author.name
    end

    it 'returns nil when author is nil' do
      issue.author_id = nil
      issue.save(validate: false)

      expect(issue.author_name).to eq nil
    end
  end

108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149
  describe '#milestone_available?' do
    let(:group) { create(:group) }
    let(:project) { create(:project, group: group) }
    let(:issue) { create(:issue, project: project) }

    def build_issuable(milestone_id)
      issuable_class.new(project: project, milestone_id: milestone_id)
    end

    it 'returns true with a milestone from the issue project' do
      milestone = create(:milestone, project: project)

      expect(build_issuable(milestone.id).milestone_available?).to be_truthy
    end

    it 'returns true with a milestone from the issue project group' do
      milestone = create(:milestone, group: group)

      expect(build_issuable(milestone.id).milestone_available?).to be_truthy
    end

    it 'returns true with a milestone from the the parent of the issue project group', :nested_groups do
      parent = create(:group)
      group.update(parent: parent)
      milestone = create(:milestone, group: parent)

      expect(build_issuable(milestone.id).milestone_available?).to be_truthy
    end

    it 'returns false with a milestone from another project' do
      milestone = create(:milestone)

      expect(build_issuable(milestone.id).milestone_available?).to be_falsey
    end

    it 'returns false with a milestone from another group' do
      milestone = create(:milestone, group: create(:group))

      expect(build_issuable(milestone.id).milestone_available?).to be_falsey
    end
  end

150
  describe ".search" do
151
    let!(:searchable_issue) { create(:issue, title: "Searchable awesome issue") }
152
    let!(:searchable_issue2) { create(:issue, title: 'Aw') }
153

154
    it 'returns issues with a matching title' do
155 156
      expect(issuable_class.search(searchable_issue.title))
        .to eq([searchable_issue])
157 158
    end

159
    it 'returns issues with a partially matching title' do
Sean McGivern's avatar
Sean McGivern committed
160
      expect(issuable_class.search('able')).to eq([searchable_issue])
161
    end
162

163
    it 'returns issues with a matching title regardless of the casing' do
164 165
      expect(issuable_class.search(searchable_issue.title.upcase))
        .to eq([searchable_issue])
166
    end
167 168 169 170 171

    it 'returns issues with a fuzzy matching title' do
      expect(issuable_class.search('searchable issue')).to eq([searchable_issue])
    end

172 173
    it 'returns issues with a matching title for a query shorter than 3 chars' do
      expect(issuable_class.search(searchable_issue2.title.downcase)).to eq([searchable_issue2])
174
    end
175 176 177 178
  end

  describe ".full_search" do
    let!(:searchable_issue) do
179
      create(:issue, title: "Searchable awesome issue", description: 'Many cute kittens')
180
    end
181
    let!(:searchable_issue2) { create(:issue, title: "Aw", description: "Cu") }
182

183
    it 'returns issues with a matching title' do
184 185
      expect(issuable_class.full_search(searchable_issue.title))
        .to eq([searchable_issue])
186 187
    end

188
    it 'returns issues with a partially matching title' do
Sean McGivern's avatar
Sean McGivern committed
189
      expect(issuable_class.full_search('able')).to eq([searchable_issue])
190 191
    end

192
    it 'returns issues with a matching title regardless of the casing' do
193 194
      expect(issuable_class.full_search(searchable_issue.title.upcase))
        .to eq([searchable_issue])
195 196
    end

197 198 199 200 201
    it 'returns issues with a fuzzy matching title' do
      expect(issuable_class.full_search('searchable issue')).to eq([searchable_issue])
    end

    it 'returns issues with a matching description' do
202 203
      expect(issuable_class.full_search(searchable_issue.description))
        .to eq([searchable_issue])
204 205
    end

206
    it 'returns issues with a partially matching description' do
207 208
      expect(issuable_class.full_search(searchable_issue.description))
        .to eq([searchable_issue])
209 210
    end

211
    it 'returns issues with a matching description regardless of the casing' do
212 213
      expect(issuable_class.full_search(searchable_issue.description.upcase))
        .to eq([searchable_issue])
214
    end
215 216 217 218 219

    it 'returns issues with a fuzzy matching description' do
      expect(issuable_class.full_search('many kittens')).to eq([searchable_issue])
    end

220 221
    it 'returns issues with a matching description for a query shorter than 3 chars' do
      expect(issuable_class.full_search(searchable_issue2.description.downcase)).to eq([searchable_issue2])
222
    end
223

Hiroyuki Sato's avatar
Hiroyuki Sato committed
224
    context 'when matching columns is "title"' do
225 226 227 228 229 230 231 232 233 234 235
      it 'returns issues with a matching title' do
        expect(issuable_class.full_search(searchable_issue.title, matched_columns: 'title'))
          .to eq([searchable_issue])
      end

      it 'returns no issues with a matching description' do
        expect(issuable_class.full_search(searchable_issue.description, matched_columns: 'title'))
          .to be_empty
      end
    end

Hiroyuki Sato's avatar
Hiroyuki Sato committed
236
    context 'when matching columns is "description"' do
237 238 239 240 241 242 243 244 245 246 247
      it 'returns no issues with a matching title' do
        expect(issuable_class.full_search(searchable_issue.title, matched_columns: 'description'))
          .to be_empty
      end

      it 'returns issues with a matching description' do
        expect(issuable_class.full_search(searchable_issue.description, matched_columns: 'description'))
          .to eq([searchable_issue])
      end
    end

Hiroyuki Sato's avatar
Hiroyuki Sato committed
248
    context 'when matching columns is "title,description"' do
249 250 251 252 253 254 255 256 257 258 259
      it 'returns issues with a matching title' do
        expect(issuable_class.full_search(searchable_issue.title, matched_columns: 'title,description'))
          .to eq([searchable_issue])
      end

      it 'returns issues with a matching description' do
        expect(issuable_class.full_search(searchable_issue.description, matched_columns: 'title,description'))
          .to eq([searchable_issue])
      end
    end

Hiroyuki Sato's avatar
Hiroyuki Sato committed
260
    context 'when matching columns is nil"' do
261 262 263 264 265 266 267 268 269 270 271
      it 'returns issues with a matching title' do
        expect(issuable_class.full_search(searchable_issue.title, matched_columns: nil))
          .to eq([searchable_issue])
      end

      it 'returns issues with a matching description' do
        expect(issuable_class.full_search(searchable_issue.description, matched_columns: nil))
          .to eq([searchable_issue])
      end
    end

Hiroyuki Sato's avatar
Hiroyuki Sato committed
272
    context 'when matching columns is "invalid"' do
273 274 275 276 277 278 279 280 281 282 283
      it 'returns issues with a matching title' do
        expect(issuable_class.full_search(searchable_issue.title, matched_columns: 'invalid'))
          .to eq([searchable_issue])
      end

      it 'returns issues with a matching description' do
        expect(issuable_class.full_search(searchable_issue.description, matched_columns: 'invalid'))
          .to eq([searchable_issue])
      end
    end

Hiroyuki Sato's avatar
Hiroyuki Sato committed
284
    context 'when matching columns is "title,invalid"' do
285 286 287 288 289 290 291 292 293 294
      it 'returns issues with a matching title' do
        expect(issuable_class.full_search(searchable_issue.title, matched_columns: 'title,invalid'))
          .to eq([searchable_issue])
      end

      it 'returns no issues with a matching description' do
        expect(issuable_class.full_search(searchable_issue.description, matched_columns: 'title,invalid'))
          .to be_empty
      end
    end
295 296
  end

297 298 299 300 301
  describe '.to_ability_name' do
    it { expect(Issue.to_ability_name).to eq("issue") }
    it { expect(MergeRequest.to_ability_name).to eq("merge_request") }
  end

302 303 304
  describe "#today?" do
    it "returns true when created today" do
      # Avoid timezone differences and just return exactly what we want
305 306
      allow(Date).to receive(:today).and_return(issue.created_at.to_date)
      expect(issue.today?).to be_truthy
307 308 309
    end

    it "returns false when not created today" do
310 311
      allow(Date).to receive(:today).and_return(Date.yesterday)
      expect(issue.today?).to be_falsey
312 313 314 315 316
    end
  end

  describe "#new?" do
    it "returns true when created today and record hasn't been updated" do
317 318
      allow(issue).to receive(:today?).and_return(true)
      expect(issue.new?).to be_truthy
319 320 321
    end

    it "returns false when not created today" do
322 323
      allow(issue).to receive(:today?).and_return(false)
      expect(issue.new?).to be_falsey
324 325 326
    end

    it "returns false when record has been updated" do
327
      allow(issue).to receive(:today?).and_return(true)
328
      issue.update_attribute(:updated_at, 1.hour.ago)
329
      expect(issue.new?).to be_falsey
330 331
    end
  end
332

333
  describe "#sort_by_attribute" do
334
    let(:project) { create(:project) }
335 336

    context "by milestone due date" do
Felipe Artur's avatar
Felipe Artur committed
337 338 339 340
      # Correct order is:
      # Issues/MRs with milestones ordered by date
      # Issues/MRs with milestones without dates
      # Issues/MRs without milestones
341

342 343 344 345 346 347 348 349
      let!(:issue) { create(:issue, project: project) }
      let!(:early_milestone) { create(:milestone, project: project, due_date: 10.days.from_now) }
      let!(:late_milestone) { create(:milestone, project: project, due_date: 30.days.from_now) }
      let!(:issue1) { create(:issue, project: project, milestone: early_milestone) }
      let!(:issue2) { create(:issue, project: project, milestone: late_milestone) }
      let!(:issue3) { create(:issue, project: project) }

      it "sorts desc" do
350
        issues = project.issues.sort_by_attribute('milestone_due_desc')
351 352
        expect(issues).to match_array([issue2, issue1, issue, issue3])
      end
353

354
      it "sorts asc" do
355
        issues = project.issues.sort_by_attribute('milestone_due_asc')
356
        expect(issues).to match_array([issue1, issue2, issue, issue3])
357 358
      end
    end
359 360 361 362 363 364 365 366

    context 'when all of the results are level on the sort key' do
      let!(:issues) do
        10.times { create(:issue, project: project) }
      end

      it 'has no duplicates across pages' do
        sorted_issue_ids = 1.upto(10).map do |i|
367
          project.issues.sort_by_attribute('milestone_due_desc').page(i).per(1).first.id
368 369 370 371 372
        end

        expect(sorted_issue_ids).to eq(sorted_issue_ids.uniq)
      end
    end
373 374
  end

375
  describe '#subscribed?' do
376 377
    let(:project) { issue.project }

378
    context 'user is not a participant in the issue' do
379 380 381
      before do
        allow(issue).to receive(:participants).with(user).and_return([])
      end
382 383

      it 'returns false when no subcription exists' do
384
        expect(issue.subscribed?(user, project)).to be_falsey
385 386 387
      end

      it 'returns true when a subcription exists and subscribed is true' do
388
        issue.subscriptions.create(user: user, project: project, subscribed: true)
389

390
        expect(issue.subscribed?(user, project)).to be_truthy
391 392 393
      end

      it 'returns false when a subcription exists and subscribed is false' do
394
        issue.subscriptions.create(user: user, project: project, subscribed: false)
395

396
        expect(issue.subscribed?(user, project)).to be_falsey
397 398 399 400
      end
    end

    context 'user is a participant in the issue' do
401 402 403
      before do
        allow(issue).to receive(:participants).with(user).and_return([user])
      end
404 405

      it 'returns false when no subcription exists' do
406
        expect(issue.subscribed?(user, project)).to be_truthy
407 408 409
      end

      it 'returns true when a subcription exists and subscribed is true' do
410
        issue.subscriptions.create(user: user, project: project, subscribed: true)
411

412
        expect(issue.subscribed?(user, project)).to be_truthy
413 414 415
      end

      it 'returns false when a subcription exists and subscribed is false' do
416
        issue.subscriptions.create(user: user, project: project, subscribed: false)
417

418
        expect(issue.subscribed?(user, project)).to be_falsey
419 420 421 422
      end
    end
  end

423 424 425 426 427 428 429 430
  describe '#time_estimate=' do
    it 'coerces the value below Gitlab::Database::MAX_INT_VALUE' do
      expect { issue.time_estimate = 100 }.to change { issue.time_estimate }.to(100)
      expect { issue.time_estimate = Gitlab::Database::MAX_INT_VALUE + 100 }.to change { issue.time_estimate }.to(Gitlab::Database::MAX_INT_VALUE)
    end

    it 'skips coercion for not Integer values' do
      expect { issue.time_estimate = nil }.to change { issue.time_estimate }.to(nil)
431 432
      expect { issue.time_estimate = 'invalid time' }.not_to raise_error
      expect { issue.time_estimate = 22.33 }.not_to raise_error
433 434 435
    end
  end

436
  describe '#to_hook_data' do
437 438
    let(:builder) { double }

439 440
    context 'labels are updated' do
      let(:labels) { create_list(:label, 2) }
441

442 443
      before do
        issue.update(labels: [labels[1]])
444 445
        expect(Gitlab::HookData::IssuableBuilder)
          .to receive(:new).with(issue).and_return(builder)
446 447
      end

448
      it 'delegates to Gitlab::HookData::IssuableBuilder#build' do
449 450 451 452 453
        expect(builder).to receive(:build).with(
          user: user,
          changes: hash_including(
            'labels' => [[labels[0].hook_attrs], [labels[1].hook_attrs]]
          ))
454

455
        issue.to_hook_data(user, old_associations: { labels: [labels[0]] })
456 457 458 459 460
      end
    end

    context 'total_time_spent is updated' do
      before do
461
        issue.spend_time(duration: 2, user_id: user.id, spent_at: Time.now)
462
        issue.save
463 464
        expect(Gitlab::HookData::IssuableBuilder)
          .to receive(:new).with(issue).and_return(builder)
465 466 467
      end

      it 'delegates to Gitlab::HookData::IssuableBuilder#build' do
468 469 470
        expect(builder).to receive(:build).with(
          user: user,
          changes: hash_including(
471
            'total_time_spent' => [1, 2]
472 473
          ))

474
        issue.to_hook_data(user, old_associations: { total_time_spent: 1 })
475
      end
476 477
    end

478 479
    context 'issue is assigned' do
      let(:user2) { create(:user) }
480

481
      before do
482
        issue.assignees << user << user2
483 484
        expect(Gitlab::HookData::IssuableBuilder)
          .to receive(:new).with(issue).and_return(builder)
485
      end
486

487 488 489 490 491 492 493
      it 'delegates to Gitlab::HookData::IssuableBuilder#build' do
        expect(builder).to receive(:build).with(
          user: user,
          changes: hash_including(
            'assignees' => [[user.hook_attrs], [user.hook_attrs, user2.hook_attrs]]
          ))

494
        issue.to_hook_data(user, old_associations: { assignees: [user] })
495 496 497
      end
    end

498
    context 'merge_request is assigned' do
499
      let(:merge_request) { create(:merge_request) }
500
      let(:user2) { create(:user) }
501 502

      before do
503 504
        merge_request.update(assignee: user)
        merge_request.update(assignee: user2)
505 506
        expect(Gitlab::HookData::IssuableBuilder)
          .to receive(:new).with(merge_request).and_return(builder)
507
      end
508

509 510 511 512 513 514 515 516
      it 'delegates to Gitlab::HookData::IssuableBuilder#build' do
        expect(builder).to receive(:build).with(
          user: user,
          changes: hash_including(
            'assignee_id' => [user.id, user2.id],
            'assignee' => [user.hook_attrs, user2.hook_attrs]
          ))

517
        merge_request.to_hook_data(user, old_associations: { assignees: [user] })
518
      end
519 520
    end
  end
521

522
  describe '#labels_array' do
523
    let(:project) { create(:project) }
524 525 526
    let(:bug) { create(:label, project: project, title: 'bug') }
    let(:issue) { create(:issue, project: project) }

527
    before do
528 529 530 531 532 533 534 535
      issue.labels << bug
    end

    it 'loads the association and returns it as an array' do
      expect(issue.reload.labels_array).to eq([bug])
    end
  end

536
  describe '#user_notes_count' do
537
    let(:project) { create(:project) }
538 539 540 541 542 543 544 545 546 547 548 549 550 551
    let(:issue1) { create(:issue, project: project) }
    let(:issue2) { create(:issue, project: project) }

    before do
      create_list(:note, 3, noteable: issue1, project: project)
      create_list(:note, 6, noteable: issue2, project: project)
    end

    it 'counts the user notes' do
      expect(issue1.user_notes_count).to be(3)
      expect(issue2.user_notes_count).to be(6)
    end
  end

552
  describe "votes" do
553 554
    let(:project) { issue.project }

555
    before do
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
556 557
      create(:award_emoji, :upvote, awardable: issue)
      create(:award_emoji, :downvote, awardable: issue)
558 559 560 561 562
    end

    it "returns correct values" do
      expect(issue.upvotes).to eq(1)
      expect(issue.downvotes).to eq(1)
563 564 565 566
    end
  end

  describe '.order_due_date_and_labels_priority' do
567
    let(:project) { create(:project) }
568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602

    def create_issue(milestone, labels)
      create(:labeled_issue, milestone: milestone, labels: labels, project: project)
    end

    it 'sorts issues in order of milestone due date, then label priority' do
      first_priority = create(:label, project: project, priority: 1)
      second_priority = create(:label, project: project, priority: 2)
      no_priority = create(:label, project: project)

      first_milestone = create(:milestone, project: project, due_date: Time.now)
      second_milestone = create(:milestone, project: project, due_date: Time.now + 1.month)
      third_milestone = create(:milestone, project: project)

      # The issues here are ordered by label priority, to ensure that we don't
      # accidentally just sort by creation date.
      second_milestone_first_priority = create_issue(second_milestone, [first_priority, second_priority, no_priority])
      third_milestone_first_priority = create_issue(third_milestone, [first_priority, second_priority, no_priority])
      first_milestone_second_priority = create_issue(first_milestone, [second_priority, no_priority])
      second_milestone_second_priority = create_issue(second_milestone, [second_priority, no_priority])
      no_milestone_second_priority = create_issue(nil, [second_priority, no_priority])
      first_milestone_no_priority = create_issue(first_milestone, [no_priority])
      second_milestone_no_labels = create_issue(second_milestone, [])
      third_milestone_no_priority = create_issue(third_milestone, [no_priority])

      result = Issue.order_due_date_and_labels_priority

      expect(result).to eq([first_milestone_second_priority,
                            first_milestone_no_priority,
                            second_milestone_first_priority,
                            second_milestone_second_priority,
                            second_milestone_no_labels,
                            third_milestone_first_priority,
                            no_milestone_second_priority,
                            third_milestone_no_priority])
603 604
    end
  end
605

606 607 608 609 610 611 612 613 614 615 616 617 618 619
  describe '.order_labels_priority' do
    let(:label_1) { create(:label, title: 'label_1', project: issue.project, priority: 1) }
    let(:label_2) { create(:label, title: 'label_2', project: issue.project, priority: 2) }

    subject { Issue.order_labels_priority(excluded_labels: ['label_1']).first.highest_priority }

    before do
      issue.labels << label_1
      issue.labels << label_2
    end

    it { is_expected.to eq(2) }
  end

620
  describe ".with_label" do
621
    let(:project) { create(:project, :public) }
622 623 624 625 626 627 628
    let(:bug) { create(:label, project: project, title: 'bug') }
    let(:feature) { create(:label, project: project, title: 'feature') }
    let(:enhancement) { create(:label, project: project, title: 'enhancement') }
    let(:issue1) { create(:issue, title: "Bugfix1", project: project) }
    let(:issue2) { create(:issue, title: "Bugfix2", project: project) }
    let(:issue3) { create(:issue, title: "Feature1", project: project) }

629
    before do
630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648
      issue1.labels << bug
      issue1.labels << feature
      issue2.labels << bug
      issue2.labels << enhancement
      issue3.labels << feature
    end

    it 'finds the correct issue containing just enhancement label' do
      expect(Issue.with_label(enhancement.title)).to match_array([issue2])
    end

    it 'finds the correct issues containing the same label' do
      expect(Issue.with_label(bug.title)).to match_array([issue1, issue2])
    end

    it 'finds the correct issues containing only both labels' do
      expect(Issue.with_label([bug.title, enhancement.title])).to match_array([issue2])
    end
  end
Yorick Peterse's avatar
Yorick Peterse committed
649

650 651 652 653 654
  describe '#spend_time' do
    let(:user) { create(:user) }
    let(:issue) { create(:issue) }

    def spend_time(seconds)
655
      issue.spend_time(duration: seconds, user_id: user.id)
656 657 658 659 660 661 662 663 664
      issue.save!
    end

    context 'adding time' do
      it 'should update the total time spent' do
        spend_time(1800)

        expect(issue.total_time_spent).to eq(1800)
      end
665 666 667 668 669 670 671 672

      it 'updates issues updated_at' do
        issue

        Timecop.travel(1.minute.from_now) do
          expect { spend_time(1800) }.to change { issue.updated_at }
        end
      end
673 674
    end

675
    context 'subtracting time' do
676 677 678 679 680 681 682 683 684 685
      before do
        spend_time(1800)
      end

      it 'should update the total time spent' do
        spend_time(-900)

        expect(issue.total_time_spent).to eq(900)
      end

686
      context 'when time to subtract exceeds the total time spent' do
687
        it 'raise a validation error' do
688 689 690 691 692 693 694
          Timecop.travel(1.minute.from_now) do
            expect do
              expect do
                spend_time(-3600)
              end.to raise_error(ActiveRecord::RecordInvalid)
            end.not_to change { issue.updated_at }
          end
695 696 697 698
        end
      end
    end
  end
699 700 701

  describe '#first_contribution?' do
    let(:group) { create(:group) }
micael.bergeron's avatar
micael.bergeron committed
702 703
    let(:project) { create(:project, namespace: group) }
    let(:other_project) { create(:project) }
704
    let(:owner) { create(:owner) }
705
    let(:maintainer) { create(:user) }
706 707 708 709 710 711 712 713
    let(:reporter) { create(:user) }
    let(:guest) { create(:user) }

    let(:contributor) { create(:user) }
    let(:first_time_contributor) { create(:user) }

    before do
      group.add_owner(owner)
714
      project.add_maintainer(maintainer)
715 716 717 718
      project.add_reporter(reporter)
      project.add_guest(guest)
      project.add_guest(contributor)
      project.add_guest(first_time_contributor)
719
    end
micael.bergeron's avatar
micael.bergeron committed
720

721
    let(:merged_mr) { create(:merge_request, :merged, author: contributor, target_project: project, source_project: project) }
722
    let(:open_mr) { create(:merge_request, author: first_time_contributor, target_project: project, source_project: project) }
723 724 725
    let(:merged_mr_other_project) { create(:merge_request, :merged, author: first_time_contributor, target_project: other_project, source_project: other_project) }

    context "for merge requests" do
726 727
      it "is false for MAINTAINER" do
        mr = create(:merge_request, author: maintainer, target_project: project, source_project: project)
728 729

        expect(mr).not_to be_first_contribution
730 731 732 733
      end

      it "is false for OWNER" do
        mr = create(:merge_request, author: owner, target_project: project, source_project: project)
micael.bergeron's avatar
micael.bergeron committed
734

735
        expect(mr).not_to be_first_contribution
736 737 738 739
      end

      it "is false for REPORTER" do
        mr = create(:merge_request, author: reporter, target_project: project, source_project: project)
micael.bergeron's avatar
micael.bergeron committed
740

741
        expect(mr).not_to be_first_contribution
742 743 744
      end

      it "is true when you don't have any merged MR" do
745 746
        expect(open_mr).to be_first_contribution
        expect(merged_mr).not_to be_first_contribution
747 748
      end

749 750 751
      it "handles multiple projects separately" do
        expect(open_mr).to be_first_contribution
        expect(merged_mr_other_project).not_to be_first_contribution
752 753 754 755 756 757 758
      end
    end

    context "for issues" do
      let(:contributor_issue) { create(:issue, author: contributor, project: project) }
      let(:first_time_contributor_issue) { create(:issue, author: first_time_contributor, project: project) }

759
      it "is false even without merged MR" do
760
        expect(merged_mr).to be
761
        expect(first_time_contributor_issue).not_to be_first_contribution
762
        expect(contributor_issue).not_to be_first_contribution
763 764 765
      end
    end
  end
766
end