.rubocop_todo.yml 18.8 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Douwe Maan's avatar
Douwe Maan committed
2
3
# `rubocop --auto-gen-config`
# on 2017-02-21 18:00:50 -0600 using RuboCop version 0.46.0.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4
5
6
7
8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 15
10
11
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup:
Douwe Maan's avatar
Douwe Maan committed
12
13
14
15
16
17
18
19
20
  Exclude:
    - 'spec/features/issues_spec.rb'
    - 'spec/features/notes_on_merge_requests_spec.rb'
    - 'spec/lib/gitlab/git_access_spec.rb'
    - 'spec/models/project_snippet_spec.rb'
    - 'spec/models/protected_branch_spec.rb'
    - 'spec/routing/routing_spec.rb'

# Offense count: 63
21
22
23
24
25
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Enabled: false

26
27
28
29
# Offense count: 12
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should
RSpec/ImplicitExpect:
Douwe Maan's avatar
Douwe Maan committed
30
31
32
33
34
  Exclude:
    - 'spec/lib/banzai/renderer_spec.rb'
    - 'spec/models/project_group_link_spec.rb'
    - 'spec/models/project_services/external_wiki_service_spec.rb'
    - 'spec/models/project_spec.rb'
35
36
37

# Offense count: 1
RSpec/SingleArgumentMessageChain:
Douwe Maan's avatar
Douwe Maan committed
38
39
  Exclude:
    - 'spec/requests/api/internal_spec.rb'
40

Douwe Maan's avatar
Douwe Maan committed
41
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
42
43
44
45
46
47
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
48
# Offense count: 6
49
# Cop supports --auto-correct.
Connor Shea's avatar
Connor Shea committed
50
Style/EachWithObject:
Douwe Maan's avatar
Douwe Maan committed
51
52
53
54
55
56
57
  Exclude:
    - 'app/services/merge_requests/get_urls_service.rb'
    - 'lib/ci/ansi2html.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
Connor Shea's avatar
Connor Shea committed
58

59
# Offense count: 24
Connor Shea's avatar
Connor Shea committed
60
61
62
63
64
65
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

66
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
67
68
# Cop supports --auto-correct.
Style/EmptyLiteral:
Douwe Maan's avatar
Douwe Maan committed
69
70
71
72
73
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
74

Douwe Maan's avatar
Douwe Maan committed
75
# Offense count: 55
76
77
78
79
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Connor Shea's avatar
Connor Shea committed
80
  Enabled: false
Connor Shea's avatar
Connor Shea committed
81

Douwe Maan's avatar
Douwe Maan committed
82
# Offense count: 173
Connor Shea's avatar
Connor Shea committed
83
84
85
86
87
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
  Enabled: false

88
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
89
90
91
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
92
93
94
95
96
97
98
99
100
  Exclude:
    - 'app/models/ci/pipeline.rb'
    - 'app/services/gravatar_service.rb'
    - 'config/initializers/rack_lineprof.rb'
    - 'lib/gitlab/version_info.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/services/issues/move_service_spec.rb'

# Offense count: 261
Connor Shea's avatar
Connor Shea committed
101
102
103
104
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
105
# Offense count: 12
Connor Shea's avatar
Connor Shea committed
106
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
107
108
109
110
111
112
113
114
115
116
117
118
119
120
  Exclude:
    - 'app/controllers/projects/forks_controller.rb'
    - 'app/controllers/projects/imports_controller.rb'
    - 'app/helpers/milestones_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/services/system_note_service.rb'
    - 'config/initializers/1_settings.rb'
    - 'lib/gitlab/auth.rb'
    - 'lib/gitlab/checks/change_access.rb'
    - 'lib/gitlab/database.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'

# Offense count: 178
Connor Shea's avatar
Connor Shea committed
121
122
123
124
125
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
126
# Offense count: 61
Connor Shea's avatar
Connor Shea committed
127
128
129
130
131
132
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
133
# Offense count: 110
Connor Shea's avatar
Connor Shea committed
134
135
136
137
138
139
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
140
# Offense count: 45
Connor Shea's avatar
Connor Shea committed
141
142
143
144
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
Connor Shea's avatar
Connor Shea committed
145
  Enabled: false
Connor Shea's avatar
Connor Shea committed
146

Douwe Maan's avatar
Douwe Maan committed
147
# Offense count: 7
Connor Shea's avatar
Connor Shea committed
148
149
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Douwe Maan's avatar
Douwe Maan committed
150
151
152
153
154
155
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/git_operation_service.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
156

Douwe Maan's avatar
Douwe Maan committed
157
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
158
159
# Cop supports --auto-correct.
Style/MethodCallParentheses:
Douwe Maan's avatar
Douwe Maan committed
160
161
162
163
164
165
166
167
168
169
170
171
172
  Exclude:
    - 'lib/ci/ansi2html.rb'
    - 'spec/controllers/projects/issues_controller_spec.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/controllers/projects/snippets_controller_spec.rb'
    - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_assignee_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_author_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_milestone_spec.rb'
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/helpers/submodule_helper_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
Connor Shea's avatar
Connor Shea committed
173

174
# Offense count: 9
175
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
176
177
178
179
180
181
182
183
184
185
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/models/commit.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/repository.rb'
    - 'config/initializers/gollum.rb'
    - 'lib/bitbucket/collection.rb'
    - 'lib/gitlab/github_import/client.rb'
    - 'lib/gitlab/lazy.rb'
    - 'lib/uploaded_file.rb'
186

187
188
189
# Offense count: 3
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Douwe Maan's avatar
Douwe Maan committed
190
191
192
193
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'lib/gitlab/workhorse.rb'
194

195
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
196
197
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
198
199
200
201
202
  Exclude:
    - 'app/helpers/commits_helper.rb'
    - 'app/workers/irker_worker.rb'
    - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
    - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
Connor Shea's avatar
Connor Shea committed
203

Douwe Maan's avatar
Douwe Maan committed
204
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
205
206
207
208
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
209
210
211
212
213
214
215
216
217
218
219
220
221
  Exclude:
    - 'app/models/namespace.rb'
    - 'app/models/user.rb'
    - 'app/services/merge_requests/refresh_service.rb'
    - 'config/initializers/secret_token.rb'
    - 'db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
    - 'db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
    - 'lib/banzai/filter/math_filter.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/metrics/instrumentation.rb'
    - 'lib/gitlab/metrics/sampler.rb'
    - 'lib/gitlab/project_search_results.rb'
Connor Shea's avatar
Connor Shea committed
222

223
# Offense count: 19
Z.J. van de Weg's avatar
Z.J. van de Weg committed
224
225
226
227
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
  Exclude:
    - 'config/initializers/1_settings.rb'
    - 'config/initializers/secret_token.rb'
    - 'lib/gitlab/import_export/command_line_util.rb'
    - 'lib/gitlab/shell.rb'
    - 'lib/gitlab/workhorse.rb'
    - 'spec/features/projects/import_export/export_file_spec.rb'
    - 'spec/lib/gitlab/git/blob_spec.rb'
    - 'spec/lib/gitlab/git/hook_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'
    - 'spec/support/test_env.rb'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 68
244
# Cop supports --auto-correct.
245
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
246
247
248
249
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
250
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
251
252
253
254
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
255
# Offense count: 459
Connor Shea's avatar
Connor Shea committed
256
257
258
259
260
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

261
# Offense count: 10
Connor Shea's avatar
Connor Shea committed
262
263
264
265
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals:
Douwe Maan's avatar
Douwe Maan committed
266
267
268
269
270
271
272
  Exclude:
    - 'spec/lib/gitlab/diff/highlight_spec.rb'
    - 'spec/models/project_services/bamboo_service_spec.rb'
    - 'spec/models/project_services/buildkite_service_spec.rb'
    - 'spec/models/project_services/drone_ci_service_spec.rb'
    - 'spec/models/project_services/teamcity_service_spec.rb'
    - 'spec/workers/repository_import_worker_spec.rb'
Connor Shea's avatar
Connor Shea committed
273

Connor Shea's avatar
Connor Shea committed
274
# Offense count: 13
Connor Shea's avatar
Connor Shea committed
275
276
# Cop supports --auto-correct.
Style/PerlBackrefs:
Douwe Maan's avatar
Douwe Maan committed
277
278
279
280
281
282
283
284
285
286
287
288
289
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

# Offense count: 72
Connor Shea's avatar
Connor Shea committed
290
291
292
293
294
295
296
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
Style/PredicateName:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
297
# Offense count: 39
Z.J. van de Weg's avatar
Z.J. van de Weg committed
298
# Cop supports --auto-correct.
299
300
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: short, verbose
Z.J. van de Weg's avatar
Z.J. van de Weg committed
301
Style/PreferredHashMethods:
Connor Shea's avatar
Connor Shea committed
302
303
  Enabled: false

304
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
305
306
# Cop supports --auto-correct.
Style/Proc:
Douwe Maan's avatar
Douwe Maan committed
307
308
309
310
311
312
313
  Exclude:
    - 'app/mailers/base_mailer.rb'
    - 'app/models/milestone.rb'
    - 'app/models/service.rb'
    - 'lib/api/api_guard.rb'
    - 'lib/gitlab/ldap/config.rb'
    - 'spec/initializers/trusted_proxies_spec.rb'
Connor Shea's avatar
Connor Shea committed
314

Douwe Maan's avatar
Douwe Maan committed
315
# Offense count: 62
Connor Shea's avatar
Connor Shea committed
316
317
318
319
320
321
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
322
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
323
324
# Cop supports --auto-correct.
Style/RedundantBegin:
Douwe Maan's avatar
Douwe Maan committed
325
326
327
328
  Exclude:
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/gitlab/git/commit.rb'
Connor Shea's avatar
Connor Shea committed
329

Douwe Maan's avatar
Douwe Maan committed
330
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
331
332
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
  Exclude:
    - 'app/models/commit.rb'
    - 'app/models/merge_request.rb'
    - 'app/validators/color_validator.rb'
    - 'app/validators/line_code_validator.rb'
    - 'lib/api/templates.rb'
    - 'lib/api/v3/templates.rb'
    - 'lib/banzai/filter/blockquote_fence_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/banzai/filter/yaml_front_matter_filter.rb'
    - 'lib/gitlab/diff/inline_diff.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'lib/gitlab/middleware/static.rb'
    - 'lib/gitlab/regex.rb'
Connor Shea's avatar
Connor Shea committed
348

Douwe Maan's avatar
Douwe Maan committed
349
# Offense count: 15
350
351
352
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Douwe Maan's avatar
Douwe Maan committed
353
354
355
356
357
358
359
360
361
362
363
364
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/groups_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/labels_controller.rb'
    - 'app/controllers/projects/milestones_controller.rb'
    - 'app/services/access_token_validation_service.rb'

# Offense count: 365
Connor Shea's avatar
Connor Shea committed
365
366
367
368
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
369
# Offense count: 107
Connor Shea's avatar
Connor Shea committed
370
371
372
373
374
375
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
376
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
377
378
# Cop supports --auto-correct.
Style/RescueModifier:
379
  Enabled: false
380
381

# Offense count: 7
Connor Shea's avatar
Connor Shea committed
382
383
# Cop supports --auto-correct.
Style/SelfAssignment:
Douwe Maan's avatar
Douwe Maan committed
384
385
386
387
388
389
  Exclude:
    - 'app/models/project_team.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
390
391
392

# Offense count: 2
# Configuration parameters: Methods.
393
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Connor Shea's avatar
Connor Shea committed
394
Style/SingleLineBlockParams:
Douwe Maan's avatar
Douwe Maan committed
395
396
397
  Exclude:
    - 'app/models/commit.rb'
    - 'spec/support/services_shared_context.rb'
Connor Shea's avatar
Connor Shea committed
398
399
400
401
402

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Douwe Maan's avatar
Douwe Maan committed
403
404
  Exclude:
    - 'lib/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
405

Douwe Maan's avatar
Douwe Maan committed
406
# Offense count: 150
Connor Shea's avatar
Connor Shea committed
407
408
409
410
411
412
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
Style/SpaceBeforeBlockBraces:
  Enabled: false

413
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
414
415
416
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
Douwe Maan's avatar
Douwe Maan committed
417
418
419
420
421
422
  Exclude:
    - 'config/routes/project.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/system_note_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
423

Douwe Maan's avatar
Douwe Maan committed
424
# Offense count: 38
425
426
427
428
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral:
Douwe Maan's avatar
Douwe Maan committed
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
  Exclude:
    - 'app/models/commit_status.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/issue.rb'
    - 'app/models/member.rb'
    - 'lib/api/entities.rb'
    - 'lib/file_size_validator.rb'
    - 'lib/gitlab/visibility_level.rb'
    - 'spec/models/concerns/participable_spec.rb'
    - 'spec/models/cycle_analytics/code_spec.rb'
    - 'spec/models/cycle_analytics/issue_spec.rb'
    - 'spec/models/cycle_analytics/plan_spec.rb'
    - 'spec/models/cycle_analytics/production_spec.rb'
    - 'spec/models/cycle_analytics/review_spec.rb'
    - 'spec/models/cycle_analytics/staging_spec.rb'
    - 'spec/models/cycle_analytics/test_spec.rb'

# Offense count: 205
Connor Shea's avatar
Connor Shea committed
447
448
449
450
451
452
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
453
# Offense count: 90
Connor Shea's avatar
Connor Shea committed
454
455
456
# Cop supports --auto-correct.
Style/SpaceInsideParens:
  Enabled: false
Z.J. van de Weg's avatar
Z.J. van de Weg committed
457

458
# Offense count: 4
Z.J. van de Weg's avatar
Z.J. van de Weg committed
459
460
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
Douwe Maan's avatar
Douwe Maan committed
461
462
  Exclude:
    - 'lib/gitlab/git_access.rb'
Connor Shea's avatar
Connor Shea committed
463

Douwe Maan's avatar
Douwe Maan committed
464
# Offense count: 52
Connor Shea's avatar
Connor Shea committed
465
466
467
468
469
470
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

471
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
472
473
474
475
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
  Exclude:
    - 'app/helpers/labels_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/helpers/todos_helper.rb'
    - 'app/models/application_setting.rb'
    - 'app/models/project_services/campfire_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'db/migrate/20161017125927_add_unique_index_to_labels.rb'
    - 'features/steps/groups.rb'
    - 'features/steps/project/merge_requests.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/ci/gitlab_ci_yaml_processor.rb'
    - 'lib/gitlab/google_code_import/importer.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/models/project_services/hipchat_service_spec.rb'
491

Douwe Maan's avatar
Douwe Maan committed
492
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
493
494
495
496
497
498
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

499
500
501
# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
502
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
503
Style/TernaryParentheses:
Douwe Maan's avatar
Douwe Maan committed
504
505
506
507
508
509
  Exclude:
    - 'features/support/capybara.rb'
    - 'lib/api/v3/projects.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/support/capybara.rb'
510

Douwe Maan's avatar
Douwe Maan committed
511
# Offense count: 43
Connor Shea's avatar
Connor Shea committed
512
513
514
515
516
517
518
519
520
521
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
  Enabled: false

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Douwe Maan's avatar
Douwe Maan committed
522
523
524
525
526
527
528
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/controllers/projects/git_http_client_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/logger.rb'
Connor Shea's avatar
Connor Shea committed
529

Douwe Maan's avatar
Douwe Maan committed
530
# Offense count: 76
Connor Shea's avatar
Connor Shea committed
531
532
533
534
# Cop supports --auto-correct.
Style/TrailingWhitespace:
  Enabled: false

535
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
536
537
538
539
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Douwe Maan's avatar
Douwe Maan committed
540
541
542
543
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
    - 'lib/gitlab/ldap/person.rb'
Connor Shea's avatar
Connor Shea committed
544

545
# Offense count: 2
Connor Shea's avatar
Connor Shea committed
546
547
# Cop supports --auto-correct.
Style/UnlessElse:
Douwe Maan's avatar
Douwe Maan committed
548
549
550
  Exclude:
    - 'lib/gitlab/project_search_results.rb'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
551

Douwe Maan's avatar
Douwe Maan committed
552
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
553
554
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
  Exclude:
    - 'app/helpers/boards_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/helpers/search_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/project_services/pushover_service.rb'
    - 'features/steps/project/forked_merge_requests.rb'
    - 'spec/controllers/admin/services_controller_spec.rb'
    - 'spec/features/admin/admin_projects_spec.rb'
    - 'spec/features/issues_spec.rb'
    - 'spec/features/projects/branches_spec.rb'
    - 'spec/features/projects/issuable_templates_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/requests/api/issues_spec.rb'
    - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
Connor Shea's avatar
Connor Shea committed
571
572
573
574

# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Douwe Maan's avatar
Douwe Maan committed
575
576
577
578
579
580
581
582
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/models/repository.rb'
    - 'lib/extracts_path.rb'