.rubocop_todo.yml 24.9 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Rémy Coutable's avatar
Rémy Coutable committed
2
# `rubocop --auto-gen-config`
3
# on 2018-01-18 18:23:26 +0100 using RuboCop version 0.52.1.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 181
Rémy Coutable's avatar
Rémy Coutable committed
10 11 12
Capybara/CurrentPathExpectation:
  Enabled: false

13
# Offense count: 956
Rémy Coutable's avatar
Rémy Coutable committed
14 15 16
Capybara/FeatureMethods:
  Enabled: false

17
# Offense count: 23
Rémy Coutable's avatar
Rémy Coutable committed
18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34
FactoryBot/DynamicAttributeDefinedStatically:
  Exclude:
    - 'spec/factories/broadcast_messages.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/runners.rb'
    - 'spec/factories/clusters/applications/helm.rb'
    - 'spec/factories/clusters/platforms/kubernetes.rb'
    - 'spec/factories/emails.rb'
    - 'spec/factories/gpg_keys.rb'
    - 'spec/factories/group_members.rb'
    - 'spec/factories/merge_requests.rb'
    - 'spec/factories/notes.rb'
    - 'spec/factories/oauth_access_grants.rb'
    - 'spec/factories/project_members.rb'
    - 'spec/factories/todos.rb'
    - 'spec/factories/uploads.rb'

35
# Offense count: 167
Rémy Coutable's avatar
Rémy Coutable committed
36 37 38 39
# Cop supports --auto-correct.
Layout/EmptyLinesAroundArguments:
  Enabled: false

40
# Offense count: 253
41 42 43 44 45
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Layout/ExtraSpacing:
  Enabled: false

46
# Offense count: 83
47
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
48
# Configuration parameters: EnforcedStyle, IndentationWidth.
49 50 51 52
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Layout/IndentArray:
  Enabled: false

53
# Offense count: 237
54
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
55
# Configuration parameters: EnforcedStyle, IndentationWidth.
56 57 58 59
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Layout/IndentHash:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
60
# Offense count: 11
61
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
62 63 64 65 66 67 68 69 70 71 72 73 74 75 76
# Configuration parameters: AllowForAlignment.
Layout/SpaceBeforeFirstArg:
  Exclude:
    - 'config/routes/project.rb'
    - 'db/migrate/20170506185517_add_foreign_key_pipeline_schedules_and_pipelines.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/search/user_uses_search_filters_spec.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/system_note_service_spec.rb'

# Offense count: 93
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
77 78 79 80
# SupportedStyles: require_no_space, require_space
Layout/SpaceInLambdaLiteral:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
81
# Offense count: 1
82
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
83 84 85 86 87 88 89
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
# SupportedStyles: space, no_space, compact
# SupportedStylesForEmptyBrackets: space, no_space
Layout/SpaceInsideArrayLiteralBrackets:
  Exclude:
    - 'spec/lib/gitlab/import_export/relation_factory_spec.rb'

90
# Offense count: 327
Rémy Coutable's avatar
Rémy Coutable committed
91 92
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
93 94 95 96 97
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
  Enabled: false

98
# Offense count: 156
99 100 101 102 103 104 105
# Cop supports --auto-correct.
Layout/SpaceInsideParens:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Layout/SpaceInsidePercentLiteralDelimiters:
Rémy Coutable's avatar
Rémy Coutable committed
106 107 108 109 110
  Exclude:
    - 'lib/gitlab/git_access.rb'
    - 'lib/gitlab/health_checks/fs_shards_check.rb'
    - 'spec/lib/gitlab/health_checks/fs_shards_check_spec.rb'

111
# Offense count: 26
Rémy Coutable's avatar
Rémy Coutable committed
112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136
Lint/DuplicateMethods:
  Exclude:
    - 'app/models/application_setting.rb'
    - 'app/models/commit.rb'
    - 'app/models/note.rb'
    - 'app/services/merge_requests/merge_service.rb'
    - 'lib/bitbucket/representation/repo.rb'
    - 'lib/declarative_policy/base.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'lib/gitlab/cycle_analytics/base_event_fetcher.rb'
    - 'lib/gitlab/diff/formatters/base_formatter.rb'
    - 'lib/gitlab/git/blob.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/git/tree.rb'
    - 'lib/gitlab/git/wiki_page.rb'
    - 'lib/gitlab/ldap/person.rb'
    - 'lib/gitlab/o_auth/user.rb'

# Offense count: 4
Lint/InterpolationCheck:
  Exclude:
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/features/users_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'

137
# Offense count: 206
Rémy Coutable's avatar
Rémy Coutable committed
138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
  Enabled: false

# Offense count: 2
Lint/NestedPercentLiteral:
  Exclude:
    - 'lib/gitlab/git/repository.rb'
    - 'spec/support/email_format_shared_examples.rb'

# Offense count: 1
Lint/ReturnInVoidContext:
  Exclude:
    - 'app/models/project.rb'

# Offense count: 1
# Configuration parameters: IgnoreImplicitReferences.
Lint/ShadowedArgument:
  Exclude:
    - 'lib/gitlab/database/sha_attribute.rb'

# Offense count: 3
# Cop supports --auto-correct.
Lint/UnneededRequireStatement:
  Exclude:
    - 'db/post_migrate/20161221153951_rename_reserved_project_names.rb'
    - 'db/post_migrate/20170313133418_rename_more_reserved_project_names.rb'
    - 'lib/declarative_policy.rb'

# Offense count: 9
Lint/UriEscapeUnescape:
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'spec/lib/google_api/auth_spec.rb'
    - 'spec/requests/api/files_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/requests/api/issues_spec.rb'
    - 'spec/requests/api/v3/issues_spec.rb'

178 179 180 181 182 183
# Offense count: 1
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310

Rémy Coutable's avatar
Rémy Coutable committed
184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200
# Offense count: 2
Naming/ConstantName:
  Exclude:
    - 'lib/gitlab/import_sources.rb'
    - 'lib/gitlab/ssh_public_key.rb'

# Offense count: 11
# Configuration parameters: EnforcedStyle.
# SupportedStyles: lowercase, uppercase
Naming/HeredocDelimiterCase:
  Exclude:
    - 'spec/lib/gitlab/diff/parser_spec.rb'
    - 'spec/lib/json_web_token/rsa_token_spec.rb'
    - 'spec/models/commit_spec.rb'
    - 'spec/support/repo_helpers.rb'
    - 'spec/support/seed_repo.rb'

201
# Offense count: 112
Rémy Coutable's avatar
Rémy Coutable committed
202 203 204 205 206
# Configuration parameters: Blacklist.
# Blacklist: END, (?-mix:EO[A-Z]{1})
Naming/HeredocDelimiterNaming:
  Enabled: false

207
# Offense count: 27
Rémy Coutable's avatar
Rémy Coutable committed
208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Performance/HashEachMethods:
  Enabled: false

# Offense count: 1
Performance/UnfreezeString:
  Exclude:
    - 'features/steps/project/commits/commits.rb'

# Offense count: 1
# Cop supports --auto-correct.
Performance/UriDefaultParser:
  Exclude:
    - 'lib/gitlab/url_sanitizer.rb'

224
# Offense count: 3821
Rémy Coutable's avatar
Rémy Coutable committed
225 226 227
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
228 229
  Enabled: false

230
# Offense count: 293
231 232 233
RSpec/EmptyLineAfterFinalLet:
  Enabled: false

234
# Offense count: 188
235 236 237
RSpec/EmptyLineAfterSubject:
  Enabled: false

238 239 240 241 242 243 244
# Offense count: 258
# Configuration parameters: EnforcedStyle.
# SupportedStyles: method_call, block
RSpec/ExpectChange:
  Enabled: false

# Offense count: 221
Rémy Coutable's avatar
Rémy Coutable committed
245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260
RSpec/ExpectInHook:
  Enabled: false

# Offense count: 7
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Exclude:
    - 'spec/spec_helper.rb'
    - 'spec/support/carrierwave.rb'
    - 'spec/support/db_cleaner.rb'
    - 'spec/support/gitaly.rb'
    - 'spec/support/setup_builds_storage.rb'

# Offense count: 19
# Configuration parameters: EnforcedStyle.
261 262
# SupportedStyles: it_behaves_like, it_should_behave_like
RSpec/ItBehavesLike:
Rémy Coutable's avatar
Rémy Coutable committed
263 264 265 266 267 268
  Exclude:
    - 'spec/lib/gitlab/git/commit_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/shell_spec.rb'
    - 'spec/services/notification_service_spec.rb'
    - 'spec/workers/git_garbage_collect_worker_spec.rb'
269

Rémy Coutable's avatar
Rémy Coutable committed
270
# Offense count: 5
271
RSpec/IteratedExpectation:
Rémy Coutable's avatar
Rémy Coutable committed
272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294
  Exclude:
    - 'spec/features/admin/admin_settings_spec.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/awards/user_interacts_with_awards_in_issue_spec.rb'
    - 'spec/lib/gitlab/gitlab_import/client_spec.rb'
    - 'spec/lib/gitlab/legacy_github_import/client_spec.rb'

# Offense count: 75
RSpec/LetBeforeExamples:
  Exclude:
    - 'spec/controllers/projects/commit_controller_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/lib/banzai/filter/user_reference_filter_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/milestone_spec.rb'
    - 'spec/models/project_services/packagist_service_spec.rb'
    - 'spec/models/repository_spec.rb'
    - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
    - 'spec/serializers/pipeline_details_entity_spec.rb'
    - 'spec/views/ci/lints/show.html.haml_spec.rb'
295

Rémy Coutable's avatar
Rémy Coutable committed
296 297 298 299 300 301
# Offense count: 1
RSpec/MultipleSubjects:
  Exclude:
    - 'spec/services/merge_requests/create_from_issue_service_spec.rb'

# Offense count: 4
302
RSpec/OverwritingSetup:
Rémy Coutable's avatar
Rémy Coutable committed
303 304 305 306 307 308
  Exclude:
    - 'spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb'
    - 'spec/models/email_spec.rb'
    - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
    - 'spec/services/notes/quick_actions_service_spec.rb'

309
# Offense count: 965
Rémy Coutable's avatar
Rémy Coutable committed
310 311 312
# Configuration parameters: Strict, EnforcedStyle.
# SupportedStyles: inflected, explicit
RSpec/PredicateMatcher:
313 314
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
315
# Offense count: 35
316 317 318
RSpec/RepeatedExample:
  Enabled: false

319
# Offense count: 140
Rémy Coutable's avatar
Rémy Coutable committed
320 321 322 323 324
# Configuration parameters: EnforcedStyle.
# SupportedStyles: and_return, block
RSpec/ReturnFromStub:
  Enabled: false

325
# Offense count: 112
326 327 328
RSpec/ScatteredLet:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
329
# Offense count: 22
330
RSpec/ScatteredSetup:
Rémy Coutable's avatar
Rémy Coutable committed
331 332 333 334 335 336 337 338
  Exclude:
    - 'spec/controllers/projects/templates_controller_spec.rb'
    - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
    - 'spec/lib/gitlab/git/env_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/requests/api/v3/builds_spec.rb'
    - 'spec/requests/api/v3/projects_spec.rb'
    - 'spec/services/projects/create_service_spec.rb'
339

340
# Offense count: 1
341
RSpec/SharedContext:
Rémy Coutable's avatar
Rémy Coutable committed
342 343 344 345 346 347 348 349 350 351 352 353
  Exclude:
    - 'spec/features/admin/admin_groups_spec.rb'

# Offense count: 5
RSpec/VoidExpect:
  Exclude:
    - 'spec/features/projects/artifacts/download_spec.rb'
    - 'spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb'
    - 'spec/models/ci/group_spec.rb'
    - 'spec/models/ci/runner_spec.rb'
    - 'spec/services/users/destroy_service_spec.rb'

354
# Offense count: 41
Rémy Coutable's avatar
Rémy Coutable committed
355 356 357
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/CreateTableWithTimestamps:
Douwe Maan's avatar
Douwe Maan committed
358 359
  Enabled: false

360
# Offense count: 155
361 362 363
Rails/FilePath:
  Enabled: false

364
# Offense count: 121
Rémy Coutable's avatar
Rémy Coutable committed
365 366 367 368 369
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
  Enabled: false

370
# Offense count: 157
Rémy Coutable's avatar
Rémy Coutable committed
371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/InverseOf:
  Enabled: false

# Offense count: 48
# Configuration parameters: Include.
# Include: app/controllers/**/*.rb
Rails/LexicallyScopedActionFilter:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Rails/Presence:
  Exclude:
    - 'app/controllers/projects/blob_controller.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/clusters/platforms/kubernetes.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/concerns/token_authenticatable.rb'
    - 'app/models/project_services/hipchat_service.rb'
    - 'app/models/project_services/irker_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'app/models/project_services/kubernetes_service.rb'
    - 'app/models/project_services/packagist_service.rb'
    - 'app/models/wiki_page.rb'
    - 'lib/gitlab/git/hook.rb'
    - 'lib/gitlab/github_import/importer/releases_importer.rb'

400 401 402 403
# Offense count: 2
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/ReversibleMigration:
Rémy Coutable's avatar
Rémy Coutable committed
404 405
  Exclude:
    - 'db/migrate/20160824103857_drop_unused_ci_tables.rb'
406

407
# Offense count: 446
408 409 410
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
Douwe Maan's avatar
Douwe Maan committed
411 412
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
413 414 415 416 417 418
# Offense count: 1
# Configuration parameters: Environments.
# Environments: development, test, production
Rails/UnknownEnv:
  Exclude:
    - 'db/migrate/20171124125748_populate_missing_merge_request_statuses.rb'
419

Rémy Coutable's avatar
Rémy Coutable committed
420
# Offense count: 13
421
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
422 423 424 425 426 427 428 429 430 431 432 433
Security/YAMLLoad:
  Exclude:
    - 'config/initializers/carrierwave.rb'
    - 'lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits.rb'
    - 'lib/gitlab/redis/wrapper.rb'
    - 'lib/system_check/incoming_email/imap_authentication_check.rb'
    - 'spec/config/mail_room_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'
    - 'spec/models/clusters/platforms/kubernetes_spec.rb'
    - 'spec/models/project_services/kubernetes_service_spec.rb'

434
# Offense count: 64
Rémy Coutable's avatar
Rémy Coutable committed
435 436
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
437 438 439
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false
440

Rémy Coutable's avatar
Rémy Coutable committed
441 442 443 444 445 446 447 448
# Offense count: 5
Style/CommentedKeyword:
  Exclude:
    - 'lib/tasks/gitlab/backup.rake'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 30
Style/DateTime:
Douwe Maan's avatar
Douwe Maan committed
449
  Enabled: false
Connor Shea's avatar
Connor Shea committed
450

Rémy Coutable's avatar
Rémy Coutable committed
451
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
452
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473
Style/Dir:
  Exclude:
    - 'qa/qa.rb'

# Offense count: 9
# Cop supports --auto-correct.
Style/EachWithObject:
  Exclude:
    - 'config/initializers/gollum.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ci/ansi2html.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/hook_data/issuable_builder.rb'
    - 'lib/gitlab/i18n/po_linter.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'scripts/static-analysis'

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
474 475 476 477
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
478 479 480 481 482 483 484 485
# Offense count: 14
# Cop supports --auto-correct.
Style/EmptyLambdaParameter:
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/runner.rb'

# Offense count: 12
Connor Shea's avatar
Connor Shea committed
486 487
# Cop supports --auto-correct.
Style/EmptyLiteral:
Rémy Coutable's avatar
Rémy Coutable committed
488 489 490 491 492 493 494 495 496 497 498 499
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/gitaly_client.rb'
    - 'scripts/trigger-build-omnibus'
    - 'spec/features/merge_requests/versions_spec.rb'
    - 'spec/helpers/merge_requests_helper_spec.rb'
    - 'spec/lib/gitlab/request_context_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/support/chat_slash_commands_shared_examples.rb'
500

501
# Offense count: 102
502
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
503
# Configuration parameters: EnforcedStyle.
504 505
# SupportedStyles: compact, expanded
Style/EmptyMethod:
506
  Enabled: false
Connor Shea's avatar
Connor Shea committed
507

508
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
509
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
510 511 512 513 514 515 516 517
Style/Encoding:
  Enabled: false

# Offense count: 2
Style/EvalWithLocation:
  Exclude:
    - 'app/models/service.rb'

518
# Offense count: 35
Rémy Coutable's avatar
Rémy Coutable committed
519 520
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
521 522
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
523 524
  Enabled: false

525
# Offense count: 384
Connor Shea's avatar
Connor Shea committed
526 527 528 529
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

530
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
531
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
532 533
  Enabled: false

534
# Offense count: 809
Connor Shea's avatar
Connor Shea committed
535 536 537 538
# Cop supports --auto-correct.
Style/IfUnlessModifier:
  Enabled: false

539
# Offense count: 75
Connor Shea's avatar
Connor Shea committed
540
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
541
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
542 543
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
544
  Enabled: false
Connor Shea's avatar
Connor Shea committed
545

Rémy Coutable's avatar
Rémy Coutable committed
546
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
547 548
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Rémy Coutable's avatar
Rémy Coutable committed
549 550 551 552 553 554
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'spec/features/issuables/markdown_references_spec.rb'
    - 'spec/lib/gitlab/checks/project_moved_spec.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
555

Rémy Coutable's avatar
Rémy Coutable committed
556
# Offense count: 39
Connor Shea's avatar
Connor Shea committed
557
# Cop supports --auto-correct.
558
Style/MethodCallWithoutArgsParentheses:
Douwe Maan's avatar
Douwe Maan committed
559
  Enabled: false
Connor Shea's avatar
Connor Shea committed
560

561
# Offense count: 18
562
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
563
  Enabled: false
564

Rémy Coutable's avatar
Rémy Coutable committed
565 566 567 568 569 570 571 572 573 574 575
# Offense count: 7
Style/MixinUsage:
  Exclude:
    - 'features/support/env.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/job_artifacts.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/factories/notes.rb'
    - 'spec/lib/gitlab/import_export/project_tree_restorer_spec.rb'
    - 'spec/lib/gitlab/import_export/version_checker_spec.rb'

576
# Offense count: 6
577 578
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Rémy Coutable's avatar
Rémy Coutable committed
579 580 581 582 583 584 585
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'app/services/ci/process_pipeline_service.rb'
    - 'app/services/create_deployment_service.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/ci/trace.rb'
586

587
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
588
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
589 590
# Configuration parameters: Whitelist.
# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
Connor Shea's avatar
Connor Shea committed
591
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
592
  Enabled: false
Connor Shea's avatar
Connor Shea committed
593

594
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
595
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
596
# Configuration parameters: EnforcedStyle, MinBodyLength.
Connor Shea's avatar
Connor Shea committed
597 598
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
599
  Enabled: false
Connor Shea's avatar
Connor Shea committed
600

601
# Offense count: 61
Z.J. van de Weg's avatar
Z.J. van de Weg committed
602
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
603
# Configuration parameters: EnforcedOctalStyle.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
604 605
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
606
  Enabled: false
Douwe Maan's avatar
Douwe Maan committed
607

608
# Offense count: 114
609
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
610
# Configuration parameters: AutoCorrect, EnforcedStyle.
611 612 613 614
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
615 616 617 618 619 620 621 622 623 624
# Offense count: 4
# Cop supports --auto-correct.
Style/OrAssignment:
  Exclude:
    - 'app/models/concerns/token_authenticatable.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/api/v3/members.rb'
    - 'lib/gitlab/project_transfer.rb'

# Offense count: 50
Connor Shea's avatar
Connor Shea committed
625 626 627 628
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

629
# Offense count: 917
Connor Shea's avatar
Connor Shea committed
630 631 632 633 634
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

635
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
636 637
# Cop supports --auto-correct.
Style/PerlBackrefs:
Rémy Coutable's avatar
Rémy Coutable committed
638 639 640 641 642 643 644 645 646 647 648 649 650
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

651
# Offense count: 87
Rémy Coutable's avatar
Rémy Coutable committed
652 653
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
654 655 656 657
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

658
# Offense count: 9
Connor Shea's avatar
Connor Shea committed
659 660
# Cop supports --auto-correct.
Style/RedundantBegin:
Rémy Coutable's avatar
Rémy Coutable committed
661 662 663 664 665 666 667 668 669 670 671 672 673 674 675
  Exclude:
    - 'app/controllers/projects/clusters/gcp_controller.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/api/branches.rb'
    - 'lib/gitlab/current_settings.rb'
    - 'lib/gitlab/git/commit.rb'
    - 'lib/gitlab/health_checks/base_abstract_check.rb'
    - 'lib/tasks/gitlab/task_helpers.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantConditional:
  Exclude:
    - 'lib/system_check/helpers.rb'
Connor Shea's avatar
Connor Shea committed
676

677
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
678 679
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
680
  Enabled: false
Connor Shea's avatar
Connor Shea committed
681

Rémy Coutable's avatar
Rémy Coutable committed
682
# Offense count: 15
683 684 685
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Rémy Coutable's avatar
Rémy Coutable committed
686 687 688 689 690 691 692 693 694 695 696
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/application_controller.rb'
    - 'app/services/access_token_validation_service.rb'
    - 'lib/gitlab/utils.rb'
    - 'lib/google_api/auth.rb'

697
# Offense count: 460
Connor Shea's avatar
Connor Shea committed
698 699 700 701
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

702
# Offense count: 142
Connor Shea's avatar
Connor Shea committed
703
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
704
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
Connor Shea's avatar
Connor Shea committed
705 706
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
707 708 709
  Enabled: true
  EnforcedStyle: mixed
  AllowInnerSlashes: false
Connor Shea's avatar
Connor Shea committed
710

711
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
712 713
# Cop supports --auto-correct.
Style/RescueModifier:
714
  Enabled: false
715

716
# Offense count: 107
Rémy Coutable's avatar
Rémy Coutable committed
717 718 719 720 721 722
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
  Enabled: false

723
# Offense count: 92
Rémy Coutable's avatar
Rémy Coutable committed
724 725 726 727 728
# Cop supports --auto-correct.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil.
Style/SafeNavigation:
  Enabled: false

729
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
730 731
# Cop supports --auto-correct.
Style/SelfAssignment:
Rémy Coutable's avatar
Rémy Coutable committed
732 733 734 735 736 737 738 739
  Exclude:
    - 'app/models/concerns/bulk_member_access_load.rb'
    - 'app/serializers/base_serializer.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/clusters/interchangeability_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
740 741 742 743 744

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Rémy Coutable's avatar
Rémy Coutable committed
745 746
  Exclude:
    - 'lib/gitlab/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
747

Rémy Coutable's avatar
Rémy Coutable committed
748
# Offense count: 66
Connor Shea's avatar
Connor Shea committed
749
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
750
# Configuration parameters: .
Connor Shea's avatar
Connor Shea committed
751 752 753 754
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

Rémy Coutable's avatar
Rémy Coutable committed
755
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
756
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
757 758 759 760 761 762 763
Style/StderrPuts:
  Exclude:
    - 'config/initializers/rspec_profiling.rb'

# Offense count: 45
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
764 765
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
766
  Enabled: false
767

768
# Offense count: 106
Connor Shea's avatar
Connor Shea committed
769 770 771 772 773 774
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
775
# Offense count: 9
776
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
777
# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
778
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
779
Style/TernaryParentheses:
Rémy Coutable's avatar
Rémy Coutable committed
780 781 782 783 784 785 786 787
  Exclude:
    - 'app/finders/projects_finder.rb'
    - 'app/helpers/namespaces_helper.rb'
    - 'features/support/capybara.rb'
    - 'lib/api/v3/projects.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/requests/api/pipeline_schedules_spec.rb'
    - 'spec/support/capybara.rb'
788

789
# Offense count: 17
Connor Shea's avatar
Connor Shea committed
790 791 792
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Rémy Coutable's avatar
Rémy Coutable committed
793 794 795 796 797 798 799 800 801 802 803 804 805
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/logger.rb'
    - 'lib/gitlab/upgrader.rb'
    - 'lib/system_check/app/migrations_are_up_check.rb'
    - 'lib/system_check/incoming_email/mail_room_running_check.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'lib/tasks/gitlab/task_helpers.rb'
    - 'spec/lib/gitlab/etag_caching/middleware_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
806

Rémy Coutable's avatar
Rémy Coutable committed
807
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
808 809 810 811
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Rémy Coutable's avatar
Rémy Coutable committed
812 813 814 815 816
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
    - 'lib/gitlab/ldap/person.rb'
    - 'lib/system_check/base_check.rb'
Connor Shea's avatar
Connor Shea committed
817

Rémy Coutable's avatar
Rémy Coutable committed
818
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
819 820
# Cop supports --auto-correct.
Style/UnlessElse:
Rémy Coutable's avatar
Rémy Coutable committed
821 822 823 824 825
  Exclude:
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/project_search_results.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
826

827
# Offense count: 31
Connor Shea's avatar
Connor Shea committed
828 829
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
830
  Enabled: false
Connor Shea's avatar
Connor Shea committed
831

832
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
833 834
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Rémy Coutable's avatar
Rémy Coutable committed
835 836 837 838 839 840 841 842 843 844 845
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/services/boards/create_service.rb'
    - 'app/services/merge_requests/conflicts/list_service.rb'
    - 'lib/declarative_policy/dsl.rb'
    - 'lib/extracts_path.rb'
    - 'lib/gitlab/git/repository.rb'

846
# Offense count: 22840
Rémy Coutable's avatar
Rémy Coutable committed
847 848 849 850
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310