.rubocop_todo.yml 23.4 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Rémy Coutable's avatar
Rémy Coutable committed
2
# `rubocop --auto-gen-config`
3
# on 2018-01-18 18:23:26 +0100 using RuboCop version 0.52.1.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 181
Rémy Coutable's avatar
Rémy Coutable committed
10 11 12
Capybara/CurrentPathExpectation:
  Enabled: false

13
# Offense count: 23
Rémy Coutable's avatar
Rémy Coutable committed
14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
FactoryBot/DynamicAttributeDefinedStatically:
  Exclude:
    - 'spec/factories/broadcast_messages.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/runners.rb'
    - 'spec/factories/clusters/applications/helm.rb'
    - 'spec/factories/clusters/platforms/kubernetes.rb'
    - 'spec/factories/emails.rb'
    - 'spec/factories/gpg_keys.rb'
    - 'spec/factories/group_members.rb'
    - 'spec/factories/merge_requests.rb'
    - 'spec/factories/notes.rb'
    - 'spec/factories/oauth_access_grants.rb'
    - 'spec/factories/project_members.rb'
    - 'spec/factories/todos.rb'
    - 'spec/factories/uploads.rb'

31
# Offense count: 167
Rémy Coutable's avatar
Rémy Coutable committed
32 33 34 35
# Cop supports --auto-correct.
Layout/EmptyLinesAroundArguments:
  Enabled: false

36
# Offense count: 253
37 38 39 40 41
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Layout/ExtraSpacing:
  Enabled: false

42
# Offense count: 83
43
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
44
# Configuration parameters: EnforcedStyle, IndentationWidth.
45 46 47 48
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Layout/IndentArray:
  Enabled: false

49
# Offense count: 237
50
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
51
# Configuration parameters: EnforcedStyle, IndentationWidth.
52 53 54 55
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Layout/IndentHash:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
56 57 58
# Offense count: 93
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
59 60 61 62
# SupportedStyles: require_no_space, require_space
Layout/SpaceInLambdaLiteral:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
63
# Offense count: 1
64
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
65 66 67 68 69 70 71
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
# SupportedStyles: space, no_space, compact
# SupportedStylesForEmptyBrackets: space, no_space
Layout/SpaceInsideArrayLiteralBrackets:
  Exclude:
    - 'spec/lib/gitlab/import_export/relation_factory_spec.rb'

72
# Offense count: 327
Rémy Coutable's avatar
Rémy Coutable committed
73 74
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
75 76 77 78 79
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
  Enabled: false

80
# Offense count: 156
81 82 83 84 85 86 87
# Cop supports --auto-correct.
Layout/SpaceInsideParens:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Layout/SpaceInsidePercentLiteralDelimiters:
Rémy Coutable's avatar
Rémy Coutable committed
88 89 90 91 92
  Exclude:
    - 'lib/gitlab/git_access.rb'
    - 'lib/gitlab/health_checks/fs_shards_check.rb'
    - 'spec/lib/gitlab/health_checks/fs_shards_check_spec.rb'

93
# Offense count: 26
Rémy Coutable's avatar
Rémy Coutable committed
94 95 96 97 98 99 100 101 102 103 104 105 106 107 108
Lint/DuplicateMethods:
  Exclude:
    - 'app/models/application_setting.rb'
    - 'app/models/commit.rb'
    - 'app/models/note.rb'
    - 'app/services/merge_requests/merge_service.rb'
    - 'lib/bitbucket/representation/repo.rb'
    - 'lib/declarative_policy/base.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'lib/gitlab/cycle_analytics/base_event_fetcher.rb'
    - 'lib/gitlab/diff/formatters/base_formatter.rb'
    - 'lib/gitlab/git/blob.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/git/tree.rb'
    - 'lib/gitlab/git/wiki_page.rb'
109 110
    - 'lib/gitlab/auth/ldap/person.rb'
    - 'lib/gitlab/auth/o_auth/user.rb'
Rémy Coutable's avatar
Rémy Coutable committed
111 112 113 114 115 116 117 118

# Offense count: 4
Lint/InterpolationCheck:
  Exclude:
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/features/users_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'

119
# Offense count: 206
Rémy Coutable's avatar
Rémy Coutable committed
120 121 122 123 124 125 126 127
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
  Enabled: false

# Offense count: 2
Lint/NestedPercentLiteral:
  Exclude:
    - 'lib/gitlab/git/repository.rb'
128
    - 'spec/support/shared_examples/email_format_shared_examples.rb'
Rémy Coutable's avatar
Rémy Coutable committed
129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158

# Offense count: 1
Lint/ReturnInVoidContext:
  Exclude:
    - 'app/models/project.rb'

# Offense count: 1
# Configuration parameters: IgnoreImplicitReferences.
Lint/ShadowedArgument:
  Exclude:
    - 'lib/gitlab/database/sha_attribute.rb'

# Offense count: 3
# Cop supports --auto-correct.
Lint/UnneededRequireStatement:
  Exclude:
    - 'db/post_migrate/20161221153951_rename_reserved_project_names.rb'
    - 'db/post_migrate/20170313133418_rename_more_reserved_project_names.rb'
    - 'lib/declarative_policy.rb'

# Offense count: 9
Lint/UriEscapeUnescape:
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'spec/lib/google_api/auth_spec.rb'
    - 'spec/requests/api/files_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/requests/api/issues_spec.rb'

159 160 161 162 163 164
# Offense count: 1
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310

Rémy Coutable's avatar
Rémy Coutable committed
165 166 167 168 169 170 171 172 173 174 175 176 177 178
# Offense count: 2
Naming/ConstantName:
  Exclude:
    - 'lib/gitlab/import_sources.rb'
    - 'lib/gitlab/ssh_public_key.rb'

# Offense count: 11
# Configuration parameters: EnforcedStyle.
# SupportedStyles: lowercase, uppercase
Naming/HeredocDelimiterCase:
  Exclude:
    - 'spec/lib/gitlab/diff/parser_spec.rb'
    - 'spec/lib/json_web_token/rsa_token_spec.rb'
    - 'spec/models/commit_spec.rb'
179 180
    - 'spec/support/helpers/repo_helpers.rb'
    - 'spec/support/helpers/seed_repo.rb'
Rémy Coutable's avatar
Rémy Coutable committed
181

182
# Offense count: 112
Rémy Coutable's avatar
Rémy Coutable committed
183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198
# Configuration parameters: Blacklist.
# Blacklist: END, (?-mix:EO[A-Z]{1})
Naming/HeredocDelimiterNaming:
  Enabled: false

# Offense count: 1
Performance/UnfreezeString:
  Exclude:
    - 'features/steps/project/commits/commits.rb'

# Offense count: 1
# Cop supports --auto-correct.
Performance/UriDefaultParser:
  Exclude:
    - 'lib/gitlab/url_sanitizer.rb'

199
# Offense count: 3821
Rémy Coutable's avatar
Rémy Coutable committed
200 201 202
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
203 204
  Enabled: false

205
# Offense count: 293
206 207 208
RSpec/EmptyLineAfterFinalLet:
  Enabled: false

209
# Offense count: 188
210 211 212
RSpec/EmptyLineAfterSubject:
  Enabled: false

213 214 215 216 217 218 219
# Offense count: 258
# Configuration parameters: EnforcedStyle.
# SupportedStyles: method_call, block
RSpec/ExpectChange:
  Enabled: false

# Offense count: 221
Rémy Coutable's avatar
Rémy Coutable committed
220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235
RSpec/ExpectInHook:
  Enabled: false

# Offense count: 7
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Exclude:
    - 'spec/spec_helper.rb'
    - 'spec/support/carrierwave.rb'
    - 'spec/support/db_cleaner.rb'
    - 'spec/support/gitaly.rb'
    - 'spec/support/setup_builds_storage.rb'

# Offense count: 19
# Configuration parameters: EnforcedStyle.
236 237
# SupportedStyles: it_behaves_like, it_should_behave_like
RSpec/ItBehavesLike:
Rémy Coutable's avatar
Rémy Coutable committed
238 239 240 241 242 243
  Exclude:
    - 'spec/lib/gitlab/git/commit_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/shell_spec.rb'
    - 'spec/services/notification_service_spec.rb'
    - 'spec/workers/git_garbage_collect_worker_spec.rb'
244

Rémy Coutable's avatar
Rémy Coutable committed
245
# Offense count: 5
246
RSpec/IteratedExpectation:
Rémy Coutable's avatar
Rémy Coutable committed
247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269
  Exclude:
    - 'spec/features/admin/admin_settings_spec.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/awards/user_interacts_with_awards_in_issue_spec.rb'
    - 'spec/lib/gitlab/gitlab_import/client_spec.rb'
    - 'spec/lib/gitlab/legacy_github_import/client_spec.rb'

# Offense count: 75
RSpec/LetBeforeExamples:
  Exclude:
    - 'spec/controllers/projects/commit_controller_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/lib/banzai/filter/user_reference_filter_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/milestone_spec.rb'
    - 'spec/models/project_services/packagist_service_spec.rb'
    - 'spec/models/repository_spec.rb'
    - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
    - 'spec/serializers/pipeline_details_entity_spec.rb'
    - 'spec/views/ci/lints/show.html.haml_spec.rb'
270

Rémy Coutable's avatar
Rémy Coutable committed
271 272 273 274 275 276
# Offense count: 1
RSpec/MultipleSubjects:
  Exclude:
    - 'spec/services/merge_requests/create_from_issue_service_spec.rb'

# Offense count: 4
277
RSpec/OverwritingSetup:
Rémy Coutable's avatar
Rémy Coutable committed
278 279 280 281 282 283
  Exclude:
    - 'spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb'
    - 'spec/models/email_spec.rb'
    - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
    - 'spec/services/notes/quick_actions_service_spec.rb'

284
# Offense count: 965
Rémy Coutable's avatar
Rémy Coutable committed
285 286 287
# Configuration parameters: Strict, EnforcedStyle.
# SupportedStyles: inflected, explicit
RSpec/PredicateMatcher:
288 289
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
290
# Offense count: 35
291 292 293
RSpec/RepeatedExample:
  Enabled: false

294
# Offense count: 140
Rémy Coutable's avatar
Rémy Coutable committed
295 296 297 298 299
# Configuration parameters: EnforcedStyle.
# SupportedStyles: and_return, block
RSpec/ReturnFromStub:
  Enabled: false

300
# Offense count: 112
301 302 303
RSpec/ScatteredLet:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
304
# Offense count: 22
305
RSpec/ScatteredSetup:
Rémy Coutable's avatar
Rémy Coutable committed
306 307 308 309 310 311
  Exclude:
    - 'spec/controllers/projects/templates_controller_spec.rb'
    - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
    - 'spec/lib/gitlab/git/env_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/services/projects/create_service_spec.rb'
312

313
# Offense count: 1
314
RSpec/SharedContext:
Rémy Coutable's avatar
Rémy Coutable committed
315 316 317 318 319 320 321 322 323 324 325 326
  Exclude:
    - 'spec/features/admin/admin_groups_spec.rb'

# Offense count: 5
RSpec/VoidExpect:
  Exclude:
    - 'spec/features/projects/artifacts/download_spec.rb'
    - 'spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb'
    - 'spec/models/ci/group_spec.rb'
    - 'spec/models/ci/runner_spec.rb'
    - 'spec/services/users/destroy_service_spec.rb'

327
# Offense count: 41
Rémy Coutable's avatar
Rémy Coutable committed
328 329 330
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/CreateTableWithTimestamps:
Douwe Maan's avatar
Douwe Maan committed
331 332
  Enabled: false

333
# Offense count: 155
334 335 336
Rails/FilePath:
  Enabled: false

337
# Offense count: 121
Rémy Coutable's avatar
Rémy Coutable committed
338 339 340 341 342
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
  Enabled: false

343
# Offense count: 157
Rémy Coutable's avatar
Rémy Coutable committed
344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/InverseOf:
  Enabled: false

# Offense count: 48
# Configuration parameters: Include.
# Include: app/controllers/**/*.rb
Rails/LexicallyScopedActionFilter:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Rails/Presence:
  Exclude:
    - 'app/controllers/projects/blob_controller.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/clusters/platforms/kubernetes.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/concerns/token_authenticatable.rb'
    - 'app/models/project_services/hipchat_service.rb'
    - 'app/models/project_services/irker_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'app/models/project_services/kubernetes_service.rb'
    - 'app/models/project_services/packagist_service.rb'
    - 'app/models/wiki_page.rb'
    - 'lib/gitlab/git/hook.rb'
    - 'lib/gitlab/github_import/importer/releases_importer.rb'

373 374 375 376
# Offense count: 2
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/ReversibleMigration:
Rémy Coutable's avatar
Rémy Coutable committed
377 378
  Exclude:
    - 'db/migrate/20160824103857_drop_unused_ci_tables.rb'
379

380
# Offense count: 446
381 382 383
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
Douwe Maan's avatar
Douwe Maan committed
384 385
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
386 387 388 389 390 391
# Offense count: 1
# Configuration parameters: Environments.
# Environments: development, test, production
Rails/UnknownEnv:
  Exclude:
    - 'db/migrate/20171124125748_populate_missing_merge_request_statuses.rb'
392

Rémy Coutable's avatar
Rémy Coutable committed
393
# Offense count: 13
394
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
395 396 397 398 399 400 401 402 403 404 405 406
Security/YAMLLoad:
  Exclude:
    - 'config/initializers/carrierwave.rb'
    - 'lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits.rb'
    - 'lib/gitlab/redis/wrapper.rb'
    - 'lib/system_check/incoming_email/imap_authentication_check.rb'
    - 'spec/config/mail_room_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'
    - 'spec/models/clusters/platforms/kubernetes_spec.rb'
    - 'spec/models/project_services/kubernetes_service_spec.rb'

407
# Offense count: 64
Rémy Coutable's avatar
Rémy Coutable committed
408 409
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
410 411 412
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false
413

Rémy Coutable's avatar
Rémy Coutable committed
414 415 416 417 418 419 420 421
# Offense count: 5
Style/CommentedKeyword:
  Exclude:
    - 'lib/tasks/gitlab/backup.rake'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 30
Style/DateTime:
Douwe Maan's avatar
Douwe Maan committed
422
  Enabled: false
Connor Shea's avatar
Connor Shea committed
423

Rémy Coutable's avatar
Rémy Coutable committed
424
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
425
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446
Style/Dir:
  Exclude:
    - 'qa/qa.rb'

# Offense count: 9
# Cop supports --auto-correct.
Style/EachWithObject:
  Exclude:
    - 'config/initializers/gollum.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ci/ansi2html.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/hook_data/issuable_builder.rb'
    - 'lib/gitlab/i18n/po_linter.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'scripts/static-analysis'

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
447 448 449 450
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
451 452 453 454 455 456 457 458
# Offense count: 14
# Cop supports --auto-correct.
Style/EmptyLambdaParameter:
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/runner.rb'

# Offense count: 12
Connor Shea's avatar
Connor Shea committed
459 460
# Cop supports --auto-correct.
Style/EmptyLiteral:
Rémy Coutable's avatar
Rémy Coutable committed
461 462 463 464 465
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/gitaly_client.rb'
466
    - 'scripts/trigger-build'
Rémy Coutable's avatar
Rémy Coutable committed
467 468 469 470 471
    - 'spec/features/merge_requests/versions_spec.rb'
    - 'spec/helpers/merge_requests_helper_spec.rb'
    - 'spec/lib/gitlab/request_context_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
472
    - 'spec/support/shared_examples/chat_slash_commands_shared_examples.rb'
473

474
# Offense count: 102
475
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
476
# Configuration parameters: EnforcedStyle.
477 478
# SupportedStyles: compact, expanded
Style/EmptyMethod:
479
  Enabled: false
Connor Shea's avatar
Connor Shea committed
480

481
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
482
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
483 484 485 486 487 488 489 490
Style/Encoding:
  Enabled: false

# Offense count: 2
Style/EvalWithLocation:
  Exclude:
    - 'app/models/service.rb'

491
# Offense count: 35
Rémy Coutable's avatar
Rémy Coutable committed
492 493
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
494 495
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
496 497
  Enabled: false

498
# Offense count: 384
Connor Shea's avatar
Connor Shea committed
499 500 501 502
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

503
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
504
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
505 506
  Enabled: false

507
# Offense count: 809
Connor Shea's avatar
Connor Shea committed
508 509 510 511
# Cop supports --auto-correct.
Style/IfUnlessModifier:
  Enabled: false

512
# Offense count: 75
Connor Shea's avatar
Connor Shea committed
513
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
514
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
515 516
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
517
  Enabled: false
Connor Shea's avatar
Connor Shea committed
518

Rémy Coutable's avatar
Rémy Coutable committed
519
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
520 521
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Rémy Coutable's avatar
Rémy Coutable committed
522 523 524 525 526 527
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'spec/features/issuables/markdown_references_spec.rb'
    - 'spec/lib/gitlab/checks/project_moved_spec.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
528

Rémy Coutable's avatar
Rémy Coutable committed
529
# Offense count: 39
Connor Shea's avatar
Connor Shea committed
530
# Cop supports --auto-correct.
531
Style/MethodCallWithoutArgsParentheses:
Douwe Maan's avatar
Douwe Maan committed
532
  Enabled: false
Connor Shea's avatar
Connor Shea committed
533

534
# Offense count: 18
535
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
536
  Enabled: false
537

Rémy Coutable's avatar
Rémy Coutable committed
538 539 540 541 542 543 544 545 546 547 548
# Offense count: 7
Style/MixinUsage:
  Exclude:
    - 'features/support/env.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/job_artifacts.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/factories/notes.rb'
    - 'spec/lib/gitlab/import_export/project_tree_restorer_spec.rb'
    - 'spec/lib/gitlab/import_export/version_checker_spec.rb'

549
# Offense count: 6
550 551
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Rémy Coutable's avatar
Rémy Coutable committed
552 553 554 555 556 557 558
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'app/services/ci/process_pipeline_service.rb'
    - 'app/services/create_deployment_service.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/ci/trace.rb'
559

560
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
561
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
562 563
# Configuration parameters: Whitelist.
# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
Connor Shea's avatar
Connor Shea committed
564
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
565
  Enabled: false
Connor Shea's avatar
Connor Shea committed
566

567
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
568
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
569
# Configuration parameters: EnforcedStyle, MinBodyLength.
Connor Shea's avatar
Connor Shea committed
570 571
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
572
  Enabled: false
Connor Shea's avatar
Connor Shea committed
573

574
# Offense count: 61
Z.J. van de Weg's avatar
Z.J. van de Weg committed
575
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
576
# Configuration parameters: EnforcedOctalStyle.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
577 578
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
579
  Enabled: false
Douwe Maan's avatar
Douwe Maan committed
580

581
# Offense count: 114
582
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
583
# Configuration parameters: AutoCorrect, EnforcedStyle.
584 585 586 587
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
588 589 590 591 592 593 594 595 596
# Offense count: 4
# Cop supports --auto-correct.
Style/OrAssignment:
  Exclude:
    - 'app/models/concerns/token_authenticatable.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/project_transfer.rb'

# Offense count: 50
Connor Shea's avatar
Connor Shea committed
597 598 599 600
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

601
# Offense count: 917
Connor Shea's avatar
Connor Shea committed
602 603 604 605 606
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

607
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
608 609
# Cop supports --auto-correct.
Style/PerlBackrefs:
Rémy Coutable's avatar
Rémy Coutable committed
610 611 612 613 614 615 616 617 618 619 620 621 622
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

623
# Offense count: 87
Rémy Coutable's avatar
Rémy Coutable committed
624 625
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
626 627 628 629
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

630
# Offense count: 9
Connor Shea's avatar
Connor Shea committed
631 632
# Cop supports --auto-correct.
Style/RedundantBegin:
Rémy Coutable's avatar
Rémy Coutable committed
633 634 635 636 637 638 639 640 641 642 643 644 645 646 647
  Exclude:
    - 'app/controllers/projects/clusters/gcp_controller.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/api/branches.rb'
    - 'lib/gitlab/current_settings.rb'
    - 'lib/gitlab/git/commit.rb'
    - 'lib/gitlab/health_checks/base_abstract_check.rb'
    - 'lib/tasks/gitlab/task_helpers.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantConditional:
  Exclude:
    - 'lib/system_check/helpers.rb'
Connor Shea's avatar
Connor Shea committed
648

649
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
650 651
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
652
  Enabled: false
Connor Shea's avatar
Connor Shea committed
653

Rémy Coutable's avatar
Rémy Coutable committed
654
# Offense count: 15
655 656 657
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Rémy Coutable's avatar
Rémy Coutable committed
658 659 660 661 662 663 664 665 666 667 668
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/application_controller.rb'
    - 'app/services/access_token_validation_service.rb'
    - 'lib/gitlab/utils.rb'
    - 'lib/google_api/auth.rb'

669
# Offense count: 460
Connor Shea's avatar
Connor Shea committed
670 671 672 673
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

674
# Offense count: 142
Connor Shea's avatar
Connor Shea committed
675
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
676
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
Connor Shea's avatar
Connor Shea committed
677 678
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
679 680 681
  Enabled: true
  EnforcedStyle: mixed
  AllowInnerSlashes: false
Connor Shea's avatar
Connor Shea committed
682

683
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
684 685
# Cop supports --auto-correct.
Style/RescueModifier:
686
  Enabled: false
687

688
# Offense count: 107
Rémy Coutable's avatar
Rémy Coutable committed
689 690 691 692 693 694
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
  Enabled: false

695
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
696 697
# Cop supports --auto-correct.
Style/SelfAssignment:
Rémy Coutable's avatar
Rémy Coutable committed
698 699 700 701 702 703 704 705
  Exclude:
    - 'app/models/concerns/bulk_member_access_load.rb'
    - 'app/serializers/base_serializer.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/clusters/interchangeability_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
706 707 708 709 710

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Rémy Coutable's avatar
Rémy Coutable committed
711 712
  Exclude:
    - 'lib/gitlab/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
713

Rémy Coutable's avatar
Rémy Coutable committed
714
# Offense count: 66
Connor Shea's avatar
Connor Shea committed
715
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
716
# Configuration parameters: .
Connor Shea's avatar
Connor Shea committed
717 718 719 720
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

Rémy Coutable's avatar
Rémy Coutable committed
721
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
722
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
723 724 725 726 727 728 729
Style/StderrPuts:
  Exclude:
    - 'config/initializers/rspec_profiling.rb'

# Offense count: 45
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
730 731
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
732
  Enabled: false
733

734
# Offense count: 106
Connor Shea's avatar
Connor Shea committed
735 736 737 738 739 740
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
741
# Offense count: 9
742
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
743
# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
744
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
745
Style/TernaryParentheses:
Rémy Coutable's avatar
Rémy Coutable committed
746 747 748 749 750 751 752
  Exclude:
    - 'app/finders/projects_finder.rb'
    - 'app/helpers/namespaces_helper.rb'
    - 'features/support/capybara.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/requests/api/pipeline_schedules_spec.rb'
    - 'spec/support/capybara.rb'
753

754
# Offense count: 17
Connor Shea's avatar
Connor Shea committed
755 756 757
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Rémy Coutable's avatar
Rémy Coutable committed
758 759 760 761 762 763 764 765 766 767 768 769 770
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/logger.rb'
    - 'lib/gitlab/upgrader.rb'
    - 'lib/system_check/app/migrations_are_up_check.rb'
    - 'lib/system_check/incoming_email/mail_room_running_check.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'lib/tasks/gitlab/task_helpers.rb'
    - 'spec/lib/gitlab/etag_caching/middleware_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
771

Rémy Coutable's avatar
Rémy Coutable committed
772
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
773 774 775 776
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Rémy Coutable's avatar
Rémy Coutable committed
777 778 779
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
780
    - 'lib/gitlab/auth/ldap/person.rb'
Rémy Coutable's avatar
Rémy Coutable committed
781
    - 'lib/system_check/base_check.rb'
Connor Shea's avatar
Connor Shea committed
782

Rémy Coutable's avatar
Rémy Coutable committed
783
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
784 785
# Cop supports --auto-correct.
Style/UnlessElse:
Rémy Coutable's avatar
Rémy Coutable committed
786 787 788 789 790
  Exclude:
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/project_search_results.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
791

792
# Offense count: 31
Connor Shea's avatar
Connor Shea committed
793 794
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
795
  Enabled: false
Connor Shea's avatar
Connor Shea committed
796

797
# Offense count: 22840
Rémy Coutable's avatar
Rémy Coutable committed
798 799 800 801
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310