pages_domains_controller_spec.rb 5.61 KB
Newer Older
1 2 3
require 'spec_helper'

describe Projects::PagesDomainsController do
4
  let(:user) { create(:user) }
5
  let(:project) { create(:project) }
6
  let!(:pages_domain) { create(:pages_domain, project: project) }
7 8 9 10 11 12 13 14

  let(:request_params) do
    {
      namespace_id: project.namespace,
      project_id: project
    }
  end

15
  let(:pages_domain_params) do
Rob Watson's avatar
Rob Watson committed
16
    build(:pages_domain, domain: 'my.otherdomain.com').slice(:key, :certificate, :domain)
17 18
  end

19
  before do
20
    allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
21
    sign_in(user)
22
    project.add_maintainer(user)
23 24 25
  end

  describe 'GET show' do
26
    def make_request
blackst0ne's avatar
blackst0ne committed
27
      get(:show, params: request_params.merge(id: pages_domain.domain))
28
    end
29

30 31
    it "displays the 'show' page" do
      make_request
32
      expect(response).to have_gitlab_http_status(200)
33 34
      expect(response).to render_template('show')
    end
35 36 37 38 39 40 41 42 43 44 45 46

    context 'when user is developer' do
      before do
        project.add_developer(user)
      end

      it 'renders 404 page' do
        make_request

        expect(response).to have_gitlab_http_status(404)
      end
    end
47 48 49 50
  end

  describe 'GET new' do
    it "displays the 'new' page" do
blackst0ne's avatar
blackst0ne committed
51
      get(:new, params: request_params)
52

53
      expect(response).to have_gitlab_http_status(200)
54 55 56 57 58 59 60
      expect(response).to render_template('new')
    end
  end

  describe 'POST create' do
    it "creates a new pages domain" do
      expect do
blackst0ne's avatar
blackst0ne committed
61
        post(:create, params: request_params.merge(pages_domain: pages_domain_params))
62 63
      end.to change { PagesDomain.count }.by(1)

64 65 66 67 68 69 70
      created_domain = PagesDomain.reorder(:id).last

      expect(created_domain).to be_present
      expect(response).to redirect_to(project_pages_domain_path(project, created_domain))
    end
  end

71 72
  describe 'GET edit' do
    it "displays the 'edit' page" do
blackst0ne's avatar
blackst0ne committed
73
      get(:edit, params: request_params.merge(id: pages_domain.domain))
74 75 76 77 78 79 80 81 82 83 84 85

      expect(response).to have_gitlab_http_status(200)
      expect(response).to render_template('edit')
    end
  end

  describe 'PATCH update' do
    before do
      controller.instance_variable_set(:@domain, pages_domain)
    end

    let(:pages_domain_params) do
Rob Watson's avatar
Rob Watson committed
86
      attributes_for(:pages_domain).slice(:key, :certificate)
87 88 89 90 91 92 93 94 95
    end

    let(:params) do
      request_params.merge(id: pages_domain.domain, pages_domain: pages_domain_params)
    end

    it 'updates the domain' do
      expect(pages_domain)
        .to receive(:update)
96
        .with(ActionController::Parameters.new(pages_domain_params).permit!)
97 98
        .and_return(true)

blackst0ne's avatar
blackst0ne committed
99
      patch(:update, params: params)
100 101 102
    end

    it 'redirects to the project page' do
blackst0ne's avatar
blackst0ne committed
103
      patch(:update, params: params)
104 105 106 107 108 109 110 111 112

      expect(flash[:notice]).to eq 'Domain was updated'
      expect(response).to redirect_to(project_pages_path(project))
    end

    context 'the domain is invalid' do
      it 'renders the edit action' do
        allow(pages_domain).to receive(:update).and_return(false)

blackst0ne's avatar
blackst0ne committed
113
        patch(:update, params: params)
114 115 116 117 118 119 120 121 122 123 124 125

        expect(response).to render_template('edit')
      end
    end

    context 'the parameters include the domain' do
      it 'renders 400 Bad Request' do
        expect(pages_domain)
          .to receive(:update)
          .with(hash_not_including(:domain))
          .and_return(true)

blackst0ne's avatar
blackst0ne committed
126
        patch(:update, params: params.deep_merge(pages_domain: { domain: 'abc' }))
127 128 129 130
      end
    end
  end

131 132 133 134 135 136 137 138 139 140 141 142 143 144
  describe 'POST verify' do
    let(:params) { request_params.merge(id: pages_domain.domain) }

    def stub_service
      service = double(:service)

      expect(VerifyPagesDomainService).to receive(:new) { service }

      service
    end

    it 'handles verification success' do
      expect(stub_service).to receive(:execute).and_return(status: :success)

blackst0ne's avatar
blackst0ne committed
145
      post :verify, params: params
146 147 148 149 150 151 152 153

      expect(response).to redirect_to project_pages_domain_path(project, pages_domain)
      expect(flash[:notice]).to eq('Successfully verified domain ownership')
    end

    it 'handles verification failure' do
      expect(stub_service).to receive(:execute).and_return(status: :failed)

blackst0ne's avatar
blackst0ne committed
154
      post :verify, params: params
155 156 157 158 159 160

      expect(response).to redirect_to project_pages_domain_path(project, pages_domain)
      expect(flash[:alert]).to eq('Failed to verify domain ownership')
    end

    it 'returns a 404 response for an unknown domain' do
blackst0ne's avatar
blackst0ne committed
161
      post :verify, params: request_params.merge(id: 'unknown-domain')
162 163

      expect(response).to have_gitlab_http_status(404)
164 165 166 167 168 169
    end
  end

  describe 'DELETE destroy' do
    it "deletes the pages domain" do
      expect do
blackst0ne's avatar
blackst0ne committed
170
        delete(:destroy, params: request_params.merge(id: pages_domain.domain))
171 172
      end.to change { PagesDomain.count }.by(-1)

173
      expect(response).to redirect_to(project_pages_path(project))
174 175
    end
  end
176 177 178 179 180 181 182 183

  context 'pages disabled' do
    before do
      allow(Gitlab.config.pages).to receive(:enabled).and_return(false)
    end

    describe 'GET show' do
      it 'returns 404 status' do
blackst0ne's avatar
blackst0ne committed
184
        get(:show, params: request_params.merge(id: pages_domain.domain))
185

186
        expect(response).to have_gitlab_http_status(404)
187 188 189 190 191
      end
    end

    describe 'GET new' do
      it 'returns 404 status' do
blackst0ne's avatar
blackst0ne committed
192
        get :new, params: request_params
193

194
        expect(response).to have_gitlab_http_status(404)
195 196 197 198 199
      end
    end

    describe 'POST create' do
      it "returns 404 status" do
blackst0ne's avatar
blackst0ne committed
200
        post(:create, params: request_params.merge(pages_domain: pages_domain_params))
201

202
        expect(response).to have_gitlab_http_status(404)
203 204 205 206 207
      end
    end

    describe 'DELETE destroy' do
      it "deletes the pages domain" do
blackst0ne's avatar
blackst0ne committed
208
        delete(:destroy, params: request_params.merge(id: pages_domain.domain))
209

210
        expect(response).to have_gitlab_http_status(404)
211 212 213
      end
    end
  end
214
end