.rubocop_todo.yml 21.5 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Rémy Coutable's avatar
Rémy Coutable committed
2
# `rubocop --auto-gen-config`
3
# on 2018-01-18 18:23:26 +0100 using RuboCop version 0.52.1.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 181
Rémy Coutable's avatar
Rémy Coutable committed
10 11 12
Capybara/CurrentPathExpectation:
  Enabled: false

13
# Offense count: 167
Rémy Coutable's avatar
Rémy Coutable committed
14 15 16 17
# Cop supports --auto-correct.
Layout/EmptyLinesAroundArguments:
  Enabled: false

18
# Offense count: 253
19 20 21 22 23
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Layout/ExtraSpacing:
  Enabled: false

24
# Offense count: 83
25
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
26
# Configuration parameters: EnforcedStyle, IndentationWidth.
27 28 29 30
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Layout/IndentArray:
  Enabled: false

31
# Offense count: 237
32
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
33
# Configuration parameters: EnforcedStyle, IndentationWidth.
34 35 36 37
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Layout/IndentHash:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
38 39 40
# Offense count: 93
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
41 42 43 44
# SupportedStyles: require_no_space, require_space
Layout/SpaceInLambdaLiteral:
  Enabled: false

45
# Offense count: 327
Rémy Coutable's avatar
Rémy Coutable committed
46 47
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
48 49 50 51 52
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
  Enabled: false

53
# Offense count: 156
54 55 56 57
# Cop supports --auto-correct.
Layout/SpaceInsideParens:
  Enabled: false

58
# Offense count: 26
Rémy Coutable's avatar
Rémy Coutable committed
59 60 61 62 63 64 65 66 67 68 69 70 71 72 73
Lint/DuplicateMethods:
  Exclude:
    - 'app/models/application_setting.rb'
    - 'app/models/commit.rb'
    - 'app/models/note.rb'
    - 'app/services/merge_requests/merge_service.rb'
    - 'lib/bitbucket/representation/repo.rb'
    - 'lib/declarative_policy/base.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'lib/gitlab/cycle_analytics/base_event_fetcher.rb'
    - 'lib/gitlab/diff/formatters/base_formatter.rb'
    - 'lib/gitlab/git/blob.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/git/tree.rb'
    - 'lib/gitlab/git/wiki_page.rb'
74 75
    - 'lib/gitlab/auth/ldap/person.rb'
    - 'lib/gitlab/auth/o_auth/user.rb'
Rémy Coutable's avatar
Rémy Coutable committed
76 77 78 79 80 81 82 83

# Offense count: 4
Lint/InterpolationCheck:
  Exclude:
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/features/users_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'

84
# Offense count: 206
Rémy Coutable's avatar
Rémy Coutable committed
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
  Enabled: false

# Offense count: 1
Lint/ReturnInVoidContext:
  Exclude:
    - 'app/models/project.rb'

# Offense count: 9
Lint/UriEscapeUnescape:
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/models/project_services/drone_ci_service.rb'
    - 'spec/lib/google_api/auth_spec.rb'
    - 'spec/requests/api/files_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
    - 'spec/requests/api/issues_spec.rb'

104 105 106 107 108 109
# Offense count: 1
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310

Rémy Coutable's avatar
Rémy Coutable committed
110 111 112 113 114 115 116 117 118 119 120 121 122 123
# Offense count: 2
Naming/ConstantName:
  Exclude:
    - 'lib/gitlab/import_sources.rb'
    - 'lib/gitlab/ssh_public_key.rb'

# Offense count: 11
# Configuration parameters: EnforcedStyle.
# SupportedStyles: lowercase, uppercase
Naming/HeredocDelimiterCase:
  Exclude:
    - 'spec/lib/gitlab/diff/parser_spec.rb'
    - 'spec/lib/json_web_token/rsa_token_spec.rb'
    - 'spec/models/commit_spec.rb'
124 125
    - 'spec/support/helpers/repo_helpers.rb'
    - 'spec/support/helpers/seed_repo.rb'
Rémy Coutable's avatar
Rémy Coutable committed
126

127
# Offense count: 112
Rémy Coutable's avatar
Rémy Coutable committed
128 129 130 131 132 133 134 135 136 137 138
# Configuration parameters: Blacklist.
# Blacklist: END, (?-mix:EO[A-Z]{1})
Naming/HeredocDelimiterNaming:
  Enabled: false

# Offense count: 1
# Cop supports --auto-correct.
Performance/UriDefaultParser:
  Exclude:
    - 'lib/gitlab/url_sanitizer.rb'

139
# Offense count: 3821
Rémy Coutable's avatar
Rémy Coutable committed
140 141 142
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
143 144
  Enabled: false

145
# Offense count: 293
146 147 148
RSpec/EmptyLineAfterFinalLet:
  Enabled: false

149
# Offense count: 188
150 151 152
RSpec/EmptyLineAfterSubject:
  Enabled: false

153 154 155 156 157 158 159
# Offense count: 258
# Configuration parameters: EnforcedStyle.
# SupportedStyles: method_call, block
RSpec/ExpectChange:
  Enabled: false

# Offense count: 221
Rémy Coutable's avatar
Rémy Coutable committed
160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
RSpec/ExpectInHook:
  Enabled: false

# Offense count: 7
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Exclude:
    - 'spec/spec_helper.rb'
    - 'spec/support/carrierwave.rb'
    - 'spec/support/db_cleaner.rb'
    - 'spec/support/gitaly.rb'
    - 'spec/support/setup_builds_storage.rb'

# Offense count: 19
# Configuration parameters: EnforcedStyle.
176 177
# SupportedStyles: it_behaves_like, it_should_behave_like
RSpec/ItBehavesLike:
Rémy Coutable's avatar
Rémy Coutable committed
178 179 180 181 182 183
  Exclude:
    - 'spec/lib/gitlab/git/commit_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/shell_spec.rb'
    - 'spec/services/notification_service_spec.rb'
    - 'spec/workers/git_garbage_collect_worker_spec.rb'
184

Rémy Coutable's avatar
Rémy Coutable committed
185
# Offense count: 5
186
RSpec/IteratedExpectation:
Rémy Coutable's avatar
Rémy Coutable committed
187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209
  Exclude:
    - 'spec/features/admin/admin_settings_spec.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/awards/user_interacts_with_awards_in_issue_spec.rb'
    - 'spec/lib/gitlab/gitlab_import/client_spec.rb'
    - 'spec/lib/gitlab/legacy_github_import/client_spec.rb'

# Offense count: 75
RSpec/LetBeforeExamples:
  Exclude:
    - 'spec/controllers/projects/commit_controller_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/lib/banzai/filter/user_reference_filter_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb'
    - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
    - 'spec/models/commit_range_spec.rb'
    - 'spec/models/milestone_spec.rb'
    - 'spec/models/project_services/packagist_service_spec.rb'
    - 'spec/models/repository_spec.rb'
    - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
    - 'spec/serializers/pipeline_details_entity_spec.rb'
    - 'spec/views/ci/lints/show.html.haml_spec.rb'
210

Rémy Coutable's avatar
Rémy Coutable committed
211 212 213 214 215 216
# Offense count: 1
RSpec/MultipleSubjects:
  Exclude:
    - 'spec/services/merge_requests/create_from_issue_service_spec.rb'

# Offense count: 4
217
RSpec/OverwritingSetup:
Rémy Coutable's avatar
Rémy Coutable committed
218 219 220 221 222 223
  Exclude:
    - 'spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb'
    - 'spec/models/email_spec.rb'
    - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
    - 'spec/services/notes/quick_actions_service_spec.rb'

224
# Offense count: 965
Rémy Coutable's avatar
Rémy Coutable committed
225 226 227
# Configuration parameters: Strict, EnforcedStyle.
# SupportedStyles: inflected, explicit
RSpec/PredicateMatcher:
228 229
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
230
# Offense count: 35
231 232 233
RSpec/RepeatedExample:
  Enabled: false

234
# Offense count: 140
Rémy Coutable's avatar
Rémy Coutable committed
235 236 237 238 239
# Configuration parameters: EnforcedStyle.
# SupportedStyles: and_return, block
RSpec/ReturnFromStub:
  Enabled: false

240
# Offense count: 112
241 242 243
RSpec/ScatteredLet:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
244
# Offense count: 22
245
RSpec/ScatteredSetup:
Rémy Coutable's avatar
Rémy Coutable committed
246 247 248 249 250 251
  Exclude:
    - 'spec/controllers/projects/templates_controller_spec.rb'
    - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
    - 'spec/lib/gitlab/git/env_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
    - 'spec/services/projects/create_service_spec.rb'
252

253
# Offense count: 1
254
RSpec/SharedContext:
Rémy Coutable's avatar
Rémy Coutable committed
255 256 257 258 259 260 261 262 263 264 265 266
  Exclude:
    - 'spec/features/admin/admin_groups_spec.rb'

# Offense count: 5
RSpec/VoidExpect:
  Exclude:
    - 'spec/features/projects/artifacts/download_spec.rb'
    - 'spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb'
    - 'spec/models/ci/group_spec.rb'
    - 'spec/models/ci/runner_spec.rb'
    - 'spec/services/users/destroy_service_spec.rb'

267
# Offense count: 41
Rémy Coutable's avatar
Rémy Coutable committed
268 269 270
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/CreateTableWithTimestamps:
Douwe Maan's avatar
Douwe Maan committed
271 272
  Enabled: false

273
# Offense count: 155
274 275 276
Rails/FilePath:
  Enabled: false

277
# Offense count: 121
Rémy Coutable's avatar
Rémy Coutable committed
278 279 280 281 282
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
  Enabled: false

283
# Offense count: 157
Rémy Coutable's avatar
Rémy Coutable committed
284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/InverseOf:
  Enabled: false

# Offense count: 48
# Configuration parameters: Include.
# Include: app/controllers/**/*.rb
Rails/LexicallyScopedActionFilter:
  Enabled: false

# Offense count: 14
# Cop supports --auto-correct.
Rails/Presence:
  Exclude:
    - 'app/controllers/projects/blob_controller.rb'
    - 'app/models/ci/pipeline.rb'
    - 'app/models/clusters/platforms/kubernetes.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/concerns/token_authenticatable.rb'
    - 'app/models/project_services/hipchat_service.rb'
    - 'app/models/project_services/irker_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'app/models/project_services/kubernetes_service.rb'
    - 'app/models/project_services/packagist_service.rb'
    - 'app/models/wiki_page.rb'
    - 'lib/gitlab/git/hook.rb'
    - 'lib/gitlab/github_import/importer/releases_importer.rb'

313 314 315 316
# Offense count: 2
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/ReversibleMigration:
Rémy Coutable's avatar
Rémy Coutable committed
317 318
  Exclude:
    - 'db/migrate/20160824103857_drop_unused_ci_tables.rb'
319

320
# Offense count: 446
321 322 323
# Configuration parameters: Blacklist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations:
Douwe Maan's avatar
Douwe Maan committed
324 325
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
326 327 328 329 330 331
# Offense count: 1
# Configuration parameters: Environments.
# Environments: development, test, production
Rails/UnknownEnv:
  Exclude:
    - 'db/migrate/20171124125748_populate_missing_merge_request_statuses.rb'
332

Rémy Coutable's avatar
Rémy Coutable committed
333
# Offense count: 13
334
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
335 336 337 338 339 340 341 342 343 344 345 346
Security/YAMLLoad:
  Exclude:
    - 'config/initializers/carrierwave.rb'
    - 'lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits.rb'
    - 'lib/gitlab/redis/wrapper.rb'
    - 'lib/system_check/incoming_email/imap_authentication_check.rb'
    - 'spec/config/mail_room_spec.rb'
    - 'spec/initializers/secret_token_spec.rb'
    - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'
    - 'spec/models/clusters/platforms/kubernetes_spec.rb'
    - 'spec/models/project_services/kubernetes_service_spec.rb'

347
# Offense count: 64
Rémy Coutable's avatar
Rémy Coutable committed
348 349
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
350 351 352
# SupportedStyles: percent_q, bare_percent
Style/BarePercentLiterals:
  Enabled: false
353

Rémy Coutable's avatar
Rémy Coutable committed
354 355 356 357 358 359 360 361
# Offense count: 5
Style/CommentedKeyword:
  Exclude:
    - 'lib/tasks/gitlab/backup.rake'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 30
Style/DateTime:
Douwe Maan's avatar
Douwe Maan committed
362
  Enabled: false
Connor Shea's avatar
Connor Shea committed
363

Rémy Coutable's avatar
Rémy Coutable committed
364
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
365
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386
Style/Dir:
  Exclude:
    - 'qa/qa.rb'

# Offense count: 9
# Cop supports --auto-correct.
Style/EachWithObject:
  Exclude:
    - 'config/initializers/gollum.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ci/ansi2html.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/hook_data/issuable_builder.rb'
    - 'lib/gitlab/i18n/po_linter.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'scripts/static-analysis'

# Offense count: 24
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
387 388 389 390
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
391 392 393 394 395 396 397 398
# Offense count: 14
# Cop supports --auto-correct.
Style/EmptyLambdaParameter:
  Exclude:
    - 'app/models/ci/build.rb'
    - 'app/models/ci/runner.rb'

# Offense count: 12
Connor Shea's avatar
Connor Shea committed
399 400
# Cop supports --auto-correct.
Style/EmptyLiteral:
Rémy Coutable's avatar
Rémy Coutable committed
401 402 403 404 405
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'lib/gitlab/gitaly_client.rb'
406
    - 'scripts/trigger-build'
Rémy Coutable's avatar
Rémy Coutable committed
407 408 409 410 411
    - 'spec/features/merge_requests/versions_spec.rb'
    - 'spec/helpers/merge_requests_helper_spec.rb'
    - 'spec/lib/gitlab/request_context_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/requests/api/jobs_spec.rb'
412
    - 'spec/support/shared_examples/chat_slash_commands_shared_examples.rb'
413

414
# Offense count: 102
415
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
416
# Configuration parameters: EnforcedStyle.
417 418
# SupportedStyles: compact, expanded
Style/EmptyMethod:
419
  Enabled: false
Connor Shea's avatar
Connor Shea committed
420

421
# Offense count: 23
Connor Shea's avatar
Connor Shea committed
422
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
423 424 425 426 427 428 429 430
Style/Encoding:
  Enabled: false

# Offense count: 2
Style/EvalWithLocation:
  Exclude:
    - 'app/models/service.rb'

431
# Offense count: 35
Rémy Coutable's avatar
Rémy Coutable committed
432 433
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
434 435
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
436 437
  Enabled: false

438
# Offense count: 384
Connor Shea's avatar
Connor Shea committed
439 440 441 442
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

443
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
444
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
445 446
  Enabled: false

447
# Offense count: 809
Connor Shea's avatar
Connor Shea committed
448 449 450 451
# Cop supports --auto-correct.
Style/IfUnlessModifier:
  Enabled: false

452
# Offense count: 75
Connor Shea's avatar
Connor Shea committed
453
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
454
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
455 456
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
457
  Enabled: false
Connor Shea's avatar
Connor Shea committed
458

Rémy Coutable's avatar
Rémy Coutable committed
459
# Offense count: 11
Connor Shea's avatar
Connor Shea committed
460 461
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Rémy Coutable's avatar
Rémy Coutable committed
462 463 464 465 466 467
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'spec/features/issuables/markdown_references_spec.rb'
    - 'spec/lib/gitlab/checks/project_moved_spec.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
468

Rémy Coutable's avatar
Rémy Coutable committed
469
# Offense count: 39
Connor Shea's avatar
Connor Shea committed
470
# Cop supports --auto-correct.
471
Style/MethodCallWithoutArgsParentheses:
Douwe Maan's avatar
Douwe Maan committed
472
  Enabled: false
Connor Shea's avatar
Connor Shea committed
473

474
# Offense count: 18
475
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
476
  Enabled: false
477

Rémy Coutable's avatar
Rémy Coutable committed
478 479 480 481 482 483 484 485 486 487 488
# Offense count: 7
Style/MixinUsage:
  Exclude:
    - 'features/support/env.rb'
    - 'spec/factories/ci/builds.rb'
    - 'spec/factories/ci/job_artifacts.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/factories/notes.rb'
    - 'spec/lib/gitlab/import_export/project_tree_restorer_spec.rb'
    - 'spec/lib/gitlab/import_export/version_checker_spec.rb'

489
# Offense count: 6
490 491
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Rémy Coutable's avatar
Rémy Coutable committed
492 493 494 495 496 497 498
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'app/services/ci/process_pipeline_service.rb'
    - 'app/services/create_deployment_service.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/ci/trace.rb'
499

500
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
501
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
502 503
# Configuration parameters: Whitelist.
# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
Connor Shea's avatar
Connor Shea committed
504
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
505
  Enabled: false
Connor Shea's avatar
Connor Shea committed
506

507
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
508
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
509
# Configuration parameters: EnforcedStyle, MinBodyLength.
Connor Shea's avatar
Connor Shea committed
510 511
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
512
  Enabled: false
Connor Shea's avatar
Connor Shea committed
513

514
# Offense count: 61
Z.J. van de Weg's avatar
Z.J. van de Weg committed
515
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
516
# Configuration parameters: EnforcedOctalStyle.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
517 518
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
519
  Enabled: false
Douwe Maan's avatar
Douwe Maan committed
520

521
# Offense count: 114
522
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
523
# Configuration parameters: AutoCorrect, EnforcedStyle.
524 525 526 527
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
528 529 530 531 532 533 534 535 536
# Offense count: 4
# Cop supports --auto-correct.
Style/OrAssignment:
  Exclude:
    - 'app/models/concerns/token_authenticatable.rb'
    - 'lib/api/commit_statuses.rb'
    - 'lib/gitlab/project_transfer.rb'

# Offense count: 50
Connor Shea's avatar
Connor Shea committed
537 538 539 540
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

541
# Offense count: 917
Connor Shea's avatar
Connor Shea committed
542 543 544 545 546
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

547
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
548 549
# Cop supports --auto-correct.
Style/PerlBackrefs:
Rémy Coutable's avatar
Rémy Coutable committed
550 551 552 553 554 555 556 557 558 559 560 561 562
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

563
# Offense count: 87
Rémy Coutable's avatar
Rémy Coutable committed
564 565
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
566 567 568 569
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

570
# Offense count: 9
Connor Shea's avatar
Connor Shea committed
571 572
# Cop supports --auto-correct.
Style/RedundantBegin:
Rémy Coutable's avatar
Rémy Coutable committed
573 574 575 576 577 578 579 580 581 582 583 584 585 586 587
  Exclude:
    - 'app/controllers/projects/clusters/gcp_controller.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/api/branches.rb'
    - 'lib/gitlab/current_settings.rb'
    - 'lib/gitlab/git/commit.rb'
    - 'lib/gitlab/health_checks/base_abstract_check.rb'
    - 'lib/tasks/gitlab/task_helpers.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantConditional:
  Exclude:
    - 'lib/system_check/helpers.rb'
Connor Shea's avatar
Connor Shea committed
588

589
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
590 591
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
592
  Enabled: false
Connor Shea's avatar
Connor Shea committed
593

Rémy Coutable's avatar
Rémy Coutable committed
594
# Offense count: 15
595 596 597
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Rémy Coutable's avatar
Rémy Coutable committed
598 599 600 601 602 603 604 605 606 607 608
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/application_controller.rb'
    - 'app/services/access_token_validation_service.rb'
    - 'lib/gitlab/utils.rb'
    - 'lib/google_api/auth.rb'

609
# Offense count: 460
Connor Shea's avatar
Connor Shea committed
610 611 612 613
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

614
# Offense count: 142
Connor Shea's avatar
Connor Shea committed
615
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
616
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
Connor Shea's avatar
Connor Shea committed
617 618
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
619 620 621
  Enabled: true
  EnforcedStyle: mixed
  AllowInnerSlashes: false
Connor Shea's avatar
Connor Shea committed
622

623
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
624 625
# Cop supports --auto-correct.
Style/RescueModifier:
626
  Enabled: false
627

628
# Offense count: 107
Rémy Coutable's avatar
Rémy Coutable committed
629 630 631 632 633 634
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
  Enabled: false

635
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
636 637
# Cop supports --auto-correct.
Style/SelfAssignment:
Rémy Coutable's avatar
Rémy Coutable committed
638 639 640 641 642 643 644 645
  Exclude:
    - 'app/models/concerns/bulk_member_access_load.rb'
    - 'app/serializers/base_serializer.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/features/projects/clusters/interchangeability_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
646 647 648 649 650

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Rémy Coutable's avatar
Rémy Coutable committed
651 652
  Exclude:
    - 'lib/gitlab/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
653

Rémy Coutable's avatar
Rémy Coutable committed
654
# Offense count: 66
Connor Shea's avatar
Connor Shea committed
655
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
656
# Configuration parameters: .
Connor Shea's avatar
Connor Shea committed
657 658 659 660
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

Rémy Coutable's avatar
Rémy Coutable committed
661
# Offense count: 1
Connor Shea's avatar
Connor Shea committed
662
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
663 664 665 666 667 668 669
Style/StderrPuts:
  Exclude:
    - 'config/initializers/rspec_profiling.rb'

# Offense count: 45
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Connor Shea's avatar
Connor Shea committed
670 671
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
672
  Enabled: false
673

674
# Offense count: 106
Connor Shea's avatar
Connor Shea committed
675 676 677 678 679 680
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

Rémy Coutable's avatar
Rémy Coutable committed
681
# Offense count: 9
682
# Cop supports --auto-correct.
Rémy Coutable's avatar
Rémy Coutable committed
683
# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
684
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
685
Style/TernaryParentheses:
Rémy Coutable's avatar
Rémy Coutable committed
686 687 688 689 690 691 692
  Exclude:
    - 'app/finders/projects_finder.rb'
    - 'app/helpers/namespaces_helper.rb'
    - 'features/support/capybara.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/requests/api/pipeline_schedules_spec.rb'
    - 'spec/support/capybara.rb'
693

694
# Offense count: 17
Connor Shea's avatar
Connor Shea committed
695 696 697
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Rémy Coutable's avatar
Rémy Coutable committed
698 699 700 701 702 703 704 705 706 707 708 709 710
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/logger.rb'
    - 'lib/gitlab/upgrader.rb'
    - 'lib/system_check/app/migrations_are_up_check.rb'
    - 'lib/system_check/incoming_email/mail_room_running_check.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'lib/tasks/gitlab/task_helpers.rb'
    - 'spec/lib/gitlab/etag_caching/middleware_spec.rb'
    - 'spec/services/quick_actions/interpret_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
711

Rémy Coutable's avatar
Rémy Coutable committed
712
# Offense count: 5
Connor Shea's avatar
Connor Shea committed
713 714 715 716
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Rémy Coutable's avatar
Rémy Coutable committed
717 718 719
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
720
    - 'lib/gitlab/auth/ldap/person.rb'
Rémy Coutable's avatar
Rémy Coutable committed
721
    - 'lib/system_check/base_check.rb'
Connor Shea's avatar
Connor Shea committed
722

Rémy Coutable's avatar
Rémy Coutable committed
723
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
724 725
# Cop supports --auto-correct.
Style/UnlessElse:
Rémy Coutable's avatar
Rémy Coutable committed
726 727 728 729 730
  Exclude:
    - 'lib/backup/manager.rb'
    - 'lib/gitlab/project_search_results.rb'
    - 'lib/tasks/gitlab/check.rake'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
731

732
# Offense count: 31
Connor Shea's avatar
Connor Shea committed
733 734
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
735
  Enabled: false
Connor Shea's avatar
Connor Shea committed
736

737
# Offense count: 22840
Rémy Coutable's avatar
Rémy Coutable committed
738 739 740 741
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
  Max: 1310