.rubocop_todo.yml 18.6 KB
Newer Older
Z.J. van de Weg's avatar
Z.J. van de Weg committed
1
# This configuration was generated by
Douwe Maan's avatar
Douwe Maan committed
2 3
# `rubocop --auto-gen-config`
# on 2017-02-21 18:00:50 -0600 using RuboCop version 0.46.0.
Z.J. van de Weg's avatar
Z.J. van de Weg committed
4 5 6 7 8
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

9
# Offense count: 15
10 11
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup:
Douwe Maan's avatar
Douwe Maan committed
12 13 14 15 16 17 18 19 20
  Exclude:
    - 'spec/features/issues_spec.rb'
    - 'spec/features/notes_on_merge_requests_spec.rb'
    - 'spec/lib/gitlab/git_access_spec.rb'
    - 'spec/models/project_snippet_spec.rb'
    - 'spec/models/protected_branch_spec.rb'
    - 'spec/routing/routing_spec.rb'

# Offense count: 63
21 22 23 24 25
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
  Enabled: false

26 27 28 29
# Offense count: 12
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should
RSpec/ImplicitExpect:
Douwe Maan's avatar
Douwe Maan committed
30 31 32 33 34
  Exclude:
    - 'spec/lib/banzai/renderer_spec.rb'
    - 'spec/models/project_group_link_spec.rb'
    - 'spec/models/project_services/external_wiki_service_spec.rb'
    - 'spec/models/project_spec.rb'
35 36 37

# Offense count: 1
RSpec/SingleArgumentMessageChain:
Douwe Maan's avatar
Douwe Maan committed
38 39
  Exclude:
    - 'spec/requests/api/internal_spec.rb'
40

Douwe Maan's avatar
Douwe Maan committed
41
# Offense count: 6
42
# Cop supports --auto-correct.
Connor Shea's avatar
Connor Shea committed
43
Style/EachWithObject:
Douwe Maan's avatar
Douwe Maan committed
44 45 46 47 48 49 50
  Exclude:
    - 'app/services/merge_requests/get_urls_service.rb'
    - 'lib/ci/ansi2html.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/members_mapper.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
Connor Shea's avatar
Connor Shea committed
51

52
# Offense count: 24
Connor Shea's avatar
Connor Shea committed
53 54 55 56 57 58
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both
Style/EmptyElse:
  Enabled: false

59
# Offense count: 4
Connor Shea's avatar
Connor Shea committed
60 61
# Cop supports --auto-correct.
Style/EmptyLiteral:
Douwe Maan's avatar
Douwe Maan committed
62 63 64 65 66
  Exclude:
    - 'features/steps/project/commits/commits.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/git/diff_collection.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
67

Douwe Maan's avatar
Douwe Maan committed
68
# Offense count: 55
69 70 71 72
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
73
  Enabled: false
Connor Shea's avatar
Connor Shea committed
74

Douwe Maan's avatar
Douwe Maan committed
75
# Offense count: 173
Connor Shea's avatar
Connor Shea committed
76 77 78 79 80
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
  Enabled: false

81
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
82 83 84
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Douwe Maan's avatar
Douwe Maan committed
85 86 87 88 89 90 91 92 93
  Exclude:
    - 'app/models/ci/pipeline.rb'
    - 'app/services/gravatar_service.rb'
    - 'config/initializers/rack_lineprof.rb'
    - 'lib/gitlab/version_info.rb'
    - 'spec/factories/lfs_objects.rb'
    - 'spec/services/issues/move_service_spec.rb'

# Offense count: 261
Connor Shea's avatar
Connor Shea committed
94 95 96 97
# Configuration parameters: MinBodyLength.
Style/GuardClause:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
98
# Offense count: 12
Connor Shea's avatar
Connor Shea committed
99
Style/IfInsideElse:
Douwe Maan's avatar
Douwe Maan committed
100 101 102 103 104 105 106 107 108 109 110 111 112 113
  Exclude:
    - 'app/controllers/projects/forks_controller.rb'
    - 'app/controllers/projects/imports_controller.rb'
    - 'app/helpers/milestones_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/services/system_note_service.rb'
    - 'config/initializers/1_settings.rb'
    - 'lib/gitlab/auth.rb'
    - 'lib/gitlab/checks/change_access.rb'
    - 'lib/gitlab/database.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'

# Offense count: 178
Connor Shea's avatar
Connor Shea committed
114 115 116 117 118
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
119
# Offense count: 61
Connor Shea's avatar
Connor Shea committed
120 121 122 123 124 125
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
126
# Offense count: 110
Connor Shea's avatar
Connor Shea committed
127 128 129 130 131 132
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
Style/IndentHash:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
133
# Offense count: 45
Connor Shea's avatar
Connor Shea committed
134 135 136 137
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
138
  Enabled: false
Connor Shea's avatar
Connor Shea committed
139

Douwe Maan's avatar
Douwe Maan committed
140
# Offense count: 7
Connor Shea's avatar
Connor Shea committed
141 142
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Douwe Maan's avatar
Douwe Maan committed
143 144 145 146 147 148
  Exclude:
    - 'app/helpers/tree_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/services/git_operation_service.rb'
    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
    - 'spec/lib/gitlab/incoming_email_spec.rb'
Connor Shea's avatar
Connor Shea committed
149

Douwe Maan's avatar
Douwe Maan committed
150
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
151 152
# Cop supports --auto-correct.
Style/MethodCallParentheses:
Douwe Maan's avatar
Douwe Maan committed
153 154 155 156 157 158 159 160 161 162 163 164 165
  Exclude:
    - 'lib/ci/ansi2html.rb'
    - 'spec/controllers/projects/issues_controller_spec.rb'
    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
    - 'spec/controllers/projects/snippets_controller_spec.rb'
    - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_assignee_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_author_spec.rb'
    - 'spec/features/issues/filtered_search/dropdown_milestone_spec.rb'
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/helpers/submodule_helper_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/requests/api/internal_spec.rb'
Connor Shea's avatar
Connor Shea committed
166

167
# Offense count: 9
168
Style/MethodMissing:
Douwe Maan's avatar
Douwe Maan committed
169 170 171 172 173 174 175 176 177 178
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/models/commit.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/repository.rb'
    - 'config/initializers/gollum.rb'
    - 'lib/bitbucket/collection.rb'
    - 'lib/gitlab/github_import/client.rb'
    - 'lib/gitlab/lazy.rb'
    - 'lib/uploaded_file.rb'
179

180 181 182
# Offense count: 3
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Douwe Maan's avatar
Douwe Maan committed
183 184 185 186
  Exclude:
    - 'app/helpers/snippets_helper.rb'
    - 'app/models/project_wiki.rb'
    - 'lib/gitlab/workhorse.rb'
187

188
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
189 190
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
Douwe Maan's avatar
Douwe Maan committed
191 192 193 194 195
  Exclude:
    - 'app/helpers/commits_helper.rb'
    - 'app/workers/irker_worker.rb'
    - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
    - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
Connor Shea's avatar
Connor Shea committed
196

Douwe Maan's avatar
Douwe Maan committed
197
# Offense count: 15
Connor Shea's avatar
Connor Shea committed
198 199 200 201
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Douwe Maan's avatar
Douwe Maan committed
202 203 204 205 206 207 208 209 210 211 212 213 214
  Exclude:
    - 'app/models/namespace.rb'
    - 'app/models/user.rb'
    - 'app/services/merge_requests/refresh_service.rb'
    - 'config/initializers/secret_token.rb'
    - 'db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
    - 'db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
    - 'lib/banzai/filter/math_filter.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/fogbugz_import/importer.rb'
    - 'lib/gitlab/metrics/instrumentation.rb'
    - 'lib/gitlab/metrics/sampler.rb'
    - 'lib/gitlab/project_search_results.rb'
Connor Shea's avatar
Connor Shea committed
215

216
# Offense count: 19
Z.J. van de Weg's avatar
Z.J. van de Weg committed
217 218 219 220
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Douwe Maan's avatar
Douwe Maan committed
221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236
  Exclude:
    - 'config/initializers/1_settings.rb'
    - 'config/initializers/secret_token.rb'
    - 'lib/gitlab/import_export/command_line_util.rb'
    - 'lib/gitlab/shell.rb'
    - 'lib/gitlab/workhorse.rb'
    - 'spec/features/projects/import_export/export_file_spec.rb'
    - 'spec/lib/gitlab/git/blob_spec.rb'
    - 'spec/lib/gitlab/git/hook_spec.rb'
    - 'spec/lib/gitlab/git/repository_spec.rb'
    - 'spec/lib/gitlab/workhorse_spec.rb'
    - 'spec/support/import_export/export_file_helper.rb'
    - 'spec/support/test_env.rb'
    - 'spec/tasks/gitlab/backup_rake_spec.rb'

# Offense count: 68
237
# Cop supports --auto-correct.
238
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
239 240 241 242
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
243
# Offense count: 36
Connor Shea's avatar
Connor Shea committed
244 245 246 247
# Cop supports --auto-correct.
Style/ParallelAssignment:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
248
# Offense count: 459
Connor Shea's avatar
Connor Shea committed
249 250 251 252 253
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
  Enabled: false

254
# Offense count: 10
Connor Shea's avatar
Connor Shea committed
255 256 257 258
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals:
Douwe Maan's avatar
Douwe Maan committed
259 260 261 262 263 264 265
  Exclude:
    - 'spec/lib/gitlab/diff/highlight_spec.rb'
    - 'spec/models/project_services/bamboo_service_spec.rb'
    - 'spec/models/project_services/buildkite_service_spec.rb'
    - 'spec/models/project_services/drone_ci_service_spec.rb'
    - 'spec/models/project_services/teamcity_service_spec.rb'
    - 'spec/workers/repository_import_worker_spec.rb'
Connor Shea's avatar
Connor Shea committed
266

Connor Shea's avatar
Connor Shea committed
267
# Offense count: 13
Connor Shea's avatar
Connor Shea committed
268 269
# Cop supports --auto-correct.
Style/PerlBackrefs:
Douwe Maan's avatar
Douwe Maan committed
270 271 272 273 274 275 276 277 278 279 280 281 282
  Exclude:
    - 'app/controllers/projects/application_controller.rb'
    - 'app/helpers/submodule_helper.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/banzai/filter/autolink_filter.rb'
    - 'lib/banzai/filter/emoji_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/expand_variables.rb'
    - 'lib/gitlab/diff/highlight.rb'
    - 'lib/gitlab/search_results.rb'
    - 'lib/gitlab/sherlock/query.rb'

# Offense count: 72
Connor Shea's avatar
Connor Shea committed
283 284 285 286 287 288 289
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
Style/PredicateName:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
290
# Offense count: 39
Z.J. van de Weg's avatar
Z.J. van de Weg committed
291
# Cop supports --auto-correct.
292 293
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: short, verbose
Z.J. van de Weg's avatar
Z.J. van de Weg committed
294
Style/PreferredHashMethods:
Connor Shea's avatar
Connor Shea committed
295 296
  Enabled: false

297
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
298 299
# Cop supports --auto-correct.
Style/Proc:
Douwe Maan's avatar
Douwe Maan committed
300 301 302 303 304 305 306
  Exclude:
    - 'app/mailers/base_mailer.rb'
    - 'app/models/milestone.rb'
    - 'app/models/service.rb'
    - 'lib/api/api_guard.rb'
    - 'lib/gitlab/ldap/config.rb'
    - 'spec/initializers/trusted_proxies_spec.rb'
Connor Shea's avatar
Connor Shea committed
307

Douwe Maan's avatar
Douwe Maan committed
308
# Offense count: 62
Connor Shea's avatar
Connor Shea committed
309 310 311 312 313 314
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
315
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
316 317
# Cop supports --auto-correct.
Style/RedundantBegin:
Douwe Maan's avatar
Douwe Maan committed
318 319 320 321
  Exclude:
    - 'app/models/merge_request.rb'
    - 'app/services/projects/import_service.rb'
    - 'lib/gitlab/git/commit.rb'
Connor Shea's avatar
Connor Shea committed
322

Douwe Maan's avatar
Douwe Maan committed
323
# Offense count: 32
Connor Shea's avatar
Connor Shea committed
324 325
# Cop supports --auto-correct.
Style/RedundantFreeze:
Douwe Maan's avatar
Douwe Maan committed
326 327 328 329 330 331 332 333 334 335 336 337 338 339 340
  Exclude:
    - 'app/models/commit.rb'
    - 'app/models/merge_request.rb'
    - 'app/validators/color_validator.rb'
    - 'app/validators/line_code_validator.rb'
    - 'lib/api/templates.rb'
    - 'lib/api/v3/templates.rb'
    - 'lib/banzai/filter/blockquote_fence_filter.rb'
    - 'lib/banzai/filter/gollum_tags_filter.rb'
    - 'lib/banzai/filter/yaml_front_matter_filter.rb'
    - 'lib/gitlab/diff/inline_diff.rb'
    - 'lib/gitlab/ee_compat_check.rb'
    - 'lib/gitlab/import_export/relation_factory.rb'
    - 'lib/gitlab/middleware/static.rb'
    - 'lib/gitlab/regex.rb'
Connor Shea's avatar
Connor Shea committed
341

Douwe Maan's avatar
Douwe Maan committed
342
# Offense count: 15
343 344 345
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Douwe Maan's avatar
Douwe Maan committed
346 347 348 349 350 351 352 353 354 355 356 357
  Exclude:
    - 'app/controllers/application_controller.rb'
    - 'app/controllers/concerns/issuable_actions.rb'
    - 'app/controllers/groups/application_controller.rb'
    - 'app/controllers/groups_controller.rb'
    - 'app/controllers/omniauth_callbacks_controller.rb'
    - 'app/controllers/profiles/keys_controller.rb'
    - 'app/controllers/projects/labels_controller.rb'
    - 'app/controllers/projects/milestones_controller.rb'
    - 'app/services/access_token_validation_service.rb'

# Offense count: 365
Connor Shea's avatar
Connor Shea committed
358 359 360 361
# Cop supports --auto-correct.
Style/RedundantSelf:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
362
# Offense count: 107
Connor Shea's avatar
Connor Shea committed
363 364 365 366 367 368
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
369
# Offense count: 22
Connor Shea's avatar
Connor Shea committed
370 371
# Cop supports --auto-correct.
Style/RescueModifier:
372
  Enabled: false
373 374

# Offense count: 7
Connor Shea's avatar
Connor Shea committed
375 376
# Cop supports --auto-correct.
Style/SelfAssignment:
Douwe Maan's avatar
Douwe Maan committed
377 378 379 380 381 382
  Exclude:
    - 'app/models/project_team.rb'
    - 'app/services/notification_service.rb'
    - 'lib/api/runners.rb'
    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
    - 'spec/support/import_export/configuration_helper.rb'
Connor Shea's avatar
Connor Shea committed
383 384 385

# Offense count: 2
# Configuration parameters: Methods.
386
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Connor Shea's avatar
Connor Shea committed
387
Style/SingleLineBlockParams:
Douwe Maan's avatar
Douwe Maan committed
388 389 390
  Exclude:
    - 'app/models/commit.rb'
    - 'spec/support/services_shared_context.rb'
Connor Shea's avatar
Connor Shea committed
391 392 393 394 395

# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Douwe Maan's avatar
Douwe Maan committed
396 397
  Exclude:
    - 'lib/ci/ansi2html.rb'
Connor Shea's avatar
Connor Shea committed
398

Douwe Maan's avatar
Douwe Maan committed
399
# Offense count: 150
Connor Shea's avatar
Connor Shea committed
400 401 402 403 404 405
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
Style/SpaceBeforeBlockBraces:
  Enabled: false

406
# Offense count: 8
Connor Shea's avatar
Connor Shea committed
407 408 409
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
Douwe Maan's avatar
Douwe Maan committed
410 411 412 413 414 415
  Exclude:
    - 'config/routes/project.rb'
    - 'features/steps/project/source/browse_files.rb'
    - 'features/steps/project/source/markdown_render.rb'
    - 'spec/routing/project_routing_spec.rb'
    - 'spec/services/system_note_service_spec.rb'
Connor Shea's avatar
Connor Shea committed
416

Douwe Maan's avatar
Douwe Maan committed
417
# Offense count: 38
418 419 420 421
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: require_no_space, require_space
Style/SpaceInLambdaLiteral:
Douwe Maan's avatar
Douwe Maan committed
422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439
  Exclude:
    - 'app/models/commit_status.rb'
    - 'app/models/concerns/mentionable.rb'
    - 'app/models/issue.rb'
    - 'app/models/member.rb'
    - 'lib/api/entities.rb'
    - 'lib/file_size_validator.rb'
    - 'lib/gitlab/visibility_level.rb'
    - 'spec/models/concerns/participable_spec.rb'
    - 'spec/models/cycle_analytics/code_spec.rb'
    - 'spec/models/cycle_analytics/issue_spec.rb'
    - 'spec/models/cycle_analytics/plan_spec.rb'
    - 'spec/models/cycle_analytics/production_spec.rb'
    - 'spec/models/cycle_analytics/review_spec.rb'
    - 'spec/models/cycle_analytics/staging_spec.rb'
    - 'spec/models/cycle_analytics/test_spec.rb'

# Offense count: 205
Connor Shea's avatar
Connor Shea committed
440 441 442 443 444 445
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces:
  Enabled: false

Douwe Maan's avatar
Douwe Maan committed
446
# Offense count: 90
Connor Shea's avatar
Connor Shea committed
447 448 449
# Cop supports --auto-correct.
Style/SpaceInsideParens:
  Enabled: false
Z.J. van de Weg's avatar
Z.J. van de Weg committed
450

451
# Offense count: 4
Z.J. van de Weg's avatar
Z.J. van de Weg committed
452 453
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
Douwe Maan's avatar
Douwe Maan committed
454 455
  Exclude:
    - 'lib/gitlab/git_access.rb'
Connor Shea's avatar
Connor Shea committed
456

Douwe Maan's avatar
Douwe Maan committed
457
# Offense count: 52
Connor Shea's avatar
Connor Shea committed
458 459 460 461 462 463
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars:
  EnforcedStyle: use_perl_names

464
# Offense count: 25
Connor Shea's avatar
Connor Shea committed
465 466 467 468
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Douwe Maan's avatar
Douwe Maan committed
469 470 471 472 473 474 475 476 477 478 479 480 481 482 483
  Exclude:
    - 'app/helpers/labels_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/helpers/todos_helper.rb'
    - 'app/models/application_setting.rb'
    - 'app/models/project_services/campfire_service.rb'
    - 'app/models/project_services/jira_service.rb'
    - 'db/migrate/20161017125927_add_unique_index_to_labels.rb'
    - 'features/steps/groups.rb'
    - 'features/steps/project/merge_requests.rb'
    - 'lib/banzai/filter/abstract_reference_filter.rb'
    - 'lib/ci/gitlab_ci_yaml_processor.rb'
    - 'lib/gitlab/google_code_import/importer.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/models/project_services/hipchat_service_spec.rb'
484

Douwe Maan's avatar
Douwe Maan committed
485
# Offense count: 57
Connor Shea's avatar
Connor Shea committed
486 487 488 489 490 491
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
Style/SymbolProc:
  Enabled: false

492 493 494
# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
495
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
496
Style/TernaryParentheses:
Douwe Maan's avatar
Douwe Maan committed
497 498 499 500 501 502
  Exclude:
    - 'features/support/capybara.rb'
    - 'lib/api/v3/projects.rb'
    - 'lib/banzai/filter/table_of_contents_filter.rb'
    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
    - 'spec/support/capybara.rb'
503

Douwe Maan's avatar
Douwe Maan committed
504
# Offense count: 43
Connor Shea's avatar
Connor Shea committed
505 506 507 508 509 510 511 512 513 514
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
  Enabled: false

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Douwe Maan's avatar
Douwe Maan committed
515 516 517 518 519 520 521
  Exclude:
    - 'app/controllers/admin/background_jobs_controller.rb'
    - 'app/controllers/invites_controller.rb'
    - 'app/controllers/projects/git_http_client_controller.rb'
    - 'app/helpers/tab_helper.rb'
    - 'lib/gitlab/git/repository.rb'
    - 'lib/gitlab/logger.rb'
Connor Shea's avatar
Connor Shea committed
522

Douwe Maan's avatar
Douwe Maan committed
523
# Offense count: 76
Connor Shea's avatar
Connor Shea committed
524 525 526 527
# Cop supports --auto-correct.
Style/TrailingWhitespace:
  Enabled: false

528
# Offense count: 3
Connor Shea's avatar
Connor Shea committed
529 530 531 532
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Douwe Maan's avatar
Douwe Maan committed
533 534 535 536
  Exclude:
    - 'app/models/external_issue.rb'
    - 'app/serializers/base_serializer.rb'
    - 'lib/gitlab/ldap/person.rb'
Connor Shea's avatar
Connor Shea committed
537

538
# Offense count: 2
Connor Shea's avatar
Connor Shea committed
539 540
# Cop supports --auto-correct.
Style/UnlessElse:
Douwe Maan's avatar
Douwe Maan committed
541 542 543
  Exclude:
    - 'lib/gitlab/project_search_results.rb'
    - 'spec/features/issues/award_emoji_spec.rb'
Connor Shea's avatar
Connor Shea committed
544

Douwe Maan's avatar
Douwe Maan committed
545
# Offense count: 19
Connor Shea's avatar
Connor Shea committed
546 547
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Douwe Maan's avatar
Douwe Maan committed
548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563
  Exclude:
    - 'app/helpers/boards_helper.rb'
    - 'app/helpers/projects_helper.rb'
    - 'app/helpers/search_helper.rb'
    - 'app/helpers/time_helper.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/project_services/pushover_service.rb'
    - 'features/steps/project/forked_merge_requests.rb'
    - 'spec/controllers/admin/services_controller_spec.rb'
    - 'spec/features/admin/admin_projects_spec.rb'
    - 'spec/features/issues_spec.rb'
    - 'spec/features/projects/branches_spec.rb'
    - 'spec/features/projects/issuable_templates_spec.rb'
    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
    - 'spec/requests/api/issues_spec.rb'
    - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
Connor Shea's avatar
Connor Shea committed
564 565 566 567

# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Douwe Maan's avatar
Douwe Maan committed
568 569 570 571 572 573 574 575
  Exclude:
    - 'app/models/deploy_key.rb'
    - 'app/models/merge_request.rb'
    - 'app/models/network/commit.rb'
    - 'app/models/network/graph.rb'
    - 'app/models/project_services/asana_service.rb'
    - 'app/models/repository.rb'
    - 'lib/extracts_path.rb'