From f86c10ad86ff2d603d85d453082974d5604aad1f Mon Sep 17 00:00:00 2001
From: Paul-Christian Volkmer <paul-christian.volkmer@mni.thm.de>
Date: Thu, 25 Oct 2012 14:45:28 +0200
Subject: [PATCH] Removed security checks in feedback
---
.../controller/FeedbackControllerTest.java | 29 -------------------
.../arsnova/services/FeedbackServiceTest.java | 21 +-------------
2 files changed, 1 insertion(+), 49 deletions(-)
diff --git a/src/test/java/de/thm/arsnova/controller/FeedbackControllerTest.java b/src/test/java/de/thm/arsnova/controller/FeedbackControllerTest.java
index 6df324b1..cea87b5a 100644
--- a/src/test/java/de/thm/arsnova/controller/FeedbackControllerTest.java
+++ b/src/test/java/de/thm/arsnova/controller/FeedbackControllerTest.java
@@ -19,7 +19,6 @@ import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter;
import de.thm.arsnova.exceptions.NotFoundException;
-import de.thm.arsnova.exceptions.UnauthorizedException;
import de.thm.arsnova.services.StubUserService;
@RunWith(SpringJUnit4ClassRunner.class)
@@ -61,32 +60,4 @@ public class FeedbackControllerTest {
assertNull(mav);
assertTrue(response.getStatus() == 404);
}
-
- @Test(expected = UnauthorizedException.class)
- public void testShouldNotGetFeedbackIfUnauthorized() throws Exception {
- userService.setUserAuthenticated(false);
-
- request.setMethod("GET");
- request.setRequestURI("/session/00000000/feedback");
- final ModelAndView mav = handlerAdapter.handle(request, response,
- feedbackController);
-
- assertNull(mav);
- assertTrue(response.getStatus() == 401);
- }
-
- @Test(expected = UnauthorizedException.class)
- public void testShouldNotSaveFeedbackIfUnauthorized() throws Exception {
- userService.setUserAuthenticated(false);
-
- request.setMethod("POST");
- request.setRequestURI("/session/00000000/feedback");
- request.setContentType("application/json");
- request.setContent("0".getBytes());
- final ModelAndView mav = handlerAdapter.handle(request, response,
- feedbackController);
-
- assertNull(mav);
- assertTrue(response.getStatus() == 401);
- }
}
diff --git a/src/test/java/de/thm/arsnova/services/FeedbackServiceTest.java b/src/test/java/de/thm/arsnova/services/FeedbackServiceTest.java
index 1aa1f10d..9088f49c 100644
--- a/src/test/java/de/thm/arsnova/services/FeedbackServiceTest.java
+++ b/src/test/java/de/thm/arsnova/services/FeedbackServiceTest.java
@@ -18,8 +18,8 @@
*/
package de.thm.arsnova.services;
-import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -28,7 +28,6 @@ import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
import de.thm.arsnova.exceptions.NotFoundException;
-import de.thm.arsnova.exceptions.UnauthorizedException;
@RunWith(SpringJUnit4ClassRunner.class)
@ContextConfiguration(locations = {
@@ -49,12 +48,6 @@ public class FeedbackServiceTest {
feedbackService.getFeedback("00000000");
}
- @Test(expected = UnauthorizedException.class)
- public void testShouldNotReturnFeedbackIfUnauthorized() {
- userService.setUserAuthenticated(false);
- feedbackService.getFeedback("00000000");
- }
-
@Test
public void testShouldReturnFeedback() {
userService.setUserAuthenticated(true);
@@ -75,12 +68,6 @@ public class FeedbackServiceTest {
feedbackService.getFeedbackCount("00000000");
}
- @Test(expected = UnauthorizedException.class)
- public void testShouldNotReturnFeedbackCountIfUnauthorized() {
- userService.setUserAuthenticated(false);
- feedbackService.getFeedbackCount("00000000");
- }
-
@Test
public void testShouldReturnFeedbackCount() {
userService.setUserAuthenticated(true);
@@ -93,12 +80,6 @@ public class FeedbackServiceTest {
feedbackService.getAverageFeedback("00000000");
}
- @Test(expected = UnauthorizedException.class)
- public void testShouldNotReturnAverageFeedbackIfUnauthorized() {
- userService.setUserAuthenticated(false);
- feedbackService.getAverageFeedback("00000000");
- }
-
@Test
public void testShouldReturnAverageFeedback() {
userService.setUserAuthenticated(true);
--
GitLab