diff --git a/src/main/java/de/thm/arsnova/cache/CacheBuster.java b/src/main/java/de/thm/arsnova/cache/CacheBuster.java index 5d1b1ccc2d82c57d5b1c2150c7804e195072a2e5..06c3830507a9e90739d7cf22a75d7607576033a7 100644 --- a/src/main/java/de/thm/arsnova/cache/CacheBuster.java +++ b/src/main/java/de/thm/arsnova/cache/CacheBuster.java @@ -30,98 +30,98 @@ public class CacheBuster implements ICacheBuster, NovaEventVisitor { @CacheEvict(value = "statistics", allEntries = true) @Override - public void visit(NewInterposedQuestionEvent event) {} + public void visit(NewInterposedQuestionEvent event) { } @CacheEvict(value = "statistics", allEntries = true) @Override - public void visit(DeleteInterposedQuestionEvent event) {} + public void visit(DeleteInterposedQuestionEvent event) { } @Override - public void visit(NewQuestionEvent event) {} + public void visit(NewQuestionEvent event) { } @Override - public void visit(UnlockQuestionEvent event) {} + public void visit(UnlockQuestionEvent event) { } @Override - public void visit(UnlockQuestionsEvent newQuestionsEvent) {} + public void visit(UnlockQuestionsEvent newQuestionsEvent) { } @Override - public void visit(LockQuestionEvent lockQuestionEvent) {} + public void visit(LockQuestionEvent lockQuestionEvent) { } @Override - public void visit(LockQuestionsEvent lockQuestionsEvent) {} + public void visit(LockQuestionsEvent lockQuestionsEvent) { } @CacheEvict(value = "answers", key = "#event.Question") @Override - public void visit(NewAnswerEvent event) {} + public void visit(NewAnswerEvent event) { } @Override - public void visit(DeleteAnswerEvent event) {} + public void visit(DeleteAnswerEvent event) { } @Override - public void visit(DeleteQuestionEvent event) {} + public void visit(DeleteQuestionEvent event) { } @Override - public void visit(DeleteAllQuestionsEvent event) {} + public void visit(DeleteAllQuestionsEvent event) { } @Override - public void visit(DeleteAllQuestionsAnswersEvent event) {} + public void visit(DeleteAllQuestionsAnswersEvent event) { } @Override - public void visit(DeleteAllPreparationAnswersEvent event) {} + public void visit(DeleteAllPreparationAnswersEvent event) { } @Override - public void visit(DeleteAllLectureAnswersEvent event) {} + public void visit(DeleteAllLectureAnswersEvent event) { } @Override - public void visit(NewFeedbackEvent event) {} + public void visit(NewFeedbackEvent event) { } @Override - public void visit(DeleteFeedbackForSessionsEvent event) {} + public void visit(DeleteFeedbackForSessionsEvent event) { } @Override - public void visit(StatusSessionEvent event) {} + public void visit(StatusSessionEvent event) { } @CacheEvict(value = "statistics", allEntries = true) @Override - public void visit(ChangeLearningProgressEvent changeLearningProgress) {} + public void visit(ChangeLearningProgressEvent changeLearningProgress) { } @Override - public void visit(PiRoundDelayedStartEvent piRoundDelayedStartEvent) {} + public void visit(PiRoundDelayedStartEvent piRoundDelayedStartEvent) { } @Override - public void visit(PiRoundEndEvent piRoundEndEvent) {} + public void visit(PiRoundEndEvent piRoundEndEvent) { } @Override - public void visit(PiRoundCancelEvent piRoundCancelEvent) {} + public void visit(PiRoundCancelEvent piRoundCancelEvent) { } @Override - public void visit(PiRoundResetEvent piRoundResetEvent) {} + public void visit(PiRoundResetEvent piRoundResetEvent) { } @CacheEvict(value = "statistics", allEntries = true) @Override - public void visit(NewSessionEvent newSessionEvent) {} + public void visit(NewSessionEvent newSessionEvent) { } @CacheEvict(value = "statistics", allEntries = true) @Override - public void visit(DeleteSessionEvent deleteSessionEvent) {} + public void visit(DeleteSessionEvent deleteSessionEvent) { } @Override - public void visit(LockVoteEvent lockVoteEvent) {} + public void visit(LockVoteEvent lockVoteEvent) { } @Override - public void visit(LockVotesEvent lockVotesEvent) {} + public void visit(LockVotesEvent lockVotesEvent) { } @Override - public void visit(UnlockVoteEvent unlockVoteEvent) {} + public void visit(UnlockVoteEvent unlockVoteEvent) { } @Override - public void visit(UnlockVotesEvent unlockVotesEvent) {} + public void visit(UnlockVotesEvent unlockVotesEvent) { } @Override - public void visit(FeatureChangeEvent featureChangeEvent) {} + public void visit(FeatureChangeEvent featureChangeEvent) { } @Override - public void visit(LockFeedbackEvent lockFeedbackEvent) {} + public void visit(LockFeedbackEvent lockFeedbackEvent) { } } diff --git a/src/main/java/de/thm/arsnova/cache/ICacheBuster.java b/src/main/java/de/thm/arsnova/cache/ICacheBuster.java index 9800991cf30979af2abaad4b316b6d8c471f4e64..a428fc71f0d19e188c190be8448d4e1e5715c332 100644 --- a/src/main/java/de/thm/arsnova/cache/ICacheBuster.java +++ b/src/main/java/de/thm/arsnova/cache/ICacheBuster.java @@ -20,4 +20,4 @@ package de.thm.arsnova.cache; /** * This interface is used as a tag to make Spring dependency injection happy... */ -public interface ICacheBuster {} +public interface ICacheBuster { } diff --git a/src/main/java/de/thm/arsnova/cache/package-info.java b/src/main/java/de/thm/arsnova/cache/package-info.java index 4bf0879279bedfe80f9c547d1c86450b33ee725d..af908a396bda1ac1f08f93f39de9cf83cd558f79 100644 --- a/src/main/java/de/thm/arsnova/cache/package-info.java +++ b/src/main/java/de/thm/arsnova/cache/package-info.java @@ -1,4 +1,4 @@ /** * Classes and interfaces related to caching */ -package de.thm.arsnova.cache; \ No newline at end of file +package de.thm.arsnova.cache; diff --git a/src/main/java/de/thm/arsnova/controller/AudienceQuestionController.java b/src/main/java/de/thm/arsnova/controller/AudienceQuestionController.java index 49472664ee824fe1c57065592efb09725d584118..6a9f611f6f9ae003e8b46b4c8b19265d112be7aa 100644 --- a/src/main/java/de/thm/arsnova/controller/AudienceQuestionController.java +++ b/src/main/java/de/thm/arsnova/controller/AudienceQuestionController.java @@ -60,7 +60,7 @@ public class AudienceQuestionController extends PaginationController { @RequestMapping(value = "/count", method = RequestMethod.GET) @DeprecatedApi @Deprecated - public int getInterposedCount(@ApiParam(value="Session-Key from current session", required=true) @RequestParam final String sessionkey) { + public int getInterposedCount(@ApiParam(value = "Session-Key from current session", required = true) @RequestParam final String sessionkey) { return questionService.getInterposedCount(sessionkey); } @@ -96,8 +96,8 @@ public class AudienceQuestionController extends PaginationController { @RequestMapping(value = "/", method = RequestMethod.POST) @ResponseStatus(HttpStatus.CREATED) public void postInterposedQuestion( - @ApiParam(value="Session-Key from current session", required=true) @RequestParam final String sessionkey, - @ApiParam(value="the body from the new question", required=true) @RequestBody final de.thm.arsnova.entities.InterposedQuestion question + @ApiParam(value = "Session-Key from current session", required = true) @RequestParam final String sessionkey, + @ApiParam(value = "the body from the new question", required = true) @RequestBody final de.thm.arsnova.entities.InterposedQuestion question ) { if (questionService.saveQuestion(question)) { return; @@ -109,7 +109,7 @@ public class AudienceQuestionController extends PaginationController { @ApiOperation(value = "Deletes an InterposedQuestion", nickname = "deleteInterposedQuestion") @RequestMapping(value = "/{questionId}", method = RequestMethod.DELETE) - public void deleteInterposedQuestion(@ApiParam(value = "ID of the question that needs to be deleted", required=true) @PathVariable final String questionId) { + public void deleteInterposedQuestion(@ApiParam(value = "ID of the question that needs to be deleted", required = true) @PathVariable final String questionId) { questionService.deleteInterposedQuestion(questionId); } } diff --git a/src/main/java/de/thm/arsnova/controller/CourseController.java b/src/main/java/de/thm/arsnova/controller/CourseController.java index f27d177974c9a2fd983a290c314e9a8c2a5e0221..3c7847a8e6363a4b7a1c243f98c34cbf291df964 100644 --- a/src/main/java/de/thm/arsnova/controller/CourseController.java +++ b/src/main/java/de/thm/arsnova/controller/CourseController.java @@ -55,7 +55,7 @@ public class CourseController extends AbstractController { @RequestMapping(value = "/mycourses", method = RequestMethod.GET) public List<Course> myCourses( - @ApiParam(value="sort my courses by name", required=true) + @ApiParam(value = "sort my courses by name", required = true) @RequestParam(value = "sortby", defaultValue = "name") final String sortby ) { diff --git a/src/main/java/de/thm/arsnova/controller/LecturerQuestionController.java b/src/main/java/de/thm/arsnova/controller/LecturerQuestionController.java index 945565766ca82a7482e763eb686834108d31bdad..6abc659169dfad60fb2b6d7a6e966043b4c8609d 100644 --- a/src/main/java/de/thm/arsnova/controller/LecturerQuestionController.java +++ b/src/main/java/de/thm/arsnova/controller/LecturerQuestionController.java @@ -128,7 +128,7 @@ public class LecturerQuestionController extends PaginationController { @RequestParam(value = "time", defaultValue = "0", required = false) final int time ) { - if(time == 0) { + if (time == 0) { questionService.startNewPiRound(questionId, null); } else { questionService.startNewPiRoundDelayed(questionId, time); @@ -621,7 +621,7 @@ public class LecturerQuestionController extends PaginationController { @RequestBody String[] sortOrder ) { try { - questionService.setSort(sessionkey, "", sorttype, ispreparation, sortOrder) ; + questionService.setSort(sessionkey, "", sorttype, ispreparation, sortOrder); } catch (final Exception e) { throw new BadRequestException(); } diff --git a/src/main/java/de/thm/arsnova/controller/SecurityExceptionControllerAdvice.java b/src/main/java/de/thm/arsnova/controller/SecurityExceptionControllerAdvice.java index 8b7f0907cd6a3bd930b4f4eeae0ca88c9e7fa936..9be2d966caf25d182e1f787886fefa179f11fa46 100644 --- a/src/main/java/de/thm/arsnova/controller/SecurityExceptionControllerAdvice.java +++ b/src/main/java/de/thm/arsnova/controller/SecurityExceptionControllerAdvice.java @@ -48,7 +48,7 @@ public class SecurityExceptionControllerAdvice { @ExceptionHandler @ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR) - public Map<String,String> defaultExceptionHandler( + public Map<String, String> defaultExceptionHandler( final Exception e, final HttpServletRequest req ) { diff --git a/src/main/java/de/thm/arsnova/controller/SessionController.java b/src/main/java/de/thm/arsnova/controller/SessionController.java index 9d94ffc5aef21772162aec4df3b89455767c20d2..dd62c315fc1852d698806dea3cfec30c1b4db3fd 100644 --- a/src/main/java/de/thm/arsnova/controller/SessionController.java +++ b/src/main/java/de/thm/arsnova/controller/SessionController.java @@ -147,9 +147,9 @@ public class SessionController extends PaginationController { @RequestMapping(value = "/", method = RequestMethod.GET) @Pagination public List<Session> getSessions( - @ApiParam(value="ownedOnly", required=true) @RequestParam(value = "ownedonly", defaultValue = "false") final boolean ownedOnly, - @ApiParam(value="visitedOnly", required=true) @RequestParam(value = "visitedonly", defaultValue = "false") final boolean visitedOnly, - @ApiParam(value="sortby", required=true) @RequestParam(value = "sortby", defaultValue = "name") final String sortby, + @ApiParam(value = "ownedOnly", required = true) @RequestParam(value = "ownedonly", defaultValue = "false") final boolean ownedOnly, + @ApiParam(value = "visitedOnly", required = true) @RequestParam(value = "visitedonly", defaultValue = "false") final boolean visitedOnly, + @ApiParam(value = "sortby", required = true) @RequestParam(value = "sortby", defaultValue = "name") final String sortby, final HttpServletResponse response ) { List<Session> sessions = null; @@ -276,7 +276,7 @@ public class SessionController extends PaginationController { @RequestMapping(value = "/{sessionkey}/lock", method = RequestMethod.POST) public Session lockSession( @ApiParam(value = "session-key from current session", required = true) @PathVariable final String sessionkey, - @ApiParam(value="lock", required=true) @RequestParam(required = false) final Boolean lock, + @ApiParam(value = "lock", required = true) @RequestParam(required = false) final Boolean lock, @ApiParam(value = "http servlet response", required = true) final HttpServletResponse response ) { if (lock != null) { @@ -336,7 +336,7 @@ public class SessionController extends PaginationController { nickname = "lockFeedbackInput") public boolean lockFeedbackInput( @ApiParam(value = "session-key from current session", required = true) @PathVariable final String sessionkey, - @ApiParam(value="lock", required=true) @RequestParam(required = true) final Boolean lock, + @ApiParam(value = "lock", required = true) @RequestParam(required = true) final Boolean lock, @ApiParam(value = "http servlet response", required = true) final HttpServletResponse response ) { return sessionService.lockFeedbackInput(sessionkey, lock); diff --git a/src/main/java/de/thm/arsnova/controller/SocketController.java b/src/main/java/de/thm/arsnova/controller/SocketController.java index 9dce5f7cf5c6df0792915a8b38f0cf9163c19a52..5862e85ec3fbd3b2cce9f73c974e107e8880d827 100644 --- a/src/main/java/de/thm/arsnova/controller/SocketController.java +++ b/src/main/java/de/thm/arsnova/controller/SocketController.java @@ -67,7 +67,7 @@ public class SocketController extends AbstractController { @ApiResponse(code = 403, message = HTML_STATUS_403) }) @RequestMapping(method = RequestMethod.POST, value = "/assign") - public void authorize(@ApiParam(value="sessionMap", required=true) @RequestBody final Map<String, String> sessionMap, @ApiParam(value="response", required=true) final HttpServletResponse response) { + public void authorize(@ApiParam(value = "sessionMap", required = true) @RequestBody final Map < String, String> sessionMap, @ApiParam(value = "response", required = true) final HttpServletResponse response) { String socketid = sessionMap.get("session"); if (null == socketid) { LOGGER.debug("Expected property 'session' missing", socketid); diff --git a/src/main/java/de/thm/arsnova/controller/WelcomeController.java b/src/main/java/de/thm/arsnova/controller/WelcomeController.java index cabe824f6bf9baa1cc3bf8c66531e5564af9c77a..54f88fd2401ec28e496e0d6460cefe8e7e594e9b 100644 --- a/src/main/java/de/thm/arsnova/controller/WelcomeController.java +++ b/src/main/java/de/thm/arsnova/controller/WelcomeController.java @@ -53,7 +53,7 @@ public class WelcomeController extends AbstractController { @Value("${mobile.path}") private String mobileContextPath; - @Resource(name="versionInfoProperties") + @Resource(name = "versionInfoProperties") private Properties versionInfoProperties; @RequestMapping(value = "/", method = RequestMethod.GET) diff --git a/src/main/java/de/thm/arsnova/dao/CouchDBDao.java b/src/main/java/de/thm/arsnova/dao/CouchDBDao.java index c4432847a59d7bf7075dd1659ad46161b75ef2a2..680d870dfb780da965f1e39280f950aac1cf3a25 100644 --- a/src/main/java/de/thm/arsnova/dao/CouchDBDao.java +++ b/src/main/java/de/thm/arsnova/dao/CouchDBDao.java @@ -1773,8 +1773,8 @@ public class CouchDBDao implements IDatabaseDao, ApplicationEventPublisherAware final List<String> unanswered = new ArrayList<String>(); for (final Question question : questions) { - if (!answered.containsKey(question.get_id()) || - (answered.containsKey(question.get_id()) && answered.get(question.get_id()) != question.getPiRound())) { + if (!answered.containsKey(question.get_id()) + || (answered.containsKey(question.get_id()) && answered.get(question.get_id()) != question.getPiRound())) { unanswered.add(question.get_id()); } } @@ -2275,7 +2275,7 @@ public class CouchDBDao implements IDatabaseDao, ApplicationEventPublisherAware List<String> sort = new ArrayList<String>(); JSONArray json = d.getJSONObject("value").getJSONArray("sortOrder"); int len = json.size(); - for (int i=0; i<len; i++) { + for (int i = 0; i < len; i++) { sort.add(json.getString(i)); } sortOrder.setSortOrder(sort); @@ -2284,7 +2284,7 @@ public class CouchDBDao implements IDatabaseDao, ApplicationEventPublisherAware return sortOrder; } - @CachePut(value = "sortorder", key ="#sortOrder.sessionId.concat('-').concat(#sortOrder.questionVariant).concat('-').concat(#sortOrder.subject)") + @CachePut(value = "sortorder", key = "#sortOrder.sessionId.concat('-').concat(#sortOrder.questionVariant).concat('-').concat(#sortOrder.subject)") @Override public SortOrder createOrUpdateSortOrder(SortOrder sortOrder) { try { @@ -2317,7 +2317,7 @@ public class CouchDBDao implements IDatabaseDao, ApplicationEventPublisherAware return null; } - @CacheEvict(value = "sortorder", key ="#sortOrder.sessionId.concat('-').concat(#sortOrder.questionVariant).concat('-').concat(#sortOrder.subject)") + @CacheEvict(value = "sortorder", key = "#sortOrder.sessionId.concat('-').concat(#sortOrder.questionVariant).concat('-').concat(#sortOrder.subject)") @Override public void deleteSortOrder(SortOrder sortOrder) { try { @@ -2534,7 +2534,7 @@ public class CouchDBDao implements IDatabaseDao, ApplicationEventPublisherAware if (null != id) { d = database.getDocument(id, rev); } - d.put("type","motdlist"); + d.put("type", "motdlist"); d.put("username", motdlist.getUsername()); d.put("motdkeys", motdlist.getMotdkeys()); diff --git a/src/main/java/de/thm/arsnova/domain/LearningProgressFactory.java b/src/main/java/de/thm/arsnova/domain/LearningProgressFactory.java index 8e50d4a5e275b0731d0ac5e5fc838375c1e1569e..9eb5d233bba59a7c8748c798d47d41febb78bab2 100644 --- a/src/main/java/de/thm/arsnova/domain/LearningProgressFactory.java +++ b/src/main/java/de/thm/arsnova/domain/LearningProgressFactory.java @@ -51,10 +51,10 @@ public class LearningProgressFactory implements NovaEventVisitor, ILearningProgr } @Override - public void visit(NewInterposedQuestionEvent event) {} + public void visit(NewInterposedQuestionEvent event) { } @Override - public void visit(DeleteInterposedQuestionEvent deleteInterposedQuestionEvent) {} + public void visit(DeleteInterposedQuestionEvent deleteInterposedQuestionEvent) { } @CacheEvict(value = "learningprogress", key = "#event.Session") @Override @@ -135,31 +135,31 @@ public class LearningProgressFactory implements NovaEventVisitor, ILearningProgr } @Override - public void visit(NewFeedbackEvent newFeedbackEvent) {} + public void visit(NewFeedbackEvent newFeedbackEvent) { } @Override - public void visit(DeleteFeedbackForSessionsEvent deleteFeedbackEvent) {} + public void visit(DeleteFeedbackForSessionsEvent deleteFeedbackEvent) { } @Override - public void visit(StatusSessionEvent statusSessionEvent) {} + public void visit(StatusSessionEvent statusSessionEvent) { } @Override - public void visit(ChangeLearningProgressEvent changeLearningProgress) {} + public void visit(ChangeLearningProgressEvent changeLearningProgress) { } @Override - public void visit(PiRoundDelayedStartEvent piRoundDelayedStartEvent) {} + public void visit(PiRoundDelayedStartEvent piRoundDelayedStartEvent) { } @Override - public void visit(PiRoundEndEvent piRoundEndEvent) {} + public void visit(PiRoundEndEvent piRoundEndEvent) { } @Override - public void visit(PiRoundCancelEvent piRoundCancelEvent) {} + public void visit(PiRoundCancelEvent piRoundCancelEvent) { } @Override - public void visit(NewSessionEvent event) {} + public void visit(NewSessionEvent event) { } @Override - public void visit(DeleteSessionEvent event) {} + public void visit(DeleteSessionEvent event) { } @Override public void setApplicationEventPublisher(ApplicationEventPublisher publisher) { @@ -167,21 +167,21 @@ public class LearningProgressFactory implements NovaEventVisitor, ILearningProgr } @Override - public void visit(LockVoteEvent lockVoteEvent) {} + public void visit(LockVoteEvent lockVoteEvent) { } @Override - public void visit(LockVotesEvent lockVotesEvent) {} + public void visit(LockVotesEvent lockVotesEvent) { } @Override - public void visit(UnlockVoteEvent unlockVoteEvent) {} + public void visit(UnlockVoteEvent unlockVoteEvent) { } @Override - public void visit(UnlockVotesEvent unlockVotesEvent) {} + public void visit(UnlockVotesEvent unlockVotesEvent) { } @Override - public void visit(FeatureChangeEvent featureChangeEvent) {} + public void visit(FeatureChangeEvent featureChangeEvent) { } @Override - public void visit(LockFeedbackEvent lockFeedbackEvent) {} + public void visit(LockFeedbackEvent lockFeedbackEvent) { } } diff --git a/src/main/java/de/thm/arsnova/domain/PointBasedLearningProgress.java b/src/main/java/de/thm/arsnova/domain/PointBasedLearningProgress.java index dfef1d348cb3a3f7b346a0979f02bd355b0b0356..a4314c51ca7d6cf8d85d89e13850dec6e77ee1a8 100644 --- a/src/main/java/de/thm/arsnova/domain/PointBasedLearningProgress.java +++ b/src/main/java/de/thm/arsnova/domain/PointBasedLearningProgress.java @@ -36,7 +36,7 @@ public class PointBasedLearningProgress extends VariantLearningProgress { lpv.setCourseProgress(coursePercentage()); lpv.setNumQuestions(courseScore.getQuestionCount()); lpv.setNumUsers(courseScore.getTotalUserCount()); - lpv.setNumerator(courseScore.getTotalUserScore()/courseScore.getTotalUserCount()); + lpv.setNumerator(courseScore.getTotalUserScore() / courseScore.getTotalUserCount()); lpv.setDenominator(courseScore.getMaximumScore()); return lpv; } @@ -50,7 +50,7 @@ public class PointBasedLearningProgress extends VariantLearningProgress { } final double courseAverageValue = userTotalValue / numUsers; final double courseProgress = courseAverageValue / courseMaximumValue; - return (int)Math.min(100, Math.round(courseProgress * 100)); + return (int) Math.min(100, Math.round(courseProgress * 100)); } @Override @@ -72,6 +72,6 @@ public class PointBasedLearningProgress extends VariantLearningProgress { return 0; } final double myProgress = userTotalValue / courseMaximumValue; - return (int)Math.min(100, Math.round(myProgress*100)); + return (int) Math.min(100, Math.round(myProgress * 100)); } } diff --git a/src/main/java/de/thm/arsnova/domain/QuestionBasedLearningProgress.java b/src/main/java/de/thm/arsnova/domain/QuestionBasedLearningProgress.java index 200df8fc9c51b6a08bbee808fdba6641a653e628..93991710eb90e5cec322d9a0c124894b941a31d5 100644 --- a/src/main/java/de/thm/arsnova/domain/QuestionBasedLearningProgress.java +++ b/src/main/java/de/thm/arsnova/domain/QuestionBasedLearningProgress.java @@ -34,7 +34,7 @@ public class QuestionBasedLearningProgress extends VariantLearningProgress { @Override protected LearningProgressValues createCourseProgress() { final int courseProgress = calculateCourseProgress(); - final int numerator = courseScore.getQuestionCount()*courseProgress/100; + final int numerator = courseScore.getQuestionCount() * courseProgress / 100; final int denominator = courseScore.getQuestionCount(); LearningProgressValues lpv = new LearningProgressValues(); lpv.setCourseProgress(courseProgress); @@ -53,10 +53,10 @@ public class QuestionBasedLearningProgress extends VariantLearningProgress { } int numAnswers = questionScore.getUserCount(); if (numAnswers != 0) { - ratio += (double)countCorrectAnswers(questionScore) / (numAnswers * courseScore.getQuestionCount()); + ratio += (double) countCorrectAnswers(questionScore) / (numAnswers * courseScore.getQuestionCount()); } } - return (int) Math.min(100, Math.round(ratio*100)); + return (int) Math.min(100, Math.round(ratio * 100)); } private int countCorrectAnswers(QuestionScore questionScore) { @@ -107,8 +107,8 @@ public class QuestionBasedLearningProgress extends VariantLearningProgress { } private int myPercentage(int numQuestionsCorrect, int questionCount) { - final double myLearningProgress = numQuestionsCorrect / (double)questionCount; - return (int) Math.min(100, Math.round(myLearningProgress*100)); + final double myLearningProgress = numQuestionsCorrect / (double) questionCount; + return (int) Math.min(100, Math.round(myLearningProgress * 100)); } diff --git a/src/main/java/de/thm/arsnova/domain/package-info.java b/src/main/java/de/thm/arsnova/domain/package-info.java index 0733c68fb4c53a0c7fd357e3d6967e4fd21fc6c3..4995c742eaa8e7cb5f67adfe4ece28bf18ce9fcc 100644 --- a/src/main/java/de/thm/arsnova/domain/package-info.java +++ b/src/main/java/de/thm/arsnova/domain/package-info.java @@ -1,4 +1,4 @@ /** * The 'M' in MVC */ -package de.thm.arsnova.domain; \ No newline at end of file +package de.thm.arsnova.domain; diff --git a/src/main/java/de/thm/arsnova/entities/LearningProgressOptions.java b/src/main/java/de/thm/arsnova/entities/LearningProgressOptions.java index 4667dae82299c4c4b775fa66912908d60e322c6e..e29f9a43eda5dcbd667b1f4caa2295391aad0498 100644 --- a/src/main/java/de/thm/arsnova/entities/LearningProgressOptions.java +++ b/src/main/java/de/thm/arsnova/entities/LearningProgressOptions.java @@ -35,7 +35,7 @@ public class LearningProgressOptions { this.questionVariant = learningProgressOptions.getQuestionVariant(); } - public LearningProgressOptions() {} + public LearningProgressOptions() { } @ApiModelProperty(required = true, value = "the type") public String getType() { diff --git a/src/main/java/de/thm/arsnova/entities/Motd.java b/src/main/java/de/thm/arsnova/entities/Motd.java index 439f75db432de1ca669f515ab9be4e9c38400820..c9748b299c7d7948dd1ce1b453d4d65a412d7a25 100644 --- a/src/main/java/de/thm/arsnova/entities/Motd.java +++ b/src/main/java/de/thm/arsnova/entities/Motd.java @@ -88,7 +88,7 @@ public class Motd { return audience; } - public void setAudience(String a){ + public void setAudience(String a) { audience = a; } @@ -97,7 +97,7 @@ public class Motd { return sessionkey; } - public void setSessionkey(String a){ + public void setSessionkey(String a) { sessionkey = a; } diff --git a/src/main/java/de/thm/arsnova/entities/Question.java b/src/main/java/de/thm/arsnova/entities/Question.java index f73d0bf9b79a1320e88e4bab9d48838febcfdcc5..c13f3d0947db08262e4c9a06ce4e87d821a068c4 100644 --- a/src/main/java/de/thm/arsnova/entities/Question.java +++ b/src/main/java/de/thm/arsnova/entities/Question.java @@ -596,7 +596,7 @@ public class Question implements Serializable { } public void updateRoundStartVariables(Date start, Date end) { - if(this.getPiRound() == 1 && this.isPiRoundFinished()) { + if (this.getPiRound() == 1 && this.isPiRoundFinished()) { this.setPiRound(2); } @@ -613,7 +613,7 @@ public class Question implements Serializable { public void updateRoundManagementState() { final long time = new Date().getTime(); - if(time > this.getPiRoundEndTime() && this.isPiRoundActive()) { + if (time > this.getPiRoundEndTime() && this.isPiRoundActive()) { this.setPiRoundEndTime(0); this.setPiRoundStartTime(0); this.setPiRoundActive(false); diff --git a/src/main/java/de/thm/arsnova/entities/SessionFeature.java b/src/main/java/de/thm/arsnova/entities/SessionFeature.java index 4cbfbcd4ca1fac4daa2a220ae389e8e082fdbe9b..37686978251c9e594315f67ee895e0529b690ad4 100644 --- a/src/main/java/de/thm/arsnova/entities/SessionFeature.java +++ b/src/main/java/de/thm/arsnova/entities/SessionFeature.java @@ -59,7 +59,7 @@ public class SessionFeature { } } - public SessionFeature() {} + public SessionFeature() { } public boolean isLecture() { return lecture; diff --git a/src/main/java/de/thm/arsnova/entities/SessionInfo.java b/src/main/java/de/thm/arsnova/entities/SessionInfo.java index 18f2e5e2273702f45c6a881cd3dbb1ba3db4cf4b..c28150ba87e122397e910625a9981734c476d02c 100644 --- a/src/main/java/de/thm/arsnova/entities/SessionInfo.java +++ b/src/main/java/de/thm/arsnova/entities/SessionInfo.java @@ -58,7 +58,7 @@ public class SessionInfo { this.ppSubject = session.getPpSubject(); } - public SessionInfo() {} + public SessionInfo() { } public static List<SessionInfo> fromSessionList(List<Session> sessions) { List<SessionInfo> infos = new ArrayList<SessionInfo>(); diff --git a/src/main/java/de/thm/arsnova/entities/transport/InterposedQuestion.java b/src/main/java/de/thm/arsnova/entities/transport/InterposedQuestion.java index d950790c601f72ccbe831d4ec65df45cd99111d5..ce8b668d5ccb21496dfabf72828db31d4dd55db8 100644 --- a/src/main/java/de/thm/arsnova/entities/transport/InterposedQuestion.java +++ b/src/main/java/de/thm/arsnova/entities/transport/InterposedQuestion.java @@ -51,7 +51,7 @@ public class InterposedQuestion { this.read = question.isRead(); } - public InterposedQuestion() {} + public InterposedQuestion() { } @ApiModelProperty(required = true, value = "used to display Id") public String getId() { diff --git a/src/main/java/de/thm/arsnova/services/MotdService.java b/src/main/java/de/thm/arsnova/services/MotdService.java index beeb901af10c8b68da292e0dfddfc61d790d43e2..f256b0ea00f6cfd1718b28831ae93c2d0e40cf67 100644 --- a/src/main/java/de/thm/arsnova/services/MotdService.java +++ b/src/main/java/de/thm/arsnova/services/MotdService.java @@ -99,7 +99,7 @@ public class MotdService implements IMotdService { List<Motd> returns = new ArrayList<Motd>(); HashSet<String> keys = new HashSet(500); // Or a more realistic size StringTokenizer st = new StringTokenizer(motdlist.getMotdkeys(), ","); - while(st.hasMoreTokens()) + while (st.hasMoreTokens()) keys.add(st.nextToken()); for (Motd motd : list) { if (!keys.contains(motd.getMotdkey())) { diff --git a/src/main/java/de/thm/arsnova/services/QuestionService.java b/src/main/java/de/thm/arsnova/services/QuestionService.java index b8e46713dc6e127ddbc35a76087218e6259a79d8..6e7981f549526cff73638ef30a53db07fb02bfc2 100644 --- a/src/main/java/de/thm/arsnova/services/QuestionService.java +++ b/src/main/java/de/thm/arsnova/services/QuestionService.java @@ -224,7 +224,7 @@ public class QuestionService implements IQuestionService, ApplicationEventPublis final Question question = databaseDao.getQuestion(questionId); final Session session = databaseDao.getSessionFromKeyword(question.getSessionKeyword()); - if(null == user) { + if (null == user) { user = userService.getCurrentUser(); } @@ -272,7 +272,7 @@ public class QuestionService implements IQuestionService, ApplicationEventPublis cancelDelayedPiRoundChange(questionId); question.resetRoundManagementState(); - if(question.getPiRound() == 1) { + if (question.getPiRound() == 1) { question.setPiRoundFinished(false); } else { question.setPiRound(1); @@ -287,7 +287,7 @@ public class QuestionService implements IQuestionService, ApplicationEventPublis public void cancelDelayedPiRoundChange(final String questionId) { Timer timer = timerList.get(questionId); - if(null != timer) { + if (null != timer) { timer.cancel(); timerList.remove(questionId); timer.purge(); @@ -1123,13 +1123,13 @@ public class QuestionService implements IQuestionService, ApplicationEventPublis List<String> tmpList = sortOrder.getSortOrder(); tmpList.add(toBeAdded); sortOrder.setSortOrder(tmpList); - if("alphabet".equals(sortOrder.getSortType())) { + if ("alphabet".equals(sortOrder.getSortType())) { sortOrder = alphabeticalSort(sortOrder); } return databaseDao.createOrUpdateSortOrder(sortOrder); } - public void deleteQuestionFromSortOrder(Question question){ + public void deleteQuestionFromSortOrder(Question question) { SortOrder sortOrder = databaseDao.getSortOrder(question.getSessionId(), question.getQuestionVariant(), question.getSubject()); if (sortOrder != null) { List<String> tempSortOrder = sortOrder.getSortOrder(); @@ -1226,7 +1226,7 @@ public class QuestionService implements IQuestionService, ApplicationEventPublis } } - public SortOrder alphabeticalSort(SortOrder sortOrder){ + public SortOrder alphabeticalSort(SortOrder sortOrder) { if (sortOrder.getSortOrder() == null) { return null; } diff --git a/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java b/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java index 0ae3d43007898bd6b06487754f18d8bcde281f53..b274390b0c90426b5ecee99fb6d8378f9deef75d 100644 --- a/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java +++ b/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java @@ -646,8 +646,8 @@ public class ARSnovaSocketIOServer implements ARSnovaSocket, NovaEventVisitor { } @Override - public void visit(NewSessionEvent event) {} + public void visit(NewSessionEvent event) { } @Override - public void visit(DeleteSessionEvent event) {} + public void visit(DeleteSessionEvent event) { } } diff --git a/src/main/java/de/thm/arsnova/web/CorsFilter.java b/src/main/java/de/thm/arsnova/web/CorsFilter.java index 1b18de705c0cf6167ed3c7e0d9f6e0e1d4c5b998..0a7f003146f41fa479071c3ddd4a4ba88cb703b0 100644 --- a/src/main/java/de/thm/arsnova/web/CorsFilter.java +++ b/src/main/java/de/thm/arsnova/web/CorsFilter.java @@ -47,6 +47,6 @@ public class CorsFilter extends OncePerRequestFilter { } private String sanitizeOriginUrl(String originUrl) { - return originUrl.replaceAll("[\n\r]+"," "); + return originUrl.replaceAll("[\n\r]+", " "); } }