From 7b7a43f22ec2b661b71dbdcffaa0419d1ad3efff Mon Sep 17 00:00:00 2001
From: Paul-Christian Volkmer <paul-christian.volkmer@mni.thm.de>
Date: Tue, 20 Nov 2012 13:34:27 +0100
Subject: [PATCH] Remove unused members
---
.../de/thm/arsnova/services/QuestionService.java | 12 +++---------
.../java/de/thm/arsnova/services/UserService.java | 3 ++-
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/main/java/de/thm/arsnova/services/QuestionService.java b/src/main/java/de/thm/arsnova/services/QuestionService.java
index 7cd40613..a4fb8275 100644
--- a/src/main/java/de/thm/arsnova/services/QuestionService.java
+++ b/src/main/java/de/thm/arsnova/services/QuestionService.java
@@ -30,19 +30,12 @@ import de.thm.arsnova.entities.Answer;
import de.thm.arsnova.entities.Question;
import de.thm.arsnova.entities.Session;
import de.thm.arsnova.exceptions.NoContentException;
-import de.thm.arsnova.socket.ARSnovaSocketIOServer;
@Service
public class QuestionService implements IQuestionService {
@Autowired
- ARSnovaSocketIOServer server;
-
- @Autowired
- IDatabaseDao databaseDao;
-
- @Autowired
- IUserService userService;
+ private IDatabaseDao databaseDao;
public void setDatabaseDao(IDatabaseDao databaseDao) {
this.databaseDao = databaseDao;
@@ -52,8 +45,9 @@ public class QuestionService implements IQuestionService {
@Authenticated
public List<Question> getSkillQuestions(String sessionkey) {
List<Question> result = databaseDao.getSkillQuestions(sessionkey);
- if (result == null || result.size() == 0)
+ if (result == null || result.size() == 0) {
throw new NoContentException();
+ }
return result;
}
diff --git a/src/main/java/de/thm/arsnova/services/UserService.java b/src/main/java/de/thm/arsnova/services/UserService.java
index 60902a5b..09ca0a6b 100644
--- a/src/main/java/de/thm/arsnova/services/UserService.java
+++ b/src/main/java/de/thm/arsnova/services/UserService.java
@@ -75,8 +75,9 @@ public class UserService implements IUserService, InitializingBean, DisposableBe
user = new User(token);
}
- if (user == null || user.getUsername().equals("anonymous"))
+ if (user == null || user.getUsername().equals("anonymous")) {
throw new UnauthorizedException();
+ }
return user;
}
--
GitLab