From 5ccc4c5315d006346530ecf06e7095ecbf5e288d Mon Sep 17 00:00:00 2001
From: Christoph Thelen <christoph.thelen@mni.thm.de>
Date: Wed, 11 Feb 2015 18:16:17 +0100
Subject: [PATCH] Fix calculating question-based progress for course
---
.../thm/arsnova/domain/QuestionBasedLearningProgress.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/main/java/de/thm/arsnova/domain/QuestionBasedLearningProgress.java b/src/main/java/de/thm/arsnova/domain/QuestionBasedLearningProgress.java
index 9fcc56ce..81dab008 100644
--- a/src/main/java/de/thm/arsnova/domain/QuestionBasedLearningProgress.java
+++ b/src/main/java/de/thm/arsnova/domain/QuestionBasedLearningProgress.java
@@ -40,11 +40,9 @@ public class QuestionBasedLearningProgress implements LearningProgress {
private int calculateCourseProgress(CourseScore courseScore) {
int numQuestionsCorrect = numQuestionsCorrectForCourse(courseScore);
- int numUsers = courseScore.getTotalUserCount();
- final double correctQuestionsOnAverage = (double)numQuestionsCorrect / (double)numUsers;
- final double myLearningProgress = correctQuestionsOnAverage / courseScore.getQuestionCount();
+ final double correctQuestionsOnAverage = (double)numQuestionsCorrect / (double)(courseScore.getQuestionCount());
// calculate percent, cap results to 100
- return (int) Math.min(100, Math.round(myLearningProgress*100));
+ return (int) Math.min(100, Math.round(correctQuestionsOnAverage*100));
}
private int numQuestionsCorrectForCourse(CourseScore courseScore) {
--
GitLab