From 575b90536dbe1b26a3305da02580287d3acbe66c Mon Sep 17 00:00:00 2001
From: Daniel Gerhardt <code@dgerhardt.net>
Date: Mon, 11 May 2015 10:57:49 +0200
Subject: [PATCH] Fix NPE
Check user object against null before accepting feedback via Websocket.
---
.../java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java b/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java
index b228764d..1e1f975e 100644
--- a/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java
+++ b/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java
@@ -156,6 +156,11 @@ public class ARSnovaSocketIOServer implements ARSnovaSocket, NovaEventVisitor {
@Override
public void onData(final SocketIOClient client, final Feedback data, final AckRequest ackSender) {
final User u = userService.getUser2SocketId(client.getSessionId());
+ if (u == null) {
+ LOGGER.info("Client {} tried to send feedback but is not mapped to a user", client.getSessionId());
+
+ return;
+ }
final String sessionKey = userService.getSessionForUser(u.getUsername());
LOGGER.debug("Feedback recieved: {}", new Object[] {u, sessionKey, data.getValue()});
if (null != sessionKey) {
--
GitLab